summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-07-25weld SdPublishingDlgCaolán McNamara
Change-Id: I64ce16c8b107b8b4d6009e6e2d5775cbf173a019 Reviewed-on: https://gerrit.libreoffice.org/76334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-25add XInitialization to allow setting explicit dialog parentCaolán McNamara
Change-Id: Icc2626b6b3defeb6c02a43cee14cdb97dc573870 Reviewed-on: https://gerrit.libreoffice.org/76290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-25sidebar: Add .uno:MasterSlidesPanelAshod Nakashian
Change-Id: I578dc8b1f9c8df7f7cc9108c70d6fad8006871c6 Reviewed-on: https://gerrit.libreoffice.org/73502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: LOK: avoid caching pointers and leakingAshod Nakashian
Change-Id: I68163bc30b0655b11dec34bdcc750b495b93365a Reviewed-on: https://gerrit.libreoffice.org/68265 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit da70e562087b6016aeaffadedc4ce66eaf370919) Reviewed-on: https://gerrit.libreoffice.org/76284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: LOK: support localization of slide transition presetsAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/68264 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 312346531dde33cd000a1d3c95c7b7829b656438) Change-Id: Ic3ea57e537e118e10d155203921574967154c234 Reviewed-on: https://gerrit.libreoffice.org/76283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sidebar: hide preview and play controls in lokitAshod Nakashian
Change-Id: I7fc9470082612af4c4d7e56ff704936da5c63ce4 Reviewed-on: https://gerrit.libreoffice.org/73501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: LOK: publish statechange on entering master viewAshod Nakashian
Change-Id: Ib736800544b9669e3708da0c01370af22cdf3e97 Reviewed-on: https://gerrit.libreoffice.org/69617 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5 Reviewed-on: https://gerrit.libreoffice.org/76280 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24cid#1448222 Out-of-bounds readCaolán McNamara
possibly coverity gold Change-Id: I6443225482eab5be31e1e12d282e420e767f23b2 Reviewed-on: https://gerrit.libreoffice.org/76254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24sd: LOK: support per-user localization of CustomAnimationPresetAshod Nakashian
This only fixes the caching in CustomAnimationPreset and CustomAnimationPane. Other cached labels will be done separately. Reviewed-on: https://gerrit.libreoffice.org/68263 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit b44679e47211a27f4fe22d05762d9d48c8f88935) Change-Id: Iaf511168d26b3a5567ca53556e242d3c071d2623 Reviewed-on: https://gerrit.libreoffice.org/76241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24sd: use OSL_DEBUG_LEVEL instead of DEBUGAshod Nakashian
Change-Id: I0703a1564a23657e956e43fe4cbf1d9549acb94f Reviewed-on: https://gerrit.libreoffice.org/68258 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1451642 silence Division or modulo by zeroCaolán McNamara
Change-Id: I728528ecbb69c23b63807944e4ae0beb9cb86cbb Reviewed-on: https://gerrit.libreoffice.org/76222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24LOK: sd: use native SdPage to flag selectionAshod Nakashian
The slide-sorter is actually still necessary to apply/change the master slide of a given slide, so we must enable it. Change-Id: I3f59f58be76ab1c63453b4f6288044572800a556 Change-Id: I7554ba4afd28d7ea4f3ed6ba375d9765a89ef21c Reviewed-on: https://gerrit.libreoffice.org/69618 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24tdf#126070 Show scroll bars when preview overflows.Gülşah Köse
Change-Id: Ibb904fc1c5d283d8ca9d8ff8b2249d25d7091b5b Reviewed-on: https://gerrit.libreoffice.org/75954 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-22cid#1448269 Dereference null return valueCaolán McNamara
Change-Id: Ief2dfb8a87030d992a867a7a9014d3787e201831 Reviewed-on: https://gerrit.libreoffice.org/76111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22tdf#118370 Draw: add option to consolidate multiple textObjsJustin Luth
This gives the user a tool to consolidate multiple textboxes into a single textbox. First the user selects a group of textframes, and then runs the consolidate text function. This will REPLACE the marked textframes with a single textbox combining all of the text. The function inspects the text fragments to see if they end in sentence-ending punctuation. If not, then the next textbox's content is appended to it instead of starting a new pargraph. It is the user's responsibility to afterwards fix up paragraphing, and set paragraph properties. The rational for this patch is to simplify making major text changes on PDFs imported into Draw, since each paragraph is currently broken into tiny character-property textbox fragments. Copy/paste from the PDF itself doesn't keep character attributes, so it is hard for a user to re-create the text. This is related to tdf#32249, but as a comment says, a better solution would be to write an entire text-focused PDF import, rather than just pick up the pieces. And I agree, but considering this simple patch took me a couple of weeks of frustration, I'm obviously not the person to do that. And since the bug has been open for 9 years, likely no one else will either. Thus, this pick-up-the-pieces tool to help the end user. This initial patch works only with textFrames, but can easily be adjusted to consolidate other HasText() SdrObjects. However, that tended to produce unexpected results, so everything other than OBJ_TEXT is explicitly excluded. (Thus general shapes with text, callouts, text-along-path etc are ignored.) Change-Id: I68a9a5b187bf320a8e671414c5cb22b07725fd52 Reviewed-on: https://gerrit.libreoffice.org/75043 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-07-21loplugin:referencecasting in variousNoel Grandin
Change-Id: Id4e3d9d1bbfd47181299568afec45e996eb1eed5 Reviewed-on: https://gerrit.libreoffice.org/76071 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-21tdf#124583 NB draw/impress sync -context-draw stuffandreas kainz
Change-Id: I5e214c6f78a4b2e8c17861d813efba2dff90be53 Reviewed-on: https://gerrit.libreoffice.org/76025 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-21NB GlueInsertPoint didn't work in NB added EditGluePointandreas kainz
Change-Id: I1253fe7fe89ca1e247e8fafb348fbaa51a4e4f88 Reviewed-on: https://gerrit.libreoffice.org/76013 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-20cid#1448403 Use after freeCaolán McNamara
Change-Id: Ie63c336da7296ecad6aef56d57b064e450361b5d Reviewed-on: https://gerrit.libreoffice.org/76020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448375 Improper use of negative valueCaolán McNamara
Change-Id: Iaea347e5ca91ad164ad970ec8f0a485fd8a0d75e Reviewed-on: https://gerrit.libreoffice.org/76016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20loplugin:referencecasting in sdNoel Grandin
Change-Id: Ief0d02006afd6cb9cd6da1da9208e374df644a42 Reviewed-on: https://gerrit.libreoffice.org/75977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19Fix typosAndrea Gelmini
Change-Id: Ia7486fe6c110a4a7f53f1dac82dbff3a15405fd7 Reviewed-on: https://gerrit.libreoffice.org/75947 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-19tdf#126334 Fix number format array in init controls.Gülşah Köse
Customization changings need only selected number format object but Position changings on bullet need all existing number format array. After merge the customization and position keeping all numbering format objects (10 item) make sense. Change-Id: Iade1e154243deaed43b9d243f2ebd0c5298b42a4 Reviewed-on: https://gerrit.libreoffice.org/75784 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-19cid#1448229 Division or modulo by zeroCaolán McNamara
Change-Id: I8d1d7415c82c7d48f8d4bdf7b86e397fce01c015 Reviewed-on: https://gerrit.libreoffice.org/75908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448319 Use after freeCaolán McNamara
Change-Id: I45a4ea5c21707606b8853bb775a7d9eec595b88c Reviewed-on: https://gerrit.libreoffice.org/75912 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19NB fix context- behaviour in draw and impressandreas kainz
Change-Id: I943466895a51463be59dacb3686926d29562a371 Reviewed-on: https://gerrit.libreoffice.org/75931 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-19cid#1448436 Unchecked return valueCaolán McNamara
Change-Id: I971587c6340afc83ac3a28b148650a8f20120164 Reviewed-on: https://gerrit.libreoffice.org/75890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448395 Uncaught exceptionCaolán McNamara
Change-Id: I7478aa8a971e834efee0effd998c68cb85368892 Reviewed-on: https://gerrit.libreoffice.org/75885 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448356 Uncaught exceptionCaolán McNamara
Change-Id: Iaa48face892514b5af769cdb3120f001940cf0ea Reviewed-on: https://gerrit.libreoffice.org/75882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448347 Unchecked return valueCaolán McNamara
Change-Id: I18a43e9a033a7326563f37caa0292a2c34752be0 Reviewed-on: https://gerrit.libreoffice.org/75880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1311945 Uncaught exceptionCaolán McNamara
Change-Id: I1f3c2d3e644c4cbb4e38740c05a623864219313e Reviewed-on: https://gerrit.libreoffice.org/75843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1424266 Uncaught exceptionCaolán McNamara
Change-Id: I5e7373dbaef52184327596d029ab63baf57764d9 Reviewed-on: https://gerrit.libreoffice.org/75844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448227 Uncaught exceptionCaolán McNamara
Change-Id: I6149b087217b9b34ecce984536aae52b8ee9d430 Reviewed-on: https://gerrit.libreoffice.org/75846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448325 Uncaught exceptionCaolán McNamara
Change-Id: I5bb61909d5d252de7465a29a3c8e49b7b1997ba3 Reviewed-on: https://gerrit.libreoffice.org/75847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448534 Use after freeCaolán McNamara
Change-Id: Ibef20405d1ecf00b71ca12e43902ccd65c873ed2 Reviewed-on: https://gerrit.libreoffice.org/75815 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448529 Use after freeCaolán McNamara
Change-Id: I5bc3a85b7319c52e3b5d1a7e7dffcbe23cdf653c Reviewed-on: https://gerrit.libreoffice.org/75814 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1451632 Dereference after null checkCaolán McNamara
Change-Id: I5ee95a9341896b8462235ece933fa70773247c92 Reviewed-on: https://gerrit.libreoffice.org/75802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17LOK: support for ordering/moving partsAshod Nakashian
Currently reordering of slides is only supported for presentations, although it is provisioned for spreadsheets as well. Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572 Reviewed-on: https://gerrit.libreoffice.org/69612 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73495 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-17loplugin:unusedfieldsNoel Grandin
Change-Id: I38abc54776cc605c76faf94e9e8c0f4fa75b8788 Reviewed-on: https://gerrit.libreoffice.org/75740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16cid#1448514 Dereference null return valueCaolán McNamara
Change-Id: Idf32f7a51a57756ac620249e5a95c9e1c8d2f9d2 Reviewed-on: https://gerrit.libreoffice.org/75716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448419 Resource leakCaolán McNamara
Change-Id: I1ca12ee7097ba2f4e644d3ff91cff1a49af49cbe Reviewed-on: https://gerrit.libreoffice.org/75713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16Missing test dependencyStephan Bergmann
(a macOS build of mine happened to fail in CppunitTest_sd_uimpress with "no suitable windowing system found, exiting" when instdir/LibreOffice.app/Contents/Frameworks/libvclplug_osxlo.dylib had not been built yet) Change-Id: Ic699648f6b0dffd9ed01cf97cf624efe2ef8be30 Reviewed-on: https://gerrit.libreoffice.org/75679 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16LOK: getPartInfo now returns list of selected partsAshod Nakashian
For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73494 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-16Follow up patch tdf#126067 Correct indentation.Gülşah Köse
Change-Id: Idfe608afb8b02f8b9f56b9da76e3f2009617b183 Reviewed-on: https://gerrit.libreoffice.org/75676 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-16tdf#42949 Fix IWYU warnings in include/Gabor Kelemen
Recheck directories in include/ between vcl and svx in the module hierarchy Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: Ieab6083ee2aae33baf32d05943b07ad2de6f9d7f Reviewed-on: https://gerrit.libreoffice.org/75170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16tdf#126067 Fix slide scope feature.Gülşah Köse
Change-Id: I6e2450572b9c6a30526a8a2a91a6e0bf89103475 Reviewed-on: https://gerrit.libreoffice.org/75669 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-15cid#1448231 Explicit null dereferencedCaolán McNamara
Change-Id: I4cd6cb84b08b7979d537b9590a45ce27a8423d6c Reviewed-on: https://gerrit.libreoffice.org/75631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15Deduplicate EditHyperlink commandSamuel Mehrbrodt
Change-Id: I23f0c276c5c1229aeb4ea468c6b858e36c120bd9 Reviewed-on: https://gerrit.libreoffice.org/75480 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-15tdf#112543 Add Edit/Remove hyperlink to text boxes/shapes in WriterSamuel Mehrbrodt
Change-Id: I9052387cf39135c2324b9db03662dc0365323400 Reviewed-on: https://gerrit.libreoffice.org/75479 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2025-01-01 17:37:24 +0000