summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-01-02oox smartart, org chart: handle multiple elements in hierChildMiklos Vajna
In case one manager has multiple employees, then we laid out only the first one. Recognize non-assistant type as the node type (as a start) to get the correct number of employees (when there are no assistants), and also render employees on a horizontal (and not on a vertical) path. With this, the 1 manager and multiple employees case looks reasonable. Change-Id: I3bbe0413586b1a2c25f9094dbd44f1a86c799c0f Reviewed-on: https://gerrit.libreoffice.org/65813 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-02sd: fix missing includeMiklos Vajna
Change-Id: I1f4ad3827e5c093222734f2f13f0239f7887aeed
2019-01-02tdf#42949 Fix IWYU warnings in sd/source/ui/[a-r]*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I0d9cee1cd17e168522f6161c515a325e5edf1496 Reviewed-on: https://gerrit.libreoffice.org/65234 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-01Fix typo in QAAndrea Gelmini
Change-Id: Ia52b5bd629b80a37d3205889cb2c720d00a3d484 Reviewed-on: https://gerrit.libreoffice.org/65778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-29tdf#115691 Keep focus in effects list after previewJim Raykowski
Fixes gtk2 and gtk3 builds not keeping focus in effects list when sidebar is undocked. Change-Id: Iab2038bbf1ef2c1e6e1707f59776672d1b07404f Reviewed-on: https://gerrit.libreoffice.org/65618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-22tdf#122271 NB Impress use the wrong SpellDialog commandandreas kainz
Change-Id: Ib279e2677b4f58e77c7e03f6cfc21bfa7cbf077c Reviewed-on: https://gerrit.libreoffice.org/65570 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-12-21oox smartart, org chart: add initial hierChild/Root algorithmsMiklos Vajna
hierChild is supposed to align and position its child layout nodes in a linear path under the hierRoot layout node, so initially just use a simple vertical layout algorithm. Change-Id: Ie0090a724f8fbd2068fa2e08d8bc342290dcc2f0 Reviewed-on: https://gerrit.libreoffice.org/65554 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-21pass UserData by unique_ptr in MasterPagesSelectorNoel Grandin
Change-Id: I4dbd6b37f969ea3afb441b449d416eedd6bd5cec Reviewed-on: https://gerrit.libreoffice.org/65530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21no need to store B2DPolyPolygon on the heap hereNoel Grandin
it's a COW type internally, so only one pointer big Change-Id: I478f5aa6f84c87bedf6f450526e7f8f7c297e7c4 Reviewed-on: https://gerrit.libreoffice.org/65529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20sd: support for saving into .potx fileVasily Melenchuk
MS PowerPoint template format now supported not only for import, but for export too. Change-Id: Ib61798b5fe966b895ed850f4b4ad7d7d06740adc Reviewed-on: https://gerrit.libreoffice.org/65475 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-19Simplify containers iterations in sd/*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I29ccc94be73ec3ab22c4915f4a18ad0247038cc4 Reviewed-on: https://gerrit.libreoffice.org/65204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18Related: tdf#103884 remove dangling menubar commandCaolán McNamara
since... commit 08a43cc97ccf88faa9d3a04afc3aacd2c885a2d1 Date: Sat Oct 28 02:28:18 2017 +0200 related: tdf#103884 remove gltf/collada feature Change-Id: I7671746f2b33f8d4eae207448267d0284a3f9804 Reviewed-on: https://gerrit.libreoffice.org/65336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18NB grouped_compact add impress special view context- elementsandreas kainz
Change-Id: I8c466b04748da44af97b6e21fc8cced7f40304af Reviewed-on: https://gerrit.libreoffice.org/65314 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-18tdf#121592 add context-Form toolbar to NBandreas kainz
tabbed and groupedbar_compact add context-form support Change-Id: I4a59d4b71bbbc253ee4188c4c15a7353e623e2f1 Reviewed-on: https://gerrit.libreoffice.org/65295 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-17tdf#121581 update Tools tabb in NBandreas kainz
Change-Id: I788e97ce1f6422ba95a478fb1618773c850764f5 Reviewed-on: https://gerrit.libreoffice.org/65262 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-17tdf#122154 add DataSort action to data groupandreas kainz
and update some alignments Change-Id: I8d21e2764805e6b86fce776b7587d7bc0f76ae33 Reviewed-on: https://gerrit.libreoffice.org/65259 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-17Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-17nb groupedbar_compact impress sync table context menuandreas kainz
Change-Id: I31908adeab72a16a5b82fbc3bc8ac3cce9ea4a4f Reviewed-on: https://gerrit.libreoffice.org/65218 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-16crashtesting: assert on import of ooo121169-1.pptCaolán McNamara
Change-Id: I3b57bdd9a29ef41900bbb244daa27bf6d8c673c7 Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)). Reviewed-on: https://gerrit.libreoffice.org/65228 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-16nb groupedbar_compact fix table layout to sync with othersandreas kainz
Change-Id: Iac5a3144f9790457c2ccbe0fb916b66421443a6c Reviewed-on: https://gerrit.libreoffice.org/65216 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-14oox smartart, accent process: fix missing bullets and large para indentMiklos Vajna
Bulleted paragraphs had a large left indent because we assumed the bullet levels are inherited from the normal master page styles. But that's not true, as <https://support.office.com/en-us/article/add-bullets-to-a-shape-in-a-smartart-graphic-47edc03d-a2f8-4b54-acfd-ca103c515ab4> points out: "It is not possible to change the bullet style for text in a SmartArt graphic." This explains why the margin and bullet char info is missing from the file format, and hints that just hardcoding these to the importer is correct. The result is less linebreaks in the shape text and the lost bullets are also fixed. Change-Id: I60bbee75f3e834551ebb1963a2f42101f3bd91d4 Reviewed-on: https://gerrit.libreoffice.org/65168 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-14coverity#1441522 FontWorkGalleryDialog mpSdrView member is never nullCaolán McNamara
Change-Id: If17d2984831b0881d39101648206accdadde12aa Reviewed-on: https://gerrit.libreoffice.org/65163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-14update groupedbar_compact drawandreas kainz
Change-Id: Id00bcd45faa3d9e82d3ed23843f5c4320bfa8f79 Reviewed-on: https://gerrit.libreoffice.org/65135 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-14update groupedbar_compact for impressandreas kainz
Change-Id: I2d6c6d975a3047c879a87a1cee0305772c6b5d49 Reviewed-on: https://gerrit.libreoffice.org/65134 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-13Simplify containers iterations in sd/source/ui/[a-r]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I063dc78205a4cd982c252a9b62c456e9660b8790 Reviewed-on: https://gerrit.libreoffice.org/65063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13use unique_ptr in checkForUniqueItemNoel Grandin
fixing a memory leak in chart2 Change-Id: Idddb6a46b1bde5c1a11148c03bbdaac20ac78e13 Reviewed-on: https://gerrit.libreoffice.org/65031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:unusedfields in sdNoel Grandin
Change-Id: Ifbcaeb1fae1c181861ceceed79dc0c9fd6545751 Reviewed-on: https://gerrit.libreoffice.org/65052 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12oox smartart, continuous block process: read space width from constraintMiklos Vajna
The information is needed by the linear layout, but it's provided by a child algorithm of type "space", with possibly multiple foreach atoms in-between. So start supporting a custom space factor by reading it from constraints, but still assume a fixed layout node name, as it's tricky to look that up. Change-Id: I2aa8db8823694618d8ca6707ddcd71715a65b831 Reviewed-on: https://gerrit.libreoffice.org/65049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-11Impress: Support drag'n'drop of multiple effects in animation paneBrian Fraser
Change-Id: I004b2738929e9755dba03c8cab5cb2e2ccae707d Reviewed-on: https://gerrit.libreoffice.org/64129 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-12-11find-unneeded-includes: Avoid proposing o3tl fw declarationGabor Kelemen
This does not really work: even when it seems to, it compiles only because of transitive includes - Filter o3tl/typed_flags_set.hxx in f-u-u - Remove already added fw declarations from hxx files and include full header just in case - Remove now unnecessary blacklist entries Change-Id: Ie0de6667af697095a623b435806449e7e28a6004 Reviewed-on: https://gerrit.libreoffice.org/64659 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-11tdf#121677 missing item name check for updatesandreas kainz
Change-Id: I35f2beffb564f1e20731ca1e972b69130276cdea Reviewed-on: https://gerrit.libreoffice.org/64905 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-10simplify some copy constructionNoel Grandin
Change-Id: Icc20ae913052a7ae96c0722a458d75bbb5eef1cd Reviewed-on: https://gerrit.libreoffice.org/64862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-10Simplify containers iterations in sd/source/ui/[s-v]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I13c9982ad1e1aadbc6189068c5a5e29dfb171e97 Reviewed-on: https://gerrit.libreoffice.org/64811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10Check pDoc is not nullXisco Fauli
Change-Id: I9a85e6ee0b1d2df36999cbd968d84bf60e62f0a9 Reviewed-on: https://gerrit.libreoffice.org/64758 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-12-09Tabbedbar: add EditDoc command to Review Tabandreas kainz
Change-Id: I37b1397dc8406759ac138921aa9fa6c528f95bc7 Reviewed-on: https://gerrit.libreoffice.org/64827 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-08Remove misguided FALLTHROUGH commentsStephan Bergmann
...between adjacent switch labels without any intervening statements Change-Id: Ieb8a0d9f71ea4382b5f7d005cdf7111d06aeb5d0 Reviewed-on: https://gerrit.libreoffice.org/64789 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07HAVE_CPP_INLINE_VARIABLES is always true nowStephan Bergmann
...but for safety, leave the configure.ac check in for some longer. Also remove now-redundant SAL_INLINE_VARIABLE again (which was LIBO_INTERNAL_ONLY). Change-Id: Id049e0cb84b4f97f5859f1b16b867b39b448dec0 Reviewed-on: https://gerrit.libreoffice.org/64772 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07utility constructor for Image "private:graphicrepository" urlsNoel Grandin
Change-Id: I118039f4e47818a43da9302ce3550ea800522675 Reviewed-on: https://gerrit.libreoffice.org/64765 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-12-07lok sd: Insert the new shapes in the center of the slide.Jan Holesovsky
Change-Id: I134f86dc0c49ddf26e7a3cfe790c49ab200de9e9
2018-12-07LOK: Update failing unit testsTamás Zolnai
Change-Id: Ib30be297d87fa40c03974e0a97f243812dc488f3
2018-12-07lok: Insert shapes directly into the document.Mike Kaganski
Change-Id: I182aa395ce0f4e4185c9c85a866dec89499842f9
2018-12-07tdf#63029 Copy and paste comments with slidePaul Trojahn
Change-Id: Iceb0e744f8e994ece91cd8f50fefaed631aa8396 Reviewed-on: https://gerrit.libreoffice.org/64126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07remove unused SvxNumRuleFlags::CHAR_TEXT_DISTANCENoel Grandin
which is dead as far back as its introduction in commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: Ieff923732005aaa48cfae4918e8094020e6a540b Reviewed-on: https://gerrit.libreoffice.org/64715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07loplugin:singlevalfields extend to all static varsNoel Grandin
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528 Reviewed-on: https://gerrit.libreoffice.org/64710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-06tdf#121926: Take metrics into accountXisco Fauli
Similar to 6d9a2557a0f0366fff169f3c3581414b3cec80bd Change-Id: Ifecc3f86a3da8fdd4b0535cb67c6315e0d418f5a Reviewed-on: https://gerrit.libreoffice.org/64645 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-05remove unused SdrSwapGraphicsMode enumNoel Grandin
Change-Id: Iec7660563e96f821f72caae5047820f425ca69fb Reviewed-on: https://gerrit.libreoffice.org/64565 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-15 05:21:49 +0000