summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): sdStephan Bergmann
Change-Id: Ie309b2add3f615822a16e69c41c5e2e9f0ac9f7d Reviewed-on: https://gerrit.libreoffice.org/76650 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31tdf#126511 Show only icon names instead of full path.Gülşah Köse
This commit shows only icon names insead of the full path of icon on Bullet and Numbering dialog graphic case on Impress. Change-Id: Iba72bf7c413993bad88add669035765aae521a59 Reviewed-on: https://gerrit.libreoffice.org/76716 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-30tdf#126605: Do not end TextEdit when changing an attributeXisco Fauli
otherwise, pTextEditOutlinerView becomes nullptr in svx/source/svdraw/svdedxv.cxx:2184 Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921 Reviewed-on: https://gerrit.libreoffice.org/76606 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-29sfx2: Re-enable the sidebars for LOKAshod Nakashian
This re-enables the sidebars for LOK, which were disabled to avoid overheads. Also, fixes a regression where editing stopped when loading a new view because the sidebar window creation killed the edit view. Revert "Avoid various desktop GUI elements when used from LibreOfficeKit" This reverts commit c0b70ec34d5e056bb92a66cbf83838923cb41fee. Also (added by Noel to the above commit) (1) Comment out parts DesktopLOKTest::testPaintPartTile test that trigger a crash. We are installing a callback that points to something on the stack, and then not removing that callback, resulting in calls to random stack memory. There is a further problem in the LOK code in that we cannot uninstall a callback when we have multiple views because the uninstall code in doc_registerCallback can only remove a callback for the __current__ view, which I do not fix here. (2) prevent code from accidentally creating empty entries in the mpCallbackFlushHandlers map, which is what happens when you use the index operator on map, which results in a crash in doc_registerCallback because the std::shared_ptr is empty. (3) In SdTiledRenderingTest, only turn off LOK via LibreOfficeKit::setActive(false) once the document has been torn down. Otherwise, we don't remove entries from the statically allocated s_pLOKWindowsMap map in vcl/source/window/window.cxx, which means that at process exit, we have dangling Window objects. Reviewed-on: https://gerrit.libreoffice.org/71165 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 88565c3662c6fde240c98a9b4f2ce6dfbcf4094e) Change-Id: I06b06a990f05c06b1889fa89b698dff6f494e09c Reviewed-on: https://gerrit.libreoffice.org/76466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29weld SdTpOptionsMiscCaolán McNamara
Change-Id: I43db706b74811a18f573fe20cac041d320f9331c Reviewed-on: https://gerrit.libreoffice.org/76535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Simplify Sequence iterations in sdArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: If4b6d464fc393049dc8d7e5c3faf1cf66b6a369a Reviewed-on: https://gerrit.libreoffice.org/76480 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29weld SdParagraphNumTabPageCaolán McNamara
Change-Id: I71802d3d8f6335480ea2f74f6812470a8c13b0b8 Reviewed-on: https://gerrit.libreoffice.org/76536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld SdTpOptionsContentsCaolán McNamara
Change-Id: I96296248aa1a91a248b44ce676ab45925a353cf3 Reviewed-on: https://gerrit.libreoffice.org/76534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Resolves: tdf#126510 - Expander sections are bad UXHeiko Tietze
GtkExpander replaced by GtkFrames Change-Id: I07130f7f070e45bf60ffb4fc26605b79556534b3 Reviewed-on: https://gerrit.libreoffice.org/76219 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-29Fix typosAndrea Gelmini
Change-Id: I11e3dc250c140b03bbc2d2d83a448e40a1624fe3 Reviewed-on: https://gerrit.libreoffice.org/76519 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-29weld SdPrintOptionsCaolán McNamara
Change-Id: I09cdf0b327e775bf8b87c353a4d46fa6320c12aa Reviewed-on: https://gerrit.libreoffice.org/76505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:writeonlyvarsNoel Grandin
Change-Id: I00b495685cc9f74440051eafa2f8681a050a536e Reviewed-on: https://gerrit.libreoffice.org/76497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:collapseifNoel Grandin
Change-Id: I69bfafa97c66ef944cc6ae35c7e2f66d0430d6a4 Reviewed-on: https://gerrit.libreoffice.org/76496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-27drop newly unused DECL_ABSTDLG_BASE and IMPL_ABSTDLG_BASECaolán McNamara
Change-Id: I7288052dce03aa1cd1642b5de1e47508f4d47341 Reviewed-on: https://gerrit.libreoffice.org/76338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27drop newly unused SdVclAbstractDialog_ImplCaolán McNamara
Change-Id: I3c8435f3428f1222e1adb4768af697df6aaaf828 Reviewed-on: https://gerrit.libreoffice.org/76337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27enable setting a highlight bgCaolán McNamara
(cherry picked from commit 9b618c846835abb1fe664b5951dffb3c133380fe) Change-Id: I44649a9e2b1b267b56c2a5691d23665e7df94a58 Reviewed-on: https://gerrit.libreoffice.org/76449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27weld RemoteDialogCaolán McNamara
Change-Id: I4d3b9f7629137bc9b94f5c0426ae6fc956a97511 Reviewed-on: https://gerrit.libreoffice.org/76336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27Removed duplicated includeAndrea Gelmini
Change-Id: Ifa2745d724f343f5c99adc577136ca13937d7737 Reviewed-on: https://gerrit.libreoffice.org/76468 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-26sfx: LOK: notify clients of the sidebar stateAshod Nakashian
Change-Id: I35b174c3a5e302ce52ee4063fa71d47feffab624 Reviewed-on: https://gerrit.libreoffice.org/73520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: toggle sidebar decksAshod Nakashian
Change-Id: I0559a2a4ae041bc61cf3a2d5979656a7941f4b02 Reviewed-on: https://gerrit.libreoffice.org/73518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26cid#1448362 silence Dereference null return valueCaolán McNamara
Change-Id: I6b24a10bb2cd67d9750702a43d15162fb5347d76 Reviewed-on: https://gerrit.libreoffice.org/76366 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26cid#1448222 Out-of-bounds readCaolán McNamara
possibly gold Change-Id: I170d9ae52e7e2b2869655d6649496fce8661a20b Reviewed-on: https://gerrit.libreoffice.org/76368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26LOK: sd: no animation preview for LOKAshod Nakashian
Change-Id: I67babe9b340bafd196dedb2918d6a24bfc9c0ad5 Reviewed-on: https://gerrit.libreoffice.org/73515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26tdf#39742 tdf#44786 Consider Impress/Draw default printing settingsGabor Kelemen
Default settings can be set under Options - APP - Print but Impress/Draw has not used these as defaults unlike other apps Change-Id: I7d430f8fb24f9626cd628b4fe9e0520d9d42b848 Reviewed-on: https://gerrit.libreoffice.org/76079 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-07-26sd apps multiselect add Name and Description commandandreas kainz
Change-Id: Ia32f99ae967663f8a202a271061bbf61427eaf09 Reviewed-on: https://gerrit.libreoffice.org/76343 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-26tdf#125923 Fix reset button.Gülşah Köse
Reset/Revert button worked as cancel, not reset. That commit provides reset button to do its own job. Change-Id: I82d3e838bff3fd690cb5a901232ecb5f76257b95 Reviewed-on: https://gerrit.libreoffice.org/76341 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-25weld SdPublishingDlgCaolán McNamara
Change-Id: I64ce16c8b107b8b4d6009e6e2d5775cbf173a019 Reviewed-on: https://gerrit.libreoffice.org/76334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-25add XInitialization to allow setting explicit dialog parentCaolán McNamara
Change-Id: Icc2626b6b3defeb6c02a43cee14cdb97dc573870 Reviewed-on: https://gerrit.libreoffice.org/76290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-25sidebar: Add .uno:MasterSlidesPanelAshod Nakashian
Change-Id: I578dc8b1f9c8df7f7cc9108c70d6fad8006871c6 Reviewed-on: https://gerrit.libreoffice.org/73502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: LOK: avoid caching pointers and leakingAshod Nakashian
Change-Id: I68163bc30b0655b11dec34bdcc750b495b93365a Reviewed-on: https://gerrit.libreoffice.org/68265 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit da70e562087b6016aeaffadedc4ce66eaf370919) Reviewed-on: https://gerrit.libreoffice.org/76284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: LOK: support localization of slide transition presetsAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/68264 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 312346531dde33cd000a1d3c95c7b7829b656438) Change-Id: Ic3ea57e537e118e10d155203921574967154c234 Reviewed-on: https://gerrit.libreoffice.org/76283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sidebar: hide preview and play controls in lokitAshod Nakashian
Change-Id: I7fc9470082612af4c4d7e56ff704936da5c63ce4 Reviewed-on: https://gerrit.libreoffice.org/73501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: LOK: publish statechange on entering master viewAshod Nakashian
Change-Id: Ib736800544b9669e3708da0c01370af22cdf3e97 Reviewed-on: https://gerrit.libreoffice.org/69617 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5 Reviewed-on: https://gerrit.libreoffice.org/76280 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24cid#1448222 Out-of-bounds readCaolán McNamara
possibly coverity gold Change-Id: I6443225482eab5be31e1e12d282e420e767f23b2 Reviewed-on: https://gerrit.libreoffice.org/76254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24sd: LOK: support per-user localization of CustomAnimationPresetAshod Nakashian
This only fixes the caching in CustomAnimationPreset and CustomAnimationPane. Other cached labels will be done separately. Reviewed-on: https://gerrit.libreoffice.org/68263 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit b44679e47211a27f4fe22d05762d9d48c8f88935) Change-Id: Iaf511168d26b3a5567ca53556e242d3c071d2623 Reviewed-on: https://gerrit.libreoffice.org/76241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24sd: use OSL_DEBUG_LEVEL instead of DEBUGAshod Nakashian
Change-Id: I0703a1564a23657e956e43fe4cbf1d9549acb94f Reviewed-on: https://gerrit.libreoffice.org/68258 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1451642 silence Division or modulo by zeroCaolán McNamara
Change-Id: I728528ecbb69c23b63807944e4ae0beb9cb86cbb Reviewed-on: https://gerrit.libreoffice.org/76222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24LOK: sd: use native SdPage to flag selectionAshod Nakashian
The slide-sorter is actually still necessary to apply/change the master slide of a given slide, so we must enable it. Change-Id: I3f59f58be76ab1c63453b4f6288044572800a556 Change-Id: I7554ba4afd28d7ea4f3ed6ba375d9765a89ef21c Reviewed-on: https://gerrit.libreoffice.org/69618 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24tdf#126070 Show scroll bars when preview overflows.Gülşah Köse
Change-Id: Ibb904fc1c5d283d8ca9d8ff8b2249d25d7091b5b Reviewed-on: https://gerrit.libreoffice.org/75954 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-22cid#1448269 Dereference null return valueCaolán McNamara
Change-Id: Ief2dfb8a87030d992a867a7a9014d3787e201831 Reviewed-on: https://gerrit.libreoffice.org/76111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22tdf#118370 Draw: add option to consolidate multiple textObjsJustin Luth
This gives the user a tool to consolidate multiple textboxes into a single textbox. First the user selects a group of textframes, and then runs the consolidate text function. This will REPLACE the marked textframes with a single textbox combining all of the text. The function inspects the text fragments to see if they end in sentence-ending punctuation. If not, then the next textbox's content is appended to it instead of starting a new pargraph. It is the user's responsibility to afterwards fix up paragraphing, and set paragraph properties. The rational for this patch is to simplify making major text changes on PDFs imported into Draw, since each paragraph is currently broken into tiny character-property textbox fragments. Copy/paste from the PDF itself doesn't keep character attributes, so it is hard for a user to re-create the text. This is related to tdf#32249, but as a comment says, a better solution would be to write an entire text-focused PDF import, rather than just pick up the pieces. And I agree, but considering this simple patch took me a couple of weeks of frustration, I'm obviously not the person to do that. And since the bug has been open for 9 years, likely no one else will either. Thus, this pick-up-the-pieces tool to help the end user. This initial patch works only with textFrames, but can easily be adjusted to consolidate other HasText() SdrObjects. However, that tended to produce unexpected results, so everything other than OBJ_TEXT is explicitly excluded. (Thus general shapes with text, callouts, text-along-path etc are ignored.) Change-Id: I68a9a5b187bf320a8e671414c5cb22b07725fd52 Reviewed-on: https://gerrit.libreoffice.org/75043 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-07-21loplugin:referencecasting in variousNoel Grandin
Change-Id: Id4e3d9d1bbfd47181299568afec45e996eb1eed5 Reviewed-on: https://gerrit.libreoffice.org/76071 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-21tdf#124583 NB draw/impress sync -context-draw stuffandreas kainz
Change-Id: I5e214c6f78a4b2e8c17861d813efba2dff90be53 Reviewed-on: https://gerrit.libreoffice.org/76025 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-21NB GlueInsertPoint didn't work in NB added EditGluePointandreas kainz
Change-Id: I1253fe7fe89ca1e247e8fafb348fbaa51a4e4f88 Reviewed-on: https://gerrit.libreoffice.org/76013 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-20cid#1448403 Use after freeCaolán McNamara
Change-Id: Ie63c336da7296ecad6aef56d57b064e450361b5d Reviewed-on: https://gerrit.libreoffice.org/76020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448375 Improper use of negative valueCaolán McNamara
Change-Id: Iaea347e5ca91ad164ad970ec8f0a485fd8a0d75e Reviewed-on: https://gerrit.libreoffice.org/76016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20loplugin:referencecasting in sdNoel Grandin
Change-Id: Ief0d02006afd6cb9cd6da1da9208e374df644a42 Reviewed-on: https://gerrit.libreoffice.org/75977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19Fix typosAndrea Gelmini
Change-Id: Ia7486fe6c110a4a7f53f1dac82dbff3a15405fd7 Reviewed-on: https://gerrit.libreoffice.org/75947 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
generated by cgit (git 2.34.1) at 2025-03-24 17:55:39 +0000