summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2017-01-18new loplugin: useuniqueptr: sdNoel Grandin
Change-Id: I2fc8a2fa57cc00edf2edab9e3722c824e75cb7e5 Reviewed-on: https://gerrit.libreoffice.org/33204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17sw, sd: fix indentationMiklos Vajna
The indentation in these files is consistent otherwise, let's keep it that way. Change-Id: I1d73caa03425cd4d1c98ff07935512b002fb2c72
2017-01-16Convert RID_MENU_NOTEBOOKBAR to xmlMaxim Monastirsky
Brings a lot of features (icons, keyboard shortcuts, customization, context menu interception etc.) Other changes: - Make SfxDispatcher::ExecutePopup take PopupMenuFlags arg, to be able to pass NoMouseUpClose, so that the menu won't close on mouse-up under anything != gtk3. - Make .uno:OpenFromWriter and .uno:OpenFromCalc async slots, to avoid crash under gtk3 when recycling the current frame. - Don't show the menu in customization dialog, if experimental mode disabled. Change-Id: Ieea2f73f6b48fbaf4bdfc4acf1a33d25422357cb Reviewed-on: https://gerrit.libreoffice.org/33101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-14rename from bmp to pngCaolán McNamara
Change-Id: Ibcb08acfd8ac518388c33b97121fc04a7b7dbf03
2017-01-13tdf#105188 sd: fix shutdown crash after accessing master pagesMichael Stahl
The problem here is that the destructor of SdModule does a lot of things, including destroying an SdXImpressDocument that is referenced from some SdGlobalResourceContainer. This calls SD_MOD() to get the SdModule to get some resource, but at that point SfxApplication::GetModule() returns null, because the sequence was changed from first deleting the SfxModules, then clearing the pointer in ~SfxModule to null, to unique_ptr::reset(), which, at least in libstdc++, is implemented via std::swap, so it clears the pointer before deleting the SfxModule. It appears rather brittle to rely on such a subtle detail, so refactor things so that SdGlobalResourceContainer is no longer owned by SdModule but has its own pet XTerminationListener, which means it will be destroyed earlier, while the SdModule is still fully alive. (regression from f7b1cd66167050afecf487e3d89ea12de74200b5) Change-Id: I7f03f3adf431be8728ef3d65a078b536cb96f959
2017-01-12tdf#64588 - prevent loss of non-uniquely-named slideJustin Luth
Although the UI prevents someone from renaming slides so that two have the same name, it is still possible to have such non-uniquely named pages apparently. Since drag/drop uses the name to add a slide to the clipboard, it resulted in duplicates of the first found instance of the slidename, and loss of the similarly-named slides when they were dragged to a new location. Change-Id: I2986a7c6c3360162adf9430f645d0dfc73f1d4e2 Reviewed-on: https://gerrit.libreoffice.org/32481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-12silence coverity#1371305 Missing move assignment operatorCaolán McNamara
Change-Id: I761e07d1583262d83074addbff4ca67b01640387
2017-01-11tdf#105182 sd: avoid iterating too far in SdOutliner::Initialize()Michael Stahl
Considering the valid indexes are extended by "-1" for backwards iterators and "size()" for forward iterators, it's obvious that a not-yet-at-the-end-in-the-other-direction iterator can be incremented once, but not necessarily twice. Why this code even wants to increment it twice isn't obvious to me. Change-Id: I578c8c6202049ebe6dbed41b8276a6bfa0566bbc
2017-01-11Some loplugin:conststringvar/stringconstant improvements: sdStephan Bergmann
Change-Id: If44cce6e4c241f6a2203d73f6d191f270fb5ca5a
2017-01-10replace namespace url strings with function callsRosemary Sebastian
Change-Id: I1b496a93449caa4a9699f71874f293eeaa1fa320 Reviewed-on: https://gerrit.libreoffice.org/32916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-10tdf#105199: Keep URL intactStephan Bergmann
Change-Id: I85681fcc81246414332f88dc46ce4a4b60896c97
2017-01-10New loplugin:conststringvar: sdStephan Bergmann
Change-Id: I7aa74260f1456a22bae368738e3947ead1ecc7be
2017-01-10Related tdf#100151: use disposeAndClear for mpShowWindow (sd)Julien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=100151#c33 Change-Id: I81e483189eacee086b680367148f8dd3ca2d3493 Reviewed-on: https://gerrit.libreoffice.org/32904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-09Test that patterns are correctly imported for MS binary formatTomaž Vajngerl
Change-Id: I8335ee35bae11c8014d6591744199e55bc3ec41b Reviewed-on: https://gerrit.libreoffice.org/32854 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-09New loplugin:externvar: sdStephan Bergmann
Change-Id: I753a49c35c0a459f110960c56ac345f8bfc79dee
2017-01-09tdf#101828 handle rtf/richtext correctlyOliver Specht
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-06Related: tdf#105150 PPT import: handle mso_fillBackground fill type of shapesMiklos Vajna
Equivalent OOXML markup is <p:sp useBgFill="1">. For now only handle the case when the slide doesn't have an explicit background, and assume that in that case we can default to white solid fill. This partially restores the code removed in 6137b5f72f5ec491ea6bd6631a65484fa24d2973 (coverity#735432 Logically dead code, 2014-03-25), so that ProcessData::aBackgroundColoredObjects is actually read. Change-Id: I9e7a9a41965db50638e9d9d1b2361af9fd7a98ca
2017-01-06tdf#105150 PPTX import: try harder to handle <p:sp useBgFill="1">Miklos Vajna
The bugdoc has two shapes. The red rectangle is supposed to be covered by the other shape, but it wasn't as the fill style was set to none. The reason for that was we ignored useBgFill, unless the slide had an explicit fill style. Assume that in that case a white solid fill is the default. Change-Id: Iea20e216e44e13db68887f285c10bc1a8feacf0a Reviewed-on: https://gerrit.libreoffice.org/32786 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05Related: tdf#105093 sd PDF export: handle css.presentation.MediaShape as wellMiklos Vajna
It's exactly the same as css.drawing.MediaShape in this context. Change-Id: I4be114ef731e85222f0dd1d897f646ad8da3849d
2017-01-05Base SvxLineEndWindow on ToolbarPopupMaxim Monastirsky
Fixes size and position issues under gtk3/wayland Change-Id: I357a5935e2b44fd3d5effde8cf7d3499e26384db
2017-01-04tdf#81754: Unit test for the loss of text on save of pptx.Jan Holesovsky
The problem itself was fixed by commit 2ad50c9a8c8411a57bbbd7a52734e72ffc4cc0ee. Change-Id: Ie7f0781e1f5a4d6c5297882a5f64a68b85558515
2017-01-04tdf#105093 sd PDF export: handle embedded videosMiklos Vajna
In practie embedded files always have a temp file URL, so from the PDF export's point of view they are still URLs, just at the end the contents of the URL is embedded to the PDF, not just the URL itself. So add a SetScreenStream() that's similar to SetScreenURL(), but it's for embedded, not linked videos. Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781 Reviewed-on: https://gerrit.libreoffice.org/32727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04Related: tdf#104841 sw PDF export: handle linked videos on non-first pagesMiklos Vajna
Be explicit about the page number, this way a video on the second page doesn't end up as an annotation for the first page. (In the Impress case each slide is exported separately, so there this wasn't a problem.) Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6 Reviewed-on: https://gerrit.libreoffice.org/32696 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-03sd: the long and sordid history of STR_GRAPHICS_STYLE_FAMILYMichael Stahl
Nobody can agree on what the poor string should say: a2a605d864417209f3bfacc858fe9107a1e48531 "Image Styles" cf5a2811bbf5c013da3c6421ecb013137b2cc595 "Graphic Styles" b55b96589f7fe0b2f426c2472da7174ab95aab87 "Drawing Object Styles" a71a562a9958fc58a5fb914bcf7f8056a353f618 "Image Styles" 77ab005ce70938d5541d5ffa7a937fb9e6beba1e "Graphics Styles" ... but since "Image Styles" is clearly wrong, let's try another innovative variant. Change-Id: I748a0fd50d6d13a48632f77434c7f3f35cc00050
2017-01-02tdf#104841 sd PDF export: handle linked videosMiklos Vajna
Use the screen annotation markup for this purpose. Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c Reviewed-on: https://gerrit.libreoffice.org/32654 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-29SD SlsClipboard: cleanup and preparation for tdf64588Justin Luth
Isolating the patch itself from reorganization/optimization of variables. No logic change intended. Change-Id: I9e9008d57b4948372af138fb47224ebcf9c48ceb Reviewed-on: https://gerrit.libreoffice.org/32480 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-12-25remove unneeded static_castsJochen Nitschke
found thanks to old comment Change-Id: I9dbdd8c2f17243ce0d89468c18abd852c0e5eb78 Reviewed-on: https://gerrit.libreoffice.org/32420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-25inline macroJochen Nitschke
Change-Id: I138989cf94f4a621af284999b58809c7f1bd0f8b Reviewed-on: https://gerrit.libreoffice.org/32410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-24tdf#70998 Text change: graphics/picture to imagetamsil1amani3
Changed files: sd/source/ui/app/strings.src svx/source/svdraw/svdstr.src Change-Id: I380f2c568120cdef2be7a5203307d5cda8b65530 Reviewed-on: https://gerrit.libreoffice.org/32337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-23tdf#101442 - "hyperlink" to "link"Federico Bassini
changing other words "hyperlink" to "link!" Change-Id: I29d97bab7844183759bc34624a14c0216258ad8b
2016-12-22drop imglstCaolán McNamara
Change-Id: Iff88349acf3fc0f474cff0a882346a6d8496aec1
2016-12-22should be sd icon, not scCaolán McNamara
Change-Id: Ib12d6b821e27cedf324e16c548254099b100fd3e
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21ODR violation (base class must be the same across compilation units)Stephan Bergmann
Change-Id: I3693e543fcca3796e3a3dfccabb8dce3f029531d
2016-12-21convert OutDevViewType to scoped enumNoel Grandin
Change-Id: Id980f09c198ca976c88b11030f5db9d6f010add1 Reviewed-on: https://gerrit.libreoffice.org/32274 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21remove newly unused SfxImageManagerCaolán McNamara
Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
2016-12-21convert EnumContext::Context to scoped enumNoel Grandin
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3 Reviewed-on: https://gerrit.libreoffice.org/32272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21convert EnumContext::Application to scoped enumNoel Grandin
Change-Id: Ia289a7b63bf8797085315218785e2a2a4c45d232 Reviewed-on: https://gerrit.libreoffice.org/32230 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-20use new ENABLE_NSS for code which needs nssCaolán McNamara
which isn't available on a static-only build (iOS and fuzzing) and android Change-Id: I99bb7c0b45d4499579ddf73f469a762ddcae99ab Reviewed-on: https://gerrit.libreoffice.org/32182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-20convert SFX_EVENT constants to scoped enumNoel Grandin
SFX_EVENT_CLOSEAPP and SFX_EVENT_TOGGLEFULLSCREENMODE are never generated, so remove them and delete the code that receives them Change-Id: I2d003ba73fff0b02120ba29ff58e1d2399dedf00 Reviewed-on: https://gerrit.libreoffice.org/32168 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-17Adapt to no-longer explicit OUStringLiteral ctorStephan Bergmann
...from previous commit Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f Reviewed-on: https://gerrit.libreoffice.org/32098 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-16Better way of converting from OUStringLiteral to OStringStephan Bergmann
Change-Id: If31548d280fa8cabced50f3d2e78abde1b2562e5
2016-12-15Try to fix Android and iOS buildTor Lillqvist
Fix what probably is fallout from a7c35729e00f18f79156b3f8f57472506f786074. Just bypass all of xmlsecurity for Android and iOS. At least the iOS demo app, TiledLibreOffice, builds then. Change-Id: Ibc9486c0d67d1aeafa08932809b23ceeb9b5c2f3
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-14sd: Remove empty fileTakeshi Abe
Change-Id: I2139e2ed35d4ecdeb94ff6673e12dd58986d0344 Reviewed-on: https://gerrit.libreoffice.org/31975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-13sd: Update list items only when necessaryTakeshi Abe
Change-Id: I48568cb535ebb4372b2cc361d839efe233dc1d36 Reviewed-on: https://gerrit.libreoffice.org/31942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2025-01-20 08:12:41 +0000