summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-03-25fix headless buildOliver Specht
disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-24loplugin:constantparam in sdNoel Grandin
Change-Id: I1a7f4cab28a70c45e5232e1c44f6ca6f7b014bff
2016-03-23tdf#93868: PPTX import: Incorrect inheritance of shape fill propertiesMatus Uzak
DrawingML: The useBgFill attribute specifies that the shape fill should be set to that of the slide background. Change-Id: I8b568e730f00326d51e7b604579f4ff990b26f8a Reviewed-on: https://gerrit.libreoffice.org/23039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-22add HAVE_FEATURE_ATL to disable failing tests due to ATLMayank Gupta
Change-Id: Ifcdf8bf9eb4c22df6493f85592c9c72fac28876e Reviewed-on: https://gerrit.libreoffice.org/23144 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-03-22tdf#98646 Fixed freeze by flattening loopsArmin Le Grand
DrawViewShell::MakeVisible was using loops for finding the area to change the visible part of the EditView to. That could (and did) potentially loop for a long time for very large objects, deep zoom or numerical problems. That loops were flattened, the results checked to be the same. Also added a test for numerical overflow for getting values from the Rectangle describing the object size. Despite these values being the result of erraneous import, I opt for checking and avoiding using these values. Change-Id: I783dc1f2ad9b6a60a47e660b0d576ea3f22a4e42 Reviewed-on: https://gerrit.libreoffice.org/23278 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-03-22tdf#84323: Make osl::Thread::wait more readableGurkaran
It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-20Revert "tdf#93124: Fix incorrect text fit in imported PPT"Thorsten Behrens
Change broke autofit feature, see bugreport. This reverts commit 5ca1f04976930c6fd656ebf89d667c80e2466897.
2016-03-19tdf#93124: Fix incorrect text fit in imported PPTMike Kaganski
To make text adjustment to full width, the alignment optimizations had to be removed, and bAutoFit was removed, too. Allso, to fix tdf#41245 again, the SDRTEXTFIT_AUTOFIT that is set in SdStyleSheetPool::CreateLayoutStyleSheets had to be overridden. I touch the following commits: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2000efb31f864e912c6cf52760eea0e602b6893 http://cgit.freedesktop.org/libreoffice/core/commit/?id=3550256daa5451c1d51d220d5489c1b20150c374 http://cgit.freedesktop.org/libreoffice/core/commit/?id=812aff65ad0661fed9687a429c763dc8f2144a0c Change-Id: I7f7934e2982baf0240c740e09fcb9bd348079064 Reviewed-on: https://gerrit.libreoffice.org/18895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-18convert SvButtonState to scoped enumNoel Grandin
Change-Id: I601f9e2fe33e85cf3f7dc52ee20d68202bd2b09d
2016-03-18convert SvLBoxButtonKind to scoped enumNoel Grandin
Change-Id: Ia8e19473132cf95837acc499c5831b5ca8786a68
2016-03-18loplugin:constantparam in sdNoel Grandin
Change-Id: Idad86a005a7df1af38722fa0e909ed9b6e0858fa
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-18loplugin:constantfunction in editengNoel Grandin
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17tdf#65219 Fix temp files clean up in sd unit testsAleksas Pantechovskis
Change-Id: I99037b01c1d644b1803b315cc5e3d8fa5a19bcfb Reviewed-on: https://gerrit.libreoffice.org/22986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-17loplugin:constantparam in sfx2Noel Grandin
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd Reviewed-on: https://gerrit.libreoffice.org/23321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in svxNoel Grandin
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80 Reviewed-on: https://gerrit.libreoffice.org/23303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16tdf#98678 removed double for-loopArmin Le Grand
By error the for-loop was added twice, removed one Change-Id: If098dae28857bd87a07bb828bab2c7330c5fd7f8 Reviewed-on: https://gerrit.libreoffice.org/23294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-16tdf#84953 Only resize proportionally when dragging on a cornerSamuel Mehrbrodt
Change-Id: Iec4eda867216575e058fa673788d9345da05c872 Reviewed-on: https://gerrit.libreoffice.org/23291 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-16coverity#1356337 Resource leakCaolán McNamara
Change-Id: Id00ee8abd5f22bf0594ad41e3922222872d6c5ca
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16sd: add license boilerplateChris Sherlock
Change-Id: Iab97ad48b44d2c1bc8c6712dfe9e3d52a974f0a0
2016-03-15tdf#97919 Also resize ole objects proportionally by defaultSamuel Mehrbrodt
Change-Id: I1c3b13aa4cb0127451353f20179f39b6eebe12ec Reviewed-on: https://gerrit.libreoffice.org/23284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15sd image resizing: Small code cleanupSamuel Mehrbrodt
The decision whether to resize proportionally should be made in FuPoor::doConstructOrthogonal Change-Id: I9f27bc377db2933f781f962b0048527ded533b34 Reviewed-on: https://gerrit.libreoffice.org/23281 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15tdf#97919 Resize media objects proportionally by defaultSamuel Mehrbrodt
as we do with images Change-Id: I5b27b8310736b9dfd5c274614ad4d1e4becb1fa9 Reviewed-on: https://gerrit.libreoffice.org/23277 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15DrawViewShell: Remove unused codeSamuel Mehrbrodt
Change-Id: I288f8793a649b8c672821a39c6d9f1238a104b7e Reviewed-on: https://gerrit.libreoffice.org/23275 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15DrawViewShell: Fix indentationSamuel Mehrbrodt
Change-Id: Iedeb9d36c20b6d9038990dc5b03ce9b560becac7 Reviewed-on: https://gerrit.libreoffice.org/23274 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15remove unnecessary parentheses in case labelsNoel Grandin
Change-Id: I987bf68c767709080c67c8b183c036a4109c6caa
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11Looks like no need to instantiate PresenterCanvas via service managerStephan Bergmann
(see commit message of 86ce77b9255ab92cceb6164828c90b0b3e1ee9ed "Don't adertise PresenterCanvas as com.sun.star.rendering.Canvas service"; maybe it was just cargo cult to make it available as a service in the first place) Change-Id: I31291a7685c89d469309754cc4630b824a276890
2016-03-11Don't adertise PresenterCanvas as com.sun.star.rendering.Canvas serviceStephan Bergmann
Window::ImplGetCanvas (vcl/source/window/window.cxx) tries to obtain such a Canvas service (passing in 6 initialization arguments), and the CanvasFactory in canvas/source/factory/cf_service.cxx apparently goes through the implementations advertised to implement that service, looking for the best match. At least for Linux-rpm_deb-x86_64@70-TDF-dbg tinderbox, it somehow manages to pick the PresenterCanvas (instead of one of the more obvious choices among the variants in canvas/soruce/{cairo,directx,vcl}), but which only epects 5 initialization arguments, so CppunitTest_cppcanvas_emfplus fails with a "PresenterCanvas: invalid number of arguments" exception. (And the choice of the PresenterCanvas looks more than dubious anyway.) Normally, instances of PresenterCanvas appear to be created "directly" from PresenterHelper::createSharedCanvas (sd/source/ui/presenter/PresenterHelper.cxx) so it shouldn't hurt to no longer adertise this implementation as providing the Canvas service---and it might not even be necessary to make it available via the service manager at all. Change-Id: Ie76bfc87fec51b6d5361930204e55ef9cb80370e
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10sd: handle classification during copy&pasteMiklos Vajna
This is the same feature as done for sw internal copy&paste and for the sw RTF filter: if the copying would leak information, better not to do that. Change-Id: I39186d7b798d822f1f3a5a4b1ce2aa000c6f7906
2016-03-10sd: copy doc metadata to clipboard documentMiklos Vajna
Just like in sw, doc metadata wasn't copied to the document. As a start, copy the user-defined doc properties. Note that this just takes care of the source -> clipboard part, it's still up to the clipboard -> destination code to decide how to merge the properties at the end. Change-Id: Ic506e25ab598f4748d443d65664a193d589acd3c
2016-03-10sfx2: make SfxClassificationHelper not require a full doc shellMiklos Vajna
So that input filters can build their own doc properties and can also use CheckPaste() without having the full original document around. Change-Id: I0b8a63702f73ce04e8728a360b56ab9d1ca67af1
2016-03-10tdf#94370: Make previews of master pages finally appearKatarina Behrens
Just force the whole ValueSet to be formatted. Individual rectangles are already being invalidated (when PREVIEW_CHANGED event comes), but something naughty must be happening in ValueSet that those changes don't show. Change-Id: I4fd8af36e34c3a445d7b16b59e45256f016fd9df Reviewed-on: https://gerrit.libreoffice.org/23115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-10Adapt to "Extract Directories from BootstrapFixtureBase"Stephan Bergmann
(60b1c95cc47831246f097ee13dda8bcd71c57eb4) Change-Id: I7d2319624b7a4ae38b1673c5a0053626f7f58c1c
2016-03-10tdf#89927: PPTX import: Incorrect inheritance of text run fill propertiesMatus Uzak
Make use of FillProperties in TextCharacterProperties. DrawingML: Fill related elements in Text Run Properties are in sync with Table Cell Properties and all of Line Properties. Change-Id: I7c513ecfc5f94cf49e98a657384b5c0f5dddc1c7 Reviewed-on: https://gerrit.libreoffice.org/22979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-10tdf#97591: mark RTF clipboard format as text/rtfOliver Specht
text/rtf replaces text/richtext which is not RTF Change-Id: I2be750b595ba23ed75698b68c0d4ffd8f3a12870 Reviewed-on: https://gerrit.libreoffice.org/23086 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-03-10tdf#87812: SIDEBAR: More animation information in list controlAkshay Deep
Added Effect Category in second line of list item. Changed variable names according to conventions. Change-Id: I611f3cd377eb5865f125c76c145266571b6d4985 Reviewed-on: https://gerrit.libreoffice.org/23095 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-10loplugin:constantparam in sdNoel Grandin
Change-Id: I7f5065c08f539ceefa4b8d3925b9c09e72b25a44
2016-03-10loplugin:constantparam in editengNoel Grandin
Change-Id: I078061c502c09bccf515151d3a5bdcd1176e64fb
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09loplugin:constantparam in sfx2Noel Grandin
Change-Id: I50a2d8221f907f0e844e558f3dbdd0346c010201
2016-03-09loplugin:constantparam in svxNoel Grandin
Change-Id: Ib2a432fc334898c75ab5e5cf629a21fd310bd467
2016-03-09Add missing includesDavid Ostrovsky
These include were needed to compile on Windows, MSVC 14.0 with clang-cl. Change-Id: I4ca5cec8314920e90fcca6fa69ec4df87d680f29 Reviewed-on: https://gerrit.libreoffice.org/23044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08loplugin:constantparams in vclNoel Grandin
Change-Id: I2114436f4bef3ac71a3035a206186cefaf88bca1 Reviewed-on: https://gerrit.libreoffice.org/23023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07drop now-needless depsDavid Tardon
Change-Id: I2ef0b873a58710de399889cee3abf6b6ecf4fb1e
2016-03-07remove remaining uses of gb_SrsTemplateTarget_get_targetDavid Tardon
Change-Id: I5ddf0ba5fc289a124b39b9c14b7f5fdd3d7b54a4
2016-03-07these ResIds are used solely for their number by nowCaolán McNamara
so cut out the middle-man ResId Change-Id: Ic83db355cc1a0c7dc70958bca79b466baadaedd0