summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2023-01-31uitest: remove wait_until_file_is_availableXisco Fauli
Introduced in 33a49a99c76ca1879dbb0202384aa939a6d44a75 "uitest: introduce wait_until_file_is_available" as a blind fix for https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91 It turned out the root problem was caused by another test and the fix is addressed in https://gerrit.libreoffice.org/c/core/+/146385 "uitest: Always change doc info setting back to false" Change-Id: I4b3d5e24e35a33de6c128dcbf2f144b4cf48a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146389 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-31Some simplification after 743dd1d3c1142c1c99b0844cc26dd0be91a1de40Mike Kaganski
MapMode ctor taking origin and scales sets mbSimple to false, so avoid calling it when these are the defaults. Some calculations become unneeded when the fraction is (1, 1). Change-Id: I19a98ad2cac0a66b9bd7b72620180addb3f7fec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-31sd: use XTheme to transport the theme to xmloff import/exportTomaž Vajngerl
Refactor the existing places and tests in Impress code (sd) to use it instead. Also keep the old property of construction and view of the theme with a sequence of property values, but under the new property named "ThemeUnoRepresentation". This is needed by the UI tests currently. Change-Id: I484567f4a603f1a5e2e03955fdd2b63132dcc66e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146225 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-31svx: Refactor (sdr) views to access the SdrModel by referenceTomaž Vajngerl
In SdrPaintView (and subclasses) the mpModel variable is always the same as the input (reference) model, so there is no need for that extra variable. Change the strange and confusing var. name mrSdrModelFromSdrView (the input reference to SdrModel) to just mrModel and use that in GetModel(). Change the GetModel() to return a reference instead of a pointer and reactor the code to accomodate the change. This gets rid of many nullptr checks for the pointer that the GetModel() returns and makes the code more simple is some cases. Change-Id: I18351a417fd82f49262a83de036ec1420a65399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146373 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-31SdrModel: we never set scale fraction to anything else than 1/1Tomaž Vajngerl
This removes the scale fraction on SdrModel - SetScaleFraction and the m_aObjUnit instance variable, as it is never set to anything else than 1/1 (and don't see it usefult to set it to anything else than this). Change-Id: I990d20f110b3be00e6770b68e39df212f9c576be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146348 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-30tdf#148810: sd: move UItest to CppUnittestXisco Fauli
Change-Id: I11c0ecfb628792ed0ce62916e01fe3b69cb0fc78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146363 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-30tdf#153185 PPTX: fix export of linked OLE objectsTünde Tóth
Linked OLE objects were not exported. Change-Id: If6e8c6e0d0c9917e8ec476ad14dcaa1602c74b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146073 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-29tdf#124230 export subTnLst for event triggered nodes.Mark Hung
LibreOffice export all the child nodes of a timenode to childTnLst. It seems that PowerPoint anticipate there being fixed starting-time timenodes on childTnLst. This patch export event-triggered audio time nodes to subTnLst to make audio playback work. Other node types can be added in the future once more test cases are found. Change-Id: Ic96ec50876f568145bdde122d01dec10c1ac7c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146295 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-29sd/filter/pptx-animations: store condition in NodeContext.Mark Hung
Change-Id: I80cc7209f5347562560590554a8aa9a61e410179 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146294 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-28sd/pptx-anmiations refactor NodeContext.Mark Hung
Change-Id: I6439882884b3808dec91eaaede50856b0afdd278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-28sd/filter/pptx-anmiation refactor Cond class.Mark Hung
Change-Id: Iffb0eeb1454a858987680d402add3f5122f7b6db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146292 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-28sd/source/filter refactor pptx animation export.Mark Hung
Refactor "Any NodeContext::getCondition(bool bBegin) const" to "const Reference<XAnimationNode>& NodeContext::getNodeForCondition() const", to get rid of the bool arguement of getCondition. Change-Id: Ic61d2caecaad2d3ada38556346f66aedb258e554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-27move Theme class to own file inside docmodelTomaž Vajngerl
Also move Theme from svx to model namespace so it is consistent with other classes in docmodel. Theme header also includes ThemeSupplementalFont, ThemeFont, FontScheme classes that are used by the Theme and were also moved to docmodel. These may be moved to its own file in the future when they are used in more places. Change-Id: Ic409bea8e5298adc2b039b529c4f7b01cf64f03e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146221 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-27move ColorSet class to own file inside docmodelTomaž Vajngerl
Also move ColorSet from svx to model namespace so it is consistent with other classes in docmodel. Change-Id: Iacbdbdf5ece4015c628a0e45adf6a732b2d27777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146220 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-26tdf#153107 OOXML export: fix scale of tile of shape backgroundTibor Nagy
Relative scale values were exported as absolute values, resulting broken shape background. Change-Id: Ia38e125862e7f8ceff5d41754340723c3a9eb028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145996 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-26cid#1520593 Uncaught exceptionCaolán McNamara
Change-Id: I14f412e9dda71863036cd99bc29f86d31b947163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-26tdf#153161: sd: move UItest to CppUnittestXisco Fauli
Change-Id: I14c1bc76b6cf19e287ef57a0aa5f34d842c69309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146163 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-26use more concrete types in sd consoleNoel Grandin
Change-Id: I5ac9d084616563ba3ae67ee040b4f52156baea67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146159 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26use more concrete types in sdNoel Grandin
Change-Id: Ia2903695ddb451e21b0ed4e8d0a149d912558a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146158 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26GetDrawController should return pointerNoel Grandin
since it may be nullptr Change-Id: Id618ef6a25a8432024a67170a7d1402cb0fa6b8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26use more concrete types in sdNoel Grandin
Change-Id: I545858fe18e8a436fd2dda7402c825eac28fb2fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146156 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26no need for sd::ModuleController to load these factories via UNONoel Grandin
Change-Id: I2ac1d29ff9cbd5c8676dc1957a62ea02454d052e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26use more concrete types in sdNoel Grandin
Change-Id: I754847ac759fb7c946f2c021e898fc0139ca5226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-25tdf#153161: (Ab)use a call to XTextRange::getString to flush editsMike Kaganski
Restore the call (without checking its returned value), removed in commit d194474aabd699806cb3631bc8641dd0548b8026 ("tdf#151100: xText->getString() may be empty for content needing export", 2022-09-22), side effects of which obviously allow some object's changes to get flushed and saved. Change-Id: I62f27cd056c32ad76f79a4862e2f4a0964eaadef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146106 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-24[API CHANGE] remove service sd::framework::ModuleControllerNoel Grandin
It makes no sense to be constructed externally. Change-Id: I7e756e225e7b6e1785194b2f73edd5a7d65ec0e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-24[API CHANGE] remove service sd::framework::ConfigurationControllerNoel Grandin
It makes no sense to be constructed externally. Change-Id: I6fb8f58ff8594c58d190f78e6f26b2703046a95b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-23[API CHANGE] sd::frame::Configuration does not need to be an UNO serviceNoel Grandin
It does not ever appear to have been used as such, and it makes no sense to be constructed externally. Change-Id: Ia1a0cccdaeb19ded1197ad8aae701ac86dd3bb48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145989 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-23Resolves tdf#113439 - Show/Hide menu item in Draw's layer menuHeiko Tietze
Introduces .uno:ToggleLayerVisibility duplicating the existing LayerTabBar::MouseButtonDown() function Change-Id: I726d9a620afe22c84e5f20e76fabdfeccbcfb083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145558 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-22XUnoTunnel->dynamic_cast in SdXCustomPresentationNoel Grandin
Change-Id: I4841e93b9e15b3406f588bbbc6da9d91a2143350 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-22XUnoTunnel->dynamic_cast in SdLayerNoel Grandin
Change-Id: Id61d38dd9f3066d07ec325494753cd9096152e9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-22XUnoTunnel->dynamic_cast in SdLayerManagerNoel Grandin
Change-Id: Ibea94a8168538e59eea6312fd49b162534df8d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-22XUnoTunnel->dynamic_cast in SdUnoPageBackgroundNoel Grandin
Change-Id: I67e911eba5333770b83a3b5e7e2c1a7bc96ef1c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-22XUnoTunnel->dynamic_cast in SdUnoSearchReplaceDescriptorNoel Grandin
Change-Id: I26038e7d57f30b8cca661a5b4d56b8bb685eedd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-21move presenter console from sdext/ to sd/Noel Grandin
It really wants to part of the main sd UI where it can interact nicely with the existing logic, instead of using awkward UNO APIs. Change-Id: I6e0d486275515d48abe3438b88d4f58d4bee58fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145913 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20[API CHANGE] remove unused SlideSorterServiceNoel Grandin
which was introduced in commit 8c4d7aa42dd4b3b08c3b4a9e4ba772737b7bd0c4 Author: Kurt Zenker <kz@openoffice.org> Date: Thu Apr 3 13:42:43 2008 +0000 INTEGRATION: CWS presenterview (1.1.2); FILE ADDED but does not appear to have ever been actually used. Change-Id: Icd33f81cfee246fe72a4b9e584f7a6ca96d6e38b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20[API CHANGE] PresenterTextView UNO service is deadNoel Grandin
Nothing constructs it, and it looks like it was never fully hooked up, various bits of it have been removed, starting with commit a38cbc58bbe3b385830a5287ea272e28a8ae3652 Author: Felix Zhang <fezhang@suse.com> Date: Mon Oct 24 17:50:01 2011 +0800 remove unused methods from sdext:presenter Change-Id: I61080fa589ab6b886b841d7be5eed892c4bd829a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145898 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20no need to load the list of impress/draw modules from configNoel Grandin
this is not something that changes Change-Id: Ie382665690a8baa31c916029de567cccdfdd0425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145897 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20PresentationFactoryProvider can just be a static methodNoel Grandin
Change-Id: Ie46d784b10e01e394235b31d986868d72c4dbd10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145896 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20improve loplugin:refcountingNoel Grandin
to catch places where we are converting a weak reference to a strong reference, and then using a pointer to store the result Change-Id: I69b132907b574e5c6974fadf18bd9658107d3a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145877 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20change test to use Calibri instead of CambriaCaolán McNamara
because of the Caladea problem There are sadly now two Caladea fonts with different metrics, see: https://bugzilla.redhat.com/show_bug.cgi?id=2162532 https://github.com/huertatipografica/Caladea/issues/4 Change-Id: I7080d16ec8aae2bbe60717aea85b980a33340e9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-20tdf#148000 impress: Handle linebreaks on fontwork.Attila Szűcs
Split text lines in a paragraph, right before polygons are created for rendering, so eol will brake line in fontwork just like eop. Change-Id: Ie9e6764f9f91c2e19afd43dc9a212bd18c41c99d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145425 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-20[API CHANGE] no need to load PresentationFactoryProvider via UNO and/or configNoel Grandin
there is no benefit to having this constructed in such a convoluted manner Change-Id: Ib02b4bfe689326784bd8233003d10960700811d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-19Remove not necessary container in Animation Panel in Impress SidebarSzymon Kłos
It was causing layouting issues in LOK. Change-Id: Ic7520f46efa764d2d6b50b021b44e0a5dd07d837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136343 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145791 Tested-by: Jenkins
2023-01-19Fix SdGenericDrawPage et al queryAggregationStephan Bergmann
The base SvxDrawPage uses WeakAggImplHelper7, so (for better or worse) derives from XAggregation, but SdGenericDrawPage and its derived classes (SdDrawPage, SdMasterPage) failed to properly implement the XAggregation protocol. When fixing this, it became apparent that SdGenericDrawPage::queryInterface had erroneously delegated to SvxDrawPage::queryInterface rather than to the intermediary SvxFmDrawPage::queryInterface, so that querying for e.g. XFormsSupplier had only worked by accident: SdGenericDrawPage::queryInterface didn't support it, so delegated to SvxDrawPage::queryInterface, which didn't support it, so delegated to WeakAggImplHelper7::queryInterface, which didn't support it, so delegated to OWeakAggObject::queryInterface, which (as there was no delegator set) delegated to the most derived SvxFmDrawPage::queryAggregation, which supports it. Change-Id: Ia7154d62e493238738e6d15dea2f01a437a70bff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145763 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-19tdf#153036 PPTX import resized connector brokenAttila Szűcs
Fixed the EdgeLine1Delta calculation in case of bentConnector2. (when L shape imported as a special Z shape) Co-authored-by: Tibor Nagy (NISZ) Change-Id: I08c92e63adc744322061e4e433bfdc512745eda1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145548 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-18give message dialog a suitable parentCaolán McNamara
Change-Id: I2eb21cbc9e89189ab0fa4090c04fec98f654a542 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145687 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-17XUnoTUnnel->dynamic_cast in sd::ViewTabBarNoel Grandin
Change-Id: I0aae59685986f07e74a15ef7e7261de808b20c47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-17XUnoTunnel->dynamic_cast in sd::DrawControllerNoel Grandin
Just past the concrete type down through a couple of layers, rather than using a generic type and then casting Change-Id: I7ba6c83463f3db7176b72cb7e764d3659706ae78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145638 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-17tdf#152991 sd: fix oversized rectangle of edited embedded objectTünde Tóth
The embedded object became unusably oversized after editing, because it was not possible to minimize it by the mouse. Now the object keeps its original size to avoid of the UX problem. Note: losing the original zoom of the OLE content is still a problem. Change-Id: I8b7a2f2a84324bf4de2358ecb5fec5c1f7349155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145454 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-01-17XUnoTunnel->dynamic_cast in ViewShellWrapperNoel Grandin
Change-Id: I204bbfc67a6c60723d8ebb21424ac5c184f9b2cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-21 13:11:55 +0000