summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2017-12-11Fix typos and grammarIlmari Lauhakangas
Change-Id: I4143da3c5a809118d57849664f6ab1d2e775837f Reviewed-on: https://gerrit.libreoffice.org/46253 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10remove unused osl/time.h includes ..Jochen Nitschke
and some more in base64.cxx Change-Id: I31c9f23d3bd11f5482774e976a7c40025ffcfb86 Reviewed-on: https://gerrit.libreoffice.org/46157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08GetMarkableObjCount() is only compared against 1Matteo Casalin
Change-Id: I390b260fe481c7db73a065dd271c78a5df188ccc
2017-12-08tdf#68759 PPTX: Export IsMirroredPaul Trojahn
Change-Id: I6bab00f79f1cb122344e4bb9fd62eb4c48a1838b Reviewed-on: https://gerrit.libreoffice.org/45808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-07lokit: add .uno:DocumentRepair commandHenry Castro
Change-Id: I5b13ea6f4785bc91c29111fa63c4a1b0ea9b2660 Reviewed-on: https://gerrit.libreoffice.org/38908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-07tdf#89466 Fix minor localization bugsYousuf Philips
Change-Id: I1ee93f81dcd83b5a9277ea444ec8e10db7d790df Reviewed-on: https://gerrit.libreoffice.org/45958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-07tdf#57950 replaced some O(U)StringBuffer::append() with operator+ekuiitr
Change-Id: Idd32e3f68787186c157ba7382cab39b0b974ac20 Reviewed-on: https://gerrit.libreoffice.org/45879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:constparamsNoel Grandin
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06tdf#114207 create commands for slide number and slide fieldsYousuf Philips
Change-Id: I5b7cfaf602568d9254dfeafd6afe27b9b0895d37 Reviewed-on: https://gerrit.libreoffice.org/45722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-06tdf#101014 Keyboard between textboxes - part 2Marina Latini
Fixed the a11y issue in layout AUTOLAYOUT_TITLE_2CONTENT_CONTENT now the selection via keyboard works as requested Change-Id: I034776393c8cca68d5cb3702f12111a057d4134b Reviewed-on: https://gerrit.libreoffice.org/45907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06coverity#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I358b3c410bc7871c7184da4959b24b9f52b4a4d7 Reviewed-on: https://gerrit.libreoffice.org/45892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06loplugin:salcall handle virtual methodsNoel Grandin
Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42 Reviewed-on: https://gerrit.libreoffice.org/45851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05tdf#113856 Navigator: Bad behaviour of controllers when changing slidesmartinb214
Change-Id: I11e9cb607c36112f19f7cace1d8c5b7559ebf2a1 Reviewed-on: https://gerrit.libreoffice.org/45423 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-05Fix typoAndrea Gelmini
Change-Id: I085d0346d6f7aebc6e685bc1c2407535eb227dfc Reviewed-on: https://gerrit.libreoffice.org/45835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:countusersofdefaultparams in editeng..packageNoel Grandin
Change-Id: I4c20235a04d9ab5ea5edbb6b1b2413677b18a305 Reviewed-on: https://gerrit.libreoffice.org/45795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05remove some unused definesNoel Grandin
and move the script to python Change-Id: I97bca04053d9d38b59c74fcf61caafbc2c137cc9 Reviewed-on: https://gerrit.libreoffice.org/45776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04silence coverity#1405937 Uncaught exceptionCaolán McNamara
Change-Id: I40e9827f1ff2fb7f5121da95c4f502de11f3f612 Reviewed-on: https://gerrit.libreoffice.org/45760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-04new loplugin salcall: remove unnecessary SAL_CALLNoel Grandin
In this first commit, I use the plugin to verify the consistency of our SAL_CALL annotations. The point being to make the next commit more mechanical in nature, purely using the rewriter. There are various chunks of unix-only code that have never had to be compiled by MSVC, hence the inconsistencies. In bridges, I had to inline some typedefs to make the verification code happy, since it cannot see into typedefs. Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0 Reviewed-on: https://gerrit.libreoffice.org/45502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-03fixed interface domain.Kiyotaka Nishibori
translatable strings in sd/uiconfig/simpress/ui/*.ui are extracted as parts of 'pot/sd/messages.pot'. the domains should not be 'sw' but 'sd'. Change-Id: I59bf51c5c329988c1c75cb82e518250ff1eccde7 Reviewed-on: https://gerrit.libreoffice.org/45588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-01tdf#101014 Keyboard navigation between textboxesMarina Latini
The tab sequence in layouts AUTOLAYOUT_TITLE_4CONTENT and AUTOLAYOUT_TITLE_6CONTENT has been modified from left to right on each line for a better a11y Change-Id: I92379358860d6866414ceda430a9bd90b63e2743 Reviewed-on: https://gerrit.libreoffice.org/45638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-01Use for-range loops in ViewShellManager (sd)Julien Nabet
Change-Id: I753e3536b18bae5a162f78a8e30dc3bd89fa80a3 Reviewed-on: https://gerrit.libreoffice.org/45620 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-30silence various coverity warningsCaolán McNamara
Change-Id: I9ac4c179c30efa9d5950aa2106639d3781dd0308 Reviewed-on: https://gerrit.libreoffice.org/45583 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30coverity#1424266 Uncaught exceptionCaolán McNamara
Change-Id: I63b04fba25b09753baa1dd1cac18f44860cdb264 Reviewed-on: https://gerrit.libreoffice.org/45581 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30loplugin:unnecessaryparen: signed numeric literalsStephan Bergmann
Change-Id: I75c8224452ca9c3711a2ccaca9ecf549fa59cb64 Reviewed-on: https://gerrit.libreoffice.org/45549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30catch IllegalArgumentException tooCaolán McNamara
Change-Id: Ib34bb87d94f8cc6d381e65ffbfe186e8d76d4e83 Reviewed-on: https://gerrit.libreoffice.org/45587 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30catch SAXException in pptx testingCaolán McNamara
Change-Id: I9379ae268d5c42723a34d6f9e677fe800873ebfa Reviewed-on: https://gerrit.libreoffice.org/45580 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29tdf#76646 don't open link on Ctrl-click if not requiredSzymon Kłos
Change-Id: Ie081f8144e50f576b9f8acb2ddd5b1c891533964 Reviewed-on: https://gerrit.libreoffice.org/45499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-29tdf#76646 Ctrl-click required for hyperlinks in draw/impressSzymon Kłos
If "Ctrl-click required to follow hyperlinks" is set in Options -> LibreOffice -> Security -> Options open the link only with Ctrl key pressed. Change-Id: Icf57b4deedabd51f31f04021ba3f6bddc3829931 Reviewed-on: https://gerrit.libreoffice.org/45437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-29add pptx support to fftesterCaolán McNamara
Change-Id: I517fa449ec75d8817cc3e03d0d90ab4c289a7c0f Reviewed-on: https://gerrit.libreoffice.org/45477 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.Jan Holesovsky
This allows registering & de-registering of non-sfx windows too, and makes the Calc autofilter popup to appear. Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
2017-11-29lokdialog: Move the painting down to Window, and enable Calc and Impress.Jan Holesovsky
Tested with .uno:FormatCellDialog in Calc, Impress not tested. Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
2017-11-29loplugin:countusersofdefaultparams in sdNoel Grandin
Change-Id: I6eb55d450d02615526e78fb69337c66c840ef8a3 Reviewed-on: https://gerrit.libreoffice.org/45463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28coverity#1421075 Uncaught exceptionCaolán McNamara
Change-Id: I23463d4610f886d5c817f3682e08c0f683c8de98 Reviewed-on: https://gerrit.libreoffice.org/45395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28coverity#1421124 Uncaught exceptionCaolán McNamara
Change-Id: I23a9174bda0bddc258c9591bddc5108f62d64c2e Reviewed-on: https://gerrit.libreoffice.org/45394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28loplugin:countusersofdefaultparams in svxNoel Grandin
Change-Id: I2c9ea6c38b75dcafeb36931b6c2e94489819144f Reviewed-on: https://gerrit.libreoffice.org/45336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27undo "ofz#3577 force refresh"Caolán McNamara
oss-fuzz shows no reduction of timeouts. Seeing as this is the root of importing ole docproperties none of the lines from SfxOleStringHelper:: up can be in any timeouts, so the original stacktrace isn't in any way helpful and it must be the generic ReadUInt16 downwards part of the stack. In other words the timeout bugs in oss-fuzz are useless if they aren't reproducible This reverts commit ecc3b1fcaddd4066d90161faf4a3f532b445c85a. Change-Id: I3fb8d2ded8502278098bd223898e3e90f6e4a378 Reviewed-on: https://gerrit.libreoffice.org/45352 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27loplugin:unnecessaryparen: Warn about parentheses around literalsStephan Bergmann
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet warn about Boolean literals, which are sometimes wrapped in parentheses to silence unreachable-code warnings. To avoid multiple warnings about code like f((0)) switch to generally using a set of ParenExpr to keep track of which occurrences have already been handled. Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc Reviewed-on: https://gerrit.libreoffice.org/45317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-26coverity#1421087 Uncaught exceptionCaolán McNamara
Change-Id: Ib00d20580178c80f653e26d5d23f81f4e81d2210
2017-11-26coverity#1421097 Uncaught exceptionCaolán McNamara
Change-Id: I503ca4ca71727a96f656a2dec97d7c202edfd806
2017-11-26ofz#4436 check if seek succeededCaolán McNamara
Change-Id: I56d9692647b28c706b56ccacf08d494b3d830d94 Reviewed-on: https://gerrit.libreoffice.org/45294 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-26clang-tidy modernize-use-equals-default in sdJochen Nitschke
Change-Id: Ib3d3bb1a0484cb8bb6411444254644252e3614cf Reviewed-on: https://gerrit.libreoffice.org/45293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23various coverity warningsCaolán McNamara
Change-Id: I27f20c51f86aeaed8e932f7ca45cce8770bc34ec Reviewed-on: https://gerrit.libreoffice.org/45140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Resolves: tdf#113962 save detected filter outside file dialogCaolán McNamara
different file dialog impls work differently so store the detected filter outside the file dialog Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef Reviewed-on: https://gerrit.libreoffice.org/45166 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-25 13:58:08 +0000