summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-11-13oox smartart, accent process: add support for reading values from constraintsMiklos Vajna
And also add support for merging parent and own constraints in the layout. This fixes the lack of vertical position difference between the two pairs of shapes in the bugdoc. Change-Id: I3a91c9b0da5eed78a87116ebe0e2751a73e1508f Reviewed-on: https://gerrit.libreoffice.org/63340 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-13loplugin singlevalfields improvementNoel Grandin
checking for casting to void* turns out to mask useful stuff, so remove that and just deal with a few extra false+ Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668 Reviewed-on: https://gerrit.libreoffice.org/63145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-13loplugin:singlevalfields in svtoolsNoel Grandin
Change-Id: I6bb8a875f18df3cb7054fa65285eb3cafc1648ac Reviewed-on: https://gerrit.libreoffice.org/63316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12NB Tabbed draw: Typefix InsertLayer with CapturePointandreas kainz
Change-Id: Ic2e3bfc7986f16fee02d356df3cf0e9fa55ab5a6 Reviewed-on: https://gerrit.libreoffice.org/63294 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-12NB Tabbed Impress: fix context menu for 3DObjectandreas kainz
Change-Id: I0b78f3c4ad3c180ddae51cf8d163f6649c42ea67 Reviewed-on: https://gerrit.libreoffice.org/63296 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-12Fix typosAndrea Gelmini
Change-Id: Ibb94b2b16afbcca84dd55ae51fde6fd27afede3a Reviewed-on: https://gerrit.libreoffice.org/63297 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-12tdf#42949 Fix IWYU warnings in sd/source/ui/slidesorter/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I48e3c5a62314baa11d6c53ce41311a9a0f1c661b Reviewed-on: https://gerrit.libreoffice.org/62678 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-12svx: prefix members of SdrEditViewMiklos Vajna
Change-Id: I3e27d8444c5a152ee39b9e2cc12b9df707f092b8 Reviewed-on: https://gerrit.libreoffice.org/63281 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-11-12Impress menubar Grid section sync with Drawandreas kainz
Change-Id: Ic8738467d9099c63b42ac0d0ec28048b8466f471 Reviewed-on: https://gerrit.libreoffice.org/63271 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-11NB tabbed: update calc and impress layoutandreas kainz
Change-Id: I8a27c11c4d8f345b316d7b2bf3bc0fdfd2e03b4b Reviewed-on: https://gerrit.libreoffice.org/63258 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-10clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2Tamás Zolnai
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d Reviewed-on: https://gerrit.libreoffice.org/63241 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-10tdf#120703 PVS: drop dead code.Mike Kaganski
V547 Expression 'mpTargetSlideSorter != nullptr' is always false. The code wasn't used since commit 4b83a7fe5714eb9a1d208502a18e33da35772ece (initially, mpTargetSlideSorter pointer was compared to a pSlideSorter parameter, which was always nullptr since commit above; then commit f946e905c6c6bb041ae580b14b711c6964af97bd removed the const parameter). Change-Id: I70047ae3e7ef39419be0012e375856d8a50d5793 Reviewed-on: https://gerrit.libreoffice.org/63229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-10tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I0b3c407331bfa1fa0c5003250d327d4f26de3643 Reviewed-on: https://gerrit.libreoffice.org/63235 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-10Tabbed NB: sync home/text tabandreas kainz
Change-Id: I1d13f22325679f17ddef231991ecb0e199f00c50 Reviewed-on: https://gerrit.libreoffice.org/63223 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-09Fix sd toolbar manager lock underflowsJan-Marek Glogowski
Regressions from commit 45519023aa44 ("Resolves: tdf#119997 toolbar layout unlock doesn't refresh ui"), commit c5977a89c28b ("Resolves: tdf#96451 do magic to enable embedded chart sidebar only for chart") and commit faed29cac93f ("for now show chart sidebar"). It also adds an assert for the underflow, as nobody cared for the underflow warnings since some years. Change-Id: I86bb093987f084c85a7b640a846dfe0aefea9e48 Reviewed-on: https://gerrit.libreoffice.org/63204 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-09Simplify and fix Java UNO API test makefilesJan-Marek Glogowski
Originally I just wanted to add the juh.jar to the list of jars of the UNO API tests, but this became tedious work, so after the first few files I decided to replace the similiar makefiles with a common define for the *_unoapi* tests. This patch adds two new make defines to be used used by Java UNO and UNO API tests: - gb_JunitTest_set_unoapi_test_defaults - gb_JunitTest_set_unoapi_test_class_and_jars The first one will deduce most defaults from the test name, but still allows to optionally override most settings. If a test doesn't match the default at all, the 2nd define still shares the common jar files and the main Java UNO class, so the second define adds these to your makefile. The real fix is to add juh.jar to gb_JunitTest_use_jars. Change-Id: I4342fdac5e31f85ea18fb4268e13c287a7adc2b7 Reviewed-on: https://gerrit.libreoffice.org/63118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-08Fix typosAndrea Gelmini
Change-Id: Ifd1affb7c3945de84a210dfbda894b60014f6cd6 Reviewed-on: https://gerrit.libreoffice.org/63020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-08Convert FieldUnit to scoped enumMike Kaganski
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-08These commands do not work in sdMaxim Monastirsky
Change-Id: Ic4893d310e0503d5d0d4cd185976b149c9f079b1 Reviewed-on: https://gerrit.libreoffice.org/63053 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-11-07move SvTreeListBox to vclCaolán McNamara
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-07oox smartart, table list: fix too large width of childrenMiklos Vajna
It's possible all children request 100% of space, need to scale down in that case. This means that children other than the first one is now readable in the layout result. Change-Id: I86a05cd77510bbb6686a53e33f13a60034c8e8f6 Reviewed-on: https://gerrit.libreoffice.org/63037 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-11-07tdf#113660 - Wrong label on sidebar slide pane after switching to handout viewMark Dobo
+simplifying variable assignment Change-Id: I2f43783d6e58c16f9200d44f7f34b05974ee0772 Reviewed-on: https://gerrit.libreoffice.org/62970 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-07loplugin:collapseif in sdNoel Grandin
Change-Id: I0751c9d3f379a3621bdc7ccce6a0d58c701a0261 Reviewed-on: https://gerrit.libreoffice.org/62955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-07NB tabbed consistency updateandreas kainz
Change-Id: I14634cda6d1edcf81ef665d48dd27cabd752571c Reviewed-on: https://gerrit.libreoffice.org/62981 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-06tdf#121198: fix crash in SdrPage::GetPageNum()Xisco Fauli
Regression from 9348b322a5c230dfcc2231661b73e480b130fcd9 Change-Id: Ibf9d6b65f0dbcc3a751e3ac5f3dbc28d908d6c25 Reviewed-on: https://gerrit.libreoffice.org/62952 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-05Fix typosAndrea Gelmini
Change-Id: Id5489f3e8f1d3ced3d57b56f8d3a7a4818af0fca Reviewed-on: https://gerrit.libreoffice.org/62377 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-05tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: If748a205b328a23473152872c6d0ed87d0570cc1 Reviewed-on: https://gerrit.libreoffice.org/62857 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#120703 PVS: V547 Expression is always trueMike Kaganski
The inner check looks suspicious. Still, I don't think that intended behavior was to check nFillDefault, because in that case the next line would likely start with "else if". The change just keeps current behavior; I make this an individual commit to keep the decision's context. Change-Id: I67d37aa0fee82190ce4bba5784b76c9f522b97ff Reviewed-on: https://gerrit.libreoffice.org/62864 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#105225 new background tab pageJim Raykowski
This patch allows the new background/highlighting tab page and derived from area tab page to work correctly in the same tab dialog. It also provides a cleaner way to use the new background tab page by setting brush item as fill attributes to target set in the background tab page created method. Previously if the new background tab page and the area tab page were used in the same tab page dialog one would affect the other due to the same use of pool fill items. This patch makes a local copy of the attribute item set passed and then passes that set along to the parent class area tab page on each activation/deactivation. Tab page dialogs that use both the background and area tab pages are: Writer Paragraph Styles, Impress Presentations Styles and Drawing/ Graphics Styles, and Draw Drawing/Graphics Styles. All new background tab page merged patches have been reworked in this patch and remaining old background tab pages, with the exception of Report Design, have been replaced by the new tab page. Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c Reviewed-on: https://gerrit.libreoffice.org/57102 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-05tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I4b48dddeaabf6b321196b537bb7aa55a89ab8fe3 Reviewed-on: https://gerrit.libreoffice.org/62863 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04[Pardus] Make the slide change command accessible.Gulsah Kose
Allows to call uno:RenamePage from the android viewer and LibreOffice online. This patch is sponsored by ULAKBIM/Pardus project. Change-Id: Ife814846bd7076e9f8830bce4c2451cb6b44a15a Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/62860
2018-11-04tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I3432afca1ee9bf9e8adce1d55d58d57bf1a09cb4 Reviewed-on: https://gerrit.libreoffice.org/62847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db Reviewed-on: https://gerrit.libreoffice.org/62817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02loplugin:useuniqueptr in SdCustomShowListNoel Grandin
Change-Id: I604f4cd616ec6eb31198806456a660e7a1e915ca Reviewed-on: https://gerrit.libreoffice.org/62662 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01Draw menubar: Spahe section updateandreas kainz
Change-Id: Ia378a3375ba8fb0e3a9b446bd891466dfcf4bdbf Reviewed-on: https://gerrit.libreoffice.org/62758 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-01Limit the unique_ptr scope to get rid of .reset()Mike Kaganski
Change-Id: I5d852f4d7f5de24ff49eaada6f53cd197ee2d0f7 Reviewed-on: https://gerrit.libreoffice.org/62715 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-01oox smartart, vertical bracket list: fix node counter conditionMiklos Vajna
The visible effect of this was that the 2nd level text nodes were missing from the layout result. The cause is that when it comes to counting nodes of a condition, we assumed that the current layout node is a presentation of a model node, but this is not necessarily true. Fix the problem doing a "first presentation child of", then a "presentation of" navigation in that case, which leads us to the correct model node, so counting its children works. (An alternative way of getting non-zero children would be a "presentation parent of" navigation, followed by a "presentation of" navigation, but that would lead us to the document root, so we would count the number of 1st level elements, not the correct 2nd level elements.) Change-Id: Iccebe0e2e56b7acb7fbe2c38a7c9ebb2abb309b9 Reviewed-on: https://gerrit.libreoffice.org/62703 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-11-01loplugin:useuniqueptr in SdPPTImportNoel Grandin
Change-Id: I843a2626c6351789bee3d68f0ab9debca9caa733 Reviewed-on: https://gerrit.libreoffice.org/62663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01rename RemoveX->Remove in SfxUndoArrayNoel Grandin
accidentally left it this way when doing commit 19e715973e15f9e7cf6e8237643dbbc14f8eb87a Date: Mon Oct 29 16:15:27 2018 +0200 loplugin:useuniqueptr in MarkedUndoAction Change-Id: I250676df7af27f485c5d34281ef0da1e127eb24c Reviewed-on: https://gerrit.libreoffice.org/62694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01tdf#120920 Assertion failure when switching slide layouts with text enteredNoel Grandin
no need to call StartListening here, has already been done inside SdPage::CreatePresObj Change-Id: I590e51f7afeb336d562d3ad9ccc123f542897aae Reviewed-on: https://gerrit.libreoffice.org/62689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31tdf#120540 draw/impress UI: add Format / Table submenuJustin Luth
Although these commands were available in context menus, there was no main menu access to these commands. Also: -cleanup unused context/popup labels related to table items. Change-Id: Ia574c3783bb279e869c2b8c716f6fb394aa21873 Reviewed-on: https://gerrit.libreoffice.org/61715 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-31loplugin:useuniqueptr in ParagraphObj::ParagraphObjNoel Grandin
Change-Id: I4c5dcdad18988381b64479cad077234978437795 Reviewed-on: https://gerrit.libreoffice.org/62661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31cppCheck RedundantAssignment variable p3DObjZdibák Zoltán
Change-Id: Ib423480bdb5d2cee183b5d1bda5b1a9ff05fdafc Reviewed-on: https://gerrit.libreoffice.org/62667 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-30toolbar impress and draw update for image and draw contextandreas kainz
Change-Id: I463441256f294185349177afb83936230a6c6dea Reviewed-on: https://gerrit.libreoffice.org/62636 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-30loplugin:useuniqueptr in MarkedUndoActionNoel Grandin
Change-Id: Ic06b990112df5bc135cfd7af6f1129580f294428 Reviewed-on: https://gerrit.libreoffice.org/62509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-30tdf#42949 Fix IWYU warnings in sd/source/ui/inc/{framework,tools,view}/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also a typo fix :) Change-Id: I7c96e8459f6fb75b07f6447715e8165800ecba53 Reviewed-on: https://gerrit.libreoffice.org/62259 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-30Tabbed Notebookbar: Show Draw toolbar didn't work so was removedandreas kainz
Change-Id: Iab3af7ee75597b148a60d6d7d90c6104d80ca2cb Reviewed-on: https://gerrit.libreoffice.org/62536 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-30context menu: finish draw and calc context menuesandreas kainz
and update NameGroup arrangement Change-Id: I373229793fa1605e731c04824112118c15e05c29 Reviewed-on: https://gerrit.libreoffice.org/62528 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29update tabletext context toolbar for draw and impressandreas kainz
Change-Id: If4a78aa0c95c0d6943c34caf0636e9867556b725 Reviewed-on: https://gerrit.libreoffice.org/62516 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-13 04:46:22 +0000