summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04Added master slide handling in getPart* functions of SdXImpressDocumentPranam Lashkari
There was no option to get the master slide info from SdXImpressDocument Change-Id: Ic42a4c541c406a50ec26ec2113174ab25675a074 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129423 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129480 Tested-by: Jenkins
2022-02-04CppunitTest_sd_png_export_tests: fix order of argumentsXisco Fauli
nY goes first. See include/vcl/BitmapReadAccess.hxx Change-Id: I1af00102d2267017b98e6b6e286f2eda74f9ca24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129374 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-04sw: prefix members of SwClipboardChangeListener, SwPagePreview, ...Miklos Vajna
... SwScannerEventListener and SwView_Impl See tdf#94879 for motivation. Change-Id: I19958bc70e7dd80ea3f1c75e06b9ac192d40f254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129472 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-03CppunitTest_sd_png_export_tests: use assertColorsAreSimilarXisco Fauli
Change-Id: Ie78797eaa774ba94b7b57fad025c811707d2db04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129448 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-03tdf#147119: sd_png_export_tests: Add unittestXisco Fauli
Change-Id: I69504a65926e3611e0d954d3ed317d45741b341b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129354 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-03Make inserted or pasted PDF sharper on macOSTor Lillqvist
When inserting a PDF file as an image or pasting PDF data from the clipboard on a Retina iMac the resulting rendered image did not look sharp. Using a surprisingly large extra scaling factor helps. The exact reasons for this are unknown. It isn't enough to use a scaling factor of just 2 (which is the HiDI ("Retina") scale factor on my iMac). Possibly the fuzziness is related to what Pdfium uses to render text. Also, look at CountDPIScaleFactor() in vcl/source/window/window.cxx. The GetDPIScaleFactor() function lies on macOS even more than it does on other platforms. It claims that the DPI scale percentage is always 100. But in fact most Macs nowadays have a Retina display so it would make more sense, in theory, to at least always return 200 instead. That wouldn't be any more wrong. But that causes regressions in the UI rendering, like needlessly large icons in the toolbars. Change-Id: Idc694f742c4ac32a5a134f8d206cf4eee467c39a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129369 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-03tdf#147119:Revert "tdf#123973 fix missing MasterPage content in export"Xisco Fauli
This reverts commit 87866def6bfe2ee91be34a5ce37b79d6da881617. This also reverts commit 98d6ed2aeb22b27fddf716a372f483b89ecea841 < tdf#123973: sd_png_export_tests: Add unittest > Change-Id: Ic3c8c70ef789b83cec0614e766a3c067cbf078fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129351 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2022-02-02tdf#112209 PPTX import: fix grayscale effect on image filled shapeTünde Tóth
Some image filled shapes with grayscale effect in PPTX documents created with PowerPoint were not grayscale in Impress. Change-Id: I0a89f283f525eb47c21c5d5fa788484d8074a7e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128616 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-02fix buildXisco Fauli
Yesterday I pushed 5d05abcc7cb53fd7f7d7ed700e3c65e9da3e5dea < tdf#105998: sd_png_export_tests: Add unittest > Meanwhile, Armin pushed 4d535c4f867d86d40786788e5e5c9fd061a65673 < tdf#126319 Corrected bitmap creation from metafile > making the size of the export shape to be 193x193 instead of 192x192 Change-Id: I366b7fc7d53db46a0beb1c5b588ac33ecabc343b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129348 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-02tdf#137675 PPTX export: adding missing fill="none" to a:pathTibor Nagy
Follow-up to commit 9310e47e2ce71348a16e5412131946348833f4b2 "tdf#101122 DOCX custom shape export: remove bad fill". Change-Id: I2acdae3964c31ee366387d9938fe366405dcace9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127944 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-02Fix typosAndrea Gelmini
Change-Id: Ifac9aedb4972323da8b70d0a8f6f663513d2fbdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129310 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-02convert OfaRefItem to a normal classNoel Grandin
only instantiated with one type, so just turn it into a normal class Change-Id: If3ae908f3e226ae9f4d3b81a7a7d9ba492ccda4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-02sal_uLong -> sal_uInt16 slot idNoel Grandin
Change-Id: I312844466157a4029f6744a4b13306903229c51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129276 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-01tdf#105998: sd_png_export_tests: Add unittestXisco Fauli
Change-Id: I4a32d815b085f10ab9be1b861bdfdeb128ec242e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129275 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-01tdf#145030: sd: Add UItestXisco Fauli
Change-Id: I28cf3bf29905f66f458b9dfbb8ad31742f866d73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129280 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-01jsdialog: sidebar: enable animation panel effectsSzymon Kłos
- enable subcontrol .ui for jsdialogs in annimation panel - optimize to not recreate widget on every sidebar refresh - don't sent close message for whole sidebar when called from subcontrol This fixes widgets in annimation panel like: Direction listbox, or other replacements for selecting color, font etc. for font effect Change-Id: I5683ca9cefe384ed0d2a34d46936ddf4a9b45bce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125757 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129170 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-01tdf#145030 if all in effects list is unselected retain last marked objCaolán McNamara
in the slide selection Change-Id: Ibdd9c827fea3ef33f0ae385147b3fa633d5dff83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-01tdf#147032 unselect anything set_cursor selected as its side-effectCaolán McNamara
Change-Id: I723bbd82fc01f644de3bfb2a80b4640cec0cfbca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-01Revert "tdf#145030 resync with empty selection if we unselected everything"Caolán McNamara
This reverts commit ba535d8cbda1026823ce9796c20f97b7367d581f. Change-Id: I277e640c0f8ed0038e8ea867ddeef999a00b7b87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129242 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-31tdf#123973: sd_png_export_tests: Add unittestXisco Fauli
Change-Id: I4e3f97aef0865a00a771d8fa959422203a8f08f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-31sd: move png export tests to their own fileXisco Fauli
in preparation for a follow-up test for tdf#123973 Change-Id: Iadedff75c42fa24390602a6eb914027157b53029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128979 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-31tdf#146999 draw, artifacts when scrolling up and downNoel Grandin
sigh, not even draw manages to get invalidation right regression from commit 9a850dd9f3c221660b6259bdfd64a77343f2256c Date: Wed Jan 12 10:27:38 2022 +0200 used cache value in ViewObjectContact::getPrimitive2DSequence (2nd attempt) Change-Id: I2692ac6933a3956eb98f48ff0875cdc0c933bd8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129221 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-31sw: prefix members of SwPagePreview, SwScrollbar, ...Miklos Vajna
... sw::sidebar::PageStylesPanel and sw::sidebar::WrapPropertyPanel See tdf#94879 for motivation. Change-Id: I8eb8be59b9fad087fadb2735c46133aca4810415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129199 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-31tdf#130165 PPTX export: fix master objects visible propertyTibor Nagy
Follow-up to commit 4574a1ea408c2ac30042dca32d02207ec7add4da "tdf#146223 PPTX import: fix master objects visible property". Change-Id: I34e6132837d6c84974f8446978c59226a9a7d2d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127908 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-31tdf#123658 sd search: partial UI unit testJustin Luth
Windows and Mac OS are failing this unit test at an early stage, before the code change should even hit. So I am decoupling the unit test and running it prior to my patch to ensure that it really is some pre-existing issue and not related to my code. [Because lcl_search() was is not used in MAC/WIN, I was getting errors about an unused function, so I also used it in another test (where I got the code from in the first place). I verified that test still failed when the associated commit was reverted. I also made it bBackwards just to make sure the variable is used, even though irrelevant here.] Change-Id: I2413fa54b881d8e8eb8c6c8907fbc0d13c352e10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128729 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-01-29tdf#146876: sd_layout_tests: Add unittestXisco Fauli
Change-Id: I4df3b153750be8d650f2c3b0ea5bd840b4397c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129134 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-29CppunitTest_sd_layout_tests: use CPPUNIT_TEST_FIXTUREXisco Fauli
This file is relatively new, convert it to use CPPUNIT_TEST_FIXTURE before it grows more. it's clearer and faster when writting new tests Change-Id: I15485642d64e5e3ed628155ffac4cfc70e8c3451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129132 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-29used TypedWhichId in the constructor of various svx *Item classesNoel Grandin
to act as an extra check that we have the association of Item and TypedWhichId annotations correct. (*) requires that I add an upcasting constructor to TypedWhichId (*) Make the field dialog stuff in writer use a new item id FN_FIELD_DIALOG_DOC_PROPS instead of abusing the existing SID_DOCINFO Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemfo stuff in the pool) Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-28CppunitTest_sd_export_tests-ooxml*: remove unused includesXisco Fauli
Change-Id: I2811e151a9643f589e251e176d9c717472a5dd4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129099 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-28CppunitTest_sd_import_tests*: remove unused includesXisco Fauli
Change-Id: I5592b1cb244b220fac40db1680e3b9f726ba57e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129096 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-28Enable pasting PDF into ImpressTor Lillqvist
Just like when doing Insert>Image... of a PDF file, you get a bitmap of the rendering of the first page of the PDF, not separately editable shapes or text. The pasted PDF document is included when exporting to .odp at least, just like for Insert>Image... I don't know how common or easy it is on Windows or various Linux desktops to have PDF format data on the clipboard, but at least on macOS, if you select a rectangle of a PDF document viewed in the Preview app, and do Edit>Copy, a PDF document is put on the pasteboard. (Preview also puts a TIFF rendering of the selection on the pasteboard, but for some reason that is of ridiculously low resolution. That is what used to get pasted into Impress previously.) Change-Id: Ic4b29deb12609dd839d8578779600156ff1ec48b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129049 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-01-27no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemEntryInfo stuff in the pool) Change-Id: Ic7b5f2c3cc75a65bdf9c45f9522cc53954b4ba38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27add some more TypeWhichId annotationsNoel Grandin
and update the idl compiler to cope with namespaced class names Change-Id: I7b5242f872e358bc3c5584f543767719172aac83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-26tdf#139734 deleting redundant asserts after MacrosTest::loadFromDesktopyalda
Change-Id: I5cd2d05913f5c90499e3454e108d43ad75eee09c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128888 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-01-25lok: enable in-place editing of math equationsMike Kaganski
Change-Id: Ic4d187d1e2ee92eab74a6bb43e47bb4f3d47ebd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128506 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-25Related: tdf#146971 remove %PRODUCTNAME from accessible-descriptionCaolán McNamara
Change-Id: I83ff18c8b5e95fa172de950eb351cbfd855c9d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-24move titledockwin to the one place it's usedCaolán McNamara
Change-Id: Ia9a1e0f687de3f916d59f28112b7b00c0d4a6610 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-22Use o3tl::convert instead of OutputDevice::LogicToLogicMike Kaganski
Change-Id: Ifb7be992c6e951692a741d10ed24ec8b3836982a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128782 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-22Add missing test dependencyStephan Bergmann
> [_RUN_____] SdOOXMLExportTest3::testTdf140912_PicturePlaceholder [...] > warn:vcl:680849:680849:vcl/source/bitmap/BitmapEx.cxx:98: BitmapEx::BitmapEx(): could not load image sd/res/image.png via icon theme colibre > warn:svx:680849:680849:svx/source/unodraw/unoshape.cxx:1779: DBG_UNHANDLED_EXCEPTION in setPropertyValues exception: com.sun.star.beans.UnknownPropertyException message: FromWordArt svx/source/unodraw/unoshape.cxx:1600 > warn:svx.uno:680849:680849:svx/source/unodraw/unoshape.cxx:1599: Unknown Property: URL > warn:svx:680849:680849:svx/source/unodraw/unoshape.cxx:1779: DBG_UNHANDLED_EXCEPTION in setPropertyValues exception: com.sun.star.beans.UnknownPropertyException message: URL svx/source/unodraw/unoshape.cxx:1600 > sd/qa/unit/export-tests-ooxml3.cxx:1863:SdOOXMLExportTest3::testTdf140912_PicturePlaceholder > equality assertion failed > - Expected: -8490 > - Actual : 0 Change-Id: I7710bf04ff5106d52fe51b515f2ed59097e88e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128753 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-22This conversion is no-opMike Kaganski
The two map modes are both mm100, and it was always that way since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b author Jens-Heiner Rechtien <hr@openoffice.org> date Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I4c24f8665b7b27569431526a3a7ead6469322055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128682 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-01-22ofz#43902 Timeout/HangCaolán McNamara
Change-Id: I87a8f3856f82de060bfb4b6cc4abec482c7462e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-21tdf#141591 Add DevTools to the Tabbed interfacerafaelhlima
This patch adds the DevTools command to the Tabbed interface. It is located in the cotnext menu in the Tools tab. Change-Id: I5f323b1b5ffc6707fc4f8b3c6eca2db7b8b97adc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127973 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20tdf#141340 PDF export: fix hyperlinks on the wrong page with page num rangeMiklos Vajna
Regression from commit 01dbb38680aa39a4d3bc7afd05d44a4b2c9bc6ab (tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden slides, 2020-03-10), the problem was that the sd/ code that mapped page numbers between the model and the PDF output only handled hidden slides, but not partial exports. Fix this by revisiting the decision to handle hidden slides in sd/, the filter/ code at the end does have enough information to correctly do this mapping at the end, and this way both tdf#61274 and tdf#141340 can work at the same time. Change-Id: I5679743ca67fab562e14c73e32f1a06ead8e7a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128643 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-17tdf#146731: sd_layout: Add unittestXisco Fauli
Change-Id: I50e7c1e89a217c845612d02942a22d9ef1abbea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128511 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-17sd: this is actually a layout test, move it to the right fileXisco Fauli
Partially revert fa5ab8aa5d88e7128015127af75980a65f945cbb < tdf#135843 Fix the missing border handling > Change-Id: Ib80530c9e46e029c910843beac0d55dbd393af3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128512 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-17tdf#136362 Remove unnecessary blank area and option in some image toolbarJeff Huang
Only in Calc, Draw and Impress. Change-Id: I944aad875fedd1dd19657c49b059e33fd6e9d3f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127984 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-14make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin
(*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-24 17:48:29 +0000