summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-02-03thumbnails: Provide the size as a default parameter.Jan Holesovsky
And increase it consistently to 256 pixels. Change-Id: I123e11d597269d7e43298504f1dbd0098c9b0149
2014-02-03uiconfig: remove obsolete helpid's and clean trailing whitespace.Michael Meeks
Change-Id: Ic94ed52bbe0e5c612258fa56a970d61de0972eb3
2014-02-03fdo#74455 - hide direct printing button and replace with new print dialog.Michael Meeks
Change-Id: I7ae80079f4bd5fed1234753b521a680498ec43e1
2014-02-03Remove redundant SAL_DLLPRIVATEStephan Bergmann
Change-Id: I3ec6054f07ef171ee1d4f6d7c5bf92c19ff25e9b
2014-02-03some more continuous correctionsThomas Arnhold
2014-02-03xub_StrLen and tools/string.hxx final strawNorbert Thiebaud
Thre is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638 Reviewed-on: https://gerrit.libreoffice.org/7787 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-01cppcheck: redundantAssignmentJulien Nabet
Change-Id: I8f29605dd11e39da6b0d9704c4801c5a798c4078
2014-01-30Subscript/Superscript also don't depend on argsMaxim Monastirsky
Change-Id: Ie96876ae402d5497bf5a03bca54f63305ebd9914 Reviewed-on: https://gerrit.libreoffice.org/7676 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30Resolves: #i124085# disabled CF_DIBV5...Armin Le Grand
(no advantages but some problems), increased png support (cherry picked from commit c991f7cae8dcb306cb0d1f32bc5fcd8ea0a1ea81) Change-Id: I52bef1295b32eb3692a0428c96edd0c55287f34a
2014-01-29coverity#1000866 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I0b460fb2964d363d0d0ae8f95cdd590eadd2bff3
2014-01-29fdo#39440 - cppcheck cleanlinessRadu Ioan
- Fixed some The scope of the variable 'x' can be reduced. Change-Id: I6b586314b2ed201249dc52469cc4bb86b99f79d2 Reviewed-on: https://gerrit.libreoffice.org/7665 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-29coverity#1132704 Dereference before null checkCaolán McNamara
Change-Id: I1922d7f3481fc56b33a078277cd17e54b14d6953
2014-01-29fix indentCaolán McNamara
Change-Id: Ie0f32006babf12dcb4fb6c244a4110222c2ad7ec
2014-01-29Remove some redundant castsStephan Bergmann
Change-Id: I03317f55f5e08b131302190f34169054bacbeb28
2014-01-29This has only converted the condition of ?: to sal_Int32Stephan Bergmann
...not the resulting value, since 6625989ee1188285c453b99aa13fac8e0cd74ca6 "INTEGRATION: CWS impressodf12," but is unnecessary anyway. Change-Id: I2a20e3f0a71693ce4cdd4c1b48952761e59c9ff5
2014-01-28coverity#1028539 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: Ia3b39d8535cb3e7c0c625d46d45c506ba0dee9d7
2014-01-28bool improvementsStephan Bergmann
Change-Id: Icac34936bdb551ad517170fd497212513719d2aa
2014-01-28Fix apparently broken OSL_ASSERT (that would have never fired)Stephan Bergmann
Change-Id: I5db308219aab173c5ed27c2f61908472aa1b697e
2014-01-28Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28Introduce com.sun.star.frame.theAutoRecovery singleton.Matúš Kukan
To replace com.sun.star.frame.AutoRecovery single-instance service, incorrectly converted in 279859fdbc40f68d8f1649fa5b928d9de49e8d9e Unfortunately needs a lot of changes in autorecovery.cxx. Change-Id: Iba5188dffea3e03803236f23e0b3f343746ace90
2014-01-28coverity#705872 Dereference before null checkCaolán McNamara
Change-Id: Ia964362f757372862b3f2e5a0a9581171616251b
2014-01-28sd/qa: Remove InteropGrabBag property from XML dumpsJacobo Aragunde Pérez
The InteropGrabBag property adds a lot of noise to this tests and it doesn't actually have any purpose, because we are building their own tests for InteropGrabBag-supported document attributes. We have removed this property by default but we left a flag to enable it when it's convenient for debugging. Change-Id: I97cc7ba171783222a57ab5a96e5755070b949505
2014-01-27coverity#1158303 Uncaught exceptionCaolán McNamara
Change-Id: I8d718da4274c26a817643b0e2b0ccf38d9b54de1
2014-01-27coverity#1158304 Uncaught exceptionCaolán McNamara
Change-Id: Ia64eb628002ad239cbd86674c98719048cc53090
2014-01-27cp#1000025: Import casemaps from pptx.Muthu Subramanian
Note: This only imports it and it may not be even possible to export (even to othe formats). Change-Id: I8e104f1bc3a95c42ac932b6ab58365dc113fb2e0
2014-01-27coverity#1038498 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I11f3056e96436fbb305316ef5c6505629e6418a3
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23coverity#1158466 Uninitialized pointer fieldCaolán McNamara
Change-Id: I9b2d678203e8025d132a43d9c8d76e15e2db4144
2014-01-23SfxNoLayoutSingleTabDialog not needed anymoreCaolán McNamara
all single tab dialogs are .ui enabled now. So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog and ~SfxNoLayoutSingleTabDialogBase together Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-23WaE: Fix bool sillynessTor Lillqvist
Change-Id: I4aeb9204a6a5ab79954b3a8ccadf58362f0f43d2
2014-01-22remove SvStream::operator<< methodsNoel Grandin
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22convert more SvStream::operator<< callsNoel Grandin
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22bool improvementsStephan Bergmann
Change-Id: I943e54afaf6ce58aaccbf588ffd9b9e235ef3b39
2014-01-21Change EnableNoYieldMode(bool) to better namesChris Sherlock
It makes no sense to disable something via an Enable function. I have split the function into Enable and Disable functions, and update the code accordingly. Conflicts: include/vcl/svapp.hxx Change-Id: Ic05d69796f43e802a4a2a16aaca44433b6eaa018 Reviewed-on: https://gerrit.libreoffice.org/7525 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21boradcast->broadcastCaolán McNamara
Change-Id: I96720843f815bf6d499eb424c3e4ff579c2bbe23
2014-01-21Use SAL_WARN instead of printing to stderrTor Lillqvist
Change-Id: I83f2b1d7fbe940917ef2c0b7be225c722fe9df05
2014-01-21Use SAL_INFO consistently, bin a random printfTor Lillqvist
Change-Id: I2c7a0d4c3c2714bd1e2773c0749edd20ee38628f
2014-01-20require icu_headers hereCaolán McNamara
Change-Id: I56e161d42f7a58a7931191ab3d0af79f2af9ee5c
2014-01-20Related: #i56998# use locale rules to format percentageCaolán McNamara
Change-Id: I4b744cf10165383153d2a71c05df0c0ed327c641
2014-01-18ooxml: Preserve shape theme attribute for solid fillJacobo Aragunde Pérez
Users can select the fill color for a shape among the theme-defined colors. This results in the following XML: <wps:spPr> ... <a:solidFill> <a:schemeClr val="accent2"/> </a:solidFill> ... </wps:spPr> Now we store both the original fill color and the name of the theme-defined color, if it exists, on the import phase. They are put into the InteropGrabBag of the shape with the names OriginalSolidFillClr and SpPrSolidFillSchemeClr. Additionally, we needed to to store the decoded theme color inside StyleFillRef. On the export phase we have to take into account several combinations of factors: * If the final color for the shape fill is different from the original color, we must ignore any theme attributes and write the new color. * If the fill color is unchanged and some theme color exists, we must write the theme color. * If the fill color is unchanged and no theme color exists, we must check if the original color matches the style-defined color. If it does, we must not write any <a:solidFill> tag. * Otherwise we must write the <a:solidFill> tag with the RGB color. The method putPropertiesToGrabBag was added to the Shape object for convenience. The data files for some /sd/qa/ unit tests were updated to reflect the new properties inside the Shape InteropGrabBag. Change-Id: If0915c5442872a8acab0a8a081f60c89c97277bd
2014-01-18ooxml: Preserve shape style attribute fillRefJacobo Aragunde Pérez
Shape style attributes contain the default format for the shape in case that no direct format is specified for it. This is an example of the attribute we want to preserve with this patch: <wps:style> ... <a:fillRef idx="1"> <a:schemeClr val="accent1"/> </a:fillRef> ... </wps:style> The relevant values in these tags are stored at the maShapeStyleRefs member in the Shape object. The storage happens at ShapeStyleContext::onCreateContext which is run when the <a:fillRef> tag is opened. The ShapeStyleRef object contains the idx value and a Color object which will contain the inner tag <a:schemeClr>. The Color object has been modified to store the string value of schemeClr. The storage happens at ColorValueContext::onStartElement which is run when the tag <a:schemeClr> is opened. Later, Shape::createAndInsert is called by the ShapeContextHandler to create the actual XShape, this happens when the tag <wps:wsp> is closed. createAndInsert puts idx and schemeClr values into the InteropGrabBag property of the XShape with the name StyleFillRef. On export time, when the shape data is written at ShapeExport::WriteCustomShape, we added a call to DrawingML::WriteShapeStyle. This method will check the existence of the InteropGrabBag property in the shape, read the StyleFillRef prop inside it and output the proper XML to the style definition. DrawingML::WriteShapeStyle also writes some mock tags into the <wps:style> because we found that they are compulsory. We will replace them with the proper data in further patches. The method putPropertyToGrabBag was added to the Shape object for convenience. The data files for some /sd/qa/ unit tests were updated to reflect the new property StyleFillRef inside the InteropGrabBag. Change-Id: I5ffa5242852461a1a709a8f169d40f0d7a2c9aa3
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Window::Notify should return bool, reduxStephan Bergmann
Change-Id: Ib41ed9ace428081e1948cf109de095ea9e7c45c2
2014-01-17bool improvementsStephan Bergmann
Change-Id: I19b429741a2ba972bef8863008657823b9bb7f91
2014-01-17Be explicit when using bool as integral value (as Link return value)Stephan Bergmann
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-16place some elements side by side to regain a lineCaolán McNamara
Change-Id: I9b838b6c00bc6e456adcf5d63c9936c08bf0d1aa
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80