summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2024-06-07tdf#160591 PPTX export: fix colormap mapping in slide masterTibor Nagy
Change-Id: I154f0ff1769fbda361ec62f1dd589ca0d7686bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168506 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-06-06crashreporting: crash in CustomAnimationPane::UpdateAnimationLBCaolán McNamara
speculative fix sd/source/ui/animations/CustomAnimationPane.cxx:2189 vcl/source/control/ctrl.cxx:298 sd/source/ui/animations/CustomAnimationPane.cxx:2189 vcl/source/control/listbox.cxx:907 vcl/source/window/paint.cxx:781 vcl/source/control/ctrl.cxx:485 vcl/source/control/listbox.cxx:906 vcl/source/control/listbox.cxx:189 vcl/source/control/imp_listbox.cxx:722 vcl/source/control/imp_listbox.cxx:686 vcl/source/control/imp_listbox.cxx:1133 Change-Id: I707fcbcd8a86ef7cf736b5244d9e4a78fd7b4ef0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-05annot: add {add,remove}Annotation that don't notifyTomaž Vajngerl
Add addAnnotationNoNotify method, that doesn't broadcast that an annotation was added, and change addAnnotation to call the method and in addition call the broadcast bits. Previously all this had happened in the addAnnotation without the choice to not broadcast. Change removeAnnotation in a similar way. Change-Id: Ie15a386a8b8d4493d5b41fcbcb55924a693b46d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168429 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-05sd: simplify NotifyDocumentEvent, remove duplicationTomaž Vajngerl
Change-Id: I4f16925c1271261d37e3b9146bc2458581798924 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168421 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-05sd: change CHECK_RANGE macro to template functionTomaž Vajngerl
Change-Id: Iecd6f37324b2788fac77b272ac56c3a2eb122dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168420 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-05annot: improve PDF annotation export and clean-up PDFNote classTomaž Vajngerl
Add support for exporting more PDF annotation types and props. Prefix member variables in PDFNote class, extract it out of pdfwriter.hxx file into it's own header file. Change-Id: I99fb4cbb0c68fcec6585c9c21d81daaef26344cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168418 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-04sfx2: use SAL_RET_MAYBENULL in GetDispatcher() and GetFrame()Xisco Fauli
Change-Id: Ic9876dbdd0dc0ce887a6eb135bd411f8e3dc9e12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168288 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-03sd: use SAL_RET_MAYBENULL in GetViewFrame()Xisco Fauli
Change-Id: If895a550fb2404f1a7cfcc4fb427674a3f6e5fc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-03Rename 'Organizer' to 'General' in style dialogsSamuel Mehrbrodt
This tab page has general information about the style - name, inheritance, etc. Change-Id: Ie06cf8b149a369117c5102ba7e2aae0d97249b83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166773 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-02cid#1602445 silence Uncaught exceptionCaolán McNamara
Change-Id: I3427f747859d9c1f144932b5966dc44c699b0ec9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168344 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-02READMEs update: presenter console is now in sd instead of sdextJulien Nabet
since 02c4386a09c7364d58c50a388ff77db14810a218 (in 2023) move presenter console from sdext/ to sd/ Change-Id: Ia88cdf437aa5546b251fa0eb95cde8a6b6c64391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168347 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-05-31LOK: Disable map mode in DrawViewShell's ctorMike Kaganski
This allows to use views other than normal and master (these two use the same shell, and are initialized in SdXImpressDocument::initializeForTiledRendering). Change-Id: I52f3ce46738f9feca1a16d008efca76cb478dceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168286 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-05-31sd: Reduce number of calls to GetMarkedObjectList()Xisco Fauli
From 211 to 129 Change-Id: I2ccb4261f5f842e7f1514bc0c8eab2591ead173e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168256 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-30sd: drop mpDocShell from DrawViewXisco Fauli
::sd::View already has mpDocSh Change-Id: I77af258115fad54aab6120f0dbbaa72a1faa71a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168261 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-30loplugin:ostr in sdNoel Grandin
Change-Id: Icfd8d1eb21953f44fb7bfb62188247e911734bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-30AreObjectsMarked -> GetMarkedObjectList().GetMarkCount() != 0Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Ib2eb7c88338e64744f886a338acca65f782f8170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168218 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-30GetMarkedObjectByIndex -> GetMarkedObjectList().GetMark()->GetMarkedSdrObj()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: I57ab7d2d8edd98da5175bd1066dfab0fa2cc888e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168220 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29SortMarkedObjects() -> GetMarkedObjectList().ForceSort()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Ia74949a47308f95607881a7d44c8c26404902745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168217 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29GetDescriptionOfMarkedObjects() -> GetMarkedObjectList().GetMarkDescription()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: I2a2c87c2552cfc9002a9afc7d8eefb16a601b784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168216 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29GetMarkedObjectCount() -> GetMarkedObjectList().GetMarkCount()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Id94f66545950f0fdf124ba7b985a5215a01d63fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168213 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29svx: GetSdrMarkByIndex -> GetMarkedObjectList().GetMarkXisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Iec0ad9ed33329719116e39232f86d92dbd6e0da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168211 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-28sd: use SAL_RET_MAYBENULL in GetDrawView()Xisco Fauli
Directly return nullptr instead of calling SfxViewShell::GetDrawView() which return nullptr to make it obvious Change-Id: I5e81d23f541a73181bb6f7d9e7f1d6ec56ff57ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168116 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-28sd: warning C6011: Dereferencing NULL pointerXisco Fauli
Change-Id: Id073e5d340fc91836b4689fb3e7a558ef3263e56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168119 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-28loplugin:ostr in sd/../uiNoel Grandin
Change-Id: I19acde24fd8a4014807318d97433b81814cadd75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167768 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-27sd: use SAL_RET_MAYBENULL in GetViewShellBase()Xisco Fauli
Change-Id: If2f9662f87b02fe42cd144daa7855424ef31db0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168097 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-05-27sd: warning C6011: Dereferencing NULL pointerXisco Fauli
Change-Id: I29d7f1174c79262afd84ab8399050366dda95a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168106 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-27sd: use SAL_RET_MAYBENULL in GetViewShell()Xisco Fauli
Change-Id: I2074bd17c8d4069c170d3567970960e43b10a641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168098 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-05-27sd: use SAL_RET_MAYBENULL in GetShell(), GetTopShell()...Xisco Fauli
... and GetTopViewShell() Change-Id: Ia6de13c078994978e7223a7d8ba3b3f604fcd0c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168094 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-27sd: use SAL_RET_MAYBENULL in getViewFrame(), getDispatcher()...Xisco Fauli
... and getBindings() Change-Id: Ieb7c2181238faa7c7175822ef455f6e3ce04fa8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168092 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-05-24related tdf#33603: update current page on SlideSorter viewSarper Akdemir
Make SlideSorterView update the current page properly when it is the MainViewShell. Also fixes Notes Pane not properly updating on SlideSorter view mode. Change-Id: If4fed4e84951cb4a1707874b288ac46e6d5c26da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168022 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-05-24related tdf#33603: sd: outlineview: update current page on moving cursorSarper Akdemir
The "early rejection test" removed here is a historical artifact when UpdateForKeyPress was created. in the current state it checked if pOutlineViewShell->GetActualPage() was different from itself. In the OutlineViewShell::UpdatePreview, there's an additional check if we have actually moved to a new page, so we can just safely remove this. Also fixes Notes Pane not properly updating on Outline View Mode Change-Id: Ic9de2e7302e76260809f90360533f0bfe6e05d2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168017 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-05-24tdf#33603: sd: notes pane: properly handle movement keysSarper Akdemir
Makes it so that notes pane handles some previously incorrectly handled keys itself. e.g. PageUp & PageDown Change-Id: I19f73fa2782900a752889544dcc79fc180ee52d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168008 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-05-23Revert "tdf#126095 sd notebookbar: don't force table/media toolbar"Justin Luth
This reverts my 24.2 commit e58e251756ecb0312cb6891d4df23e17ef8f6fcb. Unintended side affect in Draw (not Writer) sidebar. Change-Id: I948263c1e8be1202e0504f109d84ce4469ddf45d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167970 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-05-22Drop unused ATTR_OPTIONS_SNAPGabor Kelemen
after commit 563573068fe0835b1fa132d18b53f991be0e15a0 Change-Id: Iafa5ec21cd833ed9b8ebbdaea03086f4fa1784c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167884 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-05-21cool#9019: draw/impress: disable the Grid for nowHubert Figuière
So that the grid isn't shown in the thumbnail. This will need to be reverted later for cool#7406 Change-Id: I01fbc7ebc9e33a27fb866b7ea6dbaaac68ae8f9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167872 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 41130a39ad68310a0136605cbced1f191396c456) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167826 Tested-by: Jenkins
2024-05-18Resolves: tdf#161057 draw/impress auto font color not updated on theme changeCaolán McNamara
Change-Id: Id3d02c38e3bbda34f65f5623fff1a5f39238e46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167803 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-18cid#1598235 Uninitialized pointer fieldCaolán McNamara
Change-Id: I8c403a0bcfa56e58fdf12cb045c98b2087889235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167794 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-18Drop now unused SdOptionsSnap, SdOptionsSnapItem classesGabor Kelemen
Change-Id: Ifa2a7b7447e3659ea331ca4c3ec5c05dcc9a5841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167542 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-05-17WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I92ff04181d3c4ec4f0e1cd9f63ce5a1dc869ffc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167797 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-17Use less SdOptionsSnapItem->Get/SetEliminatePolyPointLimitAngleGabor Kelemen
in favor of officecfg Change-Id: I8a8d910578a438b494567eed30a632db6f191101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167541 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-17Add missing officecfg callGabor Kelemen
accidentally omitted from f1c91993e54858f9bc7ed78d25485a09157c04be Change-Id: I19a95e4e767792543bf04bbd8ca572017eee8992 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167772 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-05-17loplugin:ostr in sd/../filterNoel Grandin
Change-Id: I0a48a71fd1386fd5baf091e041bfa82255144779 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167760 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-16Use less SdOptionsSnapItem->GetAngle/SetAngleGabor Kelemen
in favor of officecfg Change-Id: I3196fb36a1513fed983998a33acce05e03a20cbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167540 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-16Use less SdOptionsSnapItem->GetSnapArea/SetSnapAreaGabor Kelemen
in favor of officecfg Change-Id: I0457f565f3f5d68018a307de7afbed9dbd009d42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167539 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-16loplugin:ostr in sd/../consoleNoel Grandin
Change-Id: I93a0373087f93d2ca754c95e5eba283b6cfb8ebe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167745 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-16loplugin:ostr in sd/../coreNoel Grandin
Change-Id: I3f69635be67215a3b351fa54f6024651a4e85a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-16tdf#156955 Add testSamuel Mehrbrodt
Change-Id: I02d2f437c3847970441dd489cc60beaf278b8d78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167741 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-16tdf#33603: sd: notes pane: force proper flush on page changeSarper Akdemir
After clearing the notes pane outliner and filling with then new content, if the new content didn't overfill the previous' area there was a residue from the last content visible. Make sure it is flushed by triggering onResize() on page change. Which also fixes the notespane sometimes keeping the scrollbar & scrollarea from the previous content. Change-Id: Ibbcb0f4f316bd283e5e65bb2ebd9cf17a3b38c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167489 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-05-16tdf#33603: sd: make state of notes pane persist across runsSarper Akdemir
Introduces new NotesPaneModule which manages the visibility of NotesPane across modes and different runs. Also introduces new three config values under Office/Impress/MuliPaneGUI/NotesPane/Visible ImpressView, OutlineView and NotesView. Similar to what was there for SlideSorterBar. Change-Id: Id540c508e81878e5a8e1aebd6544839e70b813c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167348 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-05-16tdf#161056 Show bullets used in document in bullets dropdownSamuel Mehrbrodt
Change-Id: I40cfc39501006146f7c6c04a1f3c7cf877c6f1c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167186 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
generated by cgit (git 2.34.1) at 2025-01-15 12:43:52 +0000