summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2015-11-02afl-eventtesting: crash close impress with spelling dialog activeCaolán McNamara
Change-Id: I1085b655a9a589f2e92edfdacfea6621d2f67d9c
2015-11-02tdf#88276: New text background tab in char formatting dialogKatarina Behrens
Change-Id: I81880456d398e8bffd363626bac17ff9d54e7796 Reviewed-on: https://gerrit.libreoffice.org/19697 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-11-02cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-10-29Too much copy pasta is not good for youTor Lillqvist
Change-Id: Ie5a3cddd6fcf9d1a763284c1aea0fca579da4f8d
2015-10-29com::sun::star->css in sdNoel Grandin
Change-Id: Ic0cbc857a3a9c66241b94c30bf8c859435f5a4b4
2015-10-29Initialize Sequence<beans::NamedValue> from initializer_listsNoel Grandin
Change-Id: I216dcbd983dcf3df79df9fda371b93114540a9d8
2015-10-28What's a "mape"?Tor Lillqvist
Change-Id: I4f7895683d5e42fd9c901759615025958939eb76
2015-10-28vcl: getWindow() -> setClipboard() in ITiledRenderableMiklos Vajna
It's cleaner to let the apps do this themselves than exposing their underlying vcl::Window. Change-Id: Iff2442dd325fa65a0cf3ad4aa7f918542dab1e4c
2015-10-27Filter out non-VclWindowEventsStephan Bergmann
...to avoid bad casts like > sd/source/ui/slidesorter/controller/SlideSorterController.cxx:545:24: runtime error: downcast of address 0x7f2d4d9b0c40 which does not point to an object of type 'VclWindowEvent' > 0x7f2d4d9b0c40: note: object is of type 'VclMenuEvent' > 00 00 00 00 f0 f9 03 80 2d 7f 00 00 b2 04 00 00 00 00 00 00 40 51 72 00 10 61 00 00 01 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'VclMenuEvent' > sd::slidesorter::controller::SlideSorterController::ApplicationEventHandler(VclSimpleEvent&) sd/source/ui/slidesorter/controller/SlideSorterController.cxx:545:24 > sd::slidesorter::controller::SlideSorterController::LinkStubApplicationEventHandler(void*, VclSimpleEvent&) sd/source/ui/slidesorter/controller/SlideSorterController.cxx:543:1 > Link<VclSimpleEvent&, void>::Call(VclSimpleEvent&) const include/tools/link.hxx:84:45 > VclEventListeners::Call(VclSimpleEvent&) const vcl/source/app/vclevent.cxx:74:17 > Application::ImplCallEventListeners(VclSimpleEvent&) vcl/source/app/svapp.cxx:820:9 > Menu::ImplCallEventListeners(unsigned long, unsigned short) vcl/source/window/menu.cxx:339:9 > [...] (Even the VCLEVENT_APPLICATION_DATACHANGED handled in WindowEventHandler /is/ a VclWindowEvent, see how these events are created via ImplCallEventListeners in Application::SetSettings, vcl/source/app/svapp.cxx.) Change-Id: I107cbbff83e4a41090aadee6a66e715ef35901d4
2015-10-27Remove unncessary, wrong downcastStephan Bergmann
...which caused > sd/source/core/sdpage2.cxx:151:28: runtime error: downcast of address 0x611000ccf8c0 which does not point to an object of type 'SdrTextObj' > 0x611000ccf8c0: note: object is of type 'SdrPageObj' > 08 07 80 35 10 3e 04 ba 4f 7f 00 00 c0 1b 2c 00 b0 60 00 00 00 00 00 00 00 00 00 00 70 1c 2c 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SdrPageObj' > SdPage::SetPresentationLayout(rtl::OUString const&, bool, bool, bool) sd/source/core/sdpage2.cxx:151:28 > SdDrawDocument::SetMasterPage(unsigned short, rtl::OUString const&, SdDrawDocument*, bool, bool) sd/source/core/drawdoc3.cxx:1746:13 > AssistentDlgImpl::UpdatePreview(bool) sd/source/ui/dlg/dlgass.cxx:1513:13 > [...] Change-Id: I07afc4cd7ef0a0a32768db59b72ca94edd4026df
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27sal_uIntPtr to sal_uInt64, sal_uLong to sal_Size for streamsMatteo Casalin
Change-Id: I062f1f6c5b20ca47734a9a3cd1a229d51763a206
2015-10-27Initial work on a "Vortex" transitionTor Lillqvist
The actual transition is not yet at all like the one in the competing product. But some basic ideas are in place. Change-Id: Ie17a4fe03ae93abe51a2f1f760f417ee4b193e2c
2015-10-26sd: implement vcl::ITiledRenderable::isMimeTypeSupported()Miklos Vajna
Change-Id: I528ac9f9f687d2940c6477b1d33264f1e523051f
2015-10-26cppcheck:noExplicitConstructorNoel Grandin
Change-Id: I06f33af242c60e0349417ceab3ca4a6d47cd402d Reviewed-on: https://gerrit.libreoffice.org/19589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22sd: implement vcl::ITiledRenderable::getWindow()Miklos Vajna
Change-Id: I8bc7316d9304d9e764ee846fe3af34599bf6fc35
2015-10-21afl-eventtesting: crash if you close shell behind running presentationCaolán McNamara
Change-Id: Ib8f02ddfe3b74e97145e22aa88e6f97d52c39f7a
2015-10-21sd: fix typo in PresenterHelperMiklos Vajna
Otherwise we always use the switch-monitor icon for the restart-timer button. Change-Id: Icd2e4322285b1c73a104ce0ffada116b9cae0ad4
2015-10-20afl-eventtesting + VclPtr: missing dispose on impress annotation windowCaolán McNamara
regression from commit c72fac269626cd4c2c3f62a6eed69e47b59256a4 Date: Mon Mar 16 12:17:44 2015 +0200 vclwidget: convert lots more sites to use VclPtr Change-Id: Iac6a83003d9c395589acdc23fe511d2bb47e91ee
2015-10-20remove SlideSorterCache debug facility, and with it, the last Link<>Noel Grandin
nobody has used it, or enabled it, in a very long time Change-Id: Ic36ff45086f7f7c9098c618d21cb6fc7cd7a46df
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: Ibf07815fa1a113876730382b8d14960eb7a78a0b
2015-10-19missing returnEike Rathke
Change-Id: I84c37f4bffb51dbe05c0b8273c060851fd671659
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I5f3b978823ec43519744f49739b9b4ee6ca1e1e9
2015-10-19typoStephan Bergmann
Change-Id: Ifb4f8c039829ef326d81dd7a0e36b3b527451c21
2015-10-19afl-eventtesting: pCursor is nullCaolán McNamara
Change-Id: I24d29ffc3cfcb00e513a5267619e143b028355ce
2015-10-19afl-eventtesting: view is nullCaolán McNamara
but docshell isn't and we're using the view apparently to get the shell we already have Change-Id: Ibc2021245191a75f65ec655a2d1929601a2611b5
2015-10-19afl-eventtesting: deref of null GetMainViewShellCaolán McNamara
Change-Id: Ie6863f446aa688bc1bb3f725ee31e9984dadc7a4
2015-10-19convert DBG_ASSERTWARNING to SAL_WARN_IFNoel Grandin
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes much more sense. Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19convert remaing DBG_WARNING to SAL_INFONoel Grandin
and drop the macro Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19cleanup some local var declarationsNoel Grandin
found with git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: Ifb59fc408bdbbe7edcb78f1c48dc462422f21a71
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: Ia27922e630373d0520f25d259bb06aa25407089c
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I8182e45dedfa70b41166b1d5fe5e152ae4b8c8ff
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I6c032633eb36402aa9050587bedf9530d7e0ba71
2015-10-19convert Link<> to typedNoel Grandin
Change-Id: I178acd3bd0e16a6b6c84162269a3771d6b898b25
2015-10-19cppcheck:nullPointerRedundantCheckNoel Grandin
Change-Id: I00a58a90f96e9eaf681239146213706e278ea5e1 Reviewed-on: https://gerrit.libreoffice.org/19421 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-18cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I187273e39759b3a3ef45b047f8cc36829a7f0b10
2015-10-16sfx items: Kill the unreadable & misplaced SFX_ITEMSET_ARG too.Jan Holesovsky
Change-Id: I1e0f96dce2b9cf9da32f4f577cf76e1d8824d37a
2015-10-16sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.Jan Holesovsky
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.Jan Holesovsky
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-16sfx items: The bDeep parameter of SFX_ITEMSET_ARG is always false.Jan Holesovsky
Change-Id: Ifdffc82c9b4ec2e534204294575a78e34e0338c1
2015-10-16sd tiled rendering: emit CALLBACK_TEXT_SELECTION on multiple search resultsMiklos Vajna
Change-Id: Ib6be973bf7c911907c793571b84021dc317dcc80
2015-10-16convert Link<> to typedNoel Grandin
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15sd tiled rendering: implement CALLBACK_SET_PART for find-allMiklos Vajna
Change-Id: I607b3719e0f508f9ae24db7482323847aa8e2491
2015-10-15sd tiled rendering: let find-all at least select the first match physicallyMiklos Vajna
The LOK API can describe a multi-selection, so find-all can signal all matches, editeng can have a single selection only. Instead of having no selections after a find-all, select the first match, so e.g. copy works. Change-Id: I0eab2565916f0c3cce5d77279c0d927ad4b7054c
2015-10-15sd search: restore start selection if nothing was foundMiklos Vajna
For one, if sd::Outliner::RememberStartPosition() cares about storing the current selection in the DrawViewShell case in maStartSelection, then sd::Outliner::RestoreStartPosition() should probably restore it. For another, sd::Outliner::StartSearchAndReplace() returned true in the "nothing was found" case, which restarted the spellchecking, which killed the selection. If the selection has been restored already, then at least don't kill it in the find case: find is read-only, so no need to restart the spellchecker. Change-Id: Idd886d449a9cfb164887fc6b1fde27b5e63e272b
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15convert Link<> to typedNoel Grandin
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-14coverity#736798 Dereference before null checkCaolán McNamara
Change-Id: I44402f7c644d60e2166956ca5f98955cc73e5bab
2015-10-14coverity#736803 Dereference before null checkCaolán McNamara
Change-Id: I0bdd28c1f43da999ae2bd35d45c1958061f90c07
generated by cgit (git 2.34.1) at 2025-01-22 15:38:07 +0000