summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2024-03-30tdf#160378 Remove NewGlobalDoc from the Tabbed UI in sd and scRafael Lima
The command NewGlobalDoc is not supported by Calc, Impress and Draw, so they should not exist in the Tabbed UI. Otherwise, a gap appears, since there's no info about this command. Change-Id: I0dd2b4639cfb44437d6726d6f138c4767c5a3175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165351 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-03-29tdf#157285 PPTX import: fix placeholder heightTibor Nagy
The "TextAutoGrowHeight" property doesn't shrink the shape automatically when its content is smaller than the current size. Change-Id: Ia7f94d7452d1a1c3f004aebd73b6ed5cbfd9b43b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165551 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-03-29tdf#143148 replace include guards with pragma onceU-Aarons_Laptop\Aaron
Change-Id: Idd8ecf3ef95ce2296b31a1c7fb1ddadefdd573f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165293 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-29IASS: Update NextSlide in PresenterConsoleArmin Le Grand (allotropia)
Change-Id: I6060e95aabfdb5956bf2f4a71d047bdf5c97a723 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165458 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-03-29IASS: SlidePane/Sorter updates were missingArmin Le Grand (allotropia)
Change-Id: I75ce5311a74f15397dd5a1762e17ddff3203fc7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165468 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-03-28Add comphelper::WeakImplHelperBaseNoel Grandin
in the same way I added WeakComponentImplHelperBase Change-Id: I26d93004c3ddf716063cfb2ded1bbda1b76c2a98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165449 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-28fix comparison of UIObject's inside UITestsNoel Grandin
using == to compare them doesnt work, because we return a new one with every call to getTopFocusWindow and similar. So add a equals() method to the UNO interface to do the comparison. Change-Id: Ie909fe9b4e84fe07f4ca87bbebf65b56d3da8f78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-27IASS: Fix crash with PresenterConsoleArmin Le Grand (allotropia)
When being in IASS mode and adding e.g. an effect to a Shape (or anything else that triggers a preview) and the PresenterConsole being active, we got a crash. That happend due to the PresenterConsole being initialized *twice* due to interpreting that preview as SlideShow start. It also closed due to interpreting the preview end as SlideShow end. The next SlideShow end then bites the dust in an already messed up situation. To solve this, SlideshowImpl::startShowImpl now only uses NotifyDocumentEvent "OnStartPresentation" when this is not a SlideShow startup. I also secured PresenterScreen using a local bool to remember if it is initialized to avoid when that would be done twice (also used for shutdown). Change-Id: Ice588e0783fd39ec46d90a40affcaf2f789df8ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165356 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-03-26skip more tests on hi-dpi windowsNoel Grandin
Change-Id: Ic8a88e112f413a9ec0a77e3be5d8a586312cfe0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-26tdf#150696 Consequent term usage for Snap GuideBogdan Buzea
Change-Id: Id3ae5af203db09019b2ab1e63cc0b8f7bed7a98f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-22CppunitTest_sd_tiledrendering2: extract one test from the old, large suiteMiklos Vajna
Not a split, to avoid too many conflicts while cherry-picking, but at least create a new suite where next tests can be added without too much build time after source code edits. Change-Id: Idb421db0a63dccee205a4092d368f6d48a093a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165163 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-03-22LOK: enter editing directly after textbox insertionPranam Lashkari
Change-Id: I3e77a1eb72a12c0e4ffc289ca854e0edb4ae9e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165007 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-03-22tdf#159258 sd: fix to show objects in slideshow if they haveBalazs Varga
fillstyle or linestyle. Also the shape will be appeared in print and pdf view. (Powerpoint doing the same.) TODO: the placeholder bitmap and the default text was not removed from the slideshow/print/pdf view. Change-Id: Ifadc9a692d77b60a7e3514afe8e6ea5cab0018c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164163 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-03-21ITEM: Remove InvalidateAllItems()Armin Le Grand (allotropia)
I checked if this is used, but it can be replaced using Clear() -> all. This prevents that the whole array of Items in an ItemSet gets set to INVALID_POOL_ITEM. I also checked if INVALID_POOL_ITEM/IsInvalidItem is needed at all representing SfxItemState::DONTCARE but it is and still will need to be set for individual Items. At last checked if SfxItemState::UNKNOWN and ::DISABLED really need to be separate states, but indeed there are some rare cases that need that. To make things more consistent I also renamed SfxItemState::DONTCARE to SfxItemState::INVALID to better match Set/IsInvalid calls at ItemSet. The build showed a missing UT and led to a problem due to the hand-made ItemSet-like SearchAttrItemList. The state 'invalid' seems to be used as 'unused' marker. It should be changed to use SfxPoolItemHolder and not need that. For now, set by using an own loop to set to that state. Change-Id: Ifc51aad60570569a1e37d3084a5e307eed47d06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165035 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-03-21cool#8278 sfx2 lok: fix lost hide notification on sidebar switchMiklos Vajna
Similar to commit 55feb670ca28e0a48ac82a65b5559598704d993e (cool#8278 sfx2 lok: fix unexpected non-json sidebar status update, 2024-03-21), the trouble here was not around hiding the sidebar but around switching between decks. This went wrong in commit aaf6ce108e91b1504befe19afcee471e3316ae7a (cool#7492 sfx2 lok: set language/locale on async sidebar update, 2024-01-11), where I didn't notice that SidebarController::SwitchToDeck() may emit two callbacks, so the effort to avoid code duplication went a bit too far: the hide+show case only emitted a show callback. Fix this by building a list of state changes to emit, so once se switch decks, not only the new one is "on", but also the old one is "off". Change-Id: I1678ee61e004697a6a5c6ecaf40a18b2d1d47e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165108 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-03-21Drop C/C++ DEBUG macroStephan Bergmann
...(that was defined iff OSL_DEBUG_LEVEL >= 2) and replace its uses with OSL_DEBUG_LEVEL directly Change-Id: I807c15a02cc8ced9852287df0afb4808761d19d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165067 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-21cool#8278 sfx2 lok: fix unexpected non-json sidebar status updateMiklos Vajna
Open an Impress document via LOK, open the slide layout sidebar, click the toggle icon so it gets closed: the toggle icon will signal that the sidebar is open, when it's closed already. This is a regression from commit aaf6ce108e91b1504befe19afcee471e3316ae7a (cool#7492 sfx2 lok: set language/locale on async sidebar update, 2024-01-11), previously we always emitted LOK_CALLBACK_STATE_CHANGED callbacks with plain text payloads for the sidebar, where the locale with implicit (with all its issues), but the above scenario worked fine. Fix the problem by making SidebarController::disposeDecks() consistent with SwitchToDeck(), so now we always emit JSON payloads for the sidebar deck changes. An alternative would be to improve the code around extractUnoCommand() in online.git to handle a mix of plain text and JSON payloads, but the plain text payload is tricky to extend, so using more JSON payloads sounds like a better fix. Change-Id: I5b75c2987c230c6720181a1e95ae579727943235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165055 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-03-20vcl: move Vectorize out of Bitmap - add Vectorizer classTomaž Vajngerl
Change-Id: I991b6e908d4139723c2d408d4ba3586676fded18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164693 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-19Add some missing test dependenciesStephan Bergmann
...that I stumbled upon with a from-scratch build of this test Change-Id: I17d5a87b6af47276877bffdcccb923fd037570b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165026 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-17loplugin:unusedmethodsNoel Grandin
Change-Id: Ib0a72355972662c6b902bca9a527be91fb3e1d17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-14sd:annotation: added missing comment reply undoPranam Lashkari
Change-Id: I63e005aa35faad1ebdaad228a22477cb1dd6de67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164811 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-14tdf#141908 - CppUnittests: replace usage of sal_Int32 with colorsRafał Dobrakowski
Conversion of hex/dec colour notation (example entry Color( 255, 255, 255), Color(0xFFFFFF) - COL_WHITE) For the other available colour definitions. Change-Id: I9eed0cd64adcbc8d25e1c22143a000906a457586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163729 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-14tdf#160093 Fix SdNavigator empty after inserting formula OLE objectJim Raykowski
or OLE Object... Also fixes empty tree occurance when multiple Draw/Impress documents are opened at once. Change-Id: I03d714bf96700d3a7df661fca91cceda703149f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164607 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-03-13tdf#152878 switch off replacment image in picture frameOliver Specht
RTF documents may contain shapes of the type "Picture frame" ({\sn shapeType}{\sv 75}) that are imported as SdrGraphObj This change prevents the display of a replacement picture if there is no picture set. Change-Id: Ia3a576ddcb2a3bbffae859102d274d4ecd214f6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164755 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-03-13no need to use strlen hereNoel Grandin
we know the size of the buffer Change-Id: I20c99cd55e8af842dd8e70d8ec39550fd8e7c7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164770 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-13tdf#141908 - CppUnittests: replace usage of sal_Int32 with colorsRafał Dobrakowski
Conversion of only one colour, Color(0, 0, 0), Color(0x000000) - COL_BLACK Change-Id: I4ba2412929522532d32304734b0269c70d75e5ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163460 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-03-13tdf#160162 Fix hyperlink update in DrawHossein
Changing the links to keep them up-to-date was previously done only when the name "Slide" was used for the pages, just like Impress, as Draw and Impress share code. Now, the term "Page" is used instead of "Slide" since 942d1d2ea59bf4605f2c464a6b29c967fa9f8de8 in Draw. This change, fixes the above issue by also using the correct string consntant. The patch is tested for Draw and Impress to make sure both are working correctly now. Change-Id: I55b4f56bd499d05f87f475d4c6cb3423247bf8d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164716 Tested-by: Jenkins Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-11tdf#158152: Make presenter console to "Console: file"Baole Fang
Add a new parameter pDrawDocShell to FullScreenPane to extract filename. A new string STR_FULLSCREEN_CONSOLE is added for presenter console. Now, the presenter console's title becomes "Console: file". Change-Id: Ic18d00044dde602dd92210600e3c5311b46500b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164515 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-03-11tdf#122587 Add uno command to set layer of object(s)Jim Raykowski
Change-Id: Iabdd0f7059953760a69d82a3810eb8ed20c2fd9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159982 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-03-11Use weak reference to SfxObjectShell in SfxEventHint to avoid use-after-freeMike Kaganski
The events may be processed after the shell has been destroyed. This is happening reliably after commit e2bfc34d146806a8f96be0cd2323d716f12cba4e (Reimplement OleComponentNative_Impl to use IGlobalInterfaceTable, 2024-03-11) when controlling LibreOffice from external Java scripts; but obviously, it could happen before as well. Now SotObject inherits from cppu::OWeakObject, instead of SvRefBase. Change-Id: I73a3531499a3068c801c98f40de39bdf8ad90b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164458 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-10tdf#158773 avoid Reindex() until we are done renamingNoel Grandin
shaves 10% off load time Change-Id: I93dfb4422a3e470013b6ddc5a9ae9e9868e3ddf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-10inline aSep variableNoel Grandin
Change-Id: Ic547a6f13e7a1a3cade70547d029721ce8054567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-10tdf#90242 Navigator: Improve custom shape namingJim Raykowski
This patch makes the Draw/Impress Navigator display the name retrieved by SdrCustomShapeGeometryItem::GetPropertyValueByName("Type") for custom shape objects when the custom shape is unnamed and the Navigator is set to show all objects. For Writer and Calc, this patch makes inserted fontwork custom shape objects be automatically named 'Fontwork N'. Change-Id: Ice34461fe7a4b26d01b2d93e871a956dc55392f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152568 Tested-by: Jenkins Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-03-09tdf#158773 add a set to sd::ShapeListNoel Grandin
because the std::list is atrociously bad at checking if the element already exists when the number of shapes gets large. Shaves 5% off the load time Change-Id: I6b8f972f8ff9559c363c084d91adea88b1267d3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164597 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-08use more string_viewNoel Grandin
found by tweaking the stringview loplugin Change-Id: I92203ba99642bef7951ffa146184c5562cb31d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-08tdf#160071 Don't clone formatting to whole boxesSamuel Mehrbrodt
when clicking into an empty area of that box Change-Id: I383f1584f446e29454eda2177c8bae0f6587e42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164555 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-03-07tdf#159726 Improve Clone formattingOliver Specht
Paragraph attributes and lists are copied if there is no source selection or the source selection includes at least a full paragraph. They are only applied to an empty or a paragraph selection. As in tdf#160069 requested the clone formatting function is only enabled in text edit mode. Change-Id: I789402a7928837bb85ec941fd6f958d12585ac40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164533 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-03-07tdf#159931: pptx export: export each used slide layout for a masterSarper Akdemir
attempts to fix the slideLayout reference related regression from Idb6b88ebe87a83818d8eb27a1fa087652a002c0c. To correctly export the all used slideLayout instances for a given master, iterate through sdr::PageUsers of that master and figure out all used layouts. Change-Id: I0f58befac1ba4d5ec01aeedbb5f611c83683dcf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164468 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2024-03-07add truncate-multiline for consistencyCaolán McNamara
Change-Id: Ib9c2e28b583dd3cc8d877d69a39dce73fd54fdba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-07Revert hyperlinkInfoAtPositon changes.Gökay Şatır
Revert "Implement hyperlinkInfoAtPosition for Impress." This reverts commit 876543305c78cb596720da087454a5c54e5feb06. Revert "Readonly Hyperlink Info - normalize the clicked coordinates." This reverts commit 322669725b771f5fa2b3c10c5fb73238ca3713f6. Revert "Implement hyperlinkInfoAtPosition function for Calc." This reverts commit be01dd78c47b51b19603a6259504e29b11979b0b. Revert "Implement hyperlinkInfoAtPosition for Writer." This reverts commit 6773c8929690f557d29bc282dd8f5c4381da3484. Revert "In readonly mode, we restrict many events like click." This reverts commit a4f3b97e506f38e0c43d6fbf1192cc523750a9fd. (cherry picked from commit c3f1d63178d6aaa0888085c7b641eb6d49a18276) Conflicts: sc/source/ui/unoobj/docuno.cxx sd/source/ui/unoidl/unomodel.cxx sw/source/uibase/uno/unotxdoc.cxx Change-Id: Ie821a4bca6e6b4649cea17748c44af105cd45d30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-03-06Improve clone formattingOliver Specht
Follow-up to 178d8a38e133aebd4cff1af2d2c49aec60468c92 Makes sure that without selection at target position only character attributes are copied Change-Id: I677b1ef29855fb2cf4c42a7b821678ecdd37c7f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164430 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-03-06tdf#158773 reduce cost of ContentInfo::GetTextNoel Grandin
The specific path that is showing up on the perf profile is SdrTextObj::HasText -> EditTextObjectImpl::GetText -> ContentInfo::GetText Reduce the cost by 10% there by adding a method to check if we have text, and avoid the cost of constructing an OUString from an svl::SharedString. Also make use of the new method in places. Change-Id: Ibc2e0f61c4a2a6c33eea7f2cce09d692d82fd2b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164449 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-05Create an UNO service to do the symbol lookup in sdNoel Grandin
which means I can remove one usage of gb_Library_set_plugin_for, which is blocking linking the sd module into --enable-mergelibs=more Change-Id: I90dae749f777446f67342d121e4dc29b974cb9b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-05tdf#159933 crash when applying Solarize filter to raster imageNoel Grandin
regression from commit 07b26af18d45ad7ecacc30c2c4cb2c23033e9f2d Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Jan 22 16:01:03 2024 +0200 make the graphic filter dialogs async Change-Id: I6463ef4d20bc5a994c6f1a5f937bb7e982c1c5a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-04Resolves: tdf#159854 Trigger text is black on dark grey in Animation sidebarCaolán McNamara
in dark mode Change-Id: I2cbf9b7d14a501c309a02dd3080511f527f9e1d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-01fix build: UITest_impress_tests (re-enable date-time test)Justin Luth
accidental debugging change got mixed into a patch... This reverts part of commit 99e33129346afeb0a386ffad859a9178290211a6 which shows I clearly failed to follow my normal practise of properly reviewing the change in gerrit before submitting. Change-Id: Iaa1d9a0eaa4f12c8a5786a29887a82b193baac38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164223 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-03-01disable failing tdf159927_dateTime.py uitestNoel Grandin
Change-Id: Ib1a1209b6bad188f9b045b499906d385ade66787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164220 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-01tdf#94535 Change "Fontwork" to "Text along Path"Olivier Hallot
+ Applied to Draw and Impress format menu + Applied to Curve context menu + Connected to tdf#118336 Help page. Change-Id: Ibb5d2edf7f5baccf49852b62008aed1c89409f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162047 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-03-01NFC writerfilter GraphicImport: streamline if statementJustin Luth
The function is a const static, so it doesn't require being run. Change-Id: I31fb35e9daf54103071197e669c54818d4062264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164172 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-02-29IASS: Update edited Text in other ViewsArmin Le Grand (allotropia)
This was not working for multiple Windows for a document, and also not supported for SlideShow until now. If you edit a Text on a Slide (Object, PresObj, ...) that text is not yet set at the Model until the TextEdit ends. In that situation those changes are now propagated to other views visualizing that object. This is done with slight slowdown to not do it all the time while typing, (currently 350ms, grepped from other places in the office). It will be shown in a running open SlideShow (and evtl. trigger an effect at the Object as Preview). This will allow to get a good preview for how it looks in the SlideShow. This is also done for further EditViews opened for that Document. This was not done before. It is fine-tuned to do this only for the Views besides the EditView with the running TextEdit to not cause slowdowns in that active view - the TextEdit is already running on the Overlay to have no problems with speed, this needs to be preserved. I had to fix a multi-view error in the a11y stack that implied that only one view exists and thus has to have an Outliner - that is wrong for multiple views, only one will have one. Change-Id: I781d32a8fcb8732ee8fcfbae72c02d1f99b6cd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164160 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>