summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-10-15Restore my pretty slide highlightingCaolán McNamara
and which got horribly destroyed by merge-conflict resolution of 78f6407978aa48c3cbb116bc281940dbf1f2dcbc Change-Id: Ie560416f4aa435e80c57a4449ee499fc5af20022
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-14Resolves: fdo#84887 TabBar::ImplShowPage crashCaolán McNamara
Change-Id: I84250c6a40baeabd0d12958dfe0aea346d2b4fc8
2014-10-14add cgm loading testCaolán McNamara
Change-Id: Icb1732d867d86e2a1b180ce58cec4c91fc630881
2014-10-14fdo#84236 Remove view modes from sd context menuSamuel Mehrbrodt
Change-Id: I7146ee946c7f882decae2c8d93c63002d00dd511
2014-10-14remove duplicate definitions of PPT_TRANSITION_TYPE constantsNoel Grandin
Change-Id: I8b6743c4f2c5c3d52c7df33953ed3dd7b32a1a46
2014-10-14coverity#1242426 Dereference after null checkCaolán McNamara
Change-Id: I59c96846aa5bf4780e4c5bfb0b71242e3b928976
2014-10-14fdo#84938: convert EPP_LAYOUT constants to enumNoel Grandin
Change-Id: Ibf43bf9ca241c6286659a16906a45bbafa798748 Reviewed-on: https://gerrit.libreoffice.org/11961 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13fdo#84213 Add show/hide ruler to sd context menuSamuel Mehrbrodt
Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94
2014-10-13oox: refactor embedded media importMichael Stahl
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-13boost::rational throws if 0 is passed as denominatorDavid Tardon
Change-Id: I312fd6b964555b3b4aa4e22cec6054c9a83b2c52
2014-10-12Wording: 'Audio/Video' -> 'Audio or Video'Samuel Mehrbrodt
Change-Id: I9572d4c7fb5f50b869e69436302ac8c20e500392
2014-10-11fdo#84912 - MENU: Addition of AutoSpellcheck to Tools menuYousuf Philips
Change-Id: I5e16f68f8565a26857f4ef233e06a002209e2566 Reviewed-on: https://gerrit.libreoffice.org/11915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2014-10-11fdo#84916 Fix string: Insert Audio/VideoSamuel Mehrbrodt
Change-Id: I76cd8502f9cb2af379dd732d2081feb094599aca
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11sd: another temp-file leakMichael Stahl
Change-Id: Idcd31ea07c460aaecff3ea56072cf65e26040bda
2014-10-11sd: rename test classes to be uniqueMichael Stahl
Change-Id: I18d4f6af97fcfb9341711751a8d550e421f7a381
2014-10-10coverity#704776 Dereference after null checkCaolán McNamara
Change-Id: Ifbad1fc30665ff6b9238b5fb4728fc302b0458fa
2014-10-10coverity#708132 Uninitialized scalar fieldCaolán McNamara
Change-Id: I830210b44459cf94eabb983b99bfcc104f865492
2014-10-10coverity#1242757 Result is not floating-pointCaolán McNamara
there was two of these, see commit 164bd64255d71d96e35e908f6425acf8372795fb Date: Thu Oct 2 04:44:33 2014 -0500 coverity#1242757 Result is not floating-point Change-Id: I1f66191f329b2d87bdeb52aa1a7528ca662064a6
2014-10-10coverity#1244953 Uncaught exceptionCaolán McNamara
Change-Id: I3c4aeb3318af7cdb964128dd78f7d2cfba48000e
2014-10-10Unused PowerPointExport::mpMasterFSArray memberMatúš Kukan
Change-Id: I02b9c31146396a39a624fbb869a5880b176e0f9e
2014-10-10cid#1244955 Uncaught exceptionNoel Grandin
Change-Id: Iedf06cc78cda022112699be3db650d11c7249adc
2014-10-10vcl, sd: fix some TempFile leaks from vcl Graphic in cppunit testsMichael Stahl
The problem is that utl::TempFile::GetURL() will return an empty string if the file UCP is not available. There will be an entry in the log file: warn:legacy.osl:25344:1:ucb/source/core/provprox.cxx:366: UcbContentProviderProxy::getContentProvider - No provider for 'com.sun.star.ucb.FileContentProvider. Change-Id: I2741a04cf4b8b420294ae521199706921b37e5c6
2014-10-09German comment translation.Lennart Poettering
Change-Id: I479da454235a7cfc084ae1517ab9ffa07580ab0c
2014-10-09German comment translation.Michael Meeks
Change-Id: I98526bfd6f69d95d5c309e67c397bc85fb8817ab
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08fix build after PathKind enum commitNoel Grandin
after my hasty commit bc00203 "convert PathKind enum in SD to enum class" Change-Id: I97263e907bf7363121dc1b437eaf564efdb66ad2
2014-10-08convert PathKind enum in SD to enum classNoel Grandin
to get the NONE constant out of the global namespace Change-Id: Iecbe39126c1ec08aa852fcb903cee1a6e6f4594b
2014-10-07Resolves: fdo#44998 crash when opening context menu of a fieldCaolán McNamara
If you right click on a field in an inactive text box, then a mouse down, context command, mouse up sequence is sent. The mouse up is supposed to be captured by the context menu here. But it doesn't because the mouse down in draw sends an artificial mouse down to the editengine which eventually sets up a MouseCapture window so the context menu doesn't get considered (because it occurs before the capture window is released) so the mouse up gets send to sd while the context menu is up and that causes all sorts of havoc. Change-Id: If3b7c501586f8561be484d0828c630d84644f770
2014-10-07disambiguate uniform_int_distributionCaolán McNamara
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-07Disable sdremote by default, and improve flow control.Michael Meeks
It was intended to disable sdremote by default when it exited experimental mode. This reverts commit 576943b9bf7506829de97d2194c4bee35a485436. Change-Id: I2c1b5443e334021bd9574316167f48b1af6200e5
2014-10-07~SdUnoPageBackground() gets a SolarMutexGuardMichael Stahl
Change-Id: I76582bb6a1a8dee56611f1463d3e63246eefb310
2014-10-06Missing includeStephan Bergmann
Change-Id: I47ddb95018109e5e771324b699dfdc10f529dfc4
2014-10-06fdo#75757: remove inheritance to std::vectorTakeshi Abe
from PptSlidePersistList. This also puts in assertions that every entry in a PptSlidePersistList is non-null. Cf. 9536a28ede89e8c29940e8ba225215a45667062c Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a Reviewed-on: https://gerrit.libreoffice.org/11807 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-04coverity#1242757 Result is not floating-pointNorbert Thiebaud
Change-Id: Iae8ac2ad9d1713512619c5c33eeee9a21b5835f1
2014-10-03coverity#1242802 coverity gold(?) Structurally dead code, loop doesn't loopCaolán McNamara
Change-Id: I2be3e6d88472ba8b69f012aaf975a91f0ab4f693
2014-10-03coverity#1242533 silence Arguments in wrong orderCaolán McNamara
Change-Id: I7031e7408f5bcd9ae85fc50952253e14d2fb2edf
2014-10-03fdo#84617: Guard the destructor with SolarMutex.Jan Holesovsky
The same pattern as introduced elsewhere recently. Change-Id: Ie7b4fd1ec26d417f63bee26dd336dfc54f4847dc
2014-10-02Bin EE_CNTRL_URLSFXEXECUTE which was only set, never testedTor Lillqvist
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02bnc#657899: Paragraph vertical spacing differs from PowerPointTor Lillqvist
We need to set the "paragraph summation" flag also for .pptx import. (As is already done for .ppt import.) This is what in the Options (Preferences) UI is called "Add spacing between paragraphs and tables (in current document)", on the LibreOffice Impress:General page. This is a setting that when set becomes local to the document. I actually don't really understand why this needs to be a user-visible option, wouldn't it be enough for it to be an internal flag that is set for documents imported from .ppt and .pptx, and is clear otherwise? Change-Id: I525178957276e7d587b6ac4be8ae7919fc245a27
2014-10-02coverity#1242520 silence Arguments in wrong orderCaolán McNamara
Change-Id: I88b96d42f5ee96641dc21e3e55415f6dc32b3951
2014-10-02coverity#1242496 Resource leakCaolán McNamara
Change-Id: I419b217df306d41ed99e603bae9381f54c633598
2014-10-02coverity#1242497 Resource leakCaolán McNamara
Change-Id: I2c4295c7d308257290aaf04181805d7dc71d6553
generated by cgit (git 2.34.1) at 2024-12-27 04:05:15 +0000