summaryrefslogtreecommitdiff
path: root/sdext/source
AgeCommit message (Collapse)Author
2013-05-28fdo#46808, Convert awt::UnoControlDialog to new styleNoel Grandin
Change-Id: I9a5256c8dbacda60167403b4e26900588943a9b2
2013-05-25Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"Stephan Bergmann
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at <http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re: fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again" appears to fix things again: The problem is that the implementation of the css.awt.UnoControlDialogModel involves UNO aggregation (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in toolkit/soruce/helper/registerservices.cxx creating a OGeometryControlModel<UnoControlDialogModel> instance that aggregates a UnoControlDialogModel instance). That means that queryInterface can return a reference to something that is technically a different object, and that's what's happening here, and explains why calling setPropertyValue in two different ways on what logically appears to be a single object can end up calling two different implementations (of two different physical objects). (UNO aggregation is known to be broken and should not be used. Nevertheless, there's still code that does---code that is a horrible mess and hard to clean up.) That all this worked as intended in the past is just sheer luck, but any way of substantially touching it is asking for trouble. I'm going to revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again. I wasn't able to revert without also reverting be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert awt::XUnoControlDialog to new style," as the two were tightly dependant. Also reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431 "-Werror,-Wuninitialized" (sans the const-ness fix in UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452 "Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again." Conflicts: basctl/source/dlged/dlged.cxx filter/source/t602/t602filter.cxx xmlscript/test/imexp.cxx Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-23Resolves: #i121857# Presentation Minimizer: fix filter namingAriel Constenla-Haile
(cherry picked from commit 75833fdb6ede664fdcef38a16ecf1f8d3f3adc7d) Conflicts: sdext/source/minimizer/fileopendialog.cxx Change-Id: I164cc6d9916ddf9dba9da273b5181e5728127292
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21fdo#46808, Convert awt::XUnoControlDialog to new styleNoel Grandin
Change-Id: I40d2e2ddd92186a2ba22ebfbdda8367391e8d355
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-14Resolves: #i82852# Presentation Minimizer: missing icon in info dialogAriel Constenla-Haile
(cherry picked from commit 8fd66eeb883676c095c8360ef609e56b9bc055a3) Conflicts: sdext/source/minimizer/informationdialog.cxx sdext/source/minimizer/informationdialog.hxx Change-Id: I8f6ea8edf7c1b95fefa6c280a92030d628339e56
2013-05-10Resolves: #i122208# introduce rtl::CStringHash and rtl::CStringEqualHerbert Dürr
unify the various c-string compares and hashes. (cherry picked from commit b7e3470a154538a92f0a21b14e726d75723f4a92) Conflicts: oox/inc/oox/export/shapes.hxx oox/source/export/shapes.cxx sal/inc/rtl/string.hxx sdext/source/minimizer/pppoptimizertoken.cxx svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx vcl/source/glyphs/gcach_ftyp.cxx writerfilter/source/resourcemodel/TagLogger.cxx xmloff/source/draw/EnhancedCustomShapeToken.cxx Change-Id: Ib742744077bfb4d38a462d88b44bdef45601b4ae
2013-05-09fdo#56995 Created global option to disable presenter console in Impressmmeof
Changes made are as Follows /officecfg/registry/schema/org/openoffice/Office/Impress.xcs To add the new global checkbox to Libreoffice Impress>General>Start A new xml block for EnablePresenterScreen was added <prop oor:name="EnablePresenterScreen" oor:type="xs:boolean" > /sd/source/ui/app/optsitem.cxx To add the setter/getter for the new checkbox button, namely: SetEnablePresenterScreen IsEnablePresenterScreen EnablePresenterScreen added to index number 26 of: GetPropNameArray() /sd/source/ui/dlg/tpoption.cxx SdTpOptionsMisc() editted to attach EnablePresenterScreen to CBX_ENABLE_PRESENTER_SCREEN aCbxEnablePresenterScreen ( this, SdResId( CBX_ENABLE_PRESENTER_SCREEN)) Also Added to FillItemSet() and Reset() functions /sd/source/ui/dlg/tpoption.src b/sd/source/ui/dlg/tpoption.src enableSdRemote size changed to Size = MAP_APPFONT ( 116 , 10 ) ; Pos = MAP_APPFONT ( 12 , 171 ) ; 158 was correct but 171 was added on request To allow enableSdRemote(CBX_ENABLE_SDREMOTE) and enablePresenterScreen( CBX_ENABLE_PRESENTER_SCREEN) to be drawn adjacent. enablePresenterScreen checkbox CBX_ENABLE_PRESENTER_SCREEN added /sd/source/ui/inc/optsitem.hxx Set default value for enablePresenterScreen as 1 or TRUE sal_Bool bEnablePresenterScreen : 1; Added getter/setter named same as above for interface definition sd/source/ui/inc/tpoption.hrc Defined CBX_ENABLE_PRESENTER_SCREEN as 42nd checkbox #define CBX_ENABLE_PRESENTER_SCREEN 42 /sd/source/ui/inc/tpoption.hxx Added interface declaration of aCbxEnablePresenterScreen which was attached to CBX_ENABLE_PRESENTER_SCREEN /sdext/source/presenter/PresenterScreen.hxx Added interface declaration of bool isPresenterScreenEnabled() to PresenterScreen class to allow presenterscreen to get if the option is checked /sdext/source/presenter/PresenterScreen.cxx Added definition of isPresenterScreenEnabled(const css::uno::Reference<css::uno::XComponentContext>& rxContext) Input : Current Process Context Output : The 0/1 value of EnablePresenterScreen from presenterconfig In PresenterScreenListener::notifyEvent( ) Added if(mpPresenterScreen->isPresenterScreenEnabled(mxComponentContext) mpPresenterScreen->InitializePresenterScreen() To initialize PresenterScreen only when enabled Change-Id: If8242e607323df57d8e78d08cf2129d03c0c9e4f Reviewed-on: https://gerrit.libreoffice.org/3762 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-05-08zlib: remove ExternalPackage_zlibMichael Stahl
Change-Id: I5bce88b2044279a6563fd68c35f9c1ac824c8850
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-04-30Fix warning: unused variable 'aIniUrl' [loplugin]Tor Lillqvist
Change-Id: I11a2a7e8e1f3f089c3b475df1147cefafecdb376
2013-04-30WaE: 'SAL_OVERRIDE' macro redefinedTor Lillqvist
Change-Id: Ic8af47b52b06ef440b3fdaa966075780fb7a609b
2013-04-30Make pdf2xml usable at least from within buildenv again.Thorsten Behrens
Seems this had bitrotted quite a lot. Calling it now like a cppunit test works again. Change-Id: I27479c3c3e1c1fe0639629e9bf8844456e0b0515
2013-04-30Add unit test for pdfimport image import.Thorsten Behrens
Change-Id: Ifd51f0c25418085ba8a6e8d331ac5c6d8139d18a
2013-04-30Fix import of images from pdf.Thorsten Behrens
Seems poppler changed outputdev virt func signatures with version 12, so with system poppler, we never got any image import functions called. Added override annotation to prevent this from happening in the future. Change-Id: I565de80ce218e831e276d3a1d88ded3baee876e7
2013-04-25fdo#46808 Convert awt::Pointer to new styleNoel Grandin
Change-Id: Ic2ff491e656ab7bcf0bd5994b601818a26478243
2013-04-19Remove any remaining remnants of unused component_canUnload featureStephan Bergmann
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19remove unused component_canUnload functionsMatúš Kukan
Change-Id: Id3f41e2a620c47bb848718d0fc994739be2d64fc
2013-04-17fdo#62096 - replace some O(U)String compareTo with ==Artur Dryomov
Change-Id: I98d04d7da4c2b7ea0b769df9c2bfa8c1ad86bf2d Reviewed-on: https://gerrit.libreoffice.org/3422 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-04-16Related: rhbz#867808 if one person threw by pointer...Caolán McNamara
then its guaranteed that someone else did too, review newed Exceptions Change-Id: Ie1ad78895e443a20a8663666cd6c8d3e5deb0727
2013-04-15fdo#60724 correct spellingThomas Arnhold
Change-Id: I7318a9f4f3410edf4dbe67bf08f31682fcb4edc7
2013-04-07remove needless forward rtl::OUString declarationsLuboš Luňák
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-02drop prefix from ::cssThomas Arnhold
as css is already ::com::sun::star Change-Id: I86b43843e4b74f990b6e05dee37184a002072d12
2013-03-30fix loplugin unused warningsPeter Foley
Change-Id: I23fc6bf62e74f192f77c74ed48d5276737375f3c
2013-03-30OSL_FAIL -> SAL_WARNThomas Arnhold
Change-Id: I1871e5e3a319b2d5177ae4bd470046c022c14eb7 Reviewed-on: https://gerrit.libreoffice.org/3121 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-03-30Prefer prefix ++/-- operators for non-primitive typesJulien Nabet
+ convert while loop into for loop To check: could we use std::find (find_if)? Is it always ok to do begin()+1? What about if we return aEnd? Change-Id: I59107de5693ad7b37e5eef80134c34a03982151e
2013-03-29Prefer prefix ++/-- operators for non-primitive typesJulien Nabet
+ use const_iterator for end iterator Change-Id: I8ad8db97e35ec4fad7c02c669be981f73c9165ca
2013-03-21Remove StringMirror UNO service.Thorsten Behrens
This was a kludge from back in the day when pdfimport was an extension and could not link against office libs. While at it, fix mirror method to handle unicode surrogates correctly. Change-Id: I3582a7870efdfea50446d3604a185025b1d5a196
2013-03-21Kill fprintf in sdext in favour of SAL_LOGThorsten Behrens
Change-Id: I2253c1a4d90ab348764cd8863b8aaf2036a254de
2013-03-20avoid floating-point error with empty bitmaps.Michael Meeks
Change-Id: I11be81b52e32c776905a6caac1582cd1a839ab24
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Reviewed-on: https://gerrit.libreoffice.org/2835 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-11use startsWith() instead of compareToAscii()Thomas Arnhold
brain damage... Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-11fdo#57422 fixing scroll bar and slides positionAbdulaziz A Alayed
fixing scroll bar position and slides sorter of note view and slides if the interface language is RTL . Change-Id: I80b55dff621d6b994095ad7a4979bcca63371edf
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-08fdo#60691 add modelines to *.src and *.hrc filesBorim
use solenv/bin/add-modulelines script for the task and remove all UTF bom from *.src and *.hrc files svx/source/dialog/hdft.src Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-04coverity#982282: Resource leak in objectJulien Nabet
Change-Id: Ia7d936c90d7afd4ffa4e22a86289aba47956f576 Reviewed-on: https://gerrit.libreoffice.org/2511 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-03-04remove unused and commented out codeThomas Arnhold
This code gets never called. Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-03Related to fdo#60724: correct spellingThomas Arnhold
Using the autocorrect list of LibreOffice extras/source/autotext/lang/en-US/acor/DocumentList.xml Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657 Script: http://pastebin.ca/2327716
2013-02-25remove some trivial duplicatesThomas Arnhold
Change-Id: Ie736cb6d5ff7f4d1998338f4a3a3a3b0a67c79ad
2013-02-24log presentation minimizer results as infoCaolán McNamara
Change-Id: I0f68ca75f774dfb18423517b36a1ea4d6071a83b
2013-02-22sdext: fix loplugin warningsMiklos Vajna
Change-Id: I4bca280b352f1df40fe75658e418f2e0cb2430e8
2013-02-22s/the the/the/Tor Lillqvist
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-19fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan
- replaced osl_trace with sal_info - added new log areas to log-area.dox Change-Id: Ib47c4b4c9604bca1f8a635dd01bb89702b47b591 Reviewed-on: https://gerrit.libreoffice.org/2010 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-02-18coverity#983173 Resource leakNorbert Thiebaud
Change-Id: I913ce32579ef9045fd3d33b48a653bc4ffc628da Reviewed-on: https://gerrit.libreoffice.org/2206 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18coverity#983175 Resource leakNorbert Thiebaud
Change-Id: I03eadb6f1e7235f03149a386c407066f81473772 Reviewed-on: https://gerrit.libreoffice.org/2207 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-17coverity#984041 Uninitialized scalar variableCaolán McNamara
Change-Id: Ia726b08717d26b439f46f95dedfdb30e27e8499e
2013-02-17coverity: pass by const reference is more efficientMarkus Mohrhard
Change-Id: Iec40176a5dd567e667178f07fecd043fe0aa4344
generated by cgit (git 2.34.1) at 2025-01-04 11:59:39 +0000