Age | Commit message (Collapse) | Author |
|
Change-Id: Ib7bd6e15fff5213b5d935c6f03f2c65ea3f6ca50
Reviewed-on: https://gerrit.libreoffice.org/8416
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
|
|
Change-Id: I792249b9e92db9af4daee0bd835e04044d29bca5
Reviewed-on: https://gerrit.libreoffice.org/8308
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I91883489d9557c5e3779c6b16bf377c1b95e49da
|
|
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Icb03088809e57a388317f98046f9de3197772a41
Reviewed-on: https://gerrit.libreoffice.org/8126
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9504738a5291b85362a80e630d9e413825fa6572
|
|
Change-Id: I5ec9f0246f6c2d1b12a389906d04133b2f5a6f9f
Reviewed-on: https://gerrit.libreoffice.org/8106
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4b09cd7b970d5aca4500ae333edef0e4c2f618b9
Reviewed-on: https://gerrit.libreoffice.org/8009
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
See http://nabble.documentfoundation.org/Cppcheck-Same-expression-on-both-sides-of-in-PresenterPaneBorderManager-cxx-sdext-td4094873.html
Change-Id: I7dbb8d0254ca77127250d6ca02de7b945ef8051e
|
|
Change-Id: I5b230aaebf72b70bbb7e206414a5ac0e01f01f86
Reviewed-on: https://gerrit.libreoffice.org/7564
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I60128dbb5bf83f25eea847fe655d7126c9077414
Reviewed-on: https://gerrit.libreoffice.org/7756
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
|
|
Change-Id: I969de97522ae2e3f8693e82a500a73e28451ef77
|
|
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
|
|
Change-Id: If9d439faba5a02b50152dfa1090b9eb1afa0fc18
|
|
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
|
|
Change-Id: I8dfbbb36cca3cf71c8d347b248dd206c447db6d2
Reviewed-on: https://gerrit.libreoffice.org/7136
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up,
of course.
Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
|
|
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc
Reviewed-on: https://gerrit.libreoffice.org/7104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
|
|
Convert code like:
OUStringBuffer sVal(OUString("0x"));
to:
OUStringBuffer sVal("0x");
Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
|
|
Convert code like
aStrBuffer.append(OUString(" AS "));
to
aStrBuffer.append(" AS ");
Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
|
|
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
|
|
Change-Id: Ic23c0ccc45d7a98b3581feab43fc4c8c8aef9013
|
|
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
|
|
It seems I missed a few places in
21ec9beae29b19b8ec6f0a16fd0e708e4f210208, getting that straight
now hopefully.
Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
|
|
This is the real problem - mxPane can be validly NULL.
Change-Id: Ie8d055db9bfb68cb9031fa970518343f5aec6619
|
|
This reverts commit bae01385c895a100b5371879889e606927cff877.
Change-Id: Id149bae0904fd6c2120209d69490d0b257ac3f64
|
|
Convert code like this:
if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
if (aStr == "rem")
which compiles down to the same code.
Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
|
|
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.
I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
|
|
Convert code like:
if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
if (aByteStr.startsWith("rem"))
Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
|
|
Change-Id: Ifc16473c426bca2235e84b0d71291756074712bb
|
|
but we're now dropping slides in there for some reason so
this is just a don't crash band-aid and not the fix
for the deeper problem
Change-Id: I2f70471d03979ffb86b6289e7a432f4505c1b556
|
|
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
Change-Id: I0765649b94b370caf92a29a8ff2224e335196612
|
|
SimpleView had been unused since its inception in
b561e658ebed8cfcfd18dc90bd25de9134341fb3 "INTEGRATION: CWS presenterview."
Change-Id: Ieb3af55c4cfebd24fe229c847f38ca108ae3401e
|
|
Change-Id: Ie8f3502c735cf38e21f2f55f27d384dbe3d8d5ef
|
|
Change-Id: I745ceb72423b120ef42437778e3a5fe05bd7b42b
|
|
Change-Id: I17160893b759f4dee1871e8f6d6525d327cf8cd6
|
|
...the whole ChooserDialogHandler class is unused since before
bdc71b3e4112b5c83a6aec61403981fcdd156138 "remove non-compiled code" removed its
sole, #if'ed out use.
Change-Id: If94db1c98074132952dd204864a478e1e12d455d
|
|
Change-Id: Ibcda8d872ad89a363f71bc4d5aa92b6bae2d2608
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
Use "#pragma GCC diagnostic ignored" instead which does not prevent
generation of dependencies.
Change-Id: Ic9034f20ef71c1ee6e5363b73c831142c2813d20
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Convert code like:
0 == aStr.compareToAscii("XXX")
to
aStr.equalsAscii("XXX")
which is both clearer and faster.
Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
|
|
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
|
|
Change-Id: I5cb8f7fb35121f41aedeff46f50d51d2ee039206
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|