summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)Author
2017-05-30rhbz#1425304 sdext: join TimerScheduler thread before shutdownMichael Stahl
Use a osl::Condition to interrupt the waiting thread, and join it. Change-Id: I638a2495afd082446c39faf9362578bd0f758d04 (cherry picked from commit 15b033d1dd09cd1898a994a0f12e38ed5cf847cb) Reviewed-on: https://gerrit.libreoffice.org/37992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1a14a0404ef02a76cfc3b6bfd50b1c78bb150d45)
2017-01-25tdf#105382 Set URL-decoded default filename for minimized presentationTakeshi Abe
See mailing-list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076702.html> for a discussion on the original presentation file's URL. Reviewed-on: https://gerrit.libreoffice.org/33261 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit d8aa4503966e2c8882c238a1a30c05b72bdf6f68) Change-Id: I51ccd7672513118f39518c4ed21902de16b2298f Reviewed-on: https://gerrit.libreoffice.org/33507 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-25presenter console: fix STL assert when exiting slide showMichael Stahl
AtkListener::handleChildRemoved() calls removeAccessibleEventListener(), apparently without the listener being registered, so the remove() returns end(), which isn't valid for erase(). (probably happens since e4e208fa2b0930be5a7cbbe2fab2ff2fe2c4a1ff) Change-Id: Ia0de1bafe214f5a46f250d6573d8c4b408c9cf26 (cherry picked from commit f6d2ff1cb7f0f4917a0d4df38d5dcff8e37d20cc) Reviewed-on: https://gerrit.libreoffice.org/31192 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-09spelling mutext->mutexNoel Grandin
Change-Id: If844c07d0d50d1bb9b0a1877c0fde4a198bcf781
2016-11-07loplugin:unnecessaryvirtual in sd..sdextNoel Grandin
Change-Id: Id0bc82210fadc138b55d1abe4e06b1d2ed564df3 Reviewed-on: https://gerrit.libreoffice.org/30659 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04loplugin:unusedmethodsNoel Grandin
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e Reviewed-on: https://gerrit.libreoffice.org/30524 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:singlevalfieldsNoel Grandin
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76 Reviewed-on: https://gerrit.libreoffice.org/30476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Make stable sort more stable :)Mike Kaganski
Account for negative widths/heights; only apply text fudge factor to text elements. This prevents debug asserts that "less" comparison is invalid. Change-Id: Ifb46bb873bfc80fc8c07af4923073d2042d30b3a Reviewed-on: https://gerrit.libreoffice.org/30391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-27loplugin:expandablemethods in sdextNoel Grandin
Change-Id: I7d375d6eafdd450ac165539f8f7dd3d02826ac5b Reviewed-on: https://gerrit.libreoffice.org/30323 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20loplugin:expandablemethodds in scaddins..sdextNoel Grandin
Change-Id: Ife021e368efaafe9097750b4ca1a5472e94352a9 Reviewed-on: https://gerrit.libreoffice.org/30054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: sdextStephan Bergmann
Change-Id: I9f5e73b6f561ccb635217227787c6e8a574bdc97 Reviewed-on: https://gerrit.libreoffice.org/29854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-13xmlsecurity: add initial PDFSignatureHelperMiklos Vajna
This splits most of the PDF signature code out of the pdfverify executable, and puts it into the xmlsecurity library instead. The PDFSignatureHelper now attempts to verify PDF signatures, and code in sdext / sfx2 also calls it (even if PDF is not a ZIP-based format). Change-Id: I7b8b3ac9c976e4ea4f3796b1cda07c8a2c97bd02 Reviewed-on: https://gerrit.libreoffice.org/29751 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-06CPPUNIT_ASSERT[_DOUBLES]_EQUALStephan Bergmann
Change-Id: I417cea926abcc511e74a090ee90a851c138ac0c0
2016-10-01Fix typosAndrea Gelmini
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-10loplugin:constantparam in sdNoel Grandin
Change-Id: I2bc989802c12b379a1ba4202f54ecfef1f339c8c Reviewed-on: https://gerrit.libreoffice.org/28774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30Break test::setUpVcl into a test-setupvcl library of its ownStephan Bergmann
...so it can be gb_CppunitTest_use_library_objects-included in upcoming <https://gerrit.libreoffice.org/#/c/28322/> "tdf#99402: fix Metafile Font handling". Executable_pdf2xml.mk linked against test since b0da8f00a0d41f2b17639fcee4ed4956421e55c5 "Make pdf2xml usable at least from within buildenv again", but that seems unnecessary and would now cause problems when linking the pdf2xml executable on Linux, as the linker for whatever reason wouldn't find the libtest-setupvcl.so referenced from libtest.so, even though the latter has a proper DT_RPATH. Change-Id: Iba5d80266520ce1f5dafedffa520d18e853f7ec5 Reviewed-on: https://gerrit.libreoffice.org/28473 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-25loplugin:staticaccess: Extend loplugin:staticcall to cover all access...Stephan Bergmann
to static members (data, in addition to function) via class member access syntax. Also covers the (somewhat obscure) access to enumerator members. Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
2016-08-18coverity#1371125 Copy-paste errorCaolán McNamara
this went wrong with commit 9b9e5cfd2fa629b2e1dc4a193e48a4a4e8d34126 Date: Mon Jun 20 17:40:13 2016 +0300 tdf#99589 - tolower / toupper - dangerous to Turks ... restore the logic to the original logic, but with the new api Change-Id: I445064b19eeefabbd25849bae9ca569710cdfac5
2016-08-18cppcheck: nullPointerRedundantCheckCaolán McNamara
Change-Id: I9d6c38ad3104369c7661bc8a8561807598aecfcb
2016-08-02loplugin:countusersofdefaultparams in sdNoel Grandin
Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5 Reviewed-on: https://gerrit.libreoffice.org/27765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29Resolves: tdf#84121 wrong password passed to xpdfimportCaolán McNamara
regression from... commit eb276d11a652601f743d69ada7a38016bd97d73e Author: Fridrich Štrba <fridrich.strba@bluewin.ch> Date: Mon Jul 8 14:01:17 2013 +0200 fdo#38878: Upgrading internal xpdf -> poppler before this the hashed _OOO_pdfi_Credentials_ was used in the removed OOoImportSecurityhandler::authorize but after this the hashed password continued to be passed through stdin, while the unhashed password was the required data. Change-Id: Iadc8a372abcfab514f724dd95f05776e5153d007
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I3774f16c09b89fc6888bff3a388c290c32bb8a14
2016-06-30loplugin:unusedfieldsNoel Grandin
Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e Reviewed-on: https://gerrit.libreoffice.org/26754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28loplugin:singlevalfields in variousNoel Grandin
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27loplugin:singlevalfields in sdextNoel Grandin
Change-Id: I9bf194fb58b3bd37071647a83a629b6782836890 Reviewed-on: https://gerrit.libreoffice.org/26659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-20tdf#96080 PDF Import: fix incorrect whitespace characters sequenceVort
Change-Id: I0f8e0217cb661be318af611216191def1b209ea1 Reviewed-on: https://gerrit.libreoffice.org/26426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-06Reintroduce some code removed with "Remove unneeded Pane code in ..."Jan Holesovsky
This code was removed in 71cf1aefca1ecf10272308d7c75201bd39d3b0f6, but it was guarded by an "ifndef", not by an "ifdef", so it should still stay (unless I'm missing something). Change-Id: Ib344e73d39d1fcd3b84784977769708726d8ed1e
2016-06-06Remove unneeded Pane code in Presenter ConsoleBryan Quigley
This code hasn't been touched (on purpose) in years, it appears to have been used to resize part of the console. (It's prefed off) Change-Id: Iaaeaa8a95c71ae91299bbeeea24869bf2a237b6b Reviewed-on: https://gerrit.libreoffice.org/24663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in sdNoel Grandin
Change-Id: I27da3e7afd86217ec9f75958775da9c144d7a0a5 Reviewed-on: https://gerrit.libreoffice.org/25111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13sdext: replace boost::bindMichael Stahl
MSVC 2013 with non-debug runtime requires an additional assignment operator in OUStringBufferAppender. Change-Id: Ic93fc8d6b1d4760f0eb89e34beb1fcb18e783f73 Reviewed-on: https://gerrit.libreoffice.org/24980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-12loplugin:stringconstantStephan Bergmann
Change-Id: I5515f35871b23b67564d5eda52bf3323e7e047bb
2016-05-12sdext: replace boost::bind with C++11 lambdas, part 2Michael Stahl
Change-Id: Ife5fbf7a7a41182de00dca339cba160e3bb0062f
2016-05-12loplugin:stringconstantTor Lillqvist
Change-Id: I9eed9713a0d208e7aa4cdddc0cedb97edf831239
2016-05-12loplugin:defaultparamsTor Lillqvist
Change-Id: I4905e4c1dd72dabe2229d99742ee0012295a9742
2016-05-11sdext: replace boost::bind with C++11 lambdasMichael Stahl
Change-Id: I2a30e764b96530e21d5ff201b18f98d1cd334a6d Reviewed-on: https://gerrit.libreoffice.org/24888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10fix Windows buildNoel Grandin
Change-Id: Ib80cc10c259e26e997e3a548fbf267621c050e29
generated by cgit (git 2.34.1) at 2024-06-22 04:54:16 +0000