summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)Author
2015-09-07Work around bogus warning C4701: potentially uninitialized local variableStephan Bergmann
Change-Id: I9c5d9c53785828b3535c960f826ccd3720b2e4c3
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...the computation of nTop, nBottom was done in this curious way ever since its inception with 108632dc97a720639df495de3b5d966ee286be95 "CWS-TOOLING: integrate CWS impressaccessibility3" Change-Id: Ib516e944d96dc10ff12d0a82c0d8c921b57b0466
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I7c19ce1bde1eb405fe64aba7504fc511c0ab646e
2015-09-01sdext: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I663029b736489b81ed4ccb5f7bd657fbaf091bdf Reviewed-on: https://gerrit.libreoffice.org/18206 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I82330271362a428b2850d0f561770d35de1ee6b0
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-20loplugin: defaultparamsNoel Grandin
Change-Id: Ibf0ea539d2a95073a12f84964759d9c7a94baa7b
2015-08-19Consolidate isFileUrl checksStephan Bergmann
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-05remove unused SfxFilterFlags valuesNoel Grandin
from both the code and the XCU files Change-Id: I47f1f33c3ad4a37e346e3b8020dd9d3e284ccb77 Reviewed-on: https://gerrit.libreoffice.org/17522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03sdext: replace boost::function with std::functionMichael Stahl
This one is a bit odd, wonder if that was a bug: - aAction(aPredicate); + aAction(aPredicate()); Change-Id: I0ddd565b65fe4778a297486805fa7f7a12702224
2015-08-03new loplugin: refcountingNoel Grandin
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-08Fix typoTakeshi Abe
Change-Id: Iec20cfa243e336d36e12e13d36564eacc9db1435
2015-07-08Fix typosAndrea Gelmini
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-08sdext: the PDF library, not the treeMichael Stahl
Change-Id: Ic867140ace06337f6121d7c4576eb9850577d7cb
2015-07-07Improve sdext/ README.Michael Meeks
Change-Id: I64a5313f39efbe091a5c7164ca29535e4b45b00c
2015-07-07loplugin:unusedmethods sdextNoel Grandin
Change-Id: I9119e612a92d05f587a1f1e19ca21b2f95102891 Reviewed-on: https://gerrit.libreoffice.org/16809 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04Fix typosAndrea Gelmini
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-01Work around const-ness issues in the GooString APIStephan Bergmann
cf. <https://gerrit.libreoffice.org/#/c/16357> "Revert the removal of cast to build on old poppler" Change-Id: I75184cec64b4f32e0cf9adedeb84c8591be4fc73
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-19Fix check for broken standard libraryStephan Bergmann
The compiler's __GNUC__ etc. need not match the libstdc++ version used (esp. when using Clang as compiler), and libstdc++'s __GLIBCXX__ macro doesn't inrease monotonically with version numbers, so resort to a configure check. Change-Id: I06de6b68324169863f6f5c31ae5d855e8b04cd6b
2015-06-19Catch inadvertent uses of OUString(sal_Unicode) ctorStephan Bergmann
...with numeric values that are not meant to be characters. Inspired by <https://gerrit.libreoffice.org/#/c/16339/> "OUString: add constructor from single Unicode code point" and ecaf1cb3861c1b519a1495487fc796884cf37b92 "seems to be what was meant." Found e46e8d19458fd64ff20b1013e5eeabd07e62379c "Shall this produce a string representation of a number?" and f2a0e4032734d6be635f14ade3dea499c29ec6c2 "Don't truncate a UTF-32 code point to a UTF-16 code unit." (LIBO_INTERNAL_ONLY mostly because it uses a C++11 delegating ctor for simplicity, but also because it requires mild modifications to client code, see additional changes in this commit and some other recent commits.) Change-Id: I8a156f01d1b772c6052d7afaa088ae13ed234e2b
2015-06-19once more unto the breech dear fellowsNoel Grandin
workaround GCC4.8 issue Change-Id: Iea4d10a02a114ce94e0219e8b89acf48db5411d0
2015-06-19workaround older compilers that do not have std::list::erase(const_iterator)Noel Grandin
Change-Id: Iaa1164904febd8e97d4962e4004ec4719a1f4a42
2015-06-19fix older compilerNoel Grandin
after my commit e0f3e7c007e9eeced888b491ec2698acba4bc588 "tdf#42374 some small optimisations for opening this PDF file" Change-Id: I908770ca618581ffe26ebb2205b804d1abcae5a7
2015-06-19add commentNoel Grandin
Change-Id: I336e6ea9b08edaa7e9718f8af9c112b983eeaa58
2015-06-19fix older compilerNoel Grandin
after my commit e0f3e7c007e9eeced888b491ec2698acba4bc588 "tdf#42374 some small optimisations for opening this PDF file" Change-Id: Ib9dc0aaf3ad2afca272160a934049d89bbd54175
2015-06-19tdf#42374 - read PDF in larger chunksNoel Grandin
Optimise the reading of the imported PDF file by reading in larger chunks. Eliminates roughly 10% of the time on my box Change-Id: I48fff325076850a4ccd32ad85a3092621a923034
2015-06-19tdf#42374, improve perf by fixing bug in pdfi::HashedStyle::hashCode()Noel Grandin
which was rendering it largely useless for hashing purposes Change-Id: Ie94457ea0a6e53fd9ceed9461656e2d3b0840d58
2015-06-19tdf#42374 some small optimisations for opening this PDF fileNoel Grandin
makes it about 10% faster Change-Id: I145faed5aa7c312372f08cc651df5afcf10c70ab
2015-06-19the ElementTreeVisitable interface is doing nothing usefulNoel Grandin
Change-Id: I89e8fb90de8aadce89a8f5e353a923c972e1569f
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-13Fix typosAndrea Gelmini
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I8bd47784ae34ecd57f43b1e680ab863a6272c32f
2015-06-02loplugin:loopvartoosmallNoel Grandin
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: Ie77fdb078c9c8f8ed01dfd6c5dd583c6535803b2
2015-06-02loplugin:loopvartoosmallNoel Grandin
Change-Id: I809e408c994222cfa95ba8f56e4db7bd96be7080
2015-05-26tdf#91416 - fix some incorrectly allocated VirtualDevices.Michael Meeks
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe
2015-04-29tdf#63054: pdf_string_parser incorrectly handles escapesMike
This patch fixes the escapes handling by avoiding boost built-in functions that skip whitespaces behind the scenes. Change-Id: I9607ecd9e2e052aadcba69cf30ec25c981743c49 Reviewed-on: https://gerrit.libreoffice.org/15562 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-27More loplugin:simplifyboolStephan Bergmann
Change-Id: I4ea5c7e9f807dfd5242c8e87a87d9ad604ebd035
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: If5f4042642364424f8d7e1e13b6285503df1d381
2015-04-23loplugin:staticmethodsNoel Grandin
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-21No more need for PartialWeakComponentImplHelper hereStephan Bergmann
...since 70626249cd247d9acdad417b8eaf252bae22c059 "API CHANGE a11y unpublishing and add/removeListener rename." Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21Make cpp/poppler-version.h header optionalTomáš Chvátal
Older popler (SLE11) does not have this header yet. With the code simply if the header not found define version to oldest possible working candidate and also raise the .pc check to the same. Change-Id: I039c879879188fe2eb90cd119b80a1d6354a6a9c Reviewed-on: https://gerrit.libreoffice.org/15339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-07loplugin:staticmethodsNoel Grandin
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-07loplugin:staticmethodsNoel Grandin
Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
2015-04-02loplugin:staticmethodsNoel Grandin
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca