summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)Author
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I4b7583a69ddd8de0e428a0ce848c95f805433952
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-22fdo#79045 PDF Import: fix text displacementVort
Change-Id: I22e3b90671f1dc4f9720758a7a5b79f56fa2ff49 Reviewed-on: https://gerrit.libreoffice.org/14098 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2015-01-22pdf import: Kill cut'n'paste, and fix a memory leak.Jan Holesovsky
Change-Id: I9460e458e9ac5274d68bd11b0ed77b06d664ce0e
2015-01-21fdo#85174 PDF Import: fix character positions without modifying popplerVort
Change-Id: I4ec6409e8fa13161c5cd37fcae2055b4bc5ecfd4 Reviewed-on: https://gerrit.libreoffice.org/14066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20continue to implement drawChar for unpatched popplers without drawChar2 hackCaolán McNamara
Change-Id: Id4ad86f3f563d88777352722e397cd77cfad45e4
2015-01-20fdo#85174 PDF Import: fix character positionsVort
Change-Id: I0aa75b6cb834341e47bbeeaa15d39387a8cb5240 Reviewed-on: https://gerrit.libreoffice.org/14029 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20Some more loplugin:cstylecast: sdextStephan Bergmann
Change-Id: Id98eab748280cd9c9c6e34cc3f6938ff6911361a
2015-01-19fdo#88465 PDF Import: fix scale and rotate image transformationsVort
Change-Id: I64bb088320099303b0da6d272c3cd6a9ba954f87 Reviewed-on: https://gerrit.libreoffice.org/13957 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-04boost::unordered_map->std::unordered_mapCaolán McNamara
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2014-12-23fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5 Reviewed-on: https://gerrit.libreoffice.org/13608 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-18sdext: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I6815b791b935bffe6409af2bcfdd6d6adceb2252
2014-12-15sdext: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I0e9800f1c828294e5b97e513dae30a4f2d1161fe
2014-12-05fdo#38835 strip out OString globalsNoel Grandin
Change-Id: Id2eb27132fd6c1734e50c02617ce1bbb75e294a0
2014-11-26fix higher debug level buildCaolán McNamara
Change-Id: Ibc2b9e56882fac4ebd181ef9fd66d91981951d32
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#1019392 Uncaught exceptionCaolán McNamara
Change-Id: Iab953700c9aa95fc3acd5f25233a942a31b7f5ad
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06Resolves: fdo#76581 copy-and-paste -> slideshow crash in presenter consoleCaolán McNamara
crash started after... commit 0218b0e2fa510d7acd7413dbedefd9ad50257f76 Date: Mon Jul 15 19:45:44 2013 +0300 fdo#65457 - Provide visual clues in presenter view. Change-Id: I19d84800bd5924f2dcc9e5debcf18ef95577105c
2014-11-05coverity#1019393 Uncaught exceptionCaolán McNamara
Change-Id: I818a91a3090392efed46700b5e2d77d7f1e3bdb9
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-06convert to floating point before divideCaolán McNamara
Change-Id: I0328ca6594b3809210ea124dcb744bad3b5eb92e
2014-10-04coverity#1242725 Result is not floating-pointNorbert Thiebaud
Change-Id: I007ef5efa07f9124a08e049bca01aac87acfa48e
2014-10-02remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macroMichael Stahl
This is supported in GCC 4.6.0 already: https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02coverity#1242882 Result is not floating-pointCaolán McNamara
Change-Id: I5072c29188e33b5711e67188441c497bf8759891
2014-09-26coverity#982849 try and fix Unrecoverable parse warningCaolán McNamara
Change-Id: Iba0f175c7c079f2171bab6e5a7419c7d5966c541
2014-09-26what is it with the explicit voidsCaolán McNamara
Change-Id: I7d3995f16351cb1686003f2ba7a044ac99d6d10b
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-08sdext: check the copy on the stack, not the memberMichael Stahl
Change-Id: Id8aaccf5fa31ad670215db61853bb729302b1fec
2014-09-06Related fdo#82088: dropping aliases again :)Stefan Weiberg
Change-Id: I41f6472423b60e3699ed6158cc5eccb10de1538d Reviewed-on: https://gerrit.libreoffice.org/11295 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-27Resolves: fdo#83137 NULL pActionCaolán McNamara
Change-Id: I74c4e32aae1e3aa74d197f132c900627062b6d01
2014-08-25set names on a bunch more threads...Michael Stahl
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-20fix string out-of-bounds assert on rhbz496762-1.pdfCaolán McNamara
Change-Id: I224e3c9befd1a9ab3ba0cc2676cd6b4ba51214c8
2014-08-09fdo#75757: remove inheritance to std::vectorTakeshi Abe
... for PaneStyleContainer and ViewStyleContainer. Change-Id: I6a6e2b1733266f54a94a49ab491cf854eb5df492 Reviewed-on: https://gerrit.libreoffice.org/10847 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-01avoid memory leakDavid Tardon
Change-Id: I9ac97c4e5c7b01b5e05cb1132c0d245f5843799e
2014-08-01fix parsing of cmdline argsDavid Tardon
Change-Id: I4005c08d4163d5d26f227e01c2520379f717343a
2014-07-03Does not look like Library_pdfimport needs popplerStephan Bergmann
Change-Id: I1dd162f939ce4f0689ea14724c1e7cec8a6c16b0
2014-07-03Improve test codeStephan Bergmann
(never call CPPUNIT_ASSERT etc., which work by throwing exceptions, from a dtor) Change-Id: I293d54eb40c2ad9205d485ccff0ffd2161257142
2014-07-03Check exit code of spawned xpdfimportStephan Bergmann
Change-Id: I4bea1ebe5c9915ad5e3a4f8fecb516bc056d060d
2014-06-30Remove double assignmentPeter Senna Tschudin
The semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ expression i,f; position p1,p2; @@ ( (<+...i++...+>) = ...; | (<+...++i...+>) = ...; | (<+...i--...+>) = ...; | (<+...--i...+>) = ...; | i = <+...f(...)...+>; | i@p1 = ...; ( i = <+...i...+>; | i = <+...f(...)...+>; | i@p2 = ...; ) ) @@ expression i; position r.p1,r.p2; @@ * i@p1 = ...; i@p2 = ...; // </smpl> Change-Id: Ifacb878d58486f2645560592484ce24b2bc0bd6f Reviewed-on: https://gerrit.libreoffice.org/9968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-06-27loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-21prevent invalid memory accessMarkus Mohrhard
e.g. fdo26139-1.pdf Change-Id: Ic5854e2056c246d48e2962dfe0a91f67c2c30c04
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: Iacd3efa9e5d6103ad92e15884e8aa010d7b2ae93
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
generated by cgit (git 2.34.1) at 2025-01-31 18:38:30 +0000