summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)Author
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-06convert to floating point before divideCaolán McNamara
Change-Id: I0328ca6594b3809210ea124dcb744bad3b5eb92e
2014-10-04coverity#1242725 Result is not floating-pointNorbert Thiebaud
Change-Id: I007ef5efa07f9124a08e049bca01aac87acfa48e
2014-10-02remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macroMichael Stahl
This is supported in GCC 4.6.0 already: https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02coverity#1242882 Result is not floating-pointCaolán McNamara
Change-Id: I5072c29188e33b5711e67188441c497bf8759891
2014-09-26coverity#982849 try and fix Unrecoverable parse warningCaolán McNamara
Change-Id: Iba0f175c7c079f2171bab6e5a7419c7d5966c541
2014-09-26what is it with the explicit voidsCaolán McNamara
Change-Id: I7d3995f16351cb1686003f2ba7a044ac99d6d10b
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-08sdext: check the copy on the stack, not the memberMichael Stahl
Change-Id: Id8aaccf5fa31ad670215db61853bb729302b1fec
2014-09-06Related fdo#82088: dropping aliases again :)Stefan Weiberg
Change-Id: I41f6472423b60e3699ed6158cc5eccb10de1538d Reviewed-on: https://gerrit.libreoffice.org/11295 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-27Resolves: fdo#83137 NULL pActionCaolán McNamara
Change-Id: I74c4e32aae1e3aa74d197f132c900627062b6d01
2014-08-25set names on a bunch more threads...Michael Stahl
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-20fix string out-of-bounds assert on rhbz496762-1.pdfCaolán McNamara
Change-Id: I224e3c9befd1a9ab3ba0cc2676cd6b4ba51214c8
2014-08-09fdo#75757: remove inheritance to std::vectorTakeshi Abe
... for PaneStyleContainer and ViewStyleContainer. Change-Id: I6a6e2b1733266f54a94a49ab491cf854eb5df492 Reviewed-on: https://gerrit.libreoffice.org/10847 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-01avoid memory leakDavid Tardon
Change-Id: I9ac97c4e5c7b01b5e05cb1132c0d245f5843799e
2014-08-01fix parsing of cmdline argsDavid Tardon
Change-Id: I4005c08d4163d5d26f227e01c2520379f717343a
2014-07-03Does not look like Library_pdfimport needs popplerStephan Bergmann
Change-Id: I1dd162f939ce4f0689ea14724c1e7cec8a6c16b0
2014-07-03Improve test codeStephan Bergmann
(never call CPPUNIT_ASSERT etc., which work by throwing exceptions, from a dtor) Change-Id: I293d54eb40c2ad9205d485ccff0ffd2161257142
2014-07-03Check exit code of spawned xpdfimportStephan Bergmann
Change-Id: I4bea1ebe5c9915ad5e3a4f8fecb516bc056d060d
2014-06-30Remove double assignmentPeter Senna Tschudin
The semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ expression i,f; position p1,p2; @@ ( (<+...i++...+>) = ...; | (<+...++i...+>) = ...; | (<+...i--...+>) = ...; | (<+...--i...+>) = ...; | i = <+...f(...)...+>; | i@p1 = ...; ( i = <+...i...+>; | i = <+...f(...)...+>; | i@p2 = ...; ) ) @@ expression i; position r.p1,r.p2; @@ * i@p1 = ...; i@p2 = ...; // </smpl> Change-Id: Ifacb878d58486f2645560592484ce24b2bc0bd6f Reviewed-on: https://gerrit.libreoffice.org/9968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-06-27loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-21prevent invalid memory accessMarkus Mohrhard
e.g. fdo26139-1.pdf Change-Id: Ic5854e2056c246d48e2962dfe0a91f67c2c30c04
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: Iacd3efa9e5d6103ad92e15884e8aa010d7b2ae93
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-06fixincludeguards: fix include guardsThomas Arnhold
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b Reviewed-on: https://gerrit.libreoffice.org/9629 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-05sdext: remove SAL_THROW macroNoel Grandin
Change-Id: Ib8649fb4d5aa2249d99d5c9d9ecf9d2307a93c72
2014-06-04update_pch: add a bunch of pch filesThomas Arnhold
desktop: 1m51s -> 54s framework: 1m55s -> 1m04s package: 32s -> 16s sdext: 1m31s -> 47s svgio: 32s -> 15s uui: 49s -> 20s vbahelper: 1m44s -> 27s xmlscript: 15s -> 10s xmlsecurity: 45s -> 23s Change-Id: Ia437969c091bf877983ababc5ea2d044bbc0bee0
2014-06-04coverity#982645 bMissingDefaultsToNormal is always trueCaolán McNamara
Change-Id: Ica58be0b5512eb8f386e51ec6e84d0ec09c3027f
2014-06-04DeInitVCL at end of testsStephan Bergmann
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-02Use boost::hash_value to avoid undef conv of neg/large floating -> size_tStephan Bergmann
Change-Id: I85853ffc6083d46c02c08f14d5d3321803c31301
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29remove unnecessary NULL parameter passed to UNO ExceptionNoel Grandin
.. now that we have a default value for that parameter Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-27remove unnecessary use of Reference constructor in throwNoel Grandin
Convert code like this: throw IOException("xx", Reference< XInterface >(static_cast<OWeakObject*>(this)) ); to this: throw IOException("xx", static_cast<OWeakObject*>(this) ); Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-24coverity#983807 Uncaught exceptionCaolán McNamara
Change-Id: Ic303dae356690db009b5917168b77da2f2d8d433
2014-05-23Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20Julien Nabet
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-20Correct linker library sequence for pdfimportJan-Marek Glogowski
Otherwise I get a lot of missing fontconfig symbols. Change-Id: I9bc3e395d54380a36cd6dd73cf95b7f4e4cab54e
2014-05-20we need fontconfig nowCaolán McNamara
Change-Id: I0482f613d7c908488e7d9f84f891bd521e91cc15
2014-05-20fdo#78689 PDF Import: get font's ascent value from different sourceVort
Change-Id: I19018d25ef53bbea225bb5a9ef806ce5c1b4adc7 Reviewed-on: https://gerrit.libreoffice.org/9410 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-16coverity#984442 Use after freeCaolán McNamara
Change-Id: I28822f6b74cbf8ace8f7a194248840cb401679be
2014-05-15fdo#78549 PDF Import: fix incorrect transformation matrix writingVort
Change-Id: I60d77e01ea7774c234d1ad1b81b90a7db3461e22 Reviewed-on: https://gerrit.libreoffice.org/9310 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-14remove external header guardsThomas Arnhold
that's the problem with those: none of them was actually defined... Change-Id: I496140e43cf8ff8a5712394023d98516aaf21adc
2014-05-14use our css prefix to make this readableThomas Arnhold
Change-Id: I360832edafcfcff7e63fd3b185c2575165c2d728
2014-05-14various loplugin:passsequencebyrefNoel Grandin
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-05-13remove dead codeNoel Grandin
Change-Id: Ic4fb478921714429af138ca212bd7f67f408d434
2014-05-08fdo#78427 PDF Import: Improve detection of bold italic fontVort
(Bug #78427 is fixed only partially by this commit) Change-Id: I080dca98a77a645c4c5ae19a9bbcae7d54179d3c Reviewed-on: https://gerrit.libreoffice.org/9276 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-07fdo#78382 PDF Import: add opacity support for fill and strokeVort
Change-Id: I76375280ee4726c1d497858165f38f4e8b4224cb Reviewed-on: https://gerrit.libreoffice.org/9268 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-06fix build problemCaolán McNamara
Change-Id: Ia6a54d86d4f283c7220a88b6bc68f0fb47ed3014
2014-05-06fdo#78241 PDF Import: add dashes supportVort
Change-Id: Ifd9fbce44c7d18114d5be466bfb9d92192573205 Reviewed-on: https://gerrit.libreoffice.org/9246 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
generated by cgit (git 2.34.1) at 2025-01-14 08:59:28 +0000