summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)Author
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-30Fix typosAndrea Gelmini
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I0a24f0d6fa58407f9e365a5c812743151b88513b
2016-04-18tdf#99352 - Some VclPtrs leak past DeInitVCLNoel Grandin
Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8 Reviewed-on: https://gerrit.libreoffice.org/24204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in sdextNoel Grandin
Change-Id: I954510b953dab133bcf7b37cf598757b7d8e5fca
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I0d75653dcde39b0fbd8af723295262615978d903
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-06Avoid reserved identifierStephan Bergmann
Change-Id: I3ded47656c4e0f1c3134337bddab5713f29be27e
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-24loplugin:constantparam in sdNoel Grandin
Change-Id: I1a7f4cab28a70c45e5232e1c44f6ca6f7b014bff
2016-03-23loplugin:constantparam in sdextNoel Grandin
Change-Id: Ib349a856665776ef51524b3c6613774f739bbdfe
2016-03-22delete hidden pages before deleting unused mastersDavid Tardon
Change-Id: I40b624c0e6e6cff2c88815f7d16e862f09d79d5c
2016-03-17sdext.presenter: change OSL_TRACE -> SAL_INFODouglas Mencken
Change-Id: I34724f28b96b00b8afe2b618d8d47561082987ca Reviewed-on: https://gerrit.libreoffice.org/23311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-11tdf#97966: Remove 'static' keywordsWastack
Change-Id: I0d9837a7ccecd606e0d43b53f8b920547b0d0bcd Reviewed-on: https://gerrit.libreoffice.org/23132 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10coverity#1355499 Unchecked return valueCaolán McNamara
Change-Id: I0b9329d00bfcebb6e29db6786715b19a7697d087
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09tdf#98421: properly import vertical mirroring of images from PDFMike Kaganski
Since commit ae0e830f9ace78b889713e7e74ce46f88fa21470, mirroring is handled correctly in LO, so no need to handle it specially in PDF import code. Commit 11c865031cffc170d3db6b00fb48c683fb4ff070 fixed import to Draw, this one fixes import to Writer. Also, unit tests for both cases are provided. Change-Id: I9ef9753a364af34f9e158052855c5dba1300c934 Reviewed-on: https://gerrit.libreoffice.org/23028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-08Various loplugin warningsStephan Bergmann
Change-Id: I7a405bc22d6ff337d53ad2c187f2ae1726798bb5
2016-03-08Remove spurious \r from OSL_TRACE outputTor Lillqvist
Change-Id: I84f34f25a5d0deb6a23c233b981daacea4fe9d33
2016-03-08tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 1 to OSL_DEBUG_LEVEL > 0 in most of the files as suggested in easy hack Change-Id: I2c46dfd9de2ae965680494146120ea3c7530cc98 Reviewed-on: https://gerrit.libreoffice.org/23012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-04Silence -Werror,-Wundef in external/poppler includes (clang-cl)Stephan Bergmann
Change-Id: I42ae8b5d1769eba3e5af68b3b183c77f40c35ca8
2016-03-02loplugin:unuseddefaultparam in sdextNoel Grandin
Change-Id: I6919b8ca82e81153f4f8b663f00c9ede5ffe6305
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-22sdext: remove \n from SAL_WARN/INFO[_IF] macrosArnold Dumas
Change-Id: I07f33f6781c2b03ccbe690e70b77310e875eeef0 Reviewed-on: https://gerrit.libreoffice.org/22624 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-18tdf#43157: Clean up OSL_ASSERT, DBG_ASSERTArnold Dumas
Change-Id: I81def3487932497782b4e560ef920330ba5cc2a2 Reviewed-on: https://gerrit.libreoffice.org/22476 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-04loplugin:fpcomparison in sdext/Noel Grandin
Change-Id: If2ae6c3399ef3aceffc2080fcd790e91dc594d9b Reviewed-on: https://gerrit.libreoffice.org/21864 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-01tdf#96993: remove obsolete vertical mirror hack from PDF importMike Kaganski
Since commit ae0e830f9ace78b889713e7e74ce46f88fa21470, mirroring is handled correctly in LO, so no need to handle it specially in PDF import code. This obsolete handling causes double-mirroring. Change-Id: Ia873f0426e444cafd80b24b7d209e90eb481d8f4 Reviewed-on: https://gerrit.libreoffice.org/21870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-26-Werror,-Wunused-parameter (clang-cl)Stephan Bergmann
Change-Id: I1ac58714e04b995ef5229888f0c427104c001318
2016-01-19Ensure irreflexivity of std::stable_sort predicateStephan Bergmann
GCC 6 libstdc++ checks for that in debug mode now Change-Id: I879b1b5eb9b54ad19749e561c55333b0a084c699
2016-01-14loplugin:unusedmethods unused return value in sdextNoel Grandin
Change-Id: Ie919a094630da57371b13081ab2f04984dd96c78
2016-01-11loplugin:privatebase: Make derivation from noncopyable explicitly privateStephan Bergmann
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-26sdext: change instances of maName to more descriptive namesChris Sherlock
Change-Id: If1cb55737240ba1e35e18790894d421aae660026 Reviewed-on: https://gerrit.libreoffice.org/20960 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-21loplugin:unusedfields sdextNoel Grandin
Change-Id: I1719d684b0afd348c16a2ba942899e8ccded81c3
2015-12-12TyposJulien Nabet
Change-Id: I7a161afb520c3f26be0d5846a3ef2300c558a7d2
2015-12-11Get rid of StaticLibrary_pdfimport_sStephan Bergmann
...which contained the bulk of .cxx files that should logically go into Library_pdfimport. It was likely (only) used so that check_targets CppunitTest_sdext_pdfimport, Executable_pdf2xml, and Executable_pdfunip could access the library's internals without exporting them. For the CppunitTest, use the standard gb_CppunitTest_use_library_objects hack instead. For the two Executables, make that _use_library_objects hack available for Executables, too. (It is a bit unclear whether those two Executables are really needed, they are only referenced from the dead dmake-based sdext/source/pdfimport/test/testdocs/makefile.mk and from vcl/README, respectively; but just keep them alive for now.) Change-Id: Ia2478508de216678be7a2302aba0c48f80de9d91 Reviewed-on: https://gerrit.libreoffice.org/20645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-11Remove unused -DBASEGFX_STATIC_LIBRARYStephan Bergmann
...introduced in b9d1006ebb3c97e398d4bb31075fd2577f3ac858 "re-base on ALv2 code," probably due to a merge conflict or something like that. Change-Id: Ib38cd24e935f951482ba99f483a419a9a7782ae8
2015-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
generated by cgit (git 2.34.1) at 2025-02-12 21:55:37 +0000