summaryrefslogtreecommitdiff
path: root/setup_native
AgeCommit message (Collapse)Author
2023-06-09improve dictionary package descriptionsAndras Timar
Change-Id: I490b8a9b99dae76b92de3b5ed22bb27a9df21591
2023-02-12[cp] Collabora Office macOS packagingAndras Timar
- added EULA (sla.r) in special OS X resource fork format - added volume icon which does not work ATM, TODO later - new dmg background image and adjusted .DS_Store - fixes to tolerate space in app bundle name Change-Id: Ia855d7d677136de951c2b9b31ee8d5583475dd41
2023-01-28[cp] resolution of osxdndinstall.png must be 72dpiAndras Timar
Change-Id: Ib0a020fcbd855c97fc2294287e517b9f440c552a
2023-01-28[cp] Update brand colors: mac installerPedro Pinto Silva
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Iaa5620207577ccc45418cc0137af12d4848e268d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133498 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-28[cp] Add Persian dictionary to install set this wayAndras Timar
Change-Id: I86e0eeb68120b311759a6cef0b13740bb1529999
2023-01-23[cp] do not include version number to package nameAndras Timar
Change-Id: I2f5d9eb0e43c80d5712e0a65167ad8d0e56ab330
2023-01-23[cp] fix vendor name in package info and desktop filesAndras Timar
Change-Id: I3290ff1a0c138cbf8be34690a2127f19d7f15f4e
2023-01-23[cp] Collabora Office brandingAndras Timar
Change-Id: I694d9a6c508853d2d980f76cc259ce1e39149da4
2023-01-23[cp] provide libreoffice-writer, libreoffice-calc etc. metapackagesAndras Timar
(cherry picked from commit d151f43cdb0e7735d267115868a9dac9f45bb6b2) (cherry picked from commit ddb987c79a3852cfb552f10b1beca03f419879c2) Change-Id: Ibadbcb45eb0cacd8f26e7bfed3cff794a7ce88f1
2023-01-08Bump copyright year to 2023Adolfo Jayme Barrientos
Change-Id: I699112a3e554013bab75b82d1eae00098216c886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144903 Tested-by: Jenkins Reviewed-by: Martin Srebotnjak <miles@filmsi.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-07tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroTomoyuki Kubota
Change-Id: Ibd3f56f6e669a3bb1c1926aa4affdcc46623c81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-27Add Persian (fa-IR) dictionary to installsetAron Budea
Change-Id: I7abf38be5c8d8c8bfb7eb3a756695054b4275f9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138892 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2022-05-18tdf#149106 Remove RenamePrgFolder and RemovePrgFolder custom msi actionsSamuel Mehrbrodt
This duplicates MSI functionality - if a folder cannot be written, MSI should request a reboot automatically. See https://bugs.documentfoundation.org/show_bug.cgi?id=149106#c17 for details. Change-Id: I65f295ff6e3bb22afc616feb2ba529413f3e24c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134513 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2022-05-11Add error handling to RenamePrgFolder and RemovePrgFolderSamuel Mehrbrodt
These routines can fail during MSI installation (seen leftover program_old folders, with program folder missing). We at least want to see the error in the MSI log file when this doesn't succeed. This outputs error messages like: MSI (s) (C4:5C) [10:47:54:280]: Invoking remote custom action. DLL: C:\Windows\Installer\MSI37B4.tmp, Entrypoint: RemovePrgFolder CustomAction RemovePrgFolder returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox) Action ended 10:47:54: RemovePrgFolder. Return value 3. Change-Id: I4ce4099eeb3e0ee79eb4a2e1d3887f9810fd9669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134160 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-26Drop unused LanguageTool extensionGabor Kelemen
Do not bundle LanguageTool which is at a 10 year old version (1.7) while upstream has a lot of new releases (now at version 5.5.x) It is not bundled by any downstream distributions so it makes no much sense to keep it integrated here. Change-Id: Icd2ef151b1b8d0252ffa3db0caaba576f2783fa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133356 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-26Drop unused CT2N extensionGabor Kelemen
It is not bundled by any downstream distributions so it makes no much sense to keep it integrated here. Change-Id: I80180e53e050b8b3cd1b173ef01b51e8d706f295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133355 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-10loplugin:emptyStephan Bergmann
Change-Id: Ib52d0d4db0f50ba7551eadcb3db2920008596b59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132761 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-14Adding Central Kurdish(ckb) Spell Checker & DictionaryOlivier Hallot
Part II (core) Dictionary packaging Based on https://gerrit.libreoffice.org/c/core/+/59882 Change-Id: Ib60553acf1764743918e666d4e6308c1976c6813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129120 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-01-29use mktemp for FAKEDBRPMCaolán McNamara
Change-Id: I53d0f027b60d681e16298531e3d890fafc43aea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28use mktemp for outdirCaolán McNamara
Change-Id: I2aa04ab31c0966167dee47b1c0ea6d2228e262da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28use mktemp for UNPACKDIRCaolán McNamara
Change-Id: If87fb28193f42e60419aa30b5ba7e4af6e05bbcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-01Bump copyright year to 2021Adolfo Jayme Barrientos
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169
2021-10-29Fix misuses of NULL across Windows-only codeStephan Bergmann
...which defines NULL as a plain 0 integer literal instead of the GNU __null extension, so clang-cl's -Wnull-conversion cannot kick in. These findings are from an experimental build done with clang-cl and a modified > --- a/clang/lib/Headers/stddef.h > +++ b/clang/lib/Headers/stddef.h > @@ -83,6 +83,10 @@ typedef __WCHAR_TYPE__ wchar_t; > # if !defined(__MINGW32__) && !defined(_MSC_VER) > # define NULL __null > # else > -# define NULL 0 > +# if __cplusplus >= 201103L > +# define NULL nullptr > +# else > +# define NULL 0 > +# endif > # endif > #else > # define NULL ((void*)0) However, that build also ran into lots of places where 3rd-party code in external/ and Windows system headers caused issues when NULL is nullptr (which I worked around with various hacky patches for that build), so this is unfortunately not something that can easily be enabled generally. Change-Id: I10674464498a9bc63578d9e6cc32ddde23ab4f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124419 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-20Make some scripts more portableIlmari Lauhakangas
Change-Id: Ia89059eea51ca396a7c74143625ac9a6706de198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120773 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-06Fix and simplify "any bundled extensions installed" checkStephan Bergmann
First, Extension_nlpsolver is not unconditionally covered by --with-java, but by a dedicated --enable-ext-nlpsolver (which requires --with-java). (I had overlooked that the whole Module_nlpsolver is conditional in RepositoryModule_host.mk.) So the check for Extension_nlpsolver should instead check for NLPSOLVER in BUILD_TYPE. Second, the check for --enable-ext-numbertext could check for NUMBERTEXT in BUILD_TYPE instead of checking for NUMBERTEXT_EXTENSION_PACK, as --enable-ext-numbertext sets both (cf. m4/libo_check_extension.m4). And third, any --enable-ext-* will set WITH_EXTRA_EXTENSIONS (cf. m4/libo_check_extension.m4), so all those various BUILD_TYPE checks can all be subsumed by a single WITH_EXTRA_EXTENSIONS check. (Which nicely reduces the maintenance burden mentioned in the commit message of f267340d300da6318435ed1b2ae48b9f4275e2c4 "Remove unused $(LIBO_SHARE_FOLDER)/extensions/package.txt.") Change-Id: Ifdf8b59febd49661500292ab2003c792d8cb60a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120104 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-06gb_Package_Package must specify a directoryStephan Bergmann
...even if unused, as otherwise a minimal --without-java build (i.e., where the ifeq in setup_native/Package_packinfo.mk actually triggers) failed with > setup_native/Package_packinfo.mk:18: *** gb_Package__check: Package setup_native_packinfo has not been defined. Stop. Change-Id: I0fa3640448da333294ee2ab25183df1ffee22533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120094 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-05Remove unused $(LIBO_SHARE_FOLDER)/extensions/package.txtStephan Bergmann
There had originally been some back-and-forth among 134ae5da1cc6a5dfa4432063f930235c1a872bc0 "jl154 #162868# remove basis/presets/bundled/bundled.ini, and create always share/extensions folder", 4c333e8ac7f6135fb4e62e4960c826b278e8cc63 "jl154 #162868# removing the package.txt from the extensions folder. Extensions folder will be created in a different way than installing a dummy file", and 8f4cf9a16eb9936ef1e862ecdec7d30c9e240987 "jl154 #162868# guarantee existence of extensions folder" whether or not that dummy file was necessary to ensure creation of the (otherwise potentially empty) $(LIBO_SHARE_FOLDER)/extensions/ directory. That is no longer necessary with gb_Package_add_empty_directory (though the logic that had to be added to setup_native/Package_packinfo.mk now is a bit unfortunate, and will need to be updated whenever the list of potential bundled extensions changes). (And that dummy package.txt file is apparently not used to track whether per- user extension information needs to be updated when the contents of $(LIBO_SHARE_FOLDER)/extensions/ changes. That is rather done by comparing the status of the $(LIBO_SHARE_FOLDER)/extensions/ directory itself against user/extensions/bundled/lastsynchronized in the UserInstallation, see needToSyncRepository in desktop/source/deployment/misc/dp_misc.cxx.) Change-Id: I5b9956c508288945f32a88afaef57ac0b63dc27f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120081 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27Add Mongolian dictionaryAndras Timar
Change-Id: I4613d2e5b77374cbc8fb72033b3dfcd8e2702712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114733 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-19Updated README.md filesHossein
* Updated README.md contents to fix various issues * Fixed source links by using [git:], processed by mkdocs scripts * Added README.md for ios, setup_native, unotest * Fixed issues with "underline" and "less than" sign Change-Id: I3e52a1d3372586c390ee6c42a2ef48bbabc81398 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114248 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-11Add Esperanto dictionariesAndras Timar
Change-Id: I22d73bb5a6e4d215dc35acdd4ded47d29882671e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113941 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-02add back sal/macros.h for SAL_N_ELEMENTSTomoyuki Kubota
Change-Id: I5edb0632976e69530af38aaa334085796c103058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-16tdf#134607 use kMDItemFSName instead of _kMDItemDisplayNameWithExtensionsChristian Lohmaier
apparently the latter is not available on older versions of macOS. https://developer.apple.com/documentation/coreservices/kmditemfsname lists it as in version 10.4 and not flagged as deprecated, so keeping fingers crossed that it is not affected by user-settings or similar… Change-Id: I208d22f2abd628e7d95babc23ddb145a88bcf5cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112385 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-09Resolves tdf#133373 - macOS installer imageHeiko Tietze
Arrow moved a few pixels to the left Change-Id: Id804ca75f88325a1457f5297994ac91c2cea94da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112155 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-05tdf#134607 mac-langpacks: always query for full name with extensionChristian Lohmaier
kMDItemDisplayName has different values depending on the setting whether to show extensions for all filetypes in Finder, breaking the detection/validation of the installation target in case the user doesn't use the default setting. Change-Id: Ic9605abaaa1f070f1f5ec9940190fd1dd2555bdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110479 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27packaging: remove resolve_variables_in_downloadnameChristian Lohmaier
OOODOWNLOADNAME was set in the global section of openoffice.lst, so the code always did set the target path with set_download_filename. Thus remove the superfluous sub and then also the no longer used OOODOWNLOADNAME variables In the same vein: the "script that extracts a tarball that is appended to it" method is no longer in use since many years, delete that as well. Change-Id: I43481a3ec09e064ef77138e1cbfc1dba6854f2d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110017 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-19add --disable-librelogo to disable LibreLogo at build timeMichael Stahl
Annoyingly the packinfo_*.txt don't support conditionals but we can work-around that with a little duplication. Change-Id: Id00a6831effcc63a917fc21d2cd201474fdb559d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109569 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-19Community splash screen without EditionHeiko Tietze
macOS installer shows also just Community now Change-Id: Ia71d3b3a376f8e5e2254f2863ea61f065fb2d86f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109558 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-18mac: don't put script files into Contents/MacOS or framework-bin directoryChristian Lohmaier
Signing them as executable code would require external attributes, and those in turn break packaging into hfs+ dmg when building on apfs with Big Sur. It is not a new thing - the old Code Signing in Depth technote https://developer.apple.com/library/archive/technotes/tn2206/_index.html already reads: "Store Python, Perl, shell, and other script files and other non-Mach-O executables in your app's Contents/Resources directory. While it's possible to sign such executables and store them in Contents/MacOS, this is not recommended. […] Put another way, a properly-signed app that has all of its files in the correct places will not contain any signatures stored as extended attributes." The patch does exactly that for LO and the shipped python framework and adds symlinks for the moved files. Same applies for the Language pack applescript and the tarball - those are also moved into Contents/Resources Change-Id: Iab21e77b73f941248ca89c6e80703fdf67a1057c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109537 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-06Fix MSVC 2019 16.8.3 --with-latest-c++ two-phase name lookup issuesStephan Bergmann
> C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(105): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 5 arguments > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(83): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(118): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::string>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::string &)' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(382): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[18],std::string>(MSIHANDLE,const char (&)[18],const std::string &)' being compiled > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(105): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 6 arguments > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(83): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(118): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::string,char[6]>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::string &,const char (&)[6])' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(516): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[19],std::string,char[6]>(MSIHANDLE,const char (&)[19],const std::string &,const char (&)[6])' being compiled and > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(104): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 5 arguments > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(82): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(117): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::wstring>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::wstring &)' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(159): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[27],std::wstring>(MSIHANDLE,const char (&)[27],const std::wstring &)' being compiled Change-Id: I7e8c121f8589ae847c9e4fd12e218408ea9e451e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108836 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-03Bump copyright year to 2021Adolfo Jayme Barrientos
Change-Id: I3159bfc21a35fc80aef57c7d809d8ea8c62a732e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108566 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-17package Korean(ko-KR) dictionaries into installsetDaeHyun Sung
Change-Id: I30cc4bdf4283cefb5985dc5380e2db5660d7d6e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106840 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-19tdf#123936 Formatting files in module setup_native with clang-formatPhilipp Hofer
Change-Id: I40c25e54b1348a17d4e639a77a1834462c8a5c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105705 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-08-04Improved loplugin:staticanonymous -> redundantstatic redux, clang-clStephan Bergmann
Change-Id: Ie6dc22edbcfdf05ab8d7d668cb7cc33b5b747995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-12Related: tdf#82184: consider installer language for UI list to installMike Kaganski
If user has a language set as user locale, and installer is shown in that language, it's likely that that language is needed for installation. Change-Id: I37fb959291262b772ec8e1b35c687d64e0ee76a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-12tdf#134748: handle Kazakh language in langid_to_stringMike Kaganski
Change-Id: I8829597b7e90ea52dc4a4bdd88cd07730a0c4f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98600 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-02Add Turkish (tr) dictionaryMuhammet Kara
Change-Id: Ibc1e7505e6a7492f4d0714c848a6d1eebcdf4a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97661 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-16macOS fix langpack installer with manually selected .app directoryChristian Lohmaier
For cases when there are multiple matching apps where the Languagepack might be installed to, the "make sure to launch LO once before installing the langpack" mechanism can fail. Even if it is the call "tell application <selection> to activate" that fails, the error handler assumes that the untar operation didn't work and suggests to retry with admin privileges, modifying the .app bundle before having it started once (AKA verified by gatekeeper), breaking the app. Passing the full path to the application object should fix that. Change-Id: I47d61ad68e225fbdba191702ba85598164602e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96449 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-06-16mac langpack script: simplify mdfind call to not use wildcard matchChristian Lohmaier
I think this is leftover from very early development stages when it didn't have placeholders, but literal OpenOffice or similar at the time. Not matching for wildcard but for full LibreOffice/LibreOfficeDev string makes removing the languagepacks from the match superfluous It was wrong anyway, since kMDItemDisplayName has the name without the .app extension (you'd have to use _kMDItemDisplayNameWithExtensions for that) Change-Id: I37b1ed2d23ea18fd81a8844f35c9cb0d5dc34211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96441 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-06-16tdf#133511 adjust langpack script for removal of CFBundleGetInfoStringChristian Lohmaier
3a028418190790c3bbaf6e505ff55b7bb8c0b474 removed the string from Info.plist, but the languagepack install script tried to use that to make sure whatever the user selects/is found is from the dame type (dev vs release and codeline/version). Instead of doing multiple greps/multiline ones (there are multiple version strings in that file, only one being from LO itself…) use mdls instead to pick the interesting properties to build a "PRODUCTNAME FULLVERSION" string again we can match against. --raw switch is nul separated, so add additional xargs -0 in there instead of trying to match a nul with grep (without --raw it is a nice human readable multiline string) Change-Id: I049a8425709a0c41b61aa09452490b481d39e4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96439 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-05-06Resolves tdf#132701 - macOS installer image must be 72dpiHeiko Tietze
See also 12b389e838743dec662c70c4772553a96ad4f9ac Change-Id: Ib46cd37e29beac4c18b2f9ce5a74b01f6c357cbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93500 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2024-07-02 23:06:07 +0000