summaryrefslogtreecommitdiff
path: root/setup_native
AgeCommit message (Collapse)Author
2022-01-02Bump copyright year to 2022Adolfo Jayme Barrientos
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169 (cherry picked from commit fb32c4d96141ccc1766fa4e39405130fcf409a6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127848 Reviewed-by: Martin Srebotnjak <miles@filmsi.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-10-29Fix misuses of NULL across Windows-only codeStephan Bergmann
...which defines NULL as a plain 0 integer literal instead of the GNU __null extension, so clang-cl's -Wnull-conversion cannot kick in. These findings are from an experimental build done with clang-cl and a modified > --- a/clang/lib/Headers/stddef.h > +++ b/clang/lib/Headers/stddef.h > @@ -83,6 +83,10 @@ typedef __WCHAR_TYPE__ wchar_t; > # if !defined(__MINGW32__) && !defined(_MSC_VER) > # define NULL __null > # else > -# define NULL 0 > +# if __cplusplus >= 201103L > +# define NULL nullptr > +# else > +# define NULL 0 > +# endif > # endif > #else > # define NULL ((void*)0) However, that build also ran into lots of places where 3rd-party code in external/ and Windows system headers caused issues when NULL is nullptr (which I worked around with various hacky patches for that build), so this is unfortunately not something that can easily be enabled generally. Change-Id: I10674464498a9bc63578d9e6cc32ddde23ab4f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124419 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-20Make some scripts more portableIlmari Lauhakangas
Change-Id: Ia89059eea51ca396a7c74143625ac9a6706de198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120773 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-06Fix and simplify "any bundled extensions installed" checkStephan Bergmann
First, Extension_nlpsolver is not unconditionally covered by --with-java, but by a dedicated --enable-ext-nlpsolver (which requires --with-java). (I had overlooked that the whole Module_nlpsolver is conditional in RepositoryModule_host.mk.) So the check for Extension_nlpsolver should instead check for NLPSOLVER in BUILD_TYPE. Second, the check for --enable-ext-numbertext could check for NUMBERTEXT in BUILD_TYPE instead of checking for NUMBERTEXT_EXTENSION_PACK, as --enable-ext-numbertext sets both (cf. m4/libo_check_extension.m4). And third, any --enable-ext-* will set WITH_EXTRA_EXTENSIONS (cf. m4/libo_check_extension.m4), so all those various BUILD_TYPE checks can all be subsumed by a single WITH_EXTRA_EXTENSIONS check. (Which nicely reduces the maintenance burden mentioned in the commit message of f267340d300da6318435ed1b2ae48b9f4275e2c4 "Remove unused $(LIBO_SHARE_FOLDER)/extensions/package.txt.") Change-Id: Ifdf8b59febd49661500292ab2003c792d8cb60a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120104 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-06gb_Package_Package must specify a directoryStephan Bergmann
...even if unused, as otherwise a minimal --without-java build (i.e., where the ifeq in setup_native/Package_packinfo.mk actually triggers) failed with > setup_native/Package_packinfo.mk:18: *** gb_Package__check: Package setup_native_packinfo has not been defined. Stop. Change-Id: I0fa3640448da333294ee2ab25183df1ffee22533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120094 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-05Remove unused $(LIBO_SHARE_FOLDER)/extensions/package.txtStephan Bergmann
There had originally been some back-and-forth among 134ae5da1cc6a5dfa4432063f930235c1a872bc0 "jl154 #162868# remove basis/presets/bundled/bundled.ini, and create always share/extensions folder", 4c333e8ac7f6135fb4e62e4960c826b278e8cc63 "jl154 #162868# removing the package.txt from the extensions folder. Extensions folder will be created in a different way than installing a dummy file", and 8f4cf9a16eb9936ef1e862ecdec7d30c9e240987 "jl154 #162868# guarantee existence of extensions folder" whether or not that dummy file was necessary to ensure creation of the (otherwise potentially empty) $(LIBO_SHARE_FOLDER)/extensions/ directory. That is no longer necessary with gb_Package_add_empty_directory (though the logic that had to be added to setup_native/Package_packinfo.mk now is a bit unfortunate, and will need to be updated whenever the list of potential bundled extensions changes). (And that dummy package.txt file is apparently not used to track whether per- user extension information needs to be updated when the contents of $(LIBO_SHARE_FOLDER)/extensions/ changes. That is rather done by comparing the status of the $(LIBO_SHARE_FOLDER)/extensions/ directory itself against user/extensions/bundled/lastsynchronized in the UserInstallation, see needToSyncRepository in desktop/source/deployment/misc/dp_misc.cxx.) Change-Id: I5b9956c508288945f32a88afaef57ac0b63dc27f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120081 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27Add Mongolian dictionaryAndras Timar
Change-Id: I4613d2e5b77374cbc8fb72033b3dfcd8e2702712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114733 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-19Updated README.md filesHossein
* Updated README.md contents to fix various issues * Fixed source links by using [git:], processed by mkdocs scripts * Added README.md for ios, setup_native, unotest * Fixed issues with "underline" and "less than" sign Change-Id: I3e52a1d3372586c390ee6c42a2ef48bbabc81398 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114248 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-11Add Esperanto dictionariesAndras Timar
Change-Id: I22d73bb5a6e4d215dc35acdd4ded47d29882671e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113941 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-02add back sal/macros.h for SAL_N_ELEMENTSTomoyuki Kubota
Change-Id: I5edb0632976e69530af38aaa334085796c103058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-16tdf#134607 use kMDItemFSName instead of _kMDItemDisplayNameWithExtensionsChristian Lohmaier
apparently the latter is not available on older versions of macOS. https://developer.apple.com/documentation/coreservices/kmditemfsname lists it as in version 10.4 and not flagged as deprecated, so keeping fingers crossed that it is not affected by user-settings or similar… Change-Id: I208d22f2abd628e7d95babc23ddb145a88bcf5cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112385 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-09Resolves tdf#133373 - macOS installer imageHeiko Tietze
Arrow moved a few pixels to the left Change-Id: Id804ca75f88325a1457f5297994ac91c2cea94da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112155 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-05tdf#134607 mac-langpacks: always query for full name with extensionChristian Lohmaier
kMDItemDisplayName has different values depending on the setting whether to show extensions for all filetypes in Finder, breaking the detection/validation of the installation target in case the user doesn't use the default setting. Change-Id: Ic9605abaaa1f070f1f5ec9940190fd1dd2555bdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110479 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27packaging: remove resolve_variables_in_downloadnameChristian Lohmaier
OOODOWNLOADNAME was set in the global section of openoffice.lst, so the code always did set the target path with set_download_filename. Thus remove the superfluous sub and then also the no longer used OOODOWNLOADNAME variables In the same vein: the "script that extracts a tarball that is appended to it" method is no longer in use since many years, delete that as well. Change-Id: I43481a3ec09e064ef77138e1cbfc1dba6854f2d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110017 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-19add --disable-librelogo to disable LibreLogo at build timeMichael Stahl
Annoyingly the packinfo_*.txt don't support conditionals but we can work-around that with a little duplication. Change-Id: Id00a6831effcc63a917fc21d2cd201474fdb559d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109569 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-19Community splash screen without EditionHeiko Tietze
macOS installer shows also just Community now Change-Id: Ia71d3b3a376f8e5e2254f2863ea61f065fb2d86f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109558 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-18mac: don't put script files into Contents/MacOS or framework-bin directoryChristian Lohmaier
Signing them as executable code would require external attributes, and those in turn break packaging into hfs+ dmg when building on apfs with Big Sur. It is not a new thing - the old Code Signing in Depth technote https://developer.apple.com/library/archive/technotes/tn2206/_index.html already reads: "Store Python, Perl, shell, and other script files and other non-Mach-O executables in your app's Contents/Resources directory. While it's possible to sign such executables and store them in Contents/MacOS, this is not recommended. […] Put another way, a properly-signed app that has all of its files in the correct places will not contain any signatures stored as extended attributes." The patch does exactly that for LO and the shipped python framework and adds symlinks for the moved files. Same applies for the Language pack applescript and the tarball - those are also moved into Contents/Resources Change-Id: Iab21e77b73f941248ca89c6e80703fdf67a1057c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109537 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-06Fix MSVC 2019 16.8.3 --with-latest-c++ two-phase name lookup issuesStephan Bergmann
> C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(105): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 5 arguments > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(83): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(118): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::string>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::string &)' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(382): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[18],std::string>(MSIHANDLE,const char (&)[18],const std::string &)' being compiled > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(105): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 6 arguments > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(83): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(118): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::string,char[6]>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::string &,const char (&)[6])' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(516): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[19],std::string,char[6]>(MSIHANDLE,const char (&)[19],const std::string &,const char (&)[6])' being compiled and > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(104): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 5 arguments > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(82): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(117): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::wstring>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::wstring &)' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(159): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[27],std::wstring>(MSIHANDLE,const char (&)[27],const std::wstring &)' being compiled Change-Id: I7e8c121f8589ae847c9e4fd12e218408ea9e451e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108836 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-03Bump copyright year to 2021Adolfo Jayme Barrientos
Change-Id: I3159bfc21a35fc80aef57c7d809d8ea8c62a732e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108566 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-17package Korean(ko-KR) dictionaries into installsetDaeHyun Sung
Change-Id: I30cc4bdf4283cefb5985dc5380e2db5660d7d6e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106840 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-19tdf#123936 Formatting files in module setup_native with clang-formatPhilipp Hofer
Change-Id: I40c25e54b1348a17d4e639a77a1834462c8a5c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105705 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-08-04Improved loplugin:staticanonymous -> redundantstatic redux, clang-clStephan Bergmann
Change-Id: Ie6dc22edbcfdf05ab8d7d668cb7cc33b5b747995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-12Related: tdf#82184: consider installer language for UI list to installMike Kaganski
If user has a language set as user locale, and installer is shown in that language, it's likely that that language is needed for installation. Change-Id: I37fb959291262b772ec8e1b35c687d64e0ee76a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-12tdf#134748: handle Kazakh language in langid_to_stringMike Kaganski
Change-Id: I8829597b7e90ea52dc4a4bdd88cd07730a0c4f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98600 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-02Add Turkish (tr) dictionaryMuhammet Kara
Change-Id: Ibc1e7505e6a7492f4d0714c848a6d1eebcdf4a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97661 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-16macOS fix langpack installer with manually selected .app directoryChristian Lohmaier
For cases when there are multiple matching apps where the Languagepack might be installed to, the "make sure to launch LO once before installing the langpack" mechanism can fail. Even if it is the call "tell application <selection> to activate" that fails, the error handler assumes that the untar operation didn't work and suggests to retry with admin privileges, modifying the .app bundle before having it started once (AKA verified by gatekeeper), breaking the app. Passing the full path to the application object should fix that. Change-Id: I47d61ad68e225fbdba191702ba85598164602e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96449 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-06-16mac langpack script: simplify mdfind call to not use wildcard matchChristian Lohmaier
I think this is leftover from very early development stages when it didn't have placeholders, but literal OpenOffice or similar at the time. Not matching for wildcard but for full LibreOffice/LibreOfficeDev string makes removing the languagepacks from the match superfluous It was wrong anyway, since kMDItemDisplayName has the name without the .app extension (you'd have to use _kMDItemDisplayNameWithExtensions for that) Change-Id: I37b1ed2d23ea18fd81a8844f35c9cb0d5dc34211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96441 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-06-16tdf#133511 adjust langpack script for removal of CFBundleGetInfoStringChristian Lohmaier
3a028418190790c3bbaf6e505ff55b7bb8c0b474 removed the string from Info.plist, but the languagepack install script tried to use that to make sure whatever the user selects/is found is from the dame type (dev vs release and codeline/version). Instead of doing multiple greps/multiline ones (there are multiple version strings in that file, only one being from LO itself…) use mdls instead to pick the interesting properties to build a "PRODUCTNAME FULLVERSION" string again we can match against. --raw switch is nul separated, so add additional xargs -0 in there instead of trying to match a nul with grep (without --raw it is a nice human readable multiline string) Change-Id: I049a8425709a0c41b61aa09452490b481d39e4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96439 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-05-06Resolves tdf#132701 - macOS installer image must be 72dpiHeiko Tietze
See also 12b389e838743dec662c70c4772553a96ad4f9ac Change-Id: Ib46cd37e29beac4c18b2f9ce5a74b01f6c357cbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93500 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-05Some improvements to About box and brandingHeiko Tietze
* Label left-aligned (tdf#132322) * Long build string cut at 25 chars * Extra text such as Tinderbox info wraps now at Misc * UI-Language shortened to just UI * More padding between about image and text * Splash screen uses Vegur font * Splash with small border * Non-TDF logos have a "Community Edition" text Change-Id: I1ec31e22052e365f28fe91de3e083252975911c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93444 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-30Resolves tdf#130778 - Branding for 7.0Heiko Tietze
Remaining installer images added TDF tagline removed White background on all splash screens Change-Id: Iafde896fd3ed58957ec16ba43565c56e85db925c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93199 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-20Translate German variable namesJohnny_M
Ende -> End Change-Id: I2d63ddfeb1fa59ed1b0e3bbf2d39d5221cd5425f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92026 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-03Set INSTALLLOCATION in one single placeMike Kaganski
It used to be set both in AppSearch action (using RegLocator table), and in MigrateInstallPath custom action. This would overwrite value of INSTALLLOCATION taken from user, and read on the previous step, with values taken on the next step. Only migrating the install location in one single place - in custom action MigrateInstallPath - makes the process controllable. Also it allows to easily see all the various places in registry we read. Change-Id: Ib7e04c26e71ba92c6a62a0511971bfb3bdb7db72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87867 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-03tdf#130329: detect previous version's install locationMike Kaganski
Since component ids change across major versions, install location isn't kept automatically for major upgrades. Use OLDPRODUCTS property set during FindRelatedProducts action (see Upgrade table created by solenv/bin/modules/installer/windows/upgrade.pm). Read InstallLocation in existing MigrateInstallPath custom action under HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\GUID, where GUID is the value of OLDPRODUCTS. This only reads registry hive for the current installer architecture (32/64 bit), so that the other architecture installation path is not taken into account when old version is of different architecture, to avoid installing into wrong directory when e.g. upgrading from 32-bit to 64-bit, so 64-bit program is not installed to Program Files (x86). Change-Id: Ib9fa004818908a5706c5af040f1a5a36c03d2f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87844 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-10Improve logging of feature statesMike Kaganski
Change-Id: I8b304bbefe861abd7503204f0ae8efb0aea203ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86528 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-09-Werror,-Wwritable-strings (clang-cl)Stephan Bergmann
Change-Id: I67287498db35c60f224b095b00e6c058f53c10cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86471 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-09Register spsupp*.dll during installationMike Kaganski
This registers SharePoint integration libraries using regsvr.exe. Both 32-bit and 64-bit libraries are registered; registration of LOSPSupport.OpenDocuments is unconditional. This introduces a new hidden MSI feature, which is disabled for installation: gm_SharePointSupport_SubstMSO. When installed, it registers SharePoint.OpenDocuments class in registry, thus overriding registration of this component by MS Office, allowing LibreOffice to serve as MS Office replacement working in IE with SharePoint. To install the feature, either a transform is needed setting the feature's level <= 100, or a command line: msiexec path-to-msi ADDLOCAL=gm_SharePointSupport_SubstMSO Change-Id: I5517bbb68dcc6db8bcb2bbc2368394ee4a62d741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86452 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-02Bump copyright year to 2020Adolfo Jayme Barrientos
Change-Id: I6fb736591f32907c8977fbac8fbf1dcbaef1bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86092 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-26loplugin:consttobool (clang-cl)Stephan Bergmann
Change-Id: I81fea38cd737a8be74e6ece333ca37cc434a1c33 Reviewed-on: https://gerrit.libreoffice.org/83765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19loplugin:fakebool (clang-cl)Stephan Bergmann
...plus follow-up loplugin:implicitboolconversion and loplugin:redundantcast Change-Id: I9fc9c5cb46fbb50da87ff80af64cb0dfda3e5f90 Reviewed-on: https://gerrit.libreoffice.org/83207 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-11simplify "a = a +" to "a +="Noel Grandin
mostly so that my stringadd loplugin can point out places to improve Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5 Reviewed-on: https://gerrit.libreoffice.org/80618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06Fixing "...."Andrea Gelmini
Change-Id: I3424e17cfdfb563fdc5882942031deafae8689fe Reviewed-on: https://gerrit.libreoffice.org/78678 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29setup_native: document more obscure epmfile.pm inputMichael Stahl
Change-Id: I26ca5b61acef2474980f5e916e10bca3a18ceea3 Reviewed-on: https://gerrit.libreoffice.org/76557 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-10fix HRESULT_FROM_WIN32 can not be placed inside switch for SDK8.1nd101
For Windows SDK 8.1 HRESULT_FROM_WIN32 is defined as an inline function without the constexpr, which is required for case statement inside a switch. Change-Id: Ibb195ef900926d87ff04f82a6d73112b8858f633 Reviewed-on: https://gerrit.libreoffice.org/75111 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2019-05-07tdf#119044 setup_native: let -core depend on -ooofontsMichael Stahl
Things break without OpenSymbol font. On the other hand, if you install just the fonts, but not anything else, you can happily use the fonts in other applications. So just invert the dependency. Change-Id: I4c2dbff59699365cba67d3b1c6ade5ec7c2462bf Reviewed-on: https://gerrit.libreoffice.org/71898 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-22tdf#124794: Wait for WU service stopped before launching wusa.exeMike Kaganski
It seems that wusa.exe would fail with error code 0x80080005 if launched too soon after WU service was sent a stop control (which was added in tdf#123832). Change-Id: I470a8a8e933e8a0cd6208c095ed63c1761b3b434 Reviewed-on: https://gerrit.libreoffice.org/71045 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-05Replace legacy dynamically-loaded functions with statically linked onesMike Kaganski
We don't need the dynamic load complexity for these now with baseline Windows version being Windows 7 SP1. Stuff used only for compatibility with older versions was dumped. Change-Id: I810f271796cfd875cfa18a3081c9ad444fe57b3e Reviewed-on: https://gerrit.libreoffice.org/70321 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04Drop UNICODE/_UNICODE definesMike Kaganski
The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-22tdf#123832: Try to prevent/control hung wusa.exe while installing UCRTMike Kaganski
Reportedly under some circumstances execution of wusa.exe may hang for very long time (available logs show more than 90 min). LO MSI installer waits for wusa.exe indefinitely in its deferred inst_msu custom action; during this wait, one can't abort the installation. There is an evidence [1] that stopping WU service prior to wusa launch might prevent this hang. The patch does two things: 1. It stops running WU service prior to wusa launch. 2. It adds a check for user input by executing MsiProcessMessage twice a second, and checking its return value, to allow early return in case user cancels the installation. This is a blind shot, since I cannot reproduce the problem myself. [1] https://superuser.com/questions/1044528/ Change-Id: I8bf4ce52b3e9d98a4f90af3abcc49ac63b6a0e40 Reviewed-on: https://gerrit.libreoffice.org/69487 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-05-19 07:18:12 +0000