summaryrefslogtreecommitdiff
path: root/sfx2/source/control/statcach.cxx
AgeCommit message (Collapse)Author
2019-02-07loplugin:flatten in sfx2Noel Grandin
Change-Id: If4e07d497ead58a2ff58b5fdedd282b8784be421 Reviewed-on: https://gerrit.libreoffice.org/67435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in sfx2..svtoolsNoel Grandin
Change-Id: I1e92472b4aaeca1eb1372bd18d10cc9e0766dc39 Reviewed-on: https://gerrit.libreoffice.org/62251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16loplugin:singlevalfields in sfx2Noel Grandin
pParent in SfxDispatch_Impl was always nullptr, which led to a bunch of dead code similarly with pParent in SfxWorkWindow Change-Id: I964a43fe094409ab4b6d1eda7225af997092e81c Reviewed-on: https://gerrit.libreoffice.org/61811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05loplugin:useuniqueptr in sfx2Noel Grandin
Change-Id: I7b406cd07cae579de608faa3ec47dd1190dea411 Reviewed-on: https://gerrit.libreoffice.org/60003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-02-08tdf#115430 BindDispatch_Impl needs a disposal methodMaxim Monastirsky
The dtor will never be called otherwise, because the dispatcher is holding a reference to us, so removeStatusListener is needed first. Regression of a5dbe5a8a9e98f2d79f2c535182fc557b561ed0f ("use rtl::Reference in svl,sfx2") Change-Id: I52da6152f0ddb0030d7354f7201e969d5a1f11cf Reviewed-on: https://gerrit.libreoffice.org/49423 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-10-23loplugin:includeform: sfx2Stephan Bergmann
Change-Id: I5e9a7a2580a710880023288f5ed3584708c4769d
2017-10-06use rtl::Reference in svl,sfx2Noel Grandin
instead of manual ref-counting Change-Id: Icb6472ffadfb57c9723b26f6f247e78fff45e528 Reviewed-on: https://gerrit.libreoffice.org/43193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: sfx2Stephan Bergmann
Change-Id: If08aeb785b6ccffe477ddacc314f2182f6746648
2017-06-12cleanup unused css/frame/* includesJochen Nitschke
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2016-06-08tdf#99815 use XNotifyingDispatch in sfx2Juergen Funk
- move DispatchHelper somewhere public - use it from generic dispatcher call sites in sfx2 - return result of dispatcher calls (conveyed via XDispatchResultListener) to calling code, instead of faking it Change-Id: Ie8041133e99dd99e45819f98798829b96532b9e6 Reviewed-on: https://gerrit.libreoffice.org/24953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I3cb9226ef6bebb5062abfae312dce95f0ef74385
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I18ebddef41955948fd4528ae74f4fe9c7439d53b
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I7213b49b09ddcb00841aa5f63343baeab0e65fa4
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: Id9e7621ca7170d6cc80d8ce14f155ce564691ec0
2015-10-29com::sun::star->css in sfx2Noel Grandin
Change-Id: I20d9b45e4b28c2a4a511774d3154aceb0471d197 Reviewed-on: https://gerrit.libreoffice.org/19643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-14remove default value from SfxPoolItem::PutValueNoel Grandin
more useful to make it explicit. Specifically, otherwise my defaultvalue clang plugin would want to remove lots of places that contains #define constants which, while technically the same as the default value, convey semantic information which is quite useful. Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Idc749cf79afe1f6612f5f44a9c44aae853f78275
2015-03-19loplugin:constantfunction: sfx2Noel Grandin
Change-Id: I7b4c18b1f9644048f506fc1b1d1fb8c8c590ea7f
2014-12-23fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5 Reviewed-on: https://gerrit.libreoffice.org/13608 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02loplugin: cstylecastNoel Grandin
Change-Id: I4a230f45e91773fca7d537e91c9e9fb54773cf10
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULTStephan Bergmann
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-06-27remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-06Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part3Julien Nabet
Change-Id: Ibabd6d2d5e84fe007364bd1a4182a01ea2352b7a
2014-05-05Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part2Julien Nabet
Change-Id: Ibca921eff3647507ffb7e9011a84aeefbec58d7a
2014-04-07sfx2: sal_Bool->boolNoel Grandin
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-03-25Remove legacy DBG_PROFSART/STOP callsStephan Bergmann
...probably better done with callgrind, if still relevant at all. Change-Id: I15069df4e2f271b0c240231f35af2e664a02c296
2014-03-14sfx2: sal_Bool->boolNoel Grandin
Change-Id: I56a50ee4a169c8f82c830ebf498f7ead1335f0b5
2014-03-03SFX2 : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: I35a9403da152ea2b637c0235d776c7789e2ef207 Reviewed-on: https://gerrit.libreoffice.org/8420 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from sfx2Alexander Wilms
Change-Id: I0f556a386ce64d154b695c2a35f808c94b9f0b7a Reviewed-on: https://gerrit.libreoffice.org/8310 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-01-15remove sfx2/appuno.hxxMatúš Kukan
Change-Id: Ibfcd2954b20def05d2a7db36f5ccc0b570305441
2013-07-23convert sfx2 UNO services to WeakImplHelperNoel Grandin
...removing the SFX_ UNO-related macros as a result. Change-Id: I56542885847ff0adc604f309ed7e2582b7529f3f
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-25Bin a fairly useless OSL_TRACETor Lillqvist
Change-Id: Iab2500d60869ff7cad97601b7af72f76972ccc53
2013-02-14Removed several useless macros: UNISTRING, USTR, USTR_ASCII, ASCII_STR, ↵Jean-Noël Rouvignac
ASCII_STRING, CONST_ASCII, ASCSTR, ASCII, DEFINE_CONST_UNICODE, DEFINE_CONST_OUSTRING Change-Id: I96d690bf9f9b319e9eeafcf218ec5ce87f21215f Reviewed-on: https://gerrit.libreoffice.org/1954 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2012-07-06re-base on ALv2 code. Includes:Michael Meeks
Patches contributed by Mathias Bauer: cws mba34issues01: #i117713#: remove superfluous assertions about field unit fallbacks http://svn.apache.org/viewvc?view=revision&revision=1172341 cws mba34issues01: #i117718#: provide filter name in case storage of medium does not allow to detect one cws mba34issues01: #i117712#: fix several resource errors introduced by IAccessible2 implementation http://svn.apache.org/viewvc?view=revision&revision=1172343 http://svn.apache.org/viewvc?view=revision&revision=1172350 cws mba34issues01: #i117708#: status indicator for inactive documents http://svn.apache.org/viewvc?view=revision&revision=1172358 cws mba34issues01: #i116025#: fix typo and add missing treatment of new parameter http://svn.apache.org/viewvc?view=revision&revision=1172359 cws mba34issues01: #i117024#: rework parameter conversion for load/save slots http://svn.apache.org/viewvc?view=revision&revision=1172360 cws mba34issues01: #i116803#: possible crash on Linux when dispatch.cxx is compiled with optimization http://svn.apache.org/viewvc?view=revision&revision=1172367 cws mba34issues01: #i114600#: fix compiler warning for name clash found on Solaris http://svn.apache.org/viewvc?view=revision&revision=1172371
2012-01-10Remove cruft in debug toolsMarcel Metz
2011-11-27remove include of pch header from sfx2Norbert Thiebaud