Age | Commit message (Collapse) | Author |
|
This is now handled in Dialog::dispose
Change-Id: If6703dbf1fa02c3d83debcc17eba3c6b1ee49a1c
Reviewed-on: https://gerrit.libreoffice.org/48622
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit cc9ca93c52e40557ed918868e235d393f9ecde6e)
Reviewed-on: https://gerrit.libreoffice.org/57507
|
|
Apparently AppendInfoBar ends up calling back into SID_SIGNATURE
status function at some point, creating an endless recursion. I'm
too lazy to debug why so I'm cowardly avoiding it
Change-Id: Ib1e4b7f12fea197887b099e9a9f03b4e58884ec1
Reviewed-on: https://gerrit.libreoffice.org/53519
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 43459bac67363f49aadd851e686d4a74b8ddc256)
Reviewed-on: https://gerrit.libreoffice.org/53648
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 8853067a29e091a230a6397bd7c100494ae9f5bf)
|
|
by reloading current lines before adding a brand new one
indeed the info are deleted by ClearCustomProperties
each time SfxDocumentInfoItem destructor is called
Change-Id: Id1e2e652e90c720f00b8612aa9afbfa91b784d1d
Reviewed-on: https://gerrit.libreoffice.org/50070
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-on: https://gerrit.libreoffice.org/51297
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 5d3313c832862b545cf6ec35c2b6c5fc08d8213c)
|
|
(regression from 41af2a9e26f3ee6b505b343120d5df3617ba5c49)
(cherry picked from commit fd67ee14e769ebdf1e43d55e0117f70f90d53053)
Change-Id: I47377447dd1e04a44033dea27ce7307a65821737
Reviewed-on: https://gerrit.libreoffice.org/51244
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 21f220fce05bb99964f098247786eec014e56902)
|
|
Change-Id: I6f03b4212a3434cb5feae8da29107c5f411218e3
Reviewed-on: https://gerrit.libreoffice.org/50759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit af269d967be348b813ea6d9e5e92a95886143622)
|
|
This change makes sure that only if the shadow size edit box' text
is changed, it is converted to the size in twips. It sets wrapper's
default value on each SetControlValue, to return proper initial
size when the size text wasn't modified.
Also both ExampleSet and OutSet in SfxTabDialog's Reset handler are
processed to set relevant items back to initial value; otherwise,
as the restored item (marked as unchanged) will be absent in tab's
result set, it would not modify the old items in the two, and they
would keep previous modified values.
Change-Id: Ie4362811968c6e6cbe0f9229bd3c9b29462f5704
Reviewed-on: https://gerrit.libreoffice.org/50196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit b37a46fdf91dbc66f6ddc1c070aec70716d94a01)
|
|
Change-Id: Iaa587f1a2d78f14b999f2e9e866db058d466493f
Reviewed-on: https://gerrit.libreoffice.org/50137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 06f04bf84d48d6542d9b47d1e16228923de61302)
|
|
... as they are treated by generic code just fine.
A check added to guard against overflow (0xFFFF + 1 -> 0).
Change-Id: Ibef85191eab82002981e12f83f313f3d122da74c
Reviewed-on: https://gerrit.libreoffice.org/50163
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit d4b4f5f1f4e452cb9f4a0e202b57c0a8610c1cad)
|
|
GetSizePixel triggers pending resize handler and gives more correct
sizes than GetOptimalSize(). Some of the dialog with inconsistencies in
sizes like EditStyle, Manage Changes, etc. are fixed with this patch.
Change-Id: I0661b7d2e98233edf0cd2c9c525b271d0724da08
(cherry picked from commit 668deca97d8dd049bb17b6d8b73c4ea73f7b8b9c)
|
|
Reviewed-on: https://gerrit.libreoffice.org/47772
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit 072e3ce1cfea5bb61cc5f3001c288df6deb45613)
Change-Id: I05b270a19e29c5ed3a2482fd8163e61e66bfdf74
|
|
Reviewed-on: https://gerrit.libreoffice.org/48091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 73c0abb8e001e3f48bbd0d04f11482972fe82fe4)
Change-Id: I69e3f2145f95424e7c524127492fd7f8a03ed3ca
|
|
Includes also lots of infrastructural changes, making the
conversion of the rest of the dialogs much easier.
StartExecuteAsync should be used in-place of StartExecuteModal
and the latter removed from the code-base incrementally. More
common code from Dialog::Execute should be moved to
ImplStartExecuteModal in a next step, as this is used more widely.
Reviewed-on: https://gerrit.libreoffice.org/47722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit c40dfabd56ade10fe35690dc9810955c2e99e2c0)
Change-Id: Idb2c1ec790e38f582438471a0419a56cdcf1439d
|
|
Change-Id: I120a49f8a3fa96eb93d6de6de1d0715134520678
(cherry picked from commit c24bfdbff68f52d65ca56cc4ff7d8377898180d7)
(cherry picked from commit 10e73684468a811acae56dfeafc8ecb5876a7960)
|
|
Some dialogs load the UI before we "Execute()" the dialog, or before the
dialog fires the InitShow event. In those cases, the title event has
already been fired and won't be fired after dialog is created.
Make sure that we send the title for such dialogs.
Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4
(cherry picked from commit 10a88598a4233f2b24548571644a83dc9d20e15d)
(cherry picked from commit 49a58e6e735a90532720f74c8d255056cd018a1a)
|
|
Change-Id: I88bea3dc1ae938d31462e85ca1a8f48dd13e8e89
(cherry picked from commit 76de866e162502518acbc0ab020c257b80946c2d)
|
|
Change-Id: Ifd8c721b001b09ddab8d4fe06ae6818980d6ee76
(cherry picked from commit 7bcb9a8416d61bdd3c7fc345f87de5aa8c3054f9)
|
|
In GTV, use correct application window object to fetch the dialog
object.
Use correct view shell to notify window (dialogs, etc.) callbacks.
Change-Id: I7d82b39d4522a4b4904e156757a032c342c71efb
(cherry picked from commit 727c2303cb70a62a35f2e7ff7cd47cdb3ccd556d)
|
|
Merge the dialog floating window callbacks and function calls into one.
Unique window ids across vcl::Window is enough to distinguish between
them.
Floating windows don't have a LOK notifier as they are created in the
vcl itself (so we can't access them from sfx2). Use the parent LOK
notifier in that case (which would be a dialog).
This API should also help in autopopup filter tunneling later.
(cherry picked from commit b5e27fd809845577a90cc1811de062c070110078)
Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
|
|
This allows registering & de-registering of non-sfx windows too, and makes the
Calc autofilter popup to appear.
Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
(cherry picked from commit d516c5c9819dcd7dc6dded2f8f9d9e44061b23c0)
|
|
Tested with .uno:FormatCellDialog in Calc, Impress not tested.
Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
(cherry picked from commit e2ae221f6164ba240da7d6470fd52c1982fa07d2)
|
|
Change-Id: Id48957a8c2bde068f30bb26e66df81972fe38e0f
(cherry picked from commit 5de24bea47e7ae971a53b51ee7d1b85d134bbe52)
|
|
We need to tunnel more than just dialogs, so this is the 1st step to get the
Autofilter popup rendered.
Change-Id: I6523a39ddc7a6eb2a204e48ab364130a5822f548
(cherry picked from commit ba8154d857aa815ba3c5b52987dc17be6eba7f48)
|
|
Change-Id: I8ec0ad81abcf1adf628906b02f7f94ab74a550b5
(cherry picked from commit f2b6bffdedb12983d4ca2bab21fb68eeb3c3d08d)
|
|
Change-Id: Ie81f8bd19696e6f0abceb86369545766918ae46a
(cherry picked from commit 90e0b60b6e68f7fb4b721f239809512258c33f74)
|
|
Change-Id: I49f5e0d5f6c7c0077a6d4390f8788c1691d47bd6
(cherry picked from commit e8c7420cc49238a88a66b6514c72e63df56d430a)
|
|
Split IDialogNotifier from IDialogRenderable and make SfxViewShell
implement it.
We now just send the dialog UNO command to the backend and wait for core
to emit a 'created' dialog callback which signals dialog creation in the
backend. The client is then supposed to send the paint commands for
rendering the dialog.
Change-Id: I1bfbce83c17955fa0212408376d6bcd1b2d2d1dd
(cherry picked from commit 871eb68e14631d22aeb00ec33f0e5d801291942e)
|
|
Change-Id: Iee4cd859cdc52a2272f5b01c3e4a57336cc336a4
Reviewed-on: https://gerrit.libreoffice.org/50891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
There's one rather common failure mode with gpg, in that untrusted
keys are not accepted by gpgme for encryption.
A user can override that with --trust-model config or cmd line
params, but we can't do much from the gpgme client side:
https://www.gnupg.org/documentation/manuals/gnupg/GPG-Configuration-Options.html
Change-Id: Ia140a7fd25bd3f428aa11a7ceb0b7bdc47b2c900
Reviewed-on: https://gerrit.libreoffice.org/46060
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit d46dc8e547810208287aab77f0313f1971901464)
Reviewed-on: https://gerrit.libreoffice.org/46084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
And pass down all necessary parameters everywhere
Change-Id: I152b9d84c0e35be9e5193a9a6f67de9fb86133b0
|
|
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I96d2ffb903f9ed15070572552c9564b5089df12f
Reviewed-on: https://gerrit.libreoffice.org/44914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
This commit solves problems with big number of entries.
Window is loaded quickly and is responsive even with
over a thousand custom properties.
Change-Id: I4745c69aaff95661ca930e303ab65591e374a24d
Reviewed-on: https://gerrit.libreoffice.org/44429
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: I8279f7ae14301f485c2678271939fb6ad72d4721
Reviewed-on: https://gerrit.libreoffice.org/44350
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
This reverts commit 62896fb7a5983eb13ee87b94ae803e6552626d8d.
The usage of iterators in CreateEmptyClassRememberPos
operator() is bogus and causes:
Error: attempt to dereference a singular iterator.
|
|
Change-Id: Ic5170843d8f47f92c7975cceaa9c33d278445b98
Reviewed-on: https://gerrit.libreoffice.org/43378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Id52809401fb848d7169a665903e67ba28f4af598
Reviewed-on: https://gerrit.libreoffice.org/44084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Insert constructor everywhere, except a couple places that apparently
want to compare GetMapUnit().
Change-Id: I1910deb60562e5e949203435e827057f70a3f988
|
|
Change-Id: I5e9a7a2580a710880023288f5ed3584708c4769d
|
|
no need to explicitly specify it anymore
Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
as in interim measure for SfxTabDialogs we throw
away the TabPage if its not suitable for reuse
Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842
Reviewed-on: https://gerrit.libreoffice.org/43134
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I753f655c11883e5bf705a2361a6d4d5e55ea88c9
Reviewed-on: https://gerrit.libreoffice.org/43377
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
changed sfx2 module file, converted OUStringBuffer::append() with operator+
Change-Id: Ie85542358875324f9ddadffa01395aebccda9be9
Reviewed-on: https://gerrit.libreoffice.org/43357
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
SfxPoolItem has a copy constructor and its copy assignment
operator is deleted. Derived classes have a implicit defined
copy constructor too, if all members are copy constructible.
This patch removes default-able copy constructors and destructors
on such items.
Change-Id: I214dfc016f02617e39a69177aa2233573dfe5f28
Reviewed-on: https://gerrit.libreoffice.org/43039
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I344f5a9c7167abfde15dcd21c747819cc79b12b1
|
|
For now, just invalidate the whole dialog whenever any of the controls
in the dialog get invalidated.
Since during dialog painting, many such invalidations are triggered,
don't listen to them when we are painting.
Change-Id: Ia8fc12cf9469691d60e91ef770d687e5ff01a7ef
|
|
Were failing to show, with this warning:
Gdk-WARNING **: Tried to map a popup with a non-top most parent
Change-Id: Ib68b5fc9b3edb3d25a23b66397c13833a4d080ac
Reviewed-on: https://gerrit.libreoffice.org/42936
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
(regression from 8f04b172c5c78fa80c3692a729f0191425195869)
Change-Id: I111d12a622390afc02eb73a42b1d3c714f046bd2
|
|
Change-Id: I103f8d267b1f34f9e3d1fe03e395c8d444150204
Reviewed-on: https://gerrit.libreoffice.org/42772
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173
Reviewed-on: https://gerrit.libreoffice.org/42285
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|