summaryrefslogtreecommitdiff
path: root/sfx2/source/dialog
AgeCommit message (Collapse)Author
4 daysloplugin:redundantcastStephan Bergmann
Change-Id: I8c26a439679359553d387686d9a11718a106ef5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180181 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
5 daystdf#41775 copy the Start Center menubar to the default menubar on macOSPatrick Luby
The ShutdownIcon class on macOS handles the menubar for when there are no windows displayed. So copy the entire menubar's tree to a native menu and use that native menu as the default menubar. Note: not all menu items may crash without a C++ window so currently the Tools > Configure menu must force the Start Center window to reappear before displaying its dialog. Change-Id: I3190da0dffdd6c7181939aec71954e067689d081 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179980 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
7 daysITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
7 daystdf#146947 - UI: Ability to show/reveal characters being typed intoBalazs Varga
password prompt to decrypt a document. Add toggle buttons for showing and hiding password characters in password textbox entries. Change-Id: Iba69d303431c2f9f2c987c67fcbd3f36b42dc057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179889 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
8 daystdf#161412 - UI: fix warning in PDF password dialog didn't disappearBalazs Varga
Warning about "Only Basic Latin characters can be entered" should only be highlighted until we are entering non-ASCII characters into the password textbox. Change-Id: I87c26a3b0b1777e0e76fe12422027aa2f377ad35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179891 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-03jsdialog: enable style sidebarSzymon Kłos
- disable not supported previews field, action menu for now Change-Id: Ife94ee96dd15bd92752ff6e9cc5e68243aac0851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175646 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179625 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins
2024-12-21crash reporting: use SfxRequest to get parent for dialogsCaolán McNamara
0: return pWindow ? pWindow->GetFrameWeld() : nullptr; 2: SfxNewFileDialog aNewFileDlg(GetView()->GetFrameWeld(), SfxNewFileDialogMode::LoadTemplate); Reproducible by adding "LoadStyles" to the menu in writer, then print preview and then use that "LoadStyles" entry. Also dispatch "SID_TEMPLATE_LOAD", as used by "Load Styles from Template" entry in the dropdown from the "Styles Action" toolbar of the style panel, with an explicit frame it is associated with. Change-Id: I3d536b897fbf6be9e20e4238e6a761df56ac9701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179084 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-13Replace workaround of resize to invalidate with an explicit SfxHintCaolán McNamara
Change-Id: Ic0c8ba5e5f65f7b1e472a667b69e737f4f1d9fbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178389 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-11jsdialog: send message for weld::MenuSzymon Kłos
- we need to setup correct notifier - enable context menu in the style sidebar in Writer - handle menu actions - base of vcl::Window and PopupMenu is VclReferenceBase - prepare template function sendMessage to handle both Change-Id: I54c8dc468856c0f98495bdaf4ddd504c2f56562f Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178319 Tested-by: Jenkins
2024-12-11tdf#62845: Introduce an application-wide viewer modeMike Kaganski
Using the new 'ViewerAppMode' expert setting, the UI should disable all the edit controls; all options to create new content (including new documents); i.e., work as a view-only application. This change: 1. Introduces the setting. 2. Checks it in SfxMedium::IsReadOnly, making sure that all documents always have read-only medium. 3. Checks it in SfxFrameLoader_Impl::load, to prevent creation of new documents. 4. Checks it in SfxObjectShell::isEditDocLocked, to prevent entering edit mode. 5. Checks it in BackingWindow::checkInstalledModules, to hide buttons that create new documents. 6. Checks it in SfxViewFrame methods, to avoid showing "readonly" and "macros" infobars. Change-Id: Iaeeb8aab16db83ebdf500fd2bca8b8a9ac2180ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177903 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-09tdf#61358 - Remember the last "insert as link" stateAndreas Heinisch
Change-Id: I3fe88411092df159fa6dc39a8fb9eb3ab36eeb70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158254 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-12-07weld: Rename weld::Treeview selection signal/connectMichael Weghorn
Rename weld::TreeView member + methods to clarify that these are about selection changes: * m_aChangeHdl to m_aSelectionChangedHdl, * signal_changed to signal_selection_changed * connect_changed to connect_selection_changed In GtkInstanceTreeview, also rename the related methods calling signal_selection_changed accordingly for consistency. Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-23Use specific SvtModuleOptions::Is*Installed for clarityMike Kaganski
Change-Id: Ibe64b9fcccf33471d96bb0fb1aa896cb456657f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177069 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-22loplugin:unusedfieldsNoel Grandin
Change-Id: I9ee946ceabf59e4126db938d6abda446fcf9ce36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176994 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12loplugin:reftotemp in sfx2Noel Grandin
Change-Id: I0ec28fe2c0737b71ff18c4efbc99c896339f5062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in sfx2Noel Grandin
Change-Id: If818f7b10eb81f8921b5d90fe0c2db4d4ad97ed6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-06cid#1556442 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607753 COPY_INSTEAD_OF_MOVE cid#1554790 COPY_INSTEAD_OF_MOVE cid#1556463 COPY_INSTEAD_OF_MOVE cid#1554838 COPY_INSTEAD_OF_MOVE cid#1556231 COPY_INSTEAD_OF_MOVE cid#1556878 COPY_INSTEAD_OF_MOVE cid#1554913 COPY_INSTEAD_OF_MOVE cid#1558064 COPY_INSTEAD_OF_MOVE cid#1557043 COPY_INSTEAD_OF_MOVE cid#1556985 COPY_INSTEAD_OF_MOVE cid#1556766 COPY_INSTEAD_OF_MOVE cid#1557351 COPY_INSTEAD_OF_MOVE cid#1554863 COPY_INSTEAD_OF_MOVE cid#1556764 COPY_INSTEAD_OF_MOVE cid#1556279 COPY_INSTEAD_OF_MOVE cid#1555970 COPY_INSTEAD_OF_MOVE cid#1556942 COPY_INSTEAD_OF_MOVE cid#1557964 COPY_INSTEAD_OF_MOVE cid#1555166 COPY_INSTEAD_OF_MOVE cid#1556496 COPY_INSTEAD_OF_MOVE cid#1557175 COPY_INSTEAD_OF_MOVE cid#1558054 COPY_INSTEAD_OF_MOVE cid#1557392 COPY_INSTEAD_OF_MOVE cid#1557850 COPY_INSTEAD_OF_MOVE cid#1555118 COPY_INSTEAD_OF_MOVE cid#1557131 COPY_INSTEAD_OF_MOVE cid#1556614 COPY_INSTEAD_OF_MOVE cid#1609650 COPY_INSTEAD_OF_MOVE cid#1555114 COPY_INSTEAD_OF_MOVE cid#1555241 COPY_INSTEAD_OF_MOVE cid#1555442 COPY_INSTEAD_OF_MOVE cid#1556473 COPY_INSTEAD_OF_MOVE cid#1557654 COPY_INSTEAD_OF_MOVE cid#1554689 COPY_INSTEAD_OF_MOVE cid#1556316 COPY_INSTEAD_OF_MOVE cid#1557929 COPY_INSTEAD_OF_MOVE cid#1554807 COPY_INSTEAD_OF_MOVE cid#1554858 COPY_INSTEAD_OF_MOVE cid#1555103 COPY_INSTEAD_OF_MOVE cid#1555517 COPY_INSTEAD_OF_MOVE cid#1556424 COPY_INSTEAD_OF_MOVE cid#1557252 COPY_INSTEAD_OF_MOVE cid#1557566 COPY_INSTEAD_OF_MOVE cid#1608020 COPY_INSTEAD_OF_MOVE cid#1557742 COPY_INSTEAD_OF_MOVE cid#1555884 COPY_INSTEAD_OF_MOVE cid#1554809 COPY_INSTEAD_OF_MOVE cid#1555336 COPY_INSTEAD_OF_MOVE cid#1555173 COPY_INSTEAD_OF_MOVE cid#1556067 COPY_INSTEAD_OF_MOVE cid#1557040 COPY_INSTEAD_OF_MOVE cid#1556235 COPY_INSTEAD_OF_MOVE cid#1557366 COPY_INSTEAD_OF_MOVE cid#1555910 COPY_INSTEAD_OF_MOVE cid#1556716 COPY_INSTEAD_OF_MOVE cid#1558022 COPY_INSTEAD_OF_MOVE cid#1555769 COPY_INSTEAD_OF_MOVE cid#1555940 COPY_INSTEAD_OF_MOVE cid#1557077 COPY_INSTEAD_OF_MOVE cid#1555270 COPY_INSTEAD_OF_MOVE cid#1555660 COPY_INSTEAD_OF_MOVE cid#1556302 COPY_INSTEAD_OF_MOVE cid#1555678 COPY_INSTEAD_OF_MOVE cid#1556538 COPY_INSTEAD_OF_MOVE cid#1557689 COPY_INSTEAD_OF_MOVE cid#1555009 COPY_INSTEAD_OF_MOVE cid#1555433 COPY_INSTEAD_OF_MOVE cid#1555671 COPY_INSTEAD_OF_MOVE cid#1555255 COPY_INSTEAD_OF_MOVE cid#1557681 COPY_INSTEAD_OF_MOVE cid#1557512 COPY_INSTEAD_OF_MOVE cid#1554958 COPY_INSTEAD_OF_MOVE cid#1555758 COPY_INSTEAD_OF_MOVE cid#1555597 COPY_INSTEAD_OF_MOVE cid#1558040 COPY_INSTEAD_OF_MOVE cid#1556476 COPY_INSTEAD_OF_MOVE cid#1557646 COPY_INSTEAD_OF_MOVE cid#1557950 COPY_INSTEAD_OF_MOVE cid#1557019 COPY_INSTEAD_OF_MOVE cid#1557885 COPY_INSTEAD_OF_MOVE cid#1556402 COPY_INSTEAD_OF_MOVE cid#1557906 COPY_INSTEAD_OF_MOVE cid#1556619 COPY_INSTEAD_OF_MOVE cid#1554683 COPY_INSTEAD_OF_MOVE cid#1556549 COPY_INSTEAD_OF_MOVE cid#1554747 COPY_INSTEAD_OF_MOVE cid#1554929 COPY_INSTEAD_OF_MOVE cid#1555362 COPY_INSTEAD_OF_MOVE cid#1557053 COPY_INSTEAD_OF_MOVE cid#1557891 COPY_INSTEAD_OF_MOVE cid#1555043 COPY_INSTEAD_OF_MOVE cid#1555107 COPY_INSTEAD_OF_MOVE cid#1557203 COPY_INSTEAD_OF_MOVE cid#1556728 COPY_INSTEAD_OF_MOVE cid#1557773 COPY_INSTEAD_OF_MOVE cid#1556845 COPY_INSTEAD_OF_MOVE Change-Id: I001fb67e597b096e992fd8a0cd6f3ec577767c33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176098 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-25speedup saving large XLS file with lots of query formula(2)Noel Grandin
reduce cost of OUString construction by avoiding initialising a temporary and then overwriting it. 12s to 10s Change-Id: I889152ba71947004ca7d5c96f073182c94d95ed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175539 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-21cid#1633189 silence Unchecked return valueCaolán McNamara
and cid#1633190 Unchecked return value cid#1633191 Unchecked return value Change-Id: I4589ed1fe48067f493a1db04a468b7a8ed6ae178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21a little more natural to unconditional iterate after useCaolán McNamara
Change-Id: Iac0adfdc9344b5c25736dbec151bae20d14b20fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175119 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-20tdf#163486: PVS: identical sub-expressionsXisco Fauli
Since commit 0deea02b1da1001fa497dc5afa5e43207af491d5 Author: Sarper Akdemir <sarper.akdemir.extern@allotropia.de> Date: Sat Aug 19 17:18:50 2023 +0300 tdf#138792: PDF export: add batch of dublin core attributes V501 There are identical sub-expressions 'bKeywordsMod' to the left and to the right of the '||' operator. V501 There are identical sub-expressions 'bThemeMod' to the left and to the right of the '||' operator. V501 There are identical sub-expressions 'bTitleMod' to the left and to the right of the '||' operator. Change-Id: I438e0284a190241bf86b0e127de2f12f4a1a68b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-19tdf#163486: PVS: Numeric Truncation Error. Return value of the 'size' ↵Mike Kaganski
function is written to the 16-bit variable. Change-Id: Id912987800b9d5794fb1ab81a108163c4750d409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175213 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-16tdf#100894 speed up style tree creationNoel Grandin
by using bulk_insert_for_each() more aggressively. Reduces the open time from several minutes to 18s on my machine. I had to pass down a flag, because the gtk and the gen weld backends work differently, and the gen backend absolutely has to know up front if the inserter function is going to call set_text, otherwise it asserts in SvTreeListBox::SetEntryText Change-Id: I84750888c0a80f4041cfe024e6570dd94f6d09db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-17sfx2: Synchronously set control state in file picker on all platformsMichael Weghorn
Unify the handling to initialize the control state in `FileDialogHelper_Impl::preExecute` and set the state of the controls synchronously (right away) for all platforms. This was already done for Windows and macOS, but not for Linux, where this was delayed by doing so asynchronously in a user event. The asynchronous way of doing it was introduced in commit e1d6dc26677c9ef24360cd3b2b40acfc7dee13a0 Author: Frank Schönheit <fs@openoffice.org> Date: Tue Oct 30 13:12:46 2001 +0000 #93977# do an asynchronous InitControls and the the comment gives this reason: // allow for dialog implementations which need to be executed before they return valid values for // current filter and such However, this doesn't work everyhwere, so this was already switched back to being synchronous for macOS in commit 420c7215ad52ce0a2fc652c9b537af20c80e86f0 Author: Kurt Zenker <kz@openoffice.org> Date: Wed Mar 5 15:44:58 2008 +0000 INTEGRATION: CWS aquafilepicker02_DEV300 (1.134.22); FILE MERGED 2008/02/11 17:38:41 fheckl 1.134.22.2: RESYNC: (1.134-1.138); FILE MERGED 2008/01/14 08:40:47 fheckl 1.134.22.1: Allowing for corrrect fpicker init on MacOSX and for Windows in commit 9ebe7641b7f5f5ceebbe0b2dad73e8bb73997967 Author: Oliver Bolte <obo@openoffice.org> Date: Fri May 30 10:34:06 2008 +0000 INTEGRATION: CWS hro35_DEV300 (1.142.32); FILE MERGED 2008/05/26 09:16:01 hro 1.142.32.1: #87244# Dialog initialization sequence has to be done synchronous for modal Vista dialog . The asnyc way also doesn't work for the Qt-based VCL plugins as mentioned in Change-Id: I9edf65a31f8268feb13fd6abf627744d68fd79e3 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Sep 16 14:06:39 2024 +0200 qt: Add "Sign with default certificate" to QtFilePicker : > When no signing key is set there, the checkbox currently > isn't disabled as expected, but that's a separate issue, > also seen with the "Edit filter settings" checkbox that > is disabled with gtk3, but not with qt6 independent of this > commit. Unify to set the state synchronously everywhere again, which makes the Qt-based VCL plugins work, and also works as expected in my tests with the gen and gtk3 VCL plugins on Linux, even when locally disabling the `CommonFilePickerElementIds::LISTBOX_FILTER` handling in `FileDialogHelper_Impl::handleControlStateChanged` for testing. (That gets called for these implementations when the dialog shows and would otherwise take care of setting the proper state as well.) The gtk4 file dialog currently doesn't shown these checkboxes at all, independent of this commit. Since the first commit mentioned above only refers to an issue in the internal StarDivision bug tracker, it's not clear on what platform the synchronous handling was causing problems in the past, but it seems that the issue is gone by now. Change-Id: I4bbc7f8d03061f9858b2e355b6d1874a0b71adfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173456 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17Update "Sign with default" checkbox in FileDialogHelper_Impl::preExecuteMichael Weghorn
commit 426c641976688e3e4d1ce66f76b27ccbd2dca55a Date: Wed Jul 17 12:47:22 2024 +0200 tdf#159040: add sign with default certificate to save dialog added a call to `FileDialogHelper_Impl::updateSignByDefault` to `FileDialogHelper_Impl::InitControls` that gets asynchronously called for non-Windows and non-macOS, see `FileDialogHelper_Impl::preExecute`. Also explicitly call it for the Windows and macOS case, like all of the other methods that also get called there in that code path. This makes the "Sign with default certificate" checkbox disabled when no GPG key is set up in "Tools" -> "Options" -> "User Data" -> "Signing Key" even if commenting the call to `FileDialogHelper_Impl::updateSignByDefault` in `FileDialogHelper_Impl::handleControlStateChanged` on Windows, i.e. the correct state of the checkbox no longer depends on an implicit filter change when the dialog gets started. This is mostly in preparation of using the same code path for the Qt-based VCL plugins on Linux, where no implicity filter changed signal happens and the "Sign with default certificate" and "Edit filter settings" checkboxes are currently always enabled after starting Writer and opening the "Save As" dialog. Change-Id: Ibc6c2a16dc04f0fe7e41317aeb98ea159e7aec8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173455 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17sfx2: Drop duplicate MACOSX checkMichael Weghorn
There since: commit e103887c8c158e7059a586ef5a5f7b234c547dfe Date: Fri Jan 11 11:07:23 2013 +0200 QUARTZ is equivalent to MACOSX Change-Id: I34d04913af45c529e01249a5f1a9c5f66b7260b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173454 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-16Resolves tdf#162927 - Hiding non-hierarchical styles should not just dim itHeiko Tietze
Also show hidden styles with normal font color if the view mode is not hierarchical Change-Id: I4cc5ca7441294302b3e751c5fa49a2f3579b3c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173334 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-09-12tdf#162405: check if there's a matching singing cert only when savingSarper Akdemir
previously Save as dialog's "Sign with default certificate" checkbox's senstivity was decided depending on if there was a matching key. Doing that forces a dialog pop-up for password protected NSS databases. Now if there's a value in "/org.openoffice.UserProfile/Data/signingkey", the checkbox is sensitive. Matching key is checked during save, and reported if it isn't found & signing failed. Change-Id: Ia714b70ce6456752200088cc5382ab6374af9587 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173129 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-09-09tdf#162732 force centered alignment for donate button textCaolán McNamara
bit of a bodge, gtk defaults to baseline alignment here, so force what we want instead in a separate "Donate" button. Change-Id: Iac7044c37f2e4c0e48b769c52612a3f5a2dfd350 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-05cool#9992 lok doc sign: add SfxObjectShell::AfterSignContent()Miklos Vajna
Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case to show the signatures dialog read-only, as only that is async. The first problem for the read-write signatures dialog is that SfxObjectShell::ExecFile_Impl() has code after invoking SfxObjectShell::SignDocumentContent(), which will be executed too early if the dialog is executed async. Fix the problem by moving the code in question into a new SfxObjectShell::AfterSignContent(), and only invoke that as a callback after the async run finished. The message dialog in the moved code is still non-async, but we can deal with that later. Change-Id: I32f0895118ac0da72105ec3a24c0294e18c05545 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172914 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-09-05Resolves tdf#160937 - Minimize document properties dialog sizeHeiko Tietze
* Scrolled view behind Description items * Width for preferred image resolution set to 5 chars Change-Id: Id29c0109a3dd2998bc5d09cfbed4a848cf2d3f19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172881 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-09-05Resolves tdf#162738 - Revert tdf#160937Heiko Tietze
This reverts commit 2164406a973fd40fcc56b8839a21854f6b50a53b. Reason for revert: Going to implement a scrolled window Change-Id: Icc7dc71860bfcafaea1323a3d0c6f7e1f7dd380f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172758 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-09-03use less dynamic_cast when broadcasting SfxHintNoel Grandin
Change-Id: I24c947c20afeffffebe5ac794108c4ccecb680f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-28cid#1607037 silence Overflowed constantCaolán McNamara
and cid#1606925 Overflowed constant cid#1606695 Overflowed constant Change-Id: I2162e9b5da1f31ea1dfc603d6e60b96d98f82be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172509 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-28Resolves tdf#162615 - Long label must not overside sidebar in start centerHeiko Tietze
Change-Id: Ia8205dd32ee7fd3f67ae2c3f6fec4366c2c4d4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172455 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-08-23-Werror=maybe-uninitialized in sfx2Julien Nabet
/home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx: In member function ‘void SfxSplitWindow::InsertWindow(SfxDockingWindow*, const Size&)’: /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:462:23: error: ‘nL’ may be used uninitialized [-Werror=maybe-uninitialized] 462 | nLine = static_cast<short>(nL); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:433:16: note: ‘nL’ was declared here 433 | sal_uInt16 nL; | ^~ /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx: In member function ‘void SfxSplitWindow::MoveWindow(SfxDockingWindow*, const Size&, sal_uInt16, sal_uInt16, bool)’: /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:552:21: error: ‘nL’ may be used uninitialized [-Werror=maybe-uninitialized] 552 | if ( nLine > nL && GetItemCount( GetItemId( nL ) ) == 1 ) | ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:548:16: note: ‘nL’ was declared here 548 | sal_uInt16 nL, nP; | ^~ Change-Id: I816ec49fe2c63e4f448ae83251d3a24b08383903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172306 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-08-16cid#1557618 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557535 COPY_INSTEAD_OF_MOVE cid#1557520 COPY_INSTEAD_OF_MOVE cid#1557513 COPY_INSTEAD_OF_MOVE cid#1557503 COPY_INSTEAD_OF_MOVE cid#1557487 COPY_INSTEAD_OF_MOVE cid#1557483 COPY_INSTEAD_OF_MOVE cid#1557479 COPY_INSTEAD_OF_MOVE cid#1557474 COPY_INSTEAD_OF_MOVE cid#1557461 COPY_INSTEAD_OF_MOVE cid#1557446 COPY_INSTEAD_OF_MOVE cid#1557445 COPY_INSTEAD_OF_MOVE cid#1557441 COPY_INSTEAD_OF_MOVE cid#1557435 COPY_INSTEAD_OF_MOVE cid#1557433 COPY_INSTEAD_OF_MOVE cid#1557429 COPY_INSTEAD_OF_MOVE cid#1557375 COPY_INSTEAD_OF_MOVE cid#1557372 COPY_INSTEAD_OF_MOVE cid#1557356 COPY_INSTEAD_OF_MOVE cid#1557350 COPY_INSTEAD_OF_MOVE cid#1557344 COPY_INSTEAD_OF_MOVE cid#1557339 COPY_INSTEAD_OF_MOVE cid#1557332 COPY_INSTEAD_OF_MOVE cid#1557330 COPY_INSTEAD_OF_MOVE cid#1557328 COPY_INSTEAD_OF_MOVE cid#1557323 COPY_INSTEAD_OF_MOVE cid#1557315 COPY_INSTEAD_OF_MOVE cid#1557313 COPY_INSTEAD_OF_MOVE cid#1557304 COPY_INSTEAD_OF_MOVE cid#1557297 COPY_INSTEAD_OF_MOVE cid#1557291 COPY_INSTEAD_OF_MOVE cid#1557290 COPY_INSTEAD_OF_MOVE cid#1557271 COPY_INSTEAD_OF_MOVE cid#1557266 COPY_INSTEAD_OF_MOVE cid#1557262 COPY_INSTEAD_OF_MOVE cid#1557259 COPY_INSTEAD_OF_MOVE cid#1557246 COPY_INSTEAD_OF_MOVE cid#1557242 COPY_INSTEAD_OF_MOVE cid#1557241 COPY_INSTEAD_OF_MOVE cid#1557236 COPY_INSTEAD_OF_MOVE cid#1557228 COPY_INSTEAD_OF_MOVE cid#1557225 COPY_INSTEAD_OF_MOVE cid#1557221 COPY_INSTEAD_OF_MOVE cid#1557217 COPY_INSTEAD_OF_MOVE cid#1557213 COPY_INSTEAD_OF_MOVE cid#1557211 COPY_INSTEAD_OF_MOVE cid#1557209 COPY_INSTEAD_OF_MOVE cid#1557205 COPY_INSTEAD_OF_MOVE cid#1557204 COPY_INSTEAD_OF_MOVE cid#1557193 COPY_INSTEAD_OF_MOVE cid#1556082 COPY_INSTEAD_OF_MOVE Change-Id: I07f195a79a69d4bac0d14317854efc88d6fe94d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-14use less exception throwing for flow controlNoel Grandin
Change-Id: Ib376a1bcb75e72d6e5754818a353b0d9c7dbd26d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-14cid#1557708 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557707 COPY_INSTEAD_OF_MOVE cid#1557706 COPY_INSTEAD_OF_MOVE cid#1557705 COPY_INSTEAD_OF_MOVE cid#1557704 COPY_INSTEAD_OF_MOVE Change-Id: I2346348d9d896e352db3471e8137c0eca8b21507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-14dubious to enable/disable help button based on IsContextHelpEnabledCaolán McNamara
in just the SingleTabController, which is a specific subset of all dialogs, the case of a dialog that hosts a page typically seen in a multi-table dialog. Why should such a dialog have no help, while its sibling containing the same page alongside others would have help, or vice-versa. Change-Id: I3f54c0088e30a396e83e990510ebe7f1f3bc7bda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-14cool#9699 - Don't show Help button when there is no helpHubert Figuière
The SfxSingleTabDialogController was explictely showing the Help button even if it was previously hidden by the VclBuilder due to lack of Help URL in Collabora Online This was the case in the spelling option dialog. See https://github.com/CollaboraOnline/online/issues/9699 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I4454f3d1f0c097faeebf912c3282335fed67ec84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171697 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171847 Tested-by: Jenkins
2024-08-06cid#1555415 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555430 COPY_INSTEAD_OF_MOVE cid#1555497 COPY_INSTEAD_OF_MOVE cid#1555542 COPY_INSTEAD_OF_MOVE cid#1555543 COPY_INSTEAD_OF_MOVE cid#1555564 COPY_INSTEAD_OF_MOVE cid#1555593 COPY_INSTEAD_OF_MOVE cid#1555602 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555693 COPY_INSTEAD_OF_MOVE cid#1555719 COPY_INSTEAD_OF_MOVE cid#1555757 COPY_INSTEAD_OF_MOVE cid#1555795 COPY_INSTEAD_OF_MOVE cid#1555826 COPY_INSTEAD_OF_MOVE cid#1555847 COPY_INSTEAD_OF_MOVE cid#1555851 COPY_INSTEAD_OF_MOVE cid#1555863 COPY_INSTEAD_OF_MOVE cid#1555865 COPY_INSTEAD_OF_MOVE cid#1555867 COPY_INSTEAD_OF_MOVE cid#1555869 COPY_INSTEAD_OF_MOVE cid#1555879 COPY_INSTEAD_OF_MOVE cid#1555890 COPY_INSTEAD_OF_MOVE cid#1555893 COPY_INSTEAD_OF_MOVE cid#1555900 COPY_INSTEAD_OF_MOVE cid#1555922 COPY_INSTEAD_OF_MOVE cid#1555925 COPY_INSTEAD_OF_MOVE Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-24tdf#159040: add sign with default certificate to save dialogSarper Akdemir
Include X.509 certificates under Tools->Options->UserData among the keys for signing. Add a new checkbox to Save file dialog, to sign with that selected key easily. The checkbox is disabled if there's no matching key found. Change-Id: I9fc16790c479819cd1f35bcad040d0ebc7c4bdef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170619 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-07-19make pop-up on Encrypt With GPG Key modalSarper Akdemir
Not setting any parent window for XDocumentDigitalSignatures causes the key selection window to be non-modal, letting the user keep editing the document without completing the encryption interaction. Change-Id: Ic7e66cb43606355beaffc720b7c23cdf4f81d934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170630 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-07-15tdf#121140: GPG checkbox only for file formats with GPGENCRYPTION flagMoritz Duge
Only ODF-1.2 and ODF 1.3 support GPG encryption. Flat ODF and other formats do NOT, so lets not offer an option that subsequent code path ignores. Change-Id: Ie43be433fbcaa56c76b25e12b58b084ea9bcfd6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168001 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-07-15Simplify boolean logic locally for mbIsPwdEnabled.Moritz Duge
Change-Id: I2b2611e51ce0fdffdd25a75b211ce06b5bfd6b43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167999 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-07-14cid#1555652 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555655 COPY_INSTEAD_OF_MOVE cid#1555658 COPY_INSTEAD_OF_MOVE cid#1555665 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555670 COPY_INSTEAD_OF_MOVE cid#1555675 COPY_INSTEAD_OF_MOVE cid#1555684 COPY_INSTEAD_OF_MOVE cid#1555687 COPY_INSTEAD_OF_MOVE cid#1556539 COPY_INSTEAD_OF_MOVE cid#1556542 COPY_INSTEAD_OF_MOVE cid#1557448 COPY_INSTEAD_OF_MOVE cid#1557449 COPY_INSTEAD_OF_MOVE Change-Id: I3567528e559bca0031c4f5b46801e3130073633b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-17 19:22:35 +0000