summaryrefslogtreecommitdiff
path: root/sfx2/source/doc
AgeCommit message (Collapse)Author
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-07loplugin:staticmethods: sfx2Stephan Bergmann
Change-Id: I64bd8564b335481a8cdfb053cc9563bea8ef47d3
2016-10-06tdf#101813 sw,sfx2: enable inserting master document as sectionMichael Stahl
Traditionally only ordinary com.sun.star.text.TextDocument could be inserted as a section but then commit 3da8f3680556e0163f660a0a159930337c8c32ff unintentionally enabled inserting everything, including master documents (com.sun.star.text.GlobalDocument). I'm really not sure if this should be allowed or not but apparently somebody finds it useful so here we add some crude hacks to enable it (to be reverted in case it causes trouble). (regression? from 805fd1ca343d6295b8114a24cc29bdac332f266d) Change-Id: I439b2516fcbe54977ff04e487a920acd38c27152
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-01Fix typosAndrea Gelmini
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15Some of our supported compilers don't do constexpr, which meansNoel Grandin
o3tl::typed_flags can't be 'static const' Change-Id: Ia2e40353f7a1b9e66617fa42f9eed6213f9e2d62
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-15loplugin:singlevalfields in sc..vclNoel Grandin
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-09loplugin:constantparam in sfx2Noel Grandin
Change-Id: If5d401001abb7bf3fc642d47f537b57836e6d9c5 Reviewed-on: https://gerrit.libreoffice.org/28772 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-08Unused stringsMaxim Monastirsky
Since 7affe26a1291eef8c77e890228061f13e987bff1 ("Kill sfx2 menu support"). Change-Id: Ib08ba64e7d3dc479df15f04f4e9ab81e13611202
2016-09-07tdf101964 Make the Styles category name translatable in Templates dialogGabor Kelemen
Change-Id: Ia3a7054d8c8cfc7ae86f11087c1c2d7209bd104a Reviewed-on: https://gerrit.libreoffice.org/28722 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07loplugin:constantparam in vclNoel Grandin
Change-Id: I0cae8e5de1170dec4c82df7f1f5377143a079876 Reviewed-on: https://gerrit.libreoffice.org/28686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-31Revert "tdf#101440 Better rendering of tooltip in gtk2 and windows"Maxim Monastirsky
See tdf#101779 for a proper fix. This reverts commit c505ec78ddf97fbcb6e39b7865df5a455d41bf38. Change-Id: Ie825c1d2d8b4ab5696078da95c1b7f3fc699b2cb
2016-08-30default dtors are fine hereCaolán McNamara
Change-Id: I503f954a2729aa2737d783ed8c72f62d8a68da4c
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26loplugin:refcounting: also cover temporaries being directly stack managedStephan Bergmann
Change-Id: Ib0f7c60df1d2fba0d4d9d3fa6faf3bb97867ebc0
2016-08-24tdf#93630: Remember whether a doc was originally requested to be opened r/oStephan Bergmann
...so it'll be opened r/o again on SID_RELOAD. Needs addition of yet another m_bOriginallyLoadedReadOnly state, after a199cad8376a5470c50125def2738b44b55ec018 "tdf#65498, tdf#87545: Don't confuse logically r/o doc with physically r/o" already added m_bOriginallyReadOnly. Change-Id: I9c7129a6f1b0e7618be616d5897ee6ef29e0abb7
2016-08-16tdf#101440 Better rendering of tooltip in gtk2 and windowsAkshay Deep
Change-Id: Ifd29f0f2c42dca722c8a7a0e2d9f6a56c2edaa66 Reviewed-on: https://gerrit.libreoffice.org/28149 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in sfx2..svgioNoel Grandin
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0 Reviewed-on: https://gerrit.libreoffice.org/27903 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05tdf#85110 Add missing space to Untitled document nameMuhammet Kara
When you create a new document, it is named as "Untitled 1", "Untitled 2" etc. but the properties dialog of the file is titled as "Untitled1", "Untitled2" etc. This patch adds the missing space inbetween. Change-Id: I63c6405f825d17b78fa05bf2b65d0b04d1ee0698 Reviewed-on: https://gerrit.libreoffice.org/27872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-08-02loplugin:countusersofdefaultparams in sfx2Noel Grandin
Change-Id: I0a21e2f8069bc698700e97e7c5e4ae508240ff98 Reviewed-on: https://gerrit.libreoffice.org/27761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01Put the initialization out of 'if' scopeGiuseppe Castagno
A better change than the one I did in 97353e5c43815b45a6f365ccaea474899683d38e. The "DAV:lockdiscovery" property may not be returned, so the initialization should be done before getting said property. Change-Id: Iae87df798439fc582a66dd3c0fe353ebb859b7b6 Reviewed-on: https://gerrit.libreoffice.org/27767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-30Fix the WebDAV lock owner name shown on file locked dialog UIGiuseppe Castagno
Probably due to 8d411a4a1ef6844c00bc714f8b144d3729e4f4e8. See comment in the added code for details. Change-Id: I3e8a856a715385ed2ab1d9ecda31dd25e05e6c59 Reviewed-on: https://gerrit.libreoffice.org/27716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29Fix typo: completelly -> completelyTakeshi Abe
Change-Id: I566c5554bf32ea18121c5a186365b97c91667c5d
2016-07-28tdf#101094 (5) OPTIONS: Add options check in Content::getResourceTypeGiuseppe Castagno
Added some verbose SAL_INFO to detail server responses to PROPFIND. Corrected a wrong comment and beautified a bit code I introduced in commit 3b26a2a403ca5e99b0dd07d042d47501c091af16. Change-Id: Id59749fe60fe0b451d8e0f4093d7902fe94bbed0 Reviewed-on: https://gerrit.libreoffice.org/27635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-28Revert "temp tinderbox fix"Caolán McNamara
This reverts commit d4cb9c3a8851cb874fd8b6c77d4d7521da7579b7. Change-Id: Ifd11427ea6b4137d0e0c007e7f140fbc6caa3f31
2016-07-27temp tinderbox fixCaolán McNamara
Change-Id: Id233762e6b8547078544c55b2932462a10749882
2016-07-27tdf#95144: Add a default css::ucb::XCommandEnvironmentGiuseppe Castagno
Makes use of a dedicated interaction wrapper to server ssl certificates correctly. See comphelper::SimpleFileAccessInteraction for details. Change-Id: I5728225065ec03f9b793940de316ccd97ee7114d Reviewed-on: https://gerrit.libreoffice.org/27596 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-22Fix typosAndrea Gelmini
Thanks to Carlo Bertoldi for the german translation. Change-Id: I76f554e757318aed4e28b5a05fae0ba15bd46afb Reviewed-on: https://gerrit.libreoffice.org/27355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-07-12Fix a warning when DontTerminateEdit is mentionedPranav Kant
DontTerminateEdit was added in a5a71cea62ac3041006c5e9815ae2317999639ac Change-Id: Ia1d2ac626dbdeea689a1f36494963be18316127f Reviewed-on: https://gerrit.libreoffice.org/27161 Reviewed-by: pranavk <pranavk@collabora.com> Tested-by: pranavk <pranavk@collabora.com>
2016-07-10Menu's dispose needs non-zero ref count, tdf#100829Markus Mohrhard
Change-Id: Ie1db4aa8ab2487b9ef058478a2f86d43cf8eba41
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08cppcheck: noCopyConstructorCaolán McNamara
Change-Id: Ic81697b8b1d826bf421a3b52f9a00f34536af8c8
2016-07-08GSoC notebookbar: container with prioritySzymon Kłos
+ extended vcl builder to parse priority + IPrioritable interface for controls with priorities + added IPrioritable as a base for VclContainer + Added PriorityHBox - box which shows controls if we have enough space PriorityHBox listen vcl events from SystemWindow to detect Resize Change-Id: I74ac1a80e7d0a061f5e7a8584dbb2abf956053c7 Reviewed-on: https://gerrit.libreoffice.org/26983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04merge sfx2::IXmlIdRegistrySupplier with SfxObjectShellNoel Grandin
Change-Id: I7e8bad6b1c944f14b850b91b902b82613c26faeb Reviewed-on: https://gerrit.libreoffice.org/26899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01fix accidental vcl::Region->RegionNoel Grandin
from my commit 8dbde084 "fdo#82577: Handle Region" Change-Id: I55a7b7fc6a6f2cf270eb7f51c5e3fd1d1f59263f
2016-06-29move #includes to top of fileNoel Grandin
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29tdf#100660 - Starting document from a template crashes LibreOfficeAkshay Deep
Change-Id: Ida89fa8d35d1e22c706bc3703d2397b572bc01b5 Reviewed-on: https://gerrit.libreoffice.org/26752 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-28loplugin:staticmethodsStephan Bergmann
Change-Id: I3f94a493822b8f6f83473578cd133a54ecc6be30
2016-06-28tdf#99729 related: make SfxObjectShell::IsOwnStorageFormat acccessibleMike Kaganski
This patch removes SAL_DLLPRIVATE attribute and renames SfxObjectShell::IsOwnStorageFormat_impl() to SfxObjectShell::IsOwnStorageFormat() to allow unsing in derived classes in other modules. Change-Id: I24650ad4624adc117d08b0e747c05ff050b4046d Reviewed-on: https://gerrit.libreoffice.org/26732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-27GSoC: Remove TemplateRemoteView from Template ManagerAkshay Deep
Conflicts: include/sfx2/templatedlg.hxx sfx2/source/doc/templatedlg.cxx Change-Id: Ia0623707e452c79346d92b5a5ab75a4063928c20 Reviewed-on: https://gerrit.libreoffice.org/26658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-24loplugin:singlevalfields in sfx2Noel Grandin
Change-Id: Ice6d47ccbc3ebf8971887b8b64c0d6860c76eec8 Reviewed-on: https://gerrit.libreoffice.org/26602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>