summaryrefslogtreecommitdiff
path: root/sfx2/source/sidebar
AgeCommit message (Collapse)Author
2019-07-26sfx2: LOK: route the parent sidebar window instead of the deckAshod Nakashian
Change-Id: I0269a67c637afbc63a81405918f620009e681ff6 Reviewed-on: https://gerrit.libreoffice.org/73508 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sfx2: disble sidebar menu-button when deck is hiddenAshod Nakashian
There is no render area on the sidebar virtual-device to render the popup menu when the sidebar is collapsed into the TabBar, so we disable it altogether as we can't properly display it in LoKit. Change-Id: I2edee9e734485bb685f0ddc0c30bfe584e42a550 Reviewed-on: https://gerrit.libreoffice.org/73507 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sfx2: customize the sidebar popup menu for LokitAshod Nakashian
Don't show customization or docking options. Change-Id: I313868cb2b2d0444ee90cf9709a326a81d0e5ed8 Reviewed-on: https://gerrit.libreoffice.org/73506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sfx2: collapse the sidebar instead of closing on toggleAshod Nakashian
When toggling a sidebar deck that is open, the default behavior when floating is to close the sidebar altogether. This is both inconsistent with the behaviour when docked and unexpected. Now we simply collapse the sidebar into the TabBar (toolbar) as is done when docked. This is also the behavior desired from LoKit since the sidebar is rendered floating (to allow arbitrary resizing). The collapsed sidebar into toolbar is shown in same-position. Change-Id: I0519c5ad012cc9df31758927a4dbcd774d47fcd3 Reviewed-on: https://gerrit.libreoffice.org/73505 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sfx2: LOK: support resizing the sidebarAshod Nakashian
Change-Id: I852c522f176a8d11d3a19709ab1cd75023645c66 Reviewed-on: https://gerrit.libreoffice.org/73504 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sidebar: support closing the sidebar through the X buttonAshod Nakashian
Change-Id: I078c27d22bbee3d02ad4a3fb97ba01a394f171e1 Reviewed-on: https://gerrit.libreoffice.org/73503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sidebar: Add .uno:MasterSlidesPanelAshod Nakashian
Change-Id: I578dc8b1f9c8df7f7cc9108c70d6fad8006871c6 Reviewed-on: https://gerrit.libreoffice.org/73502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: sidebars are now visible in LOOLAshod Nakashian
Change-Id: I7ceae056e3d6ce1c991fe1194faa8bebfd6aae1e Reviewed-on: https://gerrit.libreoffice.org/73500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-20loplugin:referencecasting in sfx2Noel Grandin
Change-Id: I97cd8821aa9a6f462f9b271940483738655ee9cf Reviewed-on: https://gerrit.libreoffice.org/75979 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18tdf#126424 Don't dispose decks before saving their stateSamuel Mehrbrodt
Only dispose them in SidebarController::disposing after the state has been saved. Change-Id: I9e42383e20e2bc0100557b8cb8fbd26b3505f236 Reviewed-on: https://gerrit.libreoffice.org/75719 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-17tdf#126427 Fix deck highlighting after activating via UNO APISamuel Mehrbrodt
Change-Id: I4ff7dfa156905abcba0df8e6bfbddc9e7d37cbbb Reviewed-on: https://gerrit.libreoffice.org/75723 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11Warn when LayoutSize constraints were not respectedSamuel Mehrbrodt
Change-Id: I5145bc4e10928ed456b36617de3345512b7a35d9 Reviewed-on: https://gerrit.libreoffice.org/75351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-17loplugin:logexceptionnicely in sfx2Noel Grandin
Change-Id: Ia638b94a7859c5dddca82111e7cbe753d7dde631 Reviewed-on: https://gerrit.libreoffice.org/74114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-30Don't pass escape key event to SfxDockingWindow from sidebarJim Raykowski
...docking window Missed this in recent rework concerning key input events in SidebarDockingWindow, tdf#125525 Allow shortcut keys from sidebar docking window. Change-Id: I53906251918874d2613795cb06a3e6ef07509bd8 Reviewed-on: https://gerrit.libreoffice.org/73192 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-28tdf#125525 Allow shortcut keys from sidebar docking windowJim Raykowski
Fix for tdf#115434 prevents key presses being passed through to document window from the sidebar docking window. This patch only prevents left, right, down, up, page down/up, home, end, backspace, delete, insert and return keys from being passed. Change-Id: I97ab60a214cb9910f526a475f3134784728b7d9a Reviewed-on: https://gerrit.libreoffice.org/73073 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-16loplugin:sequentialassign in sfx2..solenvNoel Grandin
Change-Id: I57e11d45aad48713b7c6802e2b6976fd916fc6ba Reviewed-on: https://gerrit.libreoffice.org/70717 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12tdf#124654 Don't reopen closed sidebar decksSamuel Mehrbrodt
NotifyResize was called after a deck was closed, so this is the wrong place to ensure minimum sidebar width. Change-Id: I5a03dc1ee24257d49673db58bffbda1a7358cf3a Reviewed-on: https://gerrit.libreoffice.org/70597 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-05tdf#42949 Fix IWYU warnings in include/sfx2/sidebar/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic2bd25bcbcc7f5fb6e29ced70fddb74385b5fb2f Reviewed-on: https://gerrit.libreoffice.org/70077 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25Related tdf#124263 Make sure sidebar is wide enough for contentSamuel Mehrbrodt
If panel's requested minimal size is smaller than current sidebar width, enlarge the sidebar to fit the content. Change-Id: I9baa4ef6c01d5563951d4df0d939883fce02e87b Reviewed-on: https://gerrit.libreoffice.org/69561 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22tdf#124263 Respect XSidebarPanel::getMinimalWidthSamuel Mehrbrodt
even if it's larger than max sidebar width (increase max sidebar width in that case). Change-Id: I2efbd546596f756df205196fae3e545beddd2f7c Reviewed-on: https://gerrit.libreoffice.org/69551 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-22tdf#124255 Make maximum sidebar width configurableSamuel Mehrbrodt
Also change the default max width to 500px (instead of 400px). Change-Id: Idece5aadaf4c4165cc873b4605d2c0f026c89c6e Reviewed-on: https://gerrit.libreoffice.org/69545 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22loplugin:unusedfields in sfx2Noel Grandin
Change-Id: I92b25efa78e156c89a0532aec632a31ec2029e05 Reviewed-on: https://gerrit.libreoffice.org/68202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15Revert "tdf#49684 Don't focus on Navigator or Sidebar on show"Jim Raykowski
See tdf#122900 for unwanted behavior changed caused by this. This reverts commit 88cbc3ea2db8358bbedff01361f95f972f2b0231. Change-Id: I9451a4b1f059b40d33b66b06f23228fc64170d8d Reviewed-on: https://gerrit.libreoffice.org/67853 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in sfx2..slideshowNoel Grandin
Change-Id: I3bd23a8f6237d0887a4782b6179a413dd2f03e02 Reviewed-on: https://gerrit.libreoffice.org/67564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-07loplugin:flatten in sfx2Noel Grandin
Change-Id: If4e07d497ead58a2ff58b5fdedd282b8784be421 Reviewed-on: https://gerrit.libreoffice.org/67435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-28o3tl::make_unique -> std::make_unique in sax...svtools (except sc)Gabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I6eea0877eaa1886b64c0cce06a43b8088cbccd8e Reviewed-on: https://gerrit.libreoffice.org/66751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-04remove unused DataChangedEventType enum valueNoel Grandin
Change-Id: I32d3c3481f0b8bcc36613afb495b64f4eb229a67 Reviewed-on: https://gerrit.libreoffice.org/64484 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-03Fix undocking sidebar with tab bar menu undock locks focusJim Raykowski
Missed this in I91194db3cc23a24e805a90edaf1566f950ac129d Change-Id: I9a9bb3cb47b19929577f4ee36206ea1c052adeca Reviewed-on: https://gerrit.libreoffice.org/62833 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-12-01Simplify containers iterations in sfx2, shellArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I42361d6a73d201db8eb6dca09d79768e2d62051d Reviewed-on: https://gerrit.libreoffice.org/64389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-15loplugin:staticmethods in sfx2Noel Grandin
Change-Id: Ide10d0186431e745c3bb17d321cf46724e801c8f Reviewed-on: https://gerrit.libreoffice.org/63404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-06lok: Notify about the current editing context.Jan Holesovsky
Change-Id: I47e67b680a6abdb66020b295f55ee6a73b7b5608 Reviewed-on: https://gerrit.libreoffice.org/62956 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-05tdf#120534 Make escape key focus to document from sidebarJim Raykowski
from all locations other than panel content Change-Id: I85a113d3001338dd1aff27bac75a5debd4635d59 Reviewed-on: https://gerrit.libreoffice.org/62808 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-05tdf#120473 Change sidebar panel content tab navigation behaviorJim Raykowski
Change-Id: Ifa5d52ffed32a4fe0bfe75fb731ee79d0976c0cf Reviewed-on: https://gerrit.libreoffice.org/61949 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-03tdf#116869 Fix unable to access sidebar tab bar using keyboardJim Raykowski
...when sidebar is floating and deck has one panel Change-Id: Ic741efbfbaf60241b360470c9bc736743f18f0ed Reviewed-on: https://gerrit.libreoffice.org/61052 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-11-01tdf#49684 Don't focus on Navigator or Sidebar on showJim Raykowski
Change-Id: I21b36c3ed2e5b6fc574e00f86d2c48c352cf469c Reviewed-on: https://gerrit.libreoffice.org/62337 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-01tdf#119631 Keyboard navigation: Skip hidden tabs in sidebar tab barJim Raykowski
Change-Id: I6ac001c27d6947f379c9923ff8518f9983faa356 Reviewed-on: https://gerrit.libreoffice.org/62716 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-31tdf#119630 Fix lost focus in Sidebar menuJim Raykowski
Focus to document after deck selection or customization from the sidebar menu. Change-Id: I315fecfe7bfaedf4c751b1c240e08b80daa77221 Reviewed-on: https://gerrit.libreoffice.org/62677 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-28Fix Sidebar docking key regressionJim Raykowski
Add back Ctrl+Shift+F10 undocking/docking handling. This regression was introduced by me in tdf#115434 Fix key press misbehaviors in sidebar. Change-Id: I29a563b2eb96be8a6b346454fddc1605dbc4aba6 Reviewed-on: https://gerrit.libreoffice.org/62268 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-27tdf#108751 Show currently selected color name in color button tooltipJim Raykowski
Based on Heiko Tietze's work in I26f0500527d2b86049948ca64e636e1ff566f262 Change-Id: I20541dd6ad155a39c0f87361088b44923406064f Reviewed-on: https://gerrit.libreoffice.org/61815 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-25loplugin:unusedmethodsNoel Grandin
Change-Id: I1f9ac5f8a090f365d9a21486029e1c13d721a4a4 Reviewed-on: https://gerrit.libreoffice.org/62338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in sfx2..svtoolsNoel Grandin
Change-Id: I1e92472b4aaeca1eb1372bd18d10cc9e0766dc39 Reviewed-on: https://gerrit.libreoffice.org/62251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-17 23:19:38 +0000