summaryrefslogtreecommitdiff
path: root/sfx2/source/sidebar
AgeCommit message (Collapse)Author
2019-10-29remove unnecessary includesCaolán McNamara
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f Reviewed-on: https://gerrit.libreoffice.org/81676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-25tdf#42949 Fix IWYU warning in include/vcl/window.hxxGabor Kelemen
The boost/property_tree/ptree.hpp added in commit 75b8db7fa7344a679d3c5dbdc8c5bd4228cdbc7c turns out to be rather expensive: it adds about 900 kB per compilation unit and window.hxx is included in about 2600 compilation units Replacing it with forward declaration header has reduced total includebloat from 26.1 Gb to about 22.7 Change-Id: I797608b54a62a5838c7a5d47355fb6bd736ad36c Reviewed-on: https://gerrit.libreoffice.org/81500 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-23loplugin:unusedmethodsNoel Grandin
Change-Id: I5fd081780d46fd30864830eea2956bad6dc3e222 Reviewed-on: https://gerrit.libreoffice.org/81360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22loplugin:constantparamNoel Grandin
Change-Id: Ibfe70492683ff3ec208cee95d8a11155ec54f690 Reviewed-on: https://gerrit.libreoffice.org/81314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:deadvirtual unused param in ItemUpdateReceiverInterfaceNoel Grandin
Change-Id: I3db5a456a259a97dc9bdf6be0d478177bac05215 Reviewed-on: https://gerrit.libreoffice.org/81186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in TitleBar::PaintDecorationNoel Grandin
Change-Id: I3dd8ee6492be1a4b3d1032c4d50cc01111d748cb Reviewed-on: https://gerrit.libreoffice.org/81185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10jsdialogs: emit JSON at idle to avoid repeated emission.Michael Meeks
Change-Id: If8ddfaf9097f706d82117e102a56b4a8b2a41cdd Reviewed-on: https://gerrit.libreoffice.org/80616 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-10jsdialogs: set LOKNotifier in DeckSzymon Kłos
Change-Id: I845e5f06694372c614972a09e9ab9db89006df16 Reviewed-on: https://gerrit.libreoffice.org/79718 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/80615 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-10sfx2: LOK: route the parent sidebar window instead of the deckAshod Nakashian
Correct, correction of previous mis-merge. (cherry picked from commit a4142984c4d8dc00fea438bd71bf2af4917c359a) Change-Id: Id3457474bdc4de8bab7a70361ff0e2db1b813476 Reviewed-on: https://gerrit.libreoffice.org/80614 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-08jsdialogs: Expose the panel names.Jan Holesovsky
Change-Id: Ifa837bfcaba6e63c7058e34f1e386f571bfb4d61 Reviewed-on: https://gerrit.libreoffice.org/80481 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit b13e2e7d2b2767d4fadaf825756ee38bc941ad57) Reviewed-on: https://gerrit.libreoffice.org/80490
2019-10-08lok: only generate sidebar JSON for mobile views, for now.Michael Meeks
Change-Id: I7a4b20cfc93ddd77752790a7c303f512a62afbb3 Reviewed-on: https://gerrit.libreoffice.org/80460 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-01jsdialogs: send JSON to the clientSzymon Kłos
Change-Id: If43a774e1e3a4bff4a8ec862f0091d60477090d4 Reviewed-on: https://gerrit.libreoffice.org/79803 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01jsdialogs: set panel as a separate typeSzymon Kłos
Change-Id: I715915ddcaff807ae6a6593dd776dbdb86f2bf4a Reviewed-on: https://gerrit.libreoffice.org/79802 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01lok: Enable sidebar also in Impress.Jan Holesovsky
Change-Id: I6c5c7c82a3ad81e590a891f1a8cc76a873823acf Reviewed-on: https://gerrit.libreoffice.org/79856 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 4ff28e09412d2c0ef73008d3d85dae9b506e4978) Reviewed-on: https://gerrit.libreoffice.org/79900 Tested-by: Jenkins
2019-10-01tdf#127306 Fix crash when closing LO after deleting a chartSamuel Mehrbrodt
This crash was introduced with b58aa94f1f365c746135470bceb97cc182c289bc This patch basically reverts that patch and implements a different fix. Change-Id: I394a2f6490d3ee0769c0f78bb8a3980167719893 Reviewed-on: https://gerrit.libreoffice.org/79865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-09-26add property name when throwing css::uno::UnknownPropertyExceptionNoel Grandin
Change-Id: I17f06c9415b9d43b6d8896360e07216c2856367a Reviewed-on: https://gerrit.libreoffice.org/79627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-24Use lazy-loading stock Image to simplify framework image lists.Michael Meeks
Project stock names through XGraphic via origin URL. (cherry picked from commit 77b88eebaadebb626108172e4f2de36c60960051) Change-Id: Ib445694f7c142a163ef7e7bc0beea39b88b99e14 Reviewed-on: https://gerrit.libreoffice.org/79420 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-03Ensure that VCL builder entry points use proper function typeMike Kaganski
This removes duplicating typedefs from NotebookBarAddonsMerger, and removes dependency of include/vcl/builder.hxx on include/vcl/NotebookBarAddonsMerger.hxx. Change-Id: Ica5787c934d1b8ce21623f28ce155337637fdf54 Reviewed-on: https://gerrit.libreoffice.org/78549 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-03Parent reference should be const in VCL builder entry pointsMike Kaganski
Change-Id: I2331e19f5e23e0dde8edd22befc7287515adf37e Reviewed-on: https://gerrit.libreoffice.org/78536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-30Smaller-width animations pane on mobileMuhammet Kara
Change-Id: I2c3a2a703c7e9fa776e7a6c88cdca5414ce2c2c1 Reviewed-on: https://gerrit.libreoffice.org/78300 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-24loplugin:returnconstval in sfx2Noel Grandin
Change-Id: I9761dbfa66ea59d5c9c0cd87740fdb8ca34008eb Reviewed-on: https://gerrit.libreoffice.org/78034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20loplugin:constvars in sdext..sfx2Noel Grandin
Change-Id: Id9b05387b7b87d3af5e646e867e6ca9fda0711ce Reviewed-on: https://gerrit.libreoffice.org/77806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in sdext..sfx2Noel Grandin
Change-Id: If9924566b21e50cad7a12d781ac5d337de0684ab Reviewed-on: https://gerrit.libreoffice.org/77526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15replace ".get->" with "->"Noel Grandin
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12tdf#126769 Sidebar can't be collapsed clicking on the hide arrowSamuel Mehrbrodt
Change-Id: I72ab41fb6c98ab548a1b3cfce837ab9312c7df66 Reviewed-on: https://gerrit.libreoffice.org/77156 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06LOK: sd: fix unit-tests and add a couple simple onesAshod Nakashian
Change-Id: I6b8f13bf9cb609a86b85135ceb96f865451b59ac Reviewed-on: https://gerrit.libreoffice.org/77071 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-08-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Icdb749d46249ea29badbe523320b17312e077684 Reviewed-on: https://gerrit.libreoffice.org/76811 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-01Notify the client when we close the sidebarAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/71844 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 60c048e665c7e8dc32c378f0364931b6e26a9ca2) Change-Id: I4879d65285e01cf2fd99233d226f4201997b4dd7 Reviewed-on: https://gerrit.libreoffice.org/76784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01LOK: support sidebars in writer and calcAshod Nakashian
[ Miklos: added code to release LOK notifiers in SfxWorkWindow::DeleteControllers_Impl() during shutdown. ] Reviewed-on: https://gerrit.libreoffice.org/71843 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5ddf630222241bec4deda56d10992c35ae4efe06) Change-Id: I3a3bd1fb6922e435599f604328f558be60594729 Reviewed-on: https://gerrit.libreoffice.org/76556 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): sfx2Stephan Bergmann
Change-Id: Idb86a5351feaf307504d1f1f110ef8b1275bedce Reviewed-on: https://gerrit.libreoffice.org/76648 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31tdf#126508 Fix crash when changing icon styleSamuel Mehrbrodt
Regression from b58aa94f1f365c746135470bceb97cc182c289bc Change-Id: I253447c197d8b333e26f243e26794e775f3edcee Reviewed-on: https://gerrit.libreoffice.org/76589 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-30sfx2: Enable sidebar on calc and writer, but not in impressAshod Nakashian
Added by Noel to this commit: And add a special deregister mode to doc_registerCallback so we can unregister stack-based callback objects in the presence of multiple views. Reviewed-on: https://gerrit.libreoffice.org/71715 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit fba6d4267b3f827269d6550dcb003cc56b31e493) Change-Id: I8d846bc1f794cf16fd45486fd83ef87f43fd52c7 Reviewed-on: https://gerrit.libreoffice.org/76555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29Simplify Sequence iterations in sfx2Arkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I6a0d18493db7a25e8b41925f2d45cb221b5065a7 Reviewed-on: https://gerrit.libreoffice.org/76074 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29Expand collapsed sidebar when calling XSidebarProvider::showDecksSamuel Mehrbrodt
This UNO call did not work correctly when the sidebar was completely collapsed. Change-Id: I3de0b89d95aa81287c36911bbd52a9941d9886b3 Reviewed-on: https://gerrit.libreoffice.org/76525 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-27Fix typosAndrea Gelmini
Change-Id: I389c9aaa5788bf26398e0639c0f11f9dfbe4e3da Reviewed-on: https://gerrit.libreoffice.org/76374 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-26sfx2: LOK: better fit of sidebar decksAshod Nakashian
As the patch comment explains, the properties deck needs to be rendered with height long enough to avoid scrolling, but others would be greedy in using up all the available height, so we render them in more restricted space. Change-Id: I361e653239e22a7be0e5d75505cdcde18f2367d3 Reviewed-on: https://gerrit.libreoffice.org/73524 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx2: LOK: resize the sidebar after layouting to avoid scrollbarsAshod Nakashian
By resizing the deck we ensure that if the contents do not fit in the existing height, they will after we expand to the minimum height. Also, the minimum height is now the correct one. This prevents seeing vertical scrollbar in LOK, which is very slow and unfriendly, instead renders the full sidebar and lets the client scroll, if necessary. Change-Id: Idc2a622a65074b7afb26263624f2df0b5968f40d Reviewed-on: https://gerrit.libreoffice.org/73523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx2: avoid unnecessary dynamic_castAshod Nakashian
And reformat. Change-Id: If8a3dd4d16dfd51f8006d2d5d47951db30390fd8 Reviewed-on: https://gerrit.libreoffice.org/73522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: fix the minimum height of sidebarsAshod Nakashian
Change-Id: I29d4eb38c72db50061266f0cf0ace31bab690315 Reviewed-on: https://gerrit.libreoffice.org/73521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: notify clients of the sidebar stateAshod Nakashian
Change-Id: I35b174c3a5e302ce52ee4063fa71d47feffab624 Reviewed-on: https://gerrit.libreoffice.org/73520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: don't shrink sidebar height below minimumAshod Nakashian
This avoids scrolling within the sidebar and makes it possible to scroll the rendred sidebar image in the client, which is more responsive and lighter. Change-Id: I0713c699ba82bfc5fe503c9351402c67aef4494e Reviewed-on: https://gerrit.libreoffice.org/73519 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: toggle sidebar decksAshod Nakashian
Change-Id: I0559a2a4ae041bc61cf3a2d5979656a7941f4b02 Reviewed-on: https://gerrit.libreoffice.org/73518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: no sidebar tabbarAshod Nakashian
Change-Id: I210df42fec4404ed9629c9b1c24c78b680212214 Reviewed-on: https://gerrit.libreoffice.org/73517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: publish notifications to the correct viewAshod Nakashian
The ViewShell, which represents the view in question and therefore which view gets the window notifications, is incorrect when the sidebar is first created upon creating/attaching a new view. This leads us to a workaround to make sure that we publish notifications to the correct view. We also have to hide the sidebar instead of closing because the workaround wouldn't work when re-creating the sidebar on an existing view. See comments in code. Change-Id: I9d3be901688291b04d634b68e1e20c7add77381f Reviewed-on: https://gerrit.libreoffice.org/73516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: hide gallery, navigation and styles decksAshod Nakashian
These aren't fully functional, so not very useful in LOK. Change-Id: If6330b1f7bf911bbb9edad00aaea7c4d37671746 Reviewed-on: https://gerrit.libreoffice.org/73514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: start collapsedAshod Nakashian
Change-Id: I589fce5ee207da0e0ac113b7ccc1ed1edd06c5da Reviewed-on: https://gerrit.libreoffice.org/73513 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: release LOKNotifier on destructionAshod Nakashian
And enable sidebar routing only while we have a valid SidebarController instance (i.e. not disposed). Change-Id: I665f934f762c0ce9efdce5489ec9babe006376a8 Reviewed-on: https://gerrit.libreoffice.org/73512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: enable only for Impress in LOKAshod Nakashian
Change-Id: Idb361164db9ea8681b45fe99608d2cb5690db161 Reviewed-on: https://gerrit.libreoffice.org/73511 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: send close notification on disposing sidebarAshod Nakashian
Change-Id: Ia8f197d07ba4b6a089571e9ca23b4697d04e7734 Reviewed-on: https://gerrit.libreoffice.org/73510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-08 04:26:27 +0000