summaryrefslogtreecommitdiff
path: root/sfx2/source
AgeCommit message (Collapse)Author
2014-04-16coverity#1202948 Uninitialized pointer fieldCaolán McNamara
Change-Id: I2764b1f9c3d50cf7ff7bd2c552a3dec93509b245
2014-04-16coverity#1202947 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ieee8f9eba25f17ba789d3be5a006e056108c386b
2014-04-15fdo#72287 Scroll automatically to show selected item when keyboard used.Andrzej Hunt
806919adf9c9bafbaba92c2d2ab35d2e2f9863f8 added finer-grained scrolling using the scrollbar / scrollwheel, but inadvertently prevents the display from scrolling when an item is selected that is currently offscreen (e.g. by using the down-arrow button on the keyboard). Change-Id: Iaa3a7dc6d214741d37cf4ec78c00ed0034ed1e42
2014-04-15fix hacked bool in SfxDispatcher::SetSlotFilterNoel Grandin
The bEnable flag was being passed an extra value. Make this explicit now using an enum. Change-Id: I292aca44e8592c9f3c1497c24c41140c8c3b5452
2014-04-14typo: artifical -> artificialThomas Arnhold
2014-04-14typo: controlls -> controlsThomas Arnhold
2014-04-14typo: nummer -> numberThomas Arnhold
2014-04-14typo: titel -> titleThomas Arnhold
2014-04-11coverity#708157 Uninitialized scalar fieldCaolán McNamara
Change-Id: I9d798c8b6472241dc7d16e3d7b52653ad0d76654
2014-04-11unused bInAppBASIC memberCaolán McNamara
Change-Id: If7adfb573e4a7605953a2561fd280a5bc22b02fd
2014-04-11coverity#738831 Uninitialized pointer fieldCaolán McNamara
Change-Id: I9de07f4fe8b9919ec2a7e83019b5131647e552c1
2014-04-11Use valid UNOIDL identifiers in css.frame.Status.ItemStateStephan Bergmann
These are present since OOo 2.0, but are unpublished and appear to be rarely used, so changing them is hopefully OK. Change-Id: I144eceb074cfdd91777f4c940cbfbc0dd73d4347
2014-04-10Fix fdo#71423 - crash while editing Impress tables.Thorsten Behrens
Band-aid fix for this nasty crasher, seems sometimes the family item is not found. Change-Id: I7f78d59cbf2c9595ad512fa7a78370629924cd06
2014-04-10It's "its", not "it's"Tor Lillqvist
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10DownLoad -> Download.Jan Holesovsky
Change-Id: Ia1729f570cc80a0375532da6478de9d58518556e
2014-04-10Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: I9d6e9df0b686c61597aaa0e194ab321445671a20
2014-04-09Do not leak SfxDialogExecutor_ImplStephan Bergmann
Change-Id: Ife3e8e4b339b3e2cba3bc81e14f616d75c4f5ed0
2014-04-09Remove unused MacroOrganizerStephan Bergmann
Change-Id: I637e84ae7fa82f687eb3f05b3e24e236f0ba8e3c
2014-04-09Remove unused MakeVariableStephan Bergmann
...unused ever since at least fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import." Change-Id: I6ec792b68ce6b13b1cf074d9719a23daf3356e66
2014-04-09Remove always-null SvFileObject::pDownLoadDataStephan Bergmann
...left over after 66e4540041f09b4e779d27190f0925479f74103b "aDataAvailableLink in SfxMedium was never called." Change-Id: If2cfcc27f2b26ea3c950c2da1c673df940d94773
2014-04-08loplugin:literaltoboolconversionStephan Bergmann
Change-Id: I7a312fb31774e198b71e5f733a2932d6b9607f57
2014-04-08coverity#704796 Dereference after null checkCaolán McNamara
Change-Id: I97aaaa38620f162a3a4d08bb66690815beb7880e
2014-04-08coverity#704792 Dereference after null checkCaolán McNamara
Change-Id: Ie6f3174266dfa42a1eff81df45fc408656d4fbd9
2014-04-08coverity#704791 Dereference after null checkCaolán McNamara
Change-Id: I7e973ac9b91ab112952f56ce290c07c9fc5670b2
2014-04-08coverity#704790 Dereference after null checkCaolán McNamara
Change-Id: I276b404405b9717a03d43a24c6ffecd5c6553969
2014-04-08WaE: implicit conversion of literal of type 'int' to 'bool'Tor Lillqvist
Change-Id: I501dcb0ca3465e5e07564a7156a0dfa3f2767af5
2014-04-08coverity#708175 Uninitialized scalar fieldCaolán McNamara
Change-Id: I235f46bf9b0e672ddad16d9766a09f5c7c88a3e0
2014-04-08use TriState instead of sal_Bool as there's three possibilitiesCaolán McNamara
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-08WaE: -Werror=uninitializedCaolán McNamara
Change-Id: I4c2eb1e323505c6298203cb89769dc693f4e63bb
2014-04-07Bin empty @seealso, @param, @return etc metacommentsTor Lillqvist
Change-Id: I1590c20c4080578f5b528f4d6d43749e4e939fde
2014-04-07untangle the bFmt == 2 hackCaolán McNamara
Firstly, IsFormat is unused so there's no "escape" of bFmt back into the outside world. Then bFmt has two purposes. Purpose 1 is 'not be a format dialog, be a format dialog, be a format dialog but hide standard button' so, lets just add an explicit "Hide standard button" method and call it in the (apparently) one place where it's necessary. Purpose 2 is to flag that "BaseFmtHdl" was called from clicking the "Standard" button at which point its set to 2. SfxTabDialog::Init_Impl had... " // bFmt = temporary Flag passed on in the Constructor(), // if bFmt == 2, then also sal_True, // additional suppression of the standard button, // after the Initializing set to sal_True again if ( bFmtFlag != 2 ) m_pBaseFmtBtn->Show(); else bFmtFlag = sal_True; " but the variable acted on is bFmtFlag a copy of bFmt, and is never read again after that line, so setting it to sal_True is meaningless. The comment suggests that the intent is to reset bFmt to true if it was 2 during initialization, which fits with the later use of bFmt == 2 to indicate that the standard button was clicked, i.e. reset bFmt back to its standard value. So make bFmt a simple toggle of dialog as a format dialog or not, add a way to remove the standard button and add a second variable to indicate the standard button got pressed. Change-Id: I98a441f5f314845abe243e05b6d92fd71d7b0b04
2014-04-07sfx2: sal_Bool->boolNoel Grandin
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-04-07Replace SV_DECL/IMPL_REF macros with SvRef templateStephan Bergmann
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-06WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'Tor Lillqvist
Change-Id: Ib477afa1740f14832f49ce85822410b2e9db8d46
2014-04-05coverity#704787 Explicit null dereferencedCaolán McNamara
Change-Id: I8c83648f39c4e8e6aeae06e764820f7677f75288
2014-04-04"2" as arg for PrepareClose is never checked forCaolán McNamara
The 2 for PrepareClose came in with 38db42605a5b72efd55a43eff81fbc517fe0424b "#89423#: added SID_CLOSEDOC, SID_BACKTOWEBTOP, SID_LOGOUT in PluginMenu" and was checked with if( SfxApplication::IsPlugin() == sal_False || bUI == 2 ) in sfx2/source/doc/objxtor.cxx and then that was removed with 367568c891771d20bb8f8b3b579857f51c0e9016 "#132394#: remove superfluous code" Change-Id: Ib273c88b4365ea6b261c7e52bbe1876aa796dc17
2014-04-04I can't see that the bVisible as 42 is any difference from 'true'Caolán McNamara
...in practise. If I'm wrong then this needs to be a TriState Change-Id: I4aa499c89ce2f1a46edf443db053b264f285b0d5
2014-04-04svl/eitem.hxx: sal_Bool->boolNoel Grandin
Change-Id: I45dfd2429a490af3cc80f51340e0c05a91425668
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03fdo#43157 : clean up OSL_POSTCONDMichaël Lefèvre
Conflicts: include/sal/log-areas.dox Change-Id: I770b8b9fb82f873ccb88dc26ac05206f703ddf33 Reviewed-on: https://gerrit.libreoffice.org/8805 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-03Related: fdo#75307 use the unique auto help id to identify tabpagesCaolán McNamara
and dialogs that are loaded from the .ui format Change-Id: I37aea52a3973d8d8f6a2ce8dabf80bb1e64db43f
2014-04-03sfx2/tbxctrl.hxx: sal_Bool->boolNoel Grandin
and clean up the mess around the two different Select methods which just led to confusion in the overriding classes. Change-Id: Iea0ea85752180d0dc50d2b4ddb3d861e8447fb0a
2014-04-03svl: sal_Bool->boolNoel Grandin
Change-Id: I6938314a08d061d2b07d9129742d74a989bd1385
2014-04-03sfx2/objface.xx: sal_Bool->boolNoel Grandin
Change-Id: I1227c958d58903dc114a4e4173fb2714b2ec33f2
2014-04-02Related: fdo#75307 use the unique auto help id to identify tabpagesCaolán McNamara
and dialogs that are loaded from the .ui format Change-Id: Id8abff6d89818ca7384d9691a05eacd378a5905c
2014-04-02GraphicFilter::LoadGraphic: SAL_WARN -> SAL_INFOMiklos Vajna
Only the caller can decide if trying to load a graphic is really a problem, e.g. in case no persona is configured, then loading its header is OK. Change-Id: I7286b7d907940fa3a80f6256cd5264cbd5718fb8
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01coverity#984141 Uninitialized pointer fieldCaolán McNamara
Change-Id: I326923bb14e90a89461283b344cf59c798d647f3
2014-04-01Bin pointless INET_HEX_ESCAPETor Lillqvist
Change-Id: I72238e511c2fca4a4aba0be60b0f2d3b1f46e5c2
2014-03-31SAL_WARN -> SAL_INFO in SfxDispatcher::_FillState()Miklos Vajna
These warnings were hidden so far, don't make them noise till one starts to actually fix them. Change-Id: I142726d54fbc20c1c5591a5b20d26356986ba4b8
generated by cgit (git 2.34.1) at 2025-01-17 23:42:01 +0000