summaryrefslogtreecommitdiff
path: root/sfx2/source
AgeCommit message (Collapse)Author
2020-06-04Revert "Resolves tdf#127401 - Chinese locale pointing to wrong hub forward ↵Heiko Tietze
address" This reverts commit 2788cc07e9d0d078b53a7280d524175c03c51e12. Reason for revert: <INSERT REASONING HERE> Change-Id: I47277e7344d5533cc09a3fd6637a0780b36fe739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95427 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-04Resolves tdf#127401 - Chinese locale pointing to wrong hub forward addressHeiko Tietze
zh is replaced by zh-cn for donation and whatsnew commands Change-Id: Ibd56e94983882bd9090d176cb42ae0a7a1f88065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95450 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-04loplugin:simplifypointertobool improve (2)Noel Grandin
to look for the x.get() == null pattern, which can be simplified to !x Change-Id: I0eddf93257ab53ab31949961d7c33ac2dd7288ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95400 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-04Use lokCallbackTypeToString to show value symbolicallyTor Lillqvist
Change-Id: Idb685e2807cc62bbaca117f5cf85fdda622caae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95467 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-03Resolves tdf#130936 - Proper Icon Size for MIME type Icon in Start CenterHeiko Tietze
Icons are now in 48px Change-Id: I484458adf047999bc2ea0cbf16e7ff3fff131eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95028 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-03loplugin:simplifypointertobool improveNoel Grandin
to look for the x.get() != null pattern, which can be simplified to x I'll do the x.get() == nullptr pattern in a separate patch, to reduce the chances of a mistake Change-Id: I45e0d178e75359857cdf50d712039cb526016555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-02tdf#130354 sfx2: make PDF signing UI work againMiklos Vajna
Regression from commit 9112c18524c9f5e67d6cbb282586a439e3020cdb (Don't create unnecessary tempfiles for opened doc, 2019-10-18), restore the temporary file creation for the PDF case, as it's needed for PDF signing to work. Change-Id: I945f04f6ab90d0e04fb14a7634ec877fb0af1a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95367 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-02inline some use-once typedefsNoel Grandin
Change-Id: I335e0c5cf7944efa487e4535a9e6a5baab2f36dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-30loplugin:simplifybool extend to expression like !(a < b || c > d)Noel Grandin
mostly to catch stuff from the flatten work, but I think this looks good in general Change-Id: I7be5b7bcf1f3d9f980c748ba20793965cef957e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-28loplugin:sequenceloop (macOS)Stephan Bergmann
Change-Id: Ie1f5c925a058ef79df3f5183051c87fa8d342fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27Related: tdf#133385 set cursor in row on right clickCaolán McNamara
if the target row is not already selected Change-Id: I7cb39118f4a695546d8d2251390d6d3279e82bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26make highlight of get_dest_row_at_pos optionalCaolán McNamara
Change-Id: I280e1a49e938f45402f373896669fd6f7e8a66fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26tdf#133094 NotebookbarToolBox is not in the sidebarCaolán McNamara
though it is inheriting from SidebarToolBox and we're distinguish the sidebar case from the non-sidebar case wrt certain color toolbuttons Change-Id: Ieffe45adfab95d426bb36296ee3428b6bd3dbd3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-25[MS-OFFCRYPTO] convert oox implementation into UNO serviceVasily Melenchuk
To permit pluggable crypto services, abstract existing implementation behind an XPackageEncryption API. Previous code already had two halfway-polymorphic classes (agile and standard 2007 engine), so we're not adding much additional layers. As MS crypto always uses OLE storage to wrap content into one single file, current implementation passes all substorage names down into XPackageEncryption APi, so different downstream implementations (e.g. for MS RMS, or Azure AIP) are possible. Because OleStorage classes are internal to LibO core, access is provided via XInput/XOutput stream API function. Change-Id: Icc32a4e0ce215090c3b739f1dcaa0654b36b7f08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84436 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-25sfx2 UNO API: XModel2::setArgs() now also supports "EncryptionData"Vasily Melenchuk
XModel2::setArgs() only permits hand-picked set of media descriptor parameters. Add one more in preparation to API-based MS crypto rework. Change-Id: I179a1cfc2cdd7b04becba0d7dfe9740d920ae4ee Reviewed-on: https://gerrit.libreoffice.org/80432 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84434 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-22Resolves: tdf#133183 select style under mouse on right click context menuCaolán McNamara
Change-Id: I4317f6702b7a0e172d059fe83614aab94845b201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22Resolves: tdf#133180 use full width of canvas for preview renderCaolán McNamara
Change-Id: I1fa3f0fd8505712155c72c25b67da1ab6d4753e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21drop some unnecessary includesCaolán McNamara
Change-Id: Idf507ea5a9790bf54ef98ed4f0cc89e2c01cc8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21use for-range on Sequence in sfx2..swNoel Grandin
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-18Create weld::Builder implementation for JSDialogSzymon Kłos
and use for WordCountDialog on mobile Change-Id: I12c3455ff9b16c30918067f9282b72f49141a308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94055 Tested-by: Jenkins
2020-05-18officecfg,unotools,cui: add ODF 1.2 Extended / ODF 1.3 versionsMichael Stahl
... to configuration and UI. The new default is ODF 1.3 Extended, which is now ODFVER_LATEST and stored as value "3" in configuration. Adapt a few places related to DocumentDigitalSignatures etc. to new default. Change-Id: I420da4f7787cc864c6bd88470d61b146b9399aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93177 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-16loplugin:unusedmethodsNoel Grandin
Change-Id: I52187eccf6170f64d38c673a86dc80818813efa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-15LOK: sending status of paragraph outline buttonsPranam Lashkari
status of: OutlineRight, OutlineLeft, OutlineDown, OutlineUp Change-Id: I28dd805e1a620831c4092523969e1c4825b568f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94216 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-15comphelper,sfx2,dbaccess: add ODFVER_013_TEXT constantMichael Stahl
This is used for Version of package in API. Change-Id: I23d162c4dfff2f56c541a7c6c2e21c87ed7d8213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93087 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-15use more try_emplaceNoel Grandin
specifically looking for the pattern if (map.find(...) == map.end() map[...] = value Change-Id: I99f20d73f6e71a10726c9d39d8644c2e51120091 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94151 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-14loplugin:unusedfieldsNoel Grandin
Change-Id: I0ec89b56b339f26bb236887c904e6b5d14ceecea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-12weld help browserCaolán McNamara
Change-Id: Ibd8dcc10c4403731953e2e46db4ae8f89ebc7e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93216 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12always use the LinkManager's persist as the known refererCaolán McNamara
Change-Id: Ibb1bd9138993adbd8391b524c0cd654ba523cad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-11de-duplicate cut and paste functionCaolán McNamara
Change-Id: I9569a10562e50ab5660a5638c518680c58fc97dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10compact namespace in sfx2Noel Grandin
Change-Id: I70e1002fc09f5a8d0352cdb0c120fe5ed79cf3e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10lok: set device form factor of the client on view creationMarco Cecchetti
This patch allows the lok core to know about the device form facor of the client requesting the creation of new view, immediately instead of a later time. When a new view is needed a "DeviceFormFactor" parameter is forwarded to lo_documentLoadWithOptions and doc_createViewWithOptions from the client. This parameter can have one of the following values: 'desktop', 'tablet','mobile' and it is used to set a global variable accessible by SfxLokHelper::setDeviceFormFactor and SfxLokHelper::getDeviceFormFactor. This global variable is retrived in the SfxViewShell constructor for setting SfxViewShell::maLOKDeviceFormFactor attribute. In SfxViewShell we have the following 3 methods: - bool isLOKDesktop() - bool isLOKTablet() - bool isLOKMobilePhone() which replace the following boolean functions: - comphelper::LibreOfficeKit::isTablet - comphelper::LibreOfficeKit::::isMobilePhone Change-Id: I9b36f354278df8c216fcb90f6a9da8256ec9c1e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93340 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-08lok: MSForms: Add callback for form field button.Tamás Zolnai
Show and hide the button and send the button area, where it should be displayed. Change-Id: I5922eb9f5e544483dd4efd12e4218d2e51270632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93657 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-07replace ODFDefaultVersion usage with ODFSaneDefaultVersionMichael Stahl
Compare with ODFSVER_012 mostly works the same, except for places where namespaces are defined where the ODFSVER_EXTENDED bit should be checked. Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92727 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-06Resolves: tdf#132581 allow disabling the auto-group RadioButton featureCaolán McNamara
the older way of doing things is to dig around contiguous radiobuttons to see what is part of the group, while the contemporary one is to explicitly use group() to set the members. A problem of the legacy way of doing it is that the results during setup and teardown of a collection of radiobuttons can be misleading. Change-Id: I6c590d0fb6fc6db3f5e5ba4397a62930a5c8f3f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05remove unused nSearchFamily and nMask membersCaolán McNamara
and so SetSearchMask which doesn't have any effect anymore Change-Id: I0b7f402ce0317971d5196fc448fe2945a6a292f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05use SfxStyleSearchBits::Auto as fallbackCaolán McNamara
instead of SfxStyleSheetBasePool::GetSearchMask() Change-Id: I2ca3ccc775f30f0ffa99f6cc2c41c69c6d401010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05help states that SfxNewStyleDlg lists SfxStyleSearchBits::UserDefined stylesCaolán McNamara
Change-Id: Ibf89d0ff1154b943a5650ac6cd6aa64a084c15cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93491 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05use GetFamilyItem_Impl to determine the active familyCaolán McNamara
Change-Id: I1ddb4a0312f87cb549e5a054f79a72210af082a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05SearchMask doesn't have a bearing on whether to enable/disable tree dragCaolán McNamara
Change-Id: Id537a7a57adc6245025abb899fc9cfa61fb33d42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05make the family and mask explicit in SfxStyleSheetBasePool::FirstCaolán McNamara
Change-Id: I36655b65ca00e5f7b8779a28d4a1778c8e35dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05drop SfxStyleSheetBasePool::CountCaolán McNamara
and use CreateIterator to make it explicit what is being counted Change-Id: I8d76aef601533960a23c056b83a48c4f130bbe75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93446 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05search mask is always overwrittenCaolán McNamara
and isn't used by SfxNewStyleDlg anymore Change-Id: Ia4ea161b3d292e6324c5f6a4c347623e10a2c8ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05same code on each branchCaolán McNamara
Change-Id: Ifb98c6dbd1f72fcfae3958b0444facfc9c6f4cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-04make Search family and mask explicit for SfxNewStyleDlgCaolán McNamara
Change-Id: Ib3e5765d37474188d6505f1d9965969ee6c24f0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93358 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03use SfxStyleSearchBits::All for GenerateUnusedNameCaolán McNamara
use in SfxManageStyleSheetPage is definitely with SfxStyleSearchBits::All applied. It seems almost certain that use in SwDocShell::ExecStyleSheet would prefer that Change-Id: I245c3f02bcce87f124bf0e507b59738a6dff34d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93354 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03explicitly pass SfxStyleFamily to GenerateUnusedNameCaolán McNamara
Change-Id: I7879578383d58cb65441c9049e91e33bb4827afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93353 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03Related: tdf#130108 expand single arg SfxStyleSheetBasePool::Find usesCaolán McNamara
remove it and expand its uses to explicitly show what it does Change-Id: I2d4511c58b51003c327a2c70e3cc4f60751f520d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-27 22:53:33 +0000