summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2019-06-05The macOS SDK 10.15 has a tighter declaration of objc_msgSend()Tor Lillqvist
Change-Id: I51734b92965a9fa1f06aa18017d39b4b0d532456
2019-06-04AppendInfoBar can return nullStephan Bergmann
e.g., when opening the old help window ("Help - LibreOffice Help" in a build configured with --with-help to "build the old local help" (configure.ac)) Change-Id: Icecd224774b98811ddf9545c5fa83a85fab259fc Reviewed-on: https://gerrit.libreoffice.org/73390 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03tdf#67538 XTypeDetection::queryTypeByDescriptor poor performance, part2Noel Grandin
SfxMedium was creating a temporary file and copying the input file, when CloseInStream_Impl was called from the destructor. Very very bad for performance. This is specifically fixing the performance of queryTypeByDescriptor when called from a basic macro on a local test file. This takes my test macro from 16.1s to 9s. Change-Id: If52f8e0587c7b11666893f6cb79b3180d45cce43 Reviewed-on: https://gerrit.libreoffice.org/73375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-03tdf#39593 use UNO3_GETIMPLEMENTATION* macrosArkadiy Illarionov
Change-Id: I4e9af3b43a5baf19e100f42b3f37a2ade89ada5d Reviewed-on: https://gerrit.libreoffice.org/73320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-02drop some unneeded includesCaolán McNamara
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-01fix addGraphicFilterCaolán McNamara
Change-Id: I44ee2c53bd1f95c08f2d4d6b6cd7af93a0001c9c
2019-06-01Resolves: rhbz#1715109 add All files to the graphic import dialogCaolán McNamara
to pick up things without extensions, for consistency with file->open Change-Id: Ib119fb0d053d1d288eee7cd17fa4f12dcb9956d7 Reviewed-on: https://gerrit.libreoffice.org/73276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-01Related: rhbz#1715109 'All formats->All images'Caolán McNamara
because it lists just image formats, not all formats. "image" is what seems to be the word of the moment for graphics/pictures/etc so use that Change-Id: I85c8abd11a121ce000f2850857a967fada11e809 Reviewed-on: https://gerrit.libreoffice.org/73275 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-31tdf#125578 force webhelp as workaround for Safari sandboxing w/ macOS 10.14Christian Lohmaier
Sandboxing prevents access to files in user profile as well as to contents of the LibreOffice.app unless it is manually triggered by the user. Even a clicking a link pointing to the files on an automatically opened file is not enough, the user would have to copy'n'paste the target. As a workaround force online help when default browser is Safari and running on 10.14 or later. (other browsers don't seem to enforce sandboxing yet and continue to work) also fix error in the meta tag for the intermediate page (delay and URL are both part of the content attribute and not separate) Change-Id: I6cc50ec1b1928c2416fdfef4cf50e2196a8594ae Reviewed-on: https://gerrit.libreoffice.org/73163 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-05-31remove newly unused SfxTabDialogCaolán McNamara
Change-Id: Iebbfe2ab66ff6e058c90c85de747f549cbc36aa5 Reviewed-on: https://gerrit.libreoffice.org/73156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-30Don't pass escape key event to SfxDockingWindow from sidebarJim Raykowski
...docking window Missed this in recent rework concerning key input events in SidebarDockingWindow, tdf#125525 Allow shortcut keys from sidebar docking window. Change-Id: I53906251918874d2613795cb06a3e6ef07509bd8 Reviewed-on: https://gerrit.libreoffice.org/73192 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-29weld SfxDocumentInfoDialogCaolán McNamara
Change-Id: I79d5d8973a19c0e639081ec61ac596620518d0b5 Reviewed-on: https://gerrit.libreoffice.org/73145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29weld SfxCmisPropertiesPageCaolán McNamara
Change-Id: I3a824acd126dcbd3bde60ca9d68afd79cb708ed8 Reviewed-on: https://gerrit.libreoffice.org/73126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29ellipsize over-large locationsCaolán McNamara
Change-Id: I154f97d8e7f5688e9e81b8590f3dc0ab7d84c380 Reviewed-on: https://gerrit.libreoffice.org/73154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28drop unused boxCaolán McNamara
copy and paste from the normal document info page I imagine Change-Id: Iff40fbf2b4d21dd3d51c63cb6068b0b88b5438ed Reviewed-on: https://gerrit.libreoffice.org/73115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28weld SfxCustomPropertiesPageCaolán McNamara
Change-Id: I1b1ba1c2b879d270eb3af486a4d006f170d1b92e Reviewed-on: https://gerrit.libreoffice.org/73111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28Fix domain in ui files (sfx2, svtools)Julien Nabet
Change-Id: Icfa8a2d2f6283b0961aa99debadf1e3d29ddaa53 Reviewed-on: https://gerrit.libreoffice.org/73068 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28tdf#125525 Allow shortcut keys from sidebar docking windowJim Raykowski
Fix for tdf#115434 prevents key presses being passed through to document window from the sidebar docking window. This patch only prevents left, right, down, up, page down/up, home, end, backspace, delete, insert and return keys from being passed. Change-Id: I97ab60a214cb9910f526a475f3134784728b7d9a Reviewed-on: https://gerrit.libreoffice.org/73073 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-27Update URLAndrea Gelmini
It's not accessible since 2006. Use Wayback Machine copy Change-Id: I41e7467d9feb31987080ac43dfd11a2e30ebeb28 Reviewed-on: https://gerrit.libreoffice.org/71233 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-23tdf#125447 get rid of ~ in STR_UNDO stringCaolán McNamara
Change-Id: Ifdd3df50b98641785a4b1d258092efe531e98e7d Reviewed-on: https://gerrit.libreoffice.org/72870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23Resolves: tdf#125447 mnemonic appearing in tooltipCaolán McNamara
Change-Id: I570af8f19468730aad714425492f69d05c0a0cf3 Reviewed-on: https://gerrit.libreoffice.org/72852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23sw: add IgnoreComments parameter to .uno:PasteMiklos Vajna
Which allows not hardcoding true for LOK. Change-Id: I644763ba052b148fc34283e361aa02f9bba2c5ee Reviewed-on: https://gerrit.libreoffice.org/72832 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-22New loplugin:dataStephan Bergmann
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-21route delete-event through cancel handler if availableCaolán McNamara
for sync gtk dialogs too Change-Id: Iad40c539a663504d72f372a0d3b4427a23e717c4 Reviewed-on: https://gerrit.libreoffice.org/72626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-21tdf#125384 allow setting initial tabpage before dialog is runningCaolán McNamara
Change-Id: I79ad38e05e6b66089a0ed47d4054d416b8c61ff8 Reviewed-on: https://gerrit.libreoffice.org/72633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20tdf#125358: initialize nHeight to 0Xisco Fauli
Change-Id: I273abe32f1928f5fccb5ba02b3b77958dde58220 Reviewed-on: https://gerrit.libreoffice.org/72530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-05-20split width/height to allow intercept of how width is calculatedCaolán McNamara
in order to possibly get width on demand Change-Id: I1e6fcb6849705f2b166821516ebe72b179e00ee7 Reviewed-on: https://gerrit.libreoffice.org/72513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-19Fix nillability of ooSetupLastVersionStephan Bergmann
...that had been introduced with 5187d3ae495a07373a12fd5980c9269bc8ce3f8f "Resolves: tdf#69042 - Add a 'What's New' infobar": * Make the default value nil instead of an empty string. * A nilable prop can't reuse the legacy utl::ConfigManager framework to obtain string prop values, so drop it from there and directly use the direct-access functionality in SfxViewFrame::Notify. Change-Id: I5fc67a3d7e0fcb44a218889ecf8c69e81661567e Reviewed-on: https://gerrit.libreoffice.org/72485 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-19tdf#123793 Follow up fix for kb nav of special chars popupJim Raykowski
Static variable use to determine if initializing can focus properties of recent and favorite controls is needed only allows init to ever happen once. This patch changes use to a member variable. This corrects the problem of kb navigation only works the the first time the popup is shown and tab is used to navigate. Change-Id: I2bbb66071b582c9a4282c79d801b4a36c375ed2d Reviewed-on: https://gerrit.libreoffice.org/72264 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-18remove remaining '0' responsesCaolán McNamara
Change-Id: I3134c8dcc92b82ab2c6008b3e39443a360f576eb Reviewed-on: https://gerrit.libreoffice.org/72499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17Resolves: tdf#69042 - Add a "What's New" infobarheiko tietze
Shows an infobar with a link to the respective wiki page Adds a button to the About dialog Replaces If6eb1542d2ad310226f76850f480f2f99070b803 Change-Id: I1eeb504994a6364feb90cfa447029875e0ec1969 Reviewed-on: https://gerrit.libreoffice.org/72218 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-15tdf#42949 Fix IWYU warnings in unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also recheck include/unotools/* Change-Id: I3b8489aca69fbe80fa4a21748ac3c872d0d266c4 Reviewed-on: https://gerrit.libreoffice.org/71883 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-14Related: tdf#125266 set default dialog parent for SfxHelpCaolán McNamara
Change-Id: I375eeff07fd9c5fce4e037c5b6fd849570fb67c9 Reviewed-on: https://gerrit.libreoffice.org/72299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13Auto-redact - First stabMuhammet Kara
Add a SfxRedactionHelper::autoRedactPage method which searches for the given term through the gdimetafile which has the whole content of an xPage (a Draw page), and draws redaction rectangles at proper positions with proper sizes. The search is case sensitive, and finds only the first occurences on a line. Will switch to a proper search provider via a follow-up patch. Change-Id: If3db62e50994670143785b6727fdcf1ccd4c6f8e Reviewed-on: https://gerrit.libreoffice.org/68597 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13Handle *link return value in sfx2 testJan-Marek Glogowski
Change-Id: I63008858558312b5fb7378249c56fbc3729c9a19 Reviewed-on: https://gerrit.libreoffice.org/72180 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-12regenerate PCH headersLuboš Luňák
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-11tdf#123793 Add kb tab navigation to special chars popup windowJim Raykowski
...and keep the 'More Characters...' button as first focused Change-Id: Iab4cb00aaed9250f0cc7f35f27af48eb326f2a48 Reviewed-on: https://gerrit.libreoffice.org/71834 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-11Fix typoAndrea Gelmini
Change-Id: Ibf2f7fec9b8840d8a844def4228415d8bcc9f142 Reviewed-on: https://gerrit.libreoffice.org/72141 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-10CppunitTest_sw_tiledrendering: close the document while LOK is still activeMiklos Vajna
This is the same type of problem that was fixed for CppunitTest_desktop_lib in commit da17ccaec39f50de68c3fdd431bc66a2bec04127 (CppunitTest_desktop_lib: close the document while LOK is still active, 2019-05-09). Change-Id: I2fe050bf40d68dafa0334f4149e54958c492122d Reviewed-on: https://gerrit.libreoffice.org/72126 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-10tdf#116629 added chevron icon for noteboookbar hide buttonSumit Chauhan
To test the patch , cherry pick this icon-patch first https://gerrit.libreoffice.org/#/c/72082/ Change-Id: I706aee5695a2e275095832070382a9def4d89611 Reviewed-on: https://gerrit.libreoffice.org/72107 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-05-10handle empty tools::Rectangle in sfx2Noel Grandin
Change-Id: I468108c74480e61215a85232421e8ce1a00e846d Reviewed-on: https://gerrit.libreoffice.org/72058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09add a way to specify SfxRequest preferred dialog parentCaolán McNamara
when the parent isn't a XFrame, i.e. want the parent to be an open dialog Change-Id: I2dfaac1fd057095de154de549e9f395ce30d118b Reviewed-on: https://gerrit.libreoffice.org/72034 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09loplugin:unusedmethodsNoel Grandin
Change-Id: I7b4d2e5e611935284e2902b0089950768dfb7717 Reviewed-on: https://gerrit.libreoffice.org/72036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09loplugin:unusedfieldsNoel Grandin
Change-Id: I8dc5a6ef84f43bad0bee26592b3a8e95c58e6f22 Reviewed-on: https://gerrit.libreoffice.org/72027 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-08Respect page margins of the source doc during redactionMuhammet Kara
Change-Id: Ieaa50a2eba17145180ddd5d2bfc77add4801c43a Reviewed-on: https://gerrit.libreoffice.org/71929 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-05-07unipoll: emit user input-events & uno commands directly when in unipoll mode.Michael Meeks
Rather than emitting asynchronously at idle. Change-Id: I6c72e9fad0b5587941e3a4a4d17d331a0d889942 Reviewed-on: https://gerrit.libreoffice.org/71809 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>