summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-03-21Notebookbar: correct initial icon sizeSzymon Kłos
Before this patch initial icon size in the NotebookbarToolBox was determined by Sidebar settings not Notebookbar Change-Id: I66ac709c606ef60fb3505bbbe51dfebbcc81d20c Reviewed-on: https://gerrit.libreoffice.org/35493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-20uitest: use the new ui test logger also for the UNO commandsMarkus Mohrhard
Change-Id: I220b817df82cd0f26f6d8b72a28b7becfd954461 Reviewed-on: https://gerrit.libreoffice.org/35448 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-19uitest: add a way to log the UNO commandsMarkus Mohrhard
Change-Id: Ibbf7fd8e44b0be82e496eab6d98468f03038e60f Reviewed-on: https://gerrit.libreoffice.org/35441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-19Use just geParameter instead of hasParameter + getParameterMatteo Casalin
getParameter returns and empty string if the key is not found, so we can just avoid searching twice for the same key. Change-Id: Ic48debce05fe94d8e087b64bde5a589e54bfb616
2017-03-19OUString-related simplificationsMatteo Casalin
Change-Id: I2f4099410bcdb9e04583cd37bf63ef86ce81f7e5
2017-03-19Can return const OUString&, hereMatteo Casalin
Thanks to Noel Grandin for his suggestion. Change-Id: Ia0d9c46c03928e5551e766572c814f4e9ba6f278
2017-03-19SfxViewFrame::ExecReload_Impl - remove written-only variable aURLMatteo Casalin
Its only user was commented-out by commit 6c1be80980cbf02ecaf07996b1c2be5777f59124 (2004) and then removed by commit 40fe03745fc75609350cf8115134eb07f04eefa7 (2010) Change-Id: I821a97275b79230e9e389a9b57c82110fa16aa8e
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19fix typo/grammar: "the the" --> thedennisroczek
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: https://gerrit.libreoffice.org/35151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17SfxObjectFactory: directly store factory name as OUStringMatteo Casalin
Change-Id: I0779be1e4b344124514115c6645394d26ac09c36 Reviewed-on: https://gerrit.libreoffice.org/35375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Remove SfxObjectFactory::GetShortName()Matteo Casalin
Used in just two places, where GetFactoryName can also work. Change-Id: I8d498345c41aef520ef776a3deb6744cc64756f5 Reviewed-on: https://gerrit.libreoffice.org/35374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Use SfxObjectFactory::GetFactoryName, againMatteo Casalin
Change-Id: I653fdaa2564a97716e400b509eb7408ffe6050a3 Reviewed-on: https://gerrit.libreoffice.org/35373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Simplify same assignment in both branches of a conditionalMatteo Casalin
aTitle was assigned GetTitle() in both branches since initial commit (2007) Remove the (used just once) temporary, while at it. Change-Id: I0c6cb0ef8f720fea7f4105edf8233a2c64377e4f Reviewed-on: https://gerrit.libreoffice.org/35372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Use SfxObjectFactory::GetFactoryName/URLMatteo Casalin
instead of OUString::createFromAscii( GetShortName() ), in one case manually added to factory URL prefix. Change-Id: I762fc1bcd6dcf7246531816faad2682caf9133fb Reviewed-on: https://gerrit.libreoffice.org/35371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17cleanup double includes and declarationsJochen Nitschke
Change-Id: I770e09f48b1a3e8299f59a8e475ba3c18d436d7b Reviewed-on: https://gerrit.libreoffice.org/35312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17remove unused defines from HRC files in sfx2Noel Grandin
Change-Id: Iffe6508558795e059048acae2ca955a78d3e9d6d Reviewed-on: https://gerrit.libreoffice.org/35279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17gpg4libre: Also show Infobar when signature is validSamuel Mehrbrodt
Change-Id: I5eb639d5cc298b595ccee71f00c1f2fc54867186 Reviewed-on: https://gerrit.libreoffice.org/35287 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-16No need to keep these booleans as data membersMatteo Casalin
Change-Id: Id56cb074a3b62423769afc3c4a3ab2f7a312f1be Reviewed-on: https://gerrit.libreoffice.org/35284 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16tdf#103355 Working menu after closing slideshowSzymon Kłos
Change-Id: Ic6bfb6f9a86d9c475d2d3368b924b56a89c90551 Reviewed-on: https://gerrit.libreoffice.org/35251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-16Notebookbar: fixed crash after customizationSzymon Kłos
+ removed listener + prevent from using invalid pointers Change-Id: I3a846d2344148456d3edba23296a4781496eba8b Reviewed-on: https://gerrit.libreoffice.org/35248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-15tdf#105040 Notebookbar: added shortcuts toolboxSzymon Kłos
In the tabbed notebookbar the shortcuts toolbox is introduced. It is placed before tab labels, after the menu button. Customization is possible, buttons are loaded from the newly created toolbar "Notebookbar shortcuts". NotebookbarTabControl was moved to the sfx module. Change-Id: Ifa4a1688c6e92c2f03bd386608e3e9d1c28069d4 Reviewed-on: https://gerrit.libreoffice.org/35194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14remove noise UUUU tags in commentsNoel Grandin
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00 Reviewed-on: https://gerrit.libreoffice.org/35161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13tdf#95416 remove ../ in #include headers of sfx2 filesJeevan
Change-Id: I5f3e1a8fe559500aec7ea9e38edaba42dff3f98b Reviewed-on: https://gerrit.libreoffice.org/35028 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-11Fix typosAndrea Gelmini
Change-Id: Ia79bc8d35cf19438d177f31a8e0c8603102b4ef1 Reviewed-on: https://gerrit.libreoffice.org/35061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-10shuffle this around a littleCaolán McNamara
Change-Id: Ibf23114885c49163d50b3249db8788770fe74352
2017-03-09Clean up uses of integer typesStephan Bergmann
Change-Id: If022ca9de8db49b885065c32b4f6f89debae1392
2017-03-08Simplify GetStateCache callStephan Bergmann
Change-Id: I527d8112f7cf0e4fbc6380484be0c6704f3dfdd4
2017-03-08No need for extra heap allocationStephan Bergmann
Change-Id: I69435ff2be66f8b2ed879bdf7998bd8145ef59b4
2017-03-08valgrind: fix leakCaolán McNamara
Change-Id: I49a9a03ef59bca5a5c43d2835e6c4f1cbf0cfab8
2017-03-08loplugin:loopvartoosmallStephan Bergmann
Change-Id: I788afd92bb404d8faf96b631d2e7c6f869e49c2d
2017-03-08make SfxGetpApp just get and move GetOrCreate to the peripheryCaolán McNamara
Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32 Reviewed-on: https://gerrit.libreoffice.org/34957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-07shouldn't need these SfxGetpApp as it will already existCaolán McNamara
SfxGetpApp will get or create SfxApplication in normal use we start SfxApplication via SfxGlobalEvents_Impl ctor theGlobalEventBroadcaster right from the start in Desktop::Main Change-Id: I5fec2dfb79c8bc322266048603252a9aa93a883f
2017-03-07Notebookbar: don't show unnecessary separators in the popupSzymon Kłos
Change-Id: I89d11e2859676696e7bc0751ae9e71e5ae939a79 Reviewed-on: https://gerrit.libreoffice.org/34945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-07only one use of GetLastSaveDirectoryCaolán McNamara
which is to get its value and do a const_cast dance to save and restore its value which is a strange thing to do just for one obscure dialog when no other use of the save/load dialogs does this Change-Id: I7700d7ed738d578869284d415197de06167001b5
2017-03-07can use a reference hereCaolán McNamara
Change-Id: I3e9599e92679a66cae410090b5d17651a3698cce
2017-03-07Add Tooltips for emoji toolbar controlAkshay Deep
Change-Id: I93d9fb1af42d83c7f7f518a1441f4666fd7ee30a Reviewed-on: https://gerrit.libreoffice.org/32231 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-07remove dead codeJochen Nitschke
was deactivated in 2010 by commit 9334f7757330fdd113d37b3faed728e56e6330c8 Temporarily disable the extra ACL check. Change-Id: Ia9d2b7f55285e78f0737bf798b627740ccb11979 Reviewed-on: https://gerrit.libreoffice.org/34937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06convert ScrollingMode to scoped enumNoel Grandin
Change-Id: Ice1628ba09998be455fd6a77a044cb403235d462 Reviewed-on: https://gerrit.libreoffice.org/34914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06make use of the SfxItemSet::GetItem<T> methodNoel Grandin
Change-Id: I8201429993129b019a6dd51c203a9f8dcbb2253e Reviewed-on: https://gerrit.libreoffice.org/34867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06templatize HTMLEnumOption::GetEnum methodsNoel Grandin
And consequently fix bug in htmlfld.cxx in the RES_DOCSTATFLD/SwDocStatSubType handling, where it was updating the m_bUpdateDocStat fields by comparing the wrong enum variable. Change-Id: If9a68699a9d375ace120a3bf4f4bf4d4ae20a8e0 Reviewed-on: https://gerrit.libreoffice.org/34857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03lok: Listen to change tracking related commandsPranav Kant
Change-Id: Ieafd31342b356d7e95e4321cc49580b57f32e5be
2017-03-02Fix typosAndrea Gelmini
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01Correct indentation of try blockTor Lillqvist
Change-Id: I32ca961ebb4393e483bab12a6c69ab4c2016cc3f
2017-02-28loplugin:unoanyStephan Bergmann
Change-Id: Id50b15bbb9f8c62ac5258358431ff6ce0e7584d1
2017-02-28don't have to create SfxApplication if none existsCaolán McNamara
Change-Id: I312f00e8b2956470eaa496abfa2687c296f256ae Reviewed-on: https://gerrit.libreoffice.org/34717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28might as well move append 'usage' into the msConfigPath from the startCaolán McNamara
Change-Id: Ie8a15f1a20621ebdd00ab4ed195495e0acd111a5
2017-02-28Revert "move append 'usage' into the msConfigPath from the start"Caolán McNamara
oops This reverts commit dc1c69a4efe9368a1f4fae4bc11325485bcc0772. Change-Id: I5fb9016040636fb44d4337567a6b894bfe16f503
generated by cgit (git 2.34.1) at 2025-02-04 07:56:08 +0000