Age | Commit message (Collapse) | Author |
|
Most of the constructors are supposed to be only a call of
new TheInstance(arguments)
or an equivalent; so let's just change the constructor caller accordingly, to
accept unacquired new instance.
If there are exceptions that need to do more heavy lifting, they do not have
to use the constructor feature, or there can be a wrapper for the real
implementation, doing the additional work in their (C++) constructor.
Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
|
|
There is no need to use different styles for writing the same thing.
It also makes it easier in future to use search & replace.
But of course, there are also some more complicated functions.
Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
|
|
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
|
|
Change-Id: I9f5564100aa64ff4940dd93a81ff5a8d8edc7a07
|
|
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
|
|
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
|
|
Change-Id: Ia6c1db331b5b4db04c46b75b2058bf2f1369070b
|
|
to have access to its own path
(cherry picked from commit bc89d402b3df00c2402ac86896eb2ce4c3f7b7d0)
Conflicts:
sfx2/source/appl/fileobj.cxx
svgio/source/svgreader/svgimagenode.cxx
svx/source/svdraw/svdograf.cxx
Change-Id: I4f3e98588f17b4271465359a7f56f9845029e012
|
|
...as they are not only called from the service manager (which takes care of
singleton constructor functions since 997d21183322a0a94b96868073808841d2773902
"Support for singleton constructor functions") but potentially also directly
from cppumaker-generated code (which is the raison d'être for constructor
functions, after all).
However, this change:
* postpones the instance's destruction to atexit, with all dreaded consequences;
lets see how that pans out.
* makes it questionable whether the service manager holding references of these
singletons (introduced in 997d21183322a0a94b96868073808841d2773902) is
necessary after all; lets revisit that in another commit.
Change-Id: I0a2c902ab62045df1af382d190747e34b80236d3
|
|
This reverts commit ef37781683e28d1837cfce86de990e59d2c10c5f, now that
constructor function support for singleton implementations is in place and the
proper singleton theGlobalEventBroadcaster has been introduced (and drops
sfx_component_getFactory completely, which had become unused except for
SfxGlobalEvents_Impl in the meantime).
Change-Id: I2d587989dd0a1fbea6fe75f7dc2af954ac81c4ed
|
|
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance
service.
Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
|
|
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
|
|
even though they are in different containers
Change-Id: I785166c577acab03608da10fb4a33072458a82cd
|
|
Change-Id: If02c029114e9531951b18abeb9d0afd0a18ceca3
|
|
Change-Id: Ia461b8315ddd07adcb5609aefa85385db17ebba4
|
|
Change-Id: Icd387ff97c5df3cea9b20b0b893616812457e493
|
|
Change-Id: I3af683cdc273fa8cb9224a0f1f7d342a140c9dd7
|
|
This reverts commit 9b73d3a4cd9c1aea29b51b1b23d0a44c34f2f8a2
because it breaks unit tests.
Conflicts:
sfx2/source/appl/appuno.cxx
Change-Id: I7b2d2dc6ff8ade2c8dd29602827313c7bb01f97d
|
|
Change-Id: Ie0e66ac6c76eabb80340d4c11b60dd7890c6a378
|
|
Change-Id: I5bc7844c74043640494330fefc87914d4c02b768
|
|
Change-Id: I604132c35cf95ecb3a4dad0bfef5ec50dfa58645
|
|
Change-Id: If0e20538b85057c52a953a7559f6e7cb75d2fe33
|
|
Change-Id: I18ab7ed8785c63688eecdcdb77289e1691ba793d
|
|
Change-Id: Ib1eb1ccf9c5fbbec84eb8f49395651e9219b7b97
|
|
Change-Id: Ie93235666e035d6a594cfbe112f7a0d935dae1c4
|
|
Change-Id: If992d847e385bd7968a4d8e491f957f8afcc9377
|
|
Change-Id: Id63d9e29905c63dddaf44f8eab5fdc5b670fc6bf
|
|
Change-Id: Ibfcd2954b20def05d2a7db36f5ccc0b570305441
|
|
Change-Id: I603198b9fd2c6fea1c9ec7de09b23c61fe9d603c
|
|
Change-Id: I2ca8abb284e8441a49c6e96a10cf76b5680e48e2
|
|
Extract that class to its own source file.
Change-Id: Idc192354b88d4489db22f6f6e9b7f5178f4030e4
|
|
Change-Id: Ic6283b7a71a5d1c539ae99155f448e34e877080a
|
|
so we can safely change the return of 0xFFFF to 0 without
changing any callers. Which makes this safe seeing as before
now every caller would have done something stupid with the
results
Change-Id: I10d9f12525de10661ed82f3405e6c728d38be106
|
|
Change-Id: I32b458390130e9ed83af0831069329ac8f672d67
|
|
Change-Id: Ie62a6c1197594102bc68e246ae6059a9442ce314
|
|
Change-Id: I3c0804d35c5ff7a00ec7169d0ab387f4b63d65d3
|
|
Change-Id: I39a854910299ab2e7c64beabda381bb9f0bd2891
|
|
Change-Id: I2439ed19b554381f80e882aacbac05167622df92
|
|
Change-Id: I0ad9422d574c8629953fd95f0d334617c042c60f
|
|
Change-Id: If7a9f6f0538c33ec1eca3f33f23ad6a76908a98c
|
|
Thanks Stephan Bergmann for the idea.
Change-Id: Ifdde1b7eaaefd30a176c47385bc9bfec48d5b86c
|
|
...and SfxEnumItemInterface::HasBoolValue, too.
Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
|
|
Change-Id: Ia433adb26e820b89c4d207d018d0daf42654b4a0
|
|
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Use INetURLObject to get a readable url (it displayes special characters
too). It is a side effect that 'file:///' prefix disappear
which seems a good thing.
Plus some cleanup: remove second INetURLObject.
Change-Id: I4aab5e2546ae70e5a3d85b12e26e021bfa244999
|
|
Change-Id: I7ac4b51868d1a5828c810b1ac629d5a56ffb6f50
|
|
Change-Id: I01f2911c690da36ed0d5beb306e28ab438890fd9
|
|
It breaks things.
Change-Id: Ia28391aed27051e5f6a7e0996f30b23c46eb8269
|
|
Change-Id: Ie21f8a62213954da7f66c1fbe890ba9dee93cf77
|
|
mnHighItemId is never assaigned with a valid value and there is
no sense to store one selected element's index anyway,
because there can be more.
The bMove parameter of ImplGetItem is never used and doesn' work
so remove it.
Change-Id: I91d6bc3fd13a2b44e6961fea66d02702a8f31c2b
|