summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2019-01-03Fix build: missing includeTamás Zolnai
Change-Id: I3f2dfedfd7869e1206dd48f1f99bfc2ddf11213b
2019-01-03sfx2: missing includeMiklos Vajna
Change-Id: I1367a97035c3c03f2d4081b8c3e67ffbe86d8919
2019-01-03Redaction: First stepsMuhammet Kara
- Add an uno command to create an empty draw document - Create a meta file from the first page of a Writer document - Insert meta file to the draw page - Doesn't work with normal/default view on big/high-res screens because of a bug in the MapModes. Manually setting zoom level to %200 or "Page Width" (to get rid of the extra space around the actual page) works for now as workaround. Change-Id: I05a987617efdda6690400ef550b81b58b21aa27e Reviewed-on: https://gerrit.libreoffice.org/64858 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-01-01lok: add signDocument to "Office" iface - to sign not opened docs.Tomaž Vajngerl
LOKit function "signDocument" can sign document without the need to open them. This is useful to sign PDF documents after they are created from a currently opened (ODF, DOCX) document. This adds DocumentDigner to sfx2, which could also be used in desktop LibreOffice without opening them and in further tests. Change-Id: Id6f242e817f594aa672f94f9c6f9b34e4035d46a Reviewed-on: https://gerrit.libreoffice.org/65767 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-01Bump copyright year to 2019Adolfo Jayme Barrientos
Change-Id: I0d49ec7db57a0f7d18489dad61e86cbfdf4418cd
2018-12-31Remove some useless whitespacesTomaž Vajngerl
Change-Id: Iebf7add3dd937afb6dad07a10ecbe768c0a79d36 Reviewed-on: https://gerrit.libreoffice.org/65764 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-31Provide keyboard navigation to Shortcuts tool box and Hamburger menu inJim Raykowski
NotebookbarTabControl Use Ctrl+Right/Left arrow to move focus among current notebookbar tab control tab title, hamburger menu, and shortcuts tool box. Change-Id: Ia7b22ff03fce7148eb411cfe9eaabc247b737cb5 Reviewed-on: https://gerrit.libreoffice.org/63875 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-12-24tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I5ca32214bab4b26208aecaa98eecc2a6297d9093 Reviewed-on: https://gerrit.libreoffice.org/65592 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-21Fix typoAndrea Gelmini
Change-Id: Ic267dfa4946c37b487fee1bd8a7c4d644b2625ca Reviewed-on: https://gerrit.libreoffice.org/65516 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-20Silence -Werror=shadowStephan Bergmann
Change-Id: Ie1fcda19141a12dfe2b965d88e16c85cc2a64cb2
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20Enable --help=html for flatpakStephan Bergmann
To not increase the size of the main org.libreoffice.LibreOffice app further, the plan was to realize this as an org.libreoffice.LibreOffice.Help extension. Ideally, this would be a localized extension, so that, by default, only a relevant subset of the extension would be downloaded and installed. (But see below.) There are multiple technical problems, as discussed at <https://github.com/ flathub/org.libreoffice.LibreOffice/issues/35#issuecomment-447295308> "Add integrated LibreOffice Help offline": * LO can't pass a file URL with query part to xdg-open, so uses a temporary wrapper .html file that redirects to the target URL. But for the flatpak case this wrapper can't be in /tmp (which isn't visible from outside the flatpak sandbox), but is instead stored in a new temp dir under $XDG_CACHE_HOME (which is always set for flatpaks and /is/ visible form the outside) that is removed on LO exit. * The file URL stored in the temp file must be rewritten from the internal path (/app/libreoffice/help/...) to the path as seen outside the flatpak sandbox. While the path for the org.libreoffice.LibreOffice /app is stored in /.flatpak-info, the external path for the org.libreoffice.LibreOffice.Help extension is different and not stored there. So use a hack trying to construct that path from what information is available in /.flatpak-info. * But the help content consists of locale-specific and shared files, and those reference each other with relative links. But a localized flatpak extension cannot contain shared files, it can only contain per-language sub-dirs. And if the shared help files were kept out of the extension, as part of the app itself, the relative paths among these files inside the flatpak sandbox would differ from those outside of it, so would be broken when viewing the content in the external browser. A solution would either (a) need to somehow rewrite the content of all the help files being served from LO to the external browser, or (b) replicate the shared help files in all the extension's per- language sub-dirs (and if some localization uses en-US content as a fallback for only part of its translated content, e.g., in the case of media files, would need to also replicate that en-US content), or (c) use a non-localized extension that always contains the content for all localizations. For now, I chose the third approach. This makes the org.libreoffice.LibreOffice.Help extension relatively large (the current /app/libreoffice/help tree has a size of ca. 100MB), so that I decided to not have it downloaded and installed automatically ("no-autodownload": true in solenv/flatpak-manifest.in). (I checked with Flatpak 1.0.6 that if the extension should be changed to a localized one with the same name in the future, updating from an older version would work. If the old extension was not installed, just the relevant localizations of the new version will be downloaded and installed. If the old extension was installed, the full set of localizations of the new version will be downloaded and installed.) (As also mentioned at <https://github.com/flathub/org.libreoffice.LibreOffice/ issues/35#issuecomment-447295308>: "A second, minor, nuisance is that, for security reasons, an `xdg-open file:///...html` call from a flatpak leads to an intermediate popup dialog letting the user chose which application to use to open the URI, while e.g. an `xdg-open http:///...html` is allowed to go directly to the user's preferred browser. So accessing help content from LO flatpak would present that popup dialog first, forcing the user to select a browser to proceed.") Change-Id: I35f5a23947dd551dc1b9bff1dd2abd6710073b5f Reviewed-on: https://gerrit.libreoffice.org/65451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-20use unique_ptr in sfx2Noel Grandin
Change-Id: I4e0bba9b8bebdeb9263ad71d3ab505d8beed17b7 Reviewed-on: https://gerrit.libreoffice.org/65441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19store GroupData_Impl using unique_ptrNoel Grandin
Change-Id: Ib2f00c10b91ced44c7476290360485c8550ec718 Reviewed-on: https://gerrit.libreoffice.org/65339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18use unique_ptr in SfxDocTemplate_Impl::InsertRegionNoel Grandin
Change-Id: I6b94e0eec328e5b94d20fad011f1ce79e0b2fe84 Reviewed-on: https://gerrit.libreoffice.org/65335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18use unique_ptr in SfxMediumListNoel Grandin
fixing leak in SwGlobalTree::DialogClosedHdl Change-Id: I4a8e883bfe62181d4e332b3a0bbb85bbb332f711 Reviewed-on: https://gerrit.libreoffice.org/65333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18use unique_ptr in GraphicHelper::getFormatStrFromGDI_ImplNoel Grandin
Change-Id: I54d0f2138763acf5addae53051ca842b878f5680 Reviewed-on: https://gerrit.libreoffice.org/65334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18When showing --with-help=html offline help fails, fall back to online helpStephan Bergmann
Change-Id: I6a74b94adc26923f9e83dd09d9b1d077a73b5d05 Reviewed-on: https://gerrit.libreoffice.org/65322 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-18use unique_ptr in FileOpenDialog_ImplNoel Grandin
Change-Id: I530d26a489a130c9fdfa105b3891d21cbfeb3379 Reviewed-on: https://gerrit.libreoffice.org/65305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18Add SfxModelGuard to setArgsSamuel Mehrbrodt
Follow-up to 43a63b725208bfa378355011ea56cb936afa4411 Change-Id: I39d80abdb541909b3cfa4651317c9c9f478e42ca Reviewed-on: https://gerrit.libreoffice.org/65312 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-12-18Simplify ShowLockedDocumentDialog argument listMike Kaganski
No need to pass file URL explicitly - it's available as GetURLObject(). commit 607b80ca3cddc239a35580470944a438ce144fc8 follow-up. Change-Id: I6a2ceb6d3ae78c277f40215082af22112f9e2d27 Reviewed-on: https://gerrit.libreoffice.org/65300 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-18tdf#116320: properly decode file name for File Locked dialogMike Kaganski
Change-Id: I51bd7c6695ef52b08e0b6d809160d74daebb8505 Reviewed-on: https://gerrit.libreoffice.org/65298 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-17Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-17Remove unnecessary OUString aInternalStephan Bergmann
Change-Id: I37112fdb971a60012a4cb4f1aebfbb79dda3f92e Reviewed-on: https://gerrit.libreoffice.org/65258 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-17Allow setting some MediaDescriptor properties during runtimeSamuel Mehrbrodt
Change-Id: Id6bb554c0e165c6d1f9c28c48fdbcd7156f42316 Reviewed-on: https://gerrit.libreoffice.org/65256 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-12-15tdf#122112 Hide the menu bar when the notebookbar is lockedXisco Fauli
Only reproducible with GTK3 (maybe KDE5?). This way we ensure a uniformed behavior across vclplugins anyway Change-Id: I6edd6a426cb206d797b504ddcdcef999f79fa3c8 Reviewed-on: https://gerrit.libreoffice.org/65189 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-14lok: Handle Special character menu item's state correctly in onlineTamás Zolnai
Change-Id: Iaa962fe5a590ef16e710fdd49d02d564f10f0f9f Reviewed-on: https://gerrit.libreoffice.org/65188 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-13Be less eager to use a fallback in SfxViewShell::SetLOKLanguageTag()Tor Lillqvist
If the fallback language tag based on available localisations would have the same language as the original Bcp47 tag string, use a tag based on the original. For example, if the user locale is 'de-CH', the localisation for plain 'de' will be used automatically anyway, without making the LOK language tag 'de' which would actually end up being stored as 'de-DE' and thus be misleading. We will need to know that it's the 'de-CH' locale we are actually working with when handling Swiss German translations by replacing 'ß' characters in a generic German translation with 'ss'. Do it only when comphelper::LibreOfficeKit::isActive() to avoid modifying behaviour in the "normal" cases. Change-Id: Ib5bdfe07fd53251b42122389cb81782ef87b65c5 Reviewed-on: https://gerrit.libreoffice.org/63446 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-12-13use unique_ptr in SfxWorkWindowNoel Grandin
Change-Id: Id7133fd21a0d0d2a3138ba5f27e7637c9ed65d78 Reviewed-on: https://gerrit.libreoffice.org/65024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:constantparamNoel Grandin
Change-Id: I389f98d06058ba65a8c2d4df2bf7d4e5102659ad Reviewed-on: https://gerrit.libreoffice.org/65017 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12tdf#122009: Hide notebookbar in full screenXisco Fauli
Follow same logic as in presentation mode. See 6a9326803c01f4c9bc7da855053ce4e80646fad8 Change-Id: I89c31e23dd97e647ab380aa30635acda46064b2f Reviewed-on: https://gerrit.libreoffice.org/64911 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-12use unique_ptr in SfxChildWinContextCtorNoel Grandin
Change-Id: I5ad26f30704708aac42f2c48fa38382c38f98b2a Reviewed-on: https://gerrit.libreoffice.org/64998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12use unique_ptr in SfxChildWinCtorNoel Grandin
Change-Id: I155036f6a47c765595938ff325ede6bbe6dd5c48 Reviewed-on: https://gerrit.libreoffice.org/65000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12use unique_ptr for SfxChildWinFactoryNoel Grandin
Change-Id: I4305310ea296a5326838759742b14e687158d426 Reviewed-on: https://gerrit.libreoffice.org/64954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-11use unique_ptr for SfxChildWinContextFactoryNoel Grandin
Change-Id: Id0e30c5e591e7fb4b21fb55d47d15a5936fe1374 Reviewed-on: https://gerrit.libreoffice.org/64934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-08crashtesting: doubly deleted reloadtimerCaolán McNamara
since... commit 0cc702232e4799f03a468d1e8014d050a683165e Date: Tue Dec 4 15:00:43 2018 +0200 use unique_ptr in SfxObjectShell_Impl Change-Id: I3f3b0514bdb87f59d9c5f34d2d36dc63e8b1e33d Reviewed-on: https://gerrit.libreoffice.org/64527 Change-Id: I00e2cd2bcbb9a252a45d31da650e327506d2990d Reviewed-on: https://gerrit.libreoffice.org/64780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07loplugin:singlevalfields extend to all static varsNoel Grandin
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528 Reviewed-on: https://gerrit.libreoffice.org/64710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05loplugin:singlevalfields in svlNoel Grandin
Change-Id: I26d11f60f486f3cfe4615828a410789f8e22af48 Reviewed-on: https://gerrit.libreoffice.org/64602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05remove unused SfxCallMode enum valueNoel Grandin
Change-Id: Ie092724ac22088d607f6250fbed764269b3707ba Reviewed-on: https://gerrit.libreoffice.org/64571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxBaseModel::storeSelfNoel Grandin
Change-Id: I73524a15b5ac33ee6243a2e0e563b9986e887e40 Reviewed-on: https://gerrit.libreoffice.org/64528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxObjectShell_ImplNoel Grandin
Change-Id: I3f3b0514bdb87f59d9c5f34d2d36dc63e8b1e33d Reviewed-on: https://gerrit.libreoffice.org/64527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxViewFrame::ExecReload_ImplNoel Grandin
Change-Id: I35a8a3a6ccbf811e529f761f840bfc7acf870056 Reviewed-on: https://gerrit.libreoffice.org/64526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05loplugin:unnecessaryparen include more assignmentsNoel Grandin
Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04Resolves: tdf#121641 properties invisible after 'reset'Caolán McNamara
Change-Id: Iedb2b11be0e008501273925d6ae7137b28c3b912 Reviewed-on: https://gerrit.libreoffice.org/64537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04tdf#34171: check foreign lockfiles to tell who has locked documentMike Kaganski
MS Office (Word/Excel/PowerPoint) lockfiles are supported now. Note that Excel does *not* create lockfiles for pre-OOXML files. This changes osl_openFile implementation on Windows, to treat osl_File_OpenFlag_NoLock to also include FILE_SHARE_DELETE flag for CreateFileW. This is required to allow opening files created with FILE_FLAG_DELETE_ON_CLOSE flag, such as Excel's owner files. The shange should be consistent with the overall meaning of the osl_File_OpenFlag_NoLock to not impose any locking constraints to the file being opened. Change-Id: I7b99012f4bd60ab3821fb91d5166a286031b7e93 Reviewed-on: https://gerrit.libreoffice.org/64496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-04Infobar showing donation alternating with getinvolvedheiko tietze
Change-Id: Ia103201667c3469071f19450589bd22faf3ae80e Reviewed-on: https://gerrit.libreoffice.org/63883 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-04weld OfaAutoCorrDlgCaolán McNamara
Change-Id: Iba217a2998de57bf963872f9b8c1cf38694eb935 Reviewed-on: https://gerrit.libreoffice.org/64476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-15 18:43:48 +0000