summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-03-10coverity#708153 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ifd4e3f792a01d0f806b9d49355463eae79b877ab
2014-03-10coverity#708146 Uninitialized scalar fieldCaolán McNamara
Change-Id: I5c1cb12572100b736152540d1453c7f25dc7a790
2014-03-10coverity#708144 Uninitialized scalar fieldCaolán McNamara
Change-Id: Idbea2d2d0d282cbe131d1b96a0d7bafde3886c3a
2014-03-10drop the SimpleErrorHandlerCaolán McNamara
Change-Id: I968300664c386e6cf33461c5858833832e452e28
2014-03-10fdo#75243: MSO export: save custom properties with empty valueTarun Kumar
LO removes empty properties while saving the doc. This is required in some business scenarios. bSkipEmpty is set to false by default to enable LibreOffice to save even empty properties. Change-Id: I7aafe0c0be02a98fa6e72d73e9e4348a015da61f
2014-03-09coverity#1078732 Dereference null return valueCaolán McNamara
Change-Id: I6008d2ef94979a7b2224ca217a158cbcbb1fd716
2014-03-07coverity#735847 Dereference after null checkCaolán McNamara
Change-Id: I564d00d279d0b1cfee4eead4b9bc9b6e98a3b0f2
2014-03-07Fix deselection problems of template viewZolnai Tamás
deselectItems() were added to make recent docs view work, but it is unneccessary to affect template view too. Change-Id: I0c805774321939991e308e9c8c669604e81dbad5
2014-03-07Revert "fdo#74787, rhbz#1072553: fix Template Mananger import crash"Zolnai Tamás
This reverts commit 6b6ec280f3d7f35fb9c8c8ba92a31d51ab4dca16.
2014-03-07Revert "fdo#74506 fdo#74291 -Template manager-store selection before calling ↵Zolnai Tamás
dialog" This reverts commit a411bf38da3668094698c06c8424aa9d68c85702.
2014-03-07fdo#74787, rhbz#1072553: fix Template Mananger import crashMichael Stahl
File dialog causes call to ThumbnailView::LoseFocus() and clears selected folders. (regression from 0314034d8b23d5b69399cfcdf6b2f2add73f9f47) Change-Id: Ic5f2602e9dd1d12aad8c68c48f6bbb119ee6492c
2014-03-06sfx2: ensure that no timers are running after SfxApplication diesMichael Stahl
Timers may access global data that's tied to SfxApplication, and that seems difficult to fix or prevent; the SfxApplication is deleted before the main thread gets around to handling the PostUserEvent sent by Application::Quit(). log from xmloff_unoapi: ==32095== Invalid read of size 8 ==32095== at 0x934D245: Font::Font(Font const&) (font.cxx:239) ==32095== by 0x1FCEABDF: ImpEditEngine::FormatDoc() (impedit3.cxx:381) [...] ==32095== by 0x1ED0F894: SdDrawDocument::LinkStubOnlineSpellingHdl(void*, void*) (drawdoc4.cxx:826) ==32095== by 0x911FECD: Link::Call(void*) const (link.hxx:123) ==32095== by 0x914F700: Timer::Timeout() (timer.cxx:224) ==32095== by 0x914F394: Timer::ImplTimerCallbackProc() (timer.cxx:121) ==32095== by 0x170B350A: SalTimer::CallCallback() (saltimer.hxx:53) ==32095== by 0x170B26C6: SvpSalInstance::CheckTimeout(bool) (svpinst.cxx:188) ==32095== by 0x170B2D25: SvpSalInstance::Yield(bool, bool) (svpinst.cxx:317) ==32095== by 0x91460DF: ImplYield(bool, bool) (svapp.cxx:363) ==32095== by 0x9142814: Application::Yield() (svapp.cxx:395) ==32095== by 0x91427C2: Application::Execute() (svapp.cxx:344) ==32095== by 0x4EC7589: desktop::Desktop::Main() (app.cxx:1680) ==32095== Address 0x1d498b28 is 408 bytes inside a block of size 520 free'd ==32095== at 0x4A078DE: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==32095== by 0x954CFE5: VirtualDevice::~VirtualDevice() (virdev.cxx:202) ==32095== by 0x1EE26F7D: SdModule::~SdModule() (sdmod.cxx:128) ==32095== by 0x1EE26FFD: SdModule::~SdModule() (sdmod.cxx:129) ==32095== by 0x65C9E47: SfxModule::DestroyModules_Impl() (module.cxx:327) ==32095== by 0x654116A: SfxApplication::~SfxApplication() (app.cxx:226) ==32095== by 0x6541249: SfxApplication::~SfxApplication() (app.cxx:244) ==32095== by 0x655E452: SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) (appinit.cxx:121) ==32095== by 0x1B8A67A1: framework::Desktop::terminate() (desktop.cxx:343) Change-Id: Ib70444c2b0fc60daa094323510d20b146a416087
2014-03-06constructors: Fix typo preventing extensions loading.Jan Holesovsky
Change-Id: If40e685f622b15e055a3087c441fc0c332e7d7d3
2014-03-05coverity#982309 Logically dead codeCaolán McNamara
Change-Id: Id05614cf8c90d1c845876e8a6592df8420d57d47
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05HelpTabPage_Impl ResId variant is now unusedCaolán McNamara
Change-Id: I084aaae3f090b36e7f16c4cd2541613fc91d6490
2014-03-05convert help contents page to .uiCaolán McNamara
Change-Id: I9ffd2881bfbf51749d69d7fc1af2d74335d8e3f4
2014-03-05convert help search page to .uiCaolán McNamara
Change-Id: Ib40ab75ce04c60df29895b0b14450d507d67db23
2014-03-05convert help index page to .uiCaolán McNamara
Change-Id: I2d3b5311b8f40350f6d9524f802cb074c175ffaa
2014-03-05convert help bookmarks tabpage to .uiCaolán McNamara
Change-Id: I2bfbb2aa53729be1c12ccc3ca3dd8644aa4d5410
2014-03-05sal_Bool to boolMarkus Mohrhard
Change-Id: I866946a2a987a95a41cf2b32ed089568ff94b236
2014-03-05make sure we always set the filter name in the media descriptorMarkus Mohrhard
Change-Id: I659c87a0f0856a95a5f9c71180b1d595f0dc09fa
2014-03-05remove unused code in SfxBindingsNoel Grandin
SfxBindings::GetSlot(unsigned short) SfxBindings::GetSystemWindow() const Change-Id: Icc024abcde1394ade86d3f4e623e4030382d2b63
2014-03-05remove unused code SfxDispatcher::IsOnTop(SfxShell const&)Noel Grandin
Change-Id: I107f732cb0f26bf0546e6cf6181b4236a6ad7b49
2014-03-05remove unused code TemplateLocalView::HasUnfilteredItems(FILTER_APPLICATION)Noel Grandin
Change-Id: Ia4e8c6139b20f2370219d9e7b72e6b3083301ba0
2014-03-05remove unused code in ThumbnailViewNoel Grandin
ThumbnailView::DeselectItem(unsigned short) ThumbnailView::GetItemText(unsigned short) const ThumbnailView::SetColor(Color const&) Change-Id: Ifed909b3c6b32e7e553bee29fbf989963c733e69
2014-03-03minor comment changeTomaž Vajngerl
Change-Id: If917e7e9897db0fb486f4852feb0d73e951c8b74
2014-03-03fdo#61320: Allow user to choose whether to create thumbnails inside odf.christianju
Change-Id: I8c8129534ebcca32941ad76b201bb9a0243d8c3e
2014-03-03SFX2 : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: I35a9403da152ea2b637c0235d776c7789e2ef207 Reviewed-on: https://gerrit.libreoffice.org/8420 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03remove unused code in sfx2::sidebarNoel Grandin
sfx2::sidebar::ContextList::IsEmpty() sfx2::sidebar::Deck::PrintWindowTree(std::vector<sfx2::sidebar::Panel*> > const&) sfx2::sidebar::EnumContext::EvaluateMatch(sfx2::sidebar::EnumContext const&) const sfx2::sidebar::EnumContext::GetContext() const sfx2::sidebar::Paint::Set(sfx2::sidebar::Paint const&) sfx2::sidebar::Panel::PrintWindowTree() sfx2::sidebar::SidebarDockingWindow::GetChildWindow() Change-Id: I285567320677a831b2b786f4f73b000eed39987b
2014-03-02coverity#704705 Dereference after null checkCaolán McNamara
Change-Id: I7571b8d05f96ce8a3bf8532d4def647b6815854a
2014-03-02coverity#704703 Dereference after null checkCaolán McNamara
Change-Id: I272a37a9935785d86ad76db3978cb658573e998c
2014-02-28loplugin:literaltoboolconversionStephan Bergmann
Change-Id: Ic8d00f036ef439ae8e1184289edb3ba6a117e1f6
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28remove unused code RecentDocsView::SetThumbnailSize(long)Noel Grandin
Change-Id: I9a898fda8e494693f48d7611c07bd65e86c22bdf
2014-02-27Remove unused OpenStatusListener_ImplStephan Bergmann
Unused since a7551a6a18fd46b4e287225c84807f9665db63ab "INTEGRATION: CWS fwk02ea (1.93.78); FILE MERGED." Change-Id: I090e8182a91c180bc8d875ba054ec3c94722d699
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from sfx2Alexander Wilms
Change-Id: I0f556a386ce64d154b695c2a35f808c94b9f0b7a Reviewed-on: https://gerrit.libreoffice.org/8310 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26remove unused code in sfx2::sidebarNoel Grandin
removes these methods: sfx2::sidebar::Context::EvaluateMatch(std::vector<sfx2::sidebar::Context>) sfx2::sidebar::EnumContext::EvaluateMatch(std::vector<sfx2::sidebar::EnumContext>) Change-Id: I14314d526a5306530d0381ca8bf6ab150d3dd5a0
2014-02-25Yet another one undefined comparison of 'const' and a 'non-const' iterators ↵Douglas Mencken
(hope the last one) Change-Id: Iefcd1f5561e5a8cac4152f16e72e8f628e9204a5 Reviewed-on: https://gerrit.libreoffice.org/8223 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25remove unused method SfxBindings::GetDispatchProvider_Impl()Noel Grandin
Change-Id: Ie2a04a2b5056bf607911f9705c06b74b9637d211
2014-02-25remove unused code SfxTemplatePanelControl::SetParagraphFamily()Noel Grandin
Change-Id: Id2edc693bcac57ebc56db2115829f77c202d8f62
2014-02-25writeble->writableCaolán McNamara
Change-Id: If1617d6cbdafa989fa3134842dd2238d06a1d06e
2014-02-25callcatcher: update unused codeCaolán McNamara
Change-Id: Ia8e6abffb85b92ee4538fb0aeaee4e4aa18f2772
2014-02-25Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I72b0e8b07bd7309a23d5635b7e0b7dbdc9c2c721
2014-02-24Related: rhbz#1065807 rework #i66157# for multiple writable template dirsCaolán McNamara
if there are multiple user-level template dirs then we should be able to remove/rename content in all of them, not just the default writable target. The target scenario here is to default to ~/Templates when it exists as the template dir, but to retain ~/.config/libreoffice/user/template in the dir for any pre-existing templates and to treat both as equivalent in terms of removing their content etc. i#66157# wanted to avoid remove extensions templates and other internal ones, so rework that logic to instead just be hands off internal templates and allow modification of the remainder Change-Id: I56afe991d4297ba692e914ae95ea02d68553f60a
2014-02-24implicitboolconversion: warn about implicit conversion of call args to boolStephan Bergmann
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f "sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it" earlier when converting occurrences of sal_Bool to bool. Restricting this check to function call arguments avoids too much noise while hopefully still catching all the relevant problems. (This check partially overlaps the pointertobool check, so implicit conversions from pointers to bool call arguments will now generate two loplugin warnings, but that's harmless.) Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24fix 'delete' not working in the Template ManagerCaolán McNamara
regression from b29c078c7f193dd7dae74baf89fe1abb9264239c because if the search view widget is visible then its assumed that we are in search view mode Change-Id: I8e81ffa06d5d3ac50e110105c9444707fd4c41c6
2014-02-24Replace exisiting TriState, AutoState with more generic TriStateStephan Bergmann
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-23coverity#440977 Dereference after null checkCaolán McNamara
Change-Id: I8350641f3b07e8a25080d4dfe7d9c212f89dd992
generated by cgit (git 2.34.1) at 2025-02-01 03:05:01 +0000