summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-11clang-tidy performance-unnecessary-value-param in sfx2Noel Grandin
Change-Id: I035eec1f3701c48b9a85c60400c68f9365299b48
2016-04-11make GetGlobalUNOConstant and GetUNOConstant take an OUStringNoel Grandin
and eliminate converting backwards and forwards between sal_Char*/OString/OUString Change-Id: Iaf52ce93f0e732ab338f75d21b95ab4b020a4d6f Reviewed-on: https://gerrit.libreoffice.org/23919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10Replace AddEntry macroJulien Nabet
+ remove useless call to OUString constructor Change-Id: I6544e74dad2b24c694967aae9766af8870c8c06e Reviewed-on: https://gerrit.libreoffice.org/23973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-10Replace macro IterateLayoutItemsJulien Nabet
+ use const iterator when possible Change-Id: I6aa0c312394309455df804947565a3b876aa4d19 Reviewed-on: https://gerrit.libreoffice.org/23968 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-08lok context menu: Handle the case we only get the slot-id.Jan Holesovsky
Change-Id: I7a2537ccebf80c79bf61f041bfb18cd6ddc93ca2
2016-04-08lok context menu: Expose the disabled commands too.Jan Holesovsky
OTOH, don't show choices that don't have the .uno: command, we have no way to handle them. Change-Id: I0df6ffe2049bbf11ba4b8931164be6a3381d3916
2016-04-08lok context menu: Expose context menuPranav Kant
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-08SfxTabDialog: rename members missing their prefixesMiklos Vajna
Change-Id: I6c739d4c64fb0b460e993f2a326a0acfec98b1c7 Reviewed-on: https://gerrit.libreoffice.org/23902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-07tdf#97087 - Give Idles comprehensible and unique namesMuhammet Kara
Change-Id: I435d26c00f48506a3f6bfb22aae156e91636842a Reviewed-on: https://gerrit.libreoffice.org/23887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I57d2efee3e89a2793d0b9620c894a14f8970f284
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I3f077d9937a86b362942173e787dd7cc65a0bbce
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I5a4415c1f722cfd57d07f656e235a824b5ef521c
2016-04-06Revert "Avoid deadlock when two threads call into Frame::close"Michael Stahl
This reverts commit d2a59bb53ab6c6a364538bdc6928420d8cf72ba0. Ironically causes a different deadlock, with a non-main thread holding SolarMutex and blocked in SendMessage, and main thread dropping SolarMutex now and blocking with SalYieldMutex::acquire() instead of ImplSalYieldMutexAcquireWithWait(). vcllo.dll!SalYieldMutex::acquire() Line 139 vcllo.dll!SolarMutexGuard::SolarMutexGuard() Line 1477 tklo.dll!VCLXWindow::removeFocusListener(const com::sun::star::uno::Reference<com::sun::star::awt::XFocusListener> & rxListener) Line 1066 fwklo.dll!`anonymous namespace'::Frame::implts_stopWindowListening() Line 3042 fwklo.dll!`anonymous namespace'::Frame::setComponent(const com::sun::star::uno::Reference<com::sun::star::awt::XWindow> & xComponentWindow, const com::sun::star::uno::Reference<com::sun::star::frame::XController> & xController) Line 1508 fwklo.dll!`anonymous namespace'::Frame::close(unsigned char bDeliverOwnership) Line 1770 sfxlo.dll!SfxViewFrame::Exec_Impl(SfxRequest & rReq) Line 261 sfxlo.dll!SfxStubSfxViewFrameExec_Impl(SfxShell * pShell, SfxRequest & rReq) Line 706 sfxlo.dll!SfxShell::CallExec(void (SfxShell *, SfxRequest &) * pFunc, SfxRequest & rReq) Line 204 sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, bool bRecord) Line 265 sfxlo.dll!SfxDispatcher::PostMsgHandler(SfxRequest * pReq) Line 1088 sfxlo.dll!SfxDispatcher::LinkStubPostMsgHandler(void * instance, SfxRequest * data) Line 1065 sfxlo.dll!Link<SfxRequest *,void>::Call(SfxRequest * data) Line 84 sfxlo.dll!SfxHintPoster::DoEvent_Impl(void * pPostedHint) Line 45 sfxlo.dll!SfxHintPoster::LinkStubDoEvent_Impl(void * instance, void * data) Line 42 vcllo.dll!Link<void *,void>::Call(void * data) Line 84 vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1959 vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, unsigned short nEvent, const void * pEvent) Line 2524 vcllo.dll!SalFrame::CallCallback(unsigned short nEvent, const void * pEvent) Line 273 vcllo.dll!ImplHandleUserEvent(HWND__ * hWnd, long lParam) Line 4111 vcllo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned int wParam, long lParam, int & rDef) Line 5767 Change-Id: Iba97daf9cc90028c3b0ef693f928affa32bf5a0e
2016-04-06Avoid reserved identifierStephan Bergmann
Change-Id: Ica4dc147a49525f0ec65241c2a9f1d3eb75b7285
2016-04-06remove some dead bits of DDENoel Grandin
Change-Id: Ieb1d4e23f1a62b56d14a655a676d9c7d5f33c51c Reviewed-on: https://gerrit.libreoffice.org/23849 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-06...and ignore DisposedException from multiple Frame::closeStephan Bergmann
...follow-up to d2a59bb53ab6c6a364538bdc6928420d8cf72ba0 "Avoid deadlock when two threads call into Frame::close" Change-Id: I26fae3fffce683888805efcc450065c3737ec3c5
2016-04-06Avoid deadlock when two threads call into Frame::closeStephan Bergmann
...as happened at least once in JunitTest_framework_copmlex with > Thread 27 (Thread 0x2ac7e60d1700 (LWP 30831)): > #0 0x00002ac7b781c89d in __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135 > #1 0x00002ac7b7816a36 in __GI___pthread_mutex_lock (mutex=0x1ce1720) at ../nptl/pthread_mutex_lock.c:116 > #2 0x00002ac7b6e6b257 in osl_acquireMutex(oslMutexImpl*) (pMutex=0x1ce1720) at sal/osl/unx/mutex.cxx:99 > #3 0x00002ac7bf928098 in osl::Mutex::acquire() (this=0x1ce16f8) at include/osl/mutex.hxx:56 > #4 0x00002ac7c022d123 in SalYieldMutex::acquire() (this=0x1ce16f0) at vcl/unx/generic/app/geninst.cxx:54 > #5 0x00002ac7e48442ab in SolarMutexGuard::SolarMutexGuard() (this=0x2ac7e60cedb0) at include/vcl/svapp.hxx:1476 > #6 0x00002ac7e4aa7747 in framework::AddonsToolBarWrapper::dispose() (this=0x2ac7e7fbcd50) at framework/source/uielement/addonstoolbarwrapper.cxx:73 > #7 0x00002ac7e4947503 in framework::ToolbarLayoutManager::destroyToolbars() (this=0x2ac7dbf88018) at framework/source/layoutmanager/toolbarlayoutmanager.cxx:654 > #8 0x00002ac7e494364c in framework::ToolbarLayoutManager::reset() (this=0x2ac7dbf88018) at framework/source/layoutmanager/toolbarlayoutmanager.cxx:363 > #9 0x00002ac7e492a1d6 in framework::LayoutManager::implts_reset(bool) (this=0x2ac7dbfbcc40, bAttached=false) at framework/source/layoutmanager/layoutmanager.cxx:414 > #10 0x00002ac7e493a404 in framework::LayoutManager::frameAction(com::sun::star::frame::FrameActionEvent const&) (this=0x2ac7dbfbcc40, aEvent=...) at framework/source/layoutmanager/layoutmanager.cxx:2807 > #11 0x00002ac7e49e57dc in (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&) (this=0x2ac7e7fb2050, aAction=@0x2ac7e60cf73c: com::sun::star::frame::FrameAction_COMPONENT_DETACHING) at framework/source/services/frame.cxx:2845 > #12 0x00002ac7e49ded07 in (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (this=0x2ac7e7fb2050, xComponentWindow=empty uno::Reference, xController=empty uno::Reference) at framework/source/services/frame.cxx:1509 > #13 0x00002ac7e49e293b in (anonymous namespace)::Frame::close(unsigned char) (this=0x2ac7e7fb2050, bDeliverOwnership=0 '\000') at framework/source/services/frame.cxx:1770 > #14 0x00002ac7e49ce635 in framework::Desktop::impl_closeFrames(bool) (this=0x2ac7daf2f430, bAllowUI=true) at framework/source/services/desktop.cxx:1674 > #15 0x00002ac7e49cd6ee in framework::Desktop::terminate() (this=0x2ac7daf2f430) at framework/source/services/desktop.cxx:238 > #16 0x00002ac7da45deb4 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) (pThis=0x2ac7daf2f4a0, nVtableIndex=3, pRegisterReturn=0x2ac7f41b36d0, pReturnTypeRef=0x1ce84c0, bSimpleReturn=true, pStack=0x2ac7e60cfd00, nStack=0, pGPR=0x2ac7e60cffc0, pFPR=0x2ac7e60cff80) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77 > #17 0x00002ac7da45cccf in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) (pThis=0x2ac7f40f0ea0, aVtableSlot=..., pReturnTypeRef=0x1ce84c0, nParams=0, pParams=0x0, pUnoReturn=0x2ac7f41b36d0, pUnoArgs=0x0, ppUnoExc=0x2ac7e60d0560) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:241 > #18 0x00002ac7da45c459 in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) (pUnoI=0x2ac7f40f0ea0, pMemberDescr=0x2ac7f00027c0, pReturn=0x2ac7f41b36d0, pArgs=0x0, ppException=0x2ac7e60d0560) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:430 > #19 0x00002ac7e40401ea in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const (this=0x2ac7f0002870, returnValue=0x2ac7e60d09d0, outArguments=0x2ac7e60d0998) at binaryurp/source/incomingrequest.cxx:239 > #20 0x00002ac7e403e88b in binaryurp::IncomingRequest::execute() const (this=0x2ac7f0002870) at binaryurp/source/incomingrequest.cxx:73 > #21 0x00002ac7e406927d in request(void*) (pThreadSpecificData=0x2ac7f0002870) at binaryurp/source/reader.cxx:83 > #22 0x00002ac7b998953b in cppu_threadpool::JobQueue::enter(long, bool) (this=0x2ac7f0002d30, nDisposeId=47038213394384, bReturnWhenNoJob=true) at cppu/source/threadpool/jobqueue.cxx:107 > #23 0x00002ac7b998dc25 in cppu_threadpool::ORequestThread::run() (this=0x2ac7f0000fd0) at cppu/source/threadpool/thread.cxx:165 > #24 0x00002ac7b998fb0e in threadFunc(void*) (param=0x2ac7f0000fe0) at include/osl/thread.hxx:185 > #25 0x00002ac7b6e8190b in osl_thread_start_Impl(void*) (pData=0x2ac7f0001020) at sal/osl/unx/thread.cxx:240 > #26 0x00002ac7b781460a in start_thread (arg=0x2ac7e60d1700) at pthread_create.c:334 > #27 0x00002ac7b754ea4d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 > Thread 1 (Thread 0x2ac7b6cf7340 (LWP 30697)): > #0 0x00002ac7b7819b10 in pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 > #1 0x00002ac7b6e5b316 in osl_waitCondition(oslCondition, TimeValue const*) (Condition=0x2ac7f41e10b0, pTimeout=0x0) at sal/osl/unx/conditn.cxx:228 > #2 0x00002ac7cca51370 in osl::Condition::wait(TimeValue const*) (this=0x2ac7e7fb20d8, pTimeout=0x0) at include/osl/conditn.hxx:84 > #3 0x00002ac7cca50f90 in framework::Gate::wait() (this=0x2ac7e7fb20d0) at framework/inc/threadhelp/gate.hxx:123 > #4 0x00002ac7cca50708 in framework::TransactionManager::setWorkingMode(framework::EWorkingMode) (this=0x2ac7e7fb20c8, eMode=framework::E_BEFORECLOSE) at framework/source/fwi/threadhelp/transactionmanager.cxx:98 > #5 0x00002ac7e49dfc3c in (anonymous namespace)::Frame::dispose() (this=0x2ac7e7fb2050) at framework/source/services/frame.cxx:2008 > #6 0x00002ac7e49e2cd3 in (anonymous namespace)::Frame::close(unsigned char) (this=0x2ac7e7fb2050, bDeliverOwnership=1 '\001') at framework/source/services/frame.cxx:1801 > #7 0x00002ac7bbbe25fe in SfxViewFrame::Exec_Impl(SfxRequest&) (this=0x2ac7f4691cd0, rReq=...) at sfx2/source/view/viewfrm2.cxx:260 > #8 0x00002ac7bbbcd658 in SfxStubSfxViewFrameExec_Impl(SfxShell*, SfxRequest&) (pShell=0x2ac7f4691cd0, rReq=...) at workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:706 > #9 0x00002ac7bb71f792 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (this=0x2ac7f4691cd0, pFunc=0x2ac7bbbcd630 <SfxStubSfxViewFrameExec_Impl(SfxShell*, SfxRequest&)>, rReq=...) at include/sfx2/shell.hxx:204 > #10 0x00002ac7bb715e41 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x2ac7f40fe8e0, rShell=..., rSlot=..., rReq=..., bRecord=true) at sfx2/source/control/dispatch.cxx:262 > #11 0x00002ac7bb71b6fd in SfxDispatcher::PostMsgHandler(SfxRequest*) (this=0x2ac7f40fe8e0, pReq=0x2ac88c000cf0) at sfx2/source/control/dispatch.cxx:1085 > #12 0x00002ac7bb716698 in SfxDispatcher::LinkStubPostMsgHandler(void*, SfxRequest*) (instance=0x2ac7f40fe8e0, data=0x2ac88c000cf0) at sfx2/source/control/dispatch.cxx:1065 > #13 0x00002ac7bbabb3f8 in Link<SfxRequest*, void>::Call(SfxRequest*) const (this=0x2ac7f48361f0, data=0x2ac88c000cf0) at include/tools/link.hxx:84 > #14 0x00002ac7bbabb37b in SfxHintPoster::DoEvent_Impl(void*) (this=0x2ac7f48361e0, pPostedHint=0x2ac88c000cf0) at sfx2/source/notify/hintpost.cxx:44 > #15 0x00002ac7bbabb348 in SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) (instance=0x2ac7f48361e0, data=0x2ac88c000cf0) at sfx2/source/notify/hintpost.cxx:42 > #16 0x00002ac7bfaba968 in Link<void*, void>::Call(void*) const (this=0x2ac88c00b008, data=0x2ac88c000cf0) at include/tools/link.hxx:84 > #17 0x00002ac7bfab7adc in ImplHandleUserEvent(ImplSVEvent*) (pSVEvent=0x2ac88c00b000) at vcl/source/window/winproc.cxx:1956 > #18 0x00002ac7bfab4db7 in ImplWindowFrameProc(vcl::Window*, unsigned short, void const*) (_pWindow=0x2a43020, nEvent=22, pEvent=0x2ac88c00b000) at vcl/source/window/winproc.cxx:2524 > #19 0x00002ac7c01278c9 in SalFrame::CallCallback(unsigned short, void const*) const (this=0x2a43890, nEvent=22, pEvent=0x2ac88c00b000) at vcl/inc/salframe.hxx:273 > #20 0x00002ac7c0133999 in SvpSalInstance::DoYield(bool, bool, unsigned long) (this=0x1ce1640, bWait=false, bHandleAllCurrentEvents=false, nReleased=0) at vcl/headless/svpinst.cxx:293 > #21 0x00002ac7bffa63b5 in ImplYield(bool, bool, unsigned long) (i_bWait=false, i_bAllEvents=false, nReleased=0) at vcl/source/app/svapp.cxx:509 > #22 0x00002ac7bffa1148 in Application::Yield() () at vcl/source/app/svapp.cxx:553 > #23 0x00002ac7bffa10d3 in Application::Execute() () at vcl/source/app/svapp.cxx:473 > #24 0x00002ac7b70ee229 in desktop::Desktop::DoExecute() () at desktop/source/app/app.cxx:1322 > #25 0x00002ac7b70f0304 in desktop::Desktop::Main() (this=0x7ffefac27e38) at desktop/source/app/app.cxx:1647 > #26 0x00002ac7bffb3639 in ImplSVMain() () at vcl/source/app/svmain.cxx:172 > #27 0x00002ac7bffb4e18 in SVMain() () at vcl/source/app/svmain.cxx:210 > #28 0x00002ac7b714f3b5 in soffice_main() () at desktop/source/app/sofficemain.cxx:135 > #29 0x000000000040097d in sal_main () at desktop/source/app/main.c:48 > #30 0x0000000000400957 in main (argc=8, argv=0x7ffefac27fe8) at desktop/source/app/main.c:47 Change-Id: Id06a8fcfe449f566785c51174b1ad3e81459032f
2016-04-06SidebarToolBox: Remove unused param.Jan Holesovsky
Change-Id: I47d4ffe68f09156987e545511be469991dd6105d
2016-04-06SidebarToolBox: This function was needed only for InsertPropertyPanel.Jan Holesovsky
Change-Id: I7101ca70418d4d33b0dfbbd2ba6753b6891d7c3c
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I18ebddef41955948fd4528ae74f4fe9c7439d53b
2016-04-04loplugin:constantparam in sfx2Noel Grandin
Change-Id: I9a5a9fd1f4f43e0b7ef13d14979cb231f6aa9d46 Reviewed-on: https://gerrit.libreoffice.org/23801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04sequence->vector in sfx2Noel Grandin
Change-Id: I31c3075db663253b37f0a8dc64338ec6f6172801 Reviewed-on: https://gerrit.libreoffice.org/23755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04Use std::size_tMiklos Vajna
And include <cstddef> where necessary. Change-Id: Icc1208528d6a8b04375d55ccbf3cd6ef046b454f Reviewed-on: https://gerrit.libreoffice.org/23796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-04Make InputDialog class global to reuse it's code and tdf#97425Akshay Deep
tdf#97425 -> Use InputDialog to edit Java Class Parameter Change-Id: I41ac9ffbc660c4bbb9d4fd3335e95d64ccdd2842 Reviewed-on: https://gerrit.libreoffice.org/23580 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-04Kill some written-only member vars in SidebarToolBox.Jan Holesovsky
Change-Id: I26b89fefafea90a24252dc3a167682b4daf0193c
2016-04-04Bool_UseToolBoxItemSeparator in SidebarToolBox is always false, kill it.Jan Holesovsky
Change-Id: Ia1b8d4325207879634ace6d812358dac33fdc2fc
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01The label of this dialog can grow very long…Adolfo Jayme Barrientos
… so place it above its associated entry. Change-Id: I8fce05bef2cb6ea4589caed60f9384fb42170234
2016-04-01Place help button on the left in dialogOlivier Hallot
The New folder dialog, that is opened by the Template Manager dialog has now the help button on the left. Change-Id: Iabc55a031247e1ea33887dffc929dde17549f8fb Reviewed-on: https://gerrit.libreoffice.org/23740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-04-01sequence->vector in frameworkNoel Grandin
Change-Id: I457c3da4f4a31f58d688dcd96a2ccfc36518490d Reviewed-on: https://gerrit.libreoffice.org/23692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31Replace AddContext in sidebar/EnumContext.cxxJulien Nabet
+ remove extra duplicate AddEntry("Chart", Context_Chart); Change-Id: I9624000d5f9470cd4cb5072c24aa24aced740fe4 Reviewed-on: https://gerrit.libreoffice.org/23665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-30notebookbar: Trying to use the SfxChildWindow for it does not work too well.Jan Holesovsky
The notebookbar is not a child window, so trying to graft it on the SfxChildWindow infrastructure is more pain than gain, unfortunately... Instead, it's enough to create the appropriate functions for ExecMethod and StateMethod, and call them from Writer / Calc / etc. with the appropriate .ui file; that's easier & works equally well. Change-Id: I08d98d4f481bd02e90ba11df0bd1c1149697a7fa
2016-03-30notebookbar: Rename NotebookBarWindow to NotebookBar, and move accordingly.Jan Holesovsky
Change-Id: If04a8f62aba0bcb712ae6405db318a4bd073fc54
2016-03-30notebookbar: Instantiate the notebookbar via sfx2 infrastructure.Szymon Kłos
Change-Id: Iaed4596246245560e646d9086e717d5fb516897e
2016-03-30Replace MACRO_PRFIX and MACRO_POSTFIX in eventsupplier.cxxJulien Nabet
Change-Id: Ifd08a3414468e7685f55af66ed05f7a88187fa0e Reviewed-on: https://gerrit.libreoffice.org/23606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-30Replace IMPL_FORWARD_LOOP in sfx2/source/bastyp/fltfnc.cxxJulien Nabet
Change-Id: Ic9eda24be82a54c3907ffe6eb749e927db87dee7 Reviewed-on: https://gerrit.libreoffice.org/23605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-29Replace some defines in sfx2/source/appl/newhelp.cxxJulien Nabet
Change-Id: I82d13a71b59bd9cefc800f592d2b8312b70d1725 Reviewed-on: https://gerrit.libreoffice.org/23604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-28tdf#59698 Template Manager: 'OK' and 'Help' buttons addedAkshay Deep
Change-Id: I0ec224eb5c6b11a8d589def477f3cf8429195f2c Reviewed-on: https://gerrit.libreoffice.org/23552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk> Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
2016-03-26Avoid nesting parentheses in this stringAdolfo Jayme Barrientos
Change-Id: I3b6fc9ca49e4a7b0019c2c9b376eb87ae8d14e4f
2016-03-24MM: remove lock from saved documentsJan-Marek Glogowski
Actually we have to call DoSaveCompleted to get rid of the locking. Instead this adds a parameter to skip the recent file registration used in non bCreateSingleFile modes. Change-Id: I57151f08ad8d737007da84c4566685cc37612dfb
2016-03-24tdf#97398: Toggle deck/panel visibility individually for each appKatarina Behrens
Change in visibility of a shared deck ('any, any, ...') or panel made in 1 app must not affect its visibility in the remaining apps Change-Id: I78472ce078409edec796ef649349df4bda62a709 Reviewed-on: https://gerrit.libreoffice.org/23432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-23tdf#92817 Fix for Error on Save with empty lock fileJaskaran
An empty lock file is of no use except that it doesn't allow you to save your file with that same name. An empty lock file doesn't have OOOUSERNAME and SYSUSERNAME. So in that case we could take ownership of our lock. bOwnLock = true makes it our own lock. Change-Id: I9490f87d69bcad3c09f6c98b4fb9318f53e1d4bd Reviewed-on: https://gerrit.libreoffice.org/23125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-23loplugin:constantparam in sfx2Noel Grandin
Change-Id: I12aa9b28a9a1e66425717820cfcedff55434dd2f
generated by cgit (git 2.34.1) at 2025-02-06 11:13:04 +0000