summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-05-05silence default button spew in template dialogCaolán McNamara
Change-Id: I0ef5b6c273238fc564ec6f0d81ac18c0ce00842d
2016-05-04sfx2: fix SfxViewShell::CheckIPClient_Impl()Michael Stahl
Probably the Edit->Plug-in removal removed the wrong branch there since m_bPlugInsActive was always true before. This caused embded::UnreachableStateException to be thrown out of a Timer and that was only handled as a FatalError in desktop::Main, for example on kde84498-1.html. (regression from 4b3c211cfb4f64f0f31461aa2e623d64224c4423) Change-Id: If9e2578f722ea5c5b0821d3d894bb439dbf3c40c
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04tdf#82160 Reset mouse pointer if doc loading failedMaxim Monastirsky
Change-Id: Ib05226345c4b83d9190839de5cc04068ce1879d8
2016-05-03Remove unnecessary setBOOL, makeBoolAnyStephan Bergmann
Change-Id: Id82c3f352fcc2d4dafad877517098cb6f5d046d4
2016-05-03Remove Edit -> Plug-in as no longer usedBryan Quigley
This functionality seems to only have been used with NPAPI plugins. They've been previously removed. Per the help text, if it is still used by anything, you can use the context menu instead. MN_READONLY_PLUGINOFF also appeared to be unused, so removed. More code might be removable, but would affect activate on click/visible. Change-Id: I12d5bf54edd3a2f716912179b87e798b47b3cc3d Reviewed-on: https://gerrit.libreoffice.org/24500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-01tdf#96890 The file "groupuinames.xml" is invalid XMLmelikeyurtoglu
Change-Id: I623d5bbae5a016569f5c1f8174c22ee97db94467 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30Fix typosAndrea Gelmini
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-29Template Manager -> TemplatesSamuel Mehrbrodt
As agreed in the design team. Most places already use "Templates". Change-Id: I6186546883059bf0308fabd61b162eb649647ec9 Reviewed-on: https://gerrit.libreoffice.org/24493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28tdf#96097: Can't save a doc with signed macro after autosave/save a copyGuillaume Smaha
Change-Id: Icc886a8d228cb786c6f318cfa2556ef113c553eb Reviewed-on: https://gerrit.libreoffice.org/24081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-04-26tdf#64292 tdf#94639 Meaningless Functions in Template Properties DialogAkshay Deep
Removed useless Template Properties Dialog. Change-Id: I453abb67de9eb1515f98ff78cc7bebcc69482a1e Reviewed-on: https://gerrit.libreoffice.org/23339 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25There is no css::uno::Sequence<sal_uInt8> in UNOStephan Bergmann
Change-Id: I1d2207a5a8832155e29c334cbfe5dc5d794b80da
2016-04-23tdf#93060 Start Center: Update this string to dodge problematic termAdolfo Jayme Barrientos
I’ve never liked the chosen wording of this string; it has been merely a decorative item, of limited usefulness. So I’ve decided to replace it with something that describes a somewhat hidden functionality (drag’n’drop) while avoiding the misuse of the word “sidebar” to refer to the bar containing the application launcher buttons. Change-Id: I299e9e1e97a4e7aa176bc7bbc24cf0e9bea5abb5
2016-04-22SfxClassificationHelper: avoid implicit cast in loopMiklos Vajna
const std::pair<OUString, OUString>& vs const std::pair<const OUString, OUString>& Avoid copying by just using 'const auto&'. Change-Id: I711edc13d20194ee4901d1afe1f48d1f49657a53 Reviewed-on: https://gerrit.libreoffice.org/24291 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I3cb9226ef6bebb5062abfae312dce95f0ef74385
2016-04-20Use bool instead of a sal_uInt8 bitStephan Bergmann
Change-Id: Id918fd609afaa4fcfcd90f60baac165d7d6280d9
2016-04-20SvDDEObject::nError is never readStephan Bergmann
...at least since 98eabdaa5a7f4a35b87925361a5a437077e274c0/ 14483df71f08d2bf676d558708429af066fd9ecd "INTEGRATION: CWS mav09: #i27773# move implementation from so3" moved the code to where it is today. Change-Id: Ia57aee6e0ea2f1c179ca542046dd26b86c9b7e04
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18SfxViewFrame: rename members missing their prefixesMiklos Vajna
Change-Id: Ib690fed0a0ab76325370c2ca42d4e25c4d0a2882 Reviewed-on: https://gerrit.libreoffice.org/24186 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#94306 replace boost::noncopyable in sfx2 to sotJochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. Make some overloaded ctors explicit, seems cppcheck doesn't flag: T(const template<X>& rx). Change-Id: I63c5a3ac84a33ea6d49868e2d9aa281ada79958e Reviewed-on: https://gerrit.libreoffice.org/24050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in sfx2Noel Grandin
Change-Id: I8c9d6e972f74ee04c8befda3b4cabb6e9b6b2054
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Ia2be9eeda4c1035f8e1d3b68446807aeffe59453
2016-04-12loplugin:unreffunStephan Bergmann
Change-Id: Ia0f7e2507438cb966e45306d6d018d652a307601
2016-04-12WNT: check result of PostMessage()Michael Stahl
... so the next time something overflows the main thread's message queue it's easier to debug. Change-Id: I90a35e46f3b2cab190c7da5e53024ec549159ac6
2016-04-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 1 to OSL_DEBUG_LEVEL > 0 conditionals as suggested in easyhack. I didn't convert those fprintf statements because they were required for debug output formatting according to me Change-Id: I54d5b0873f527fd04d736eeb01d18f73eb9be74f Reviewed-on: https://gerrit.libreoffice.org/23069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12lok context menu: Include uno commands for submenus tooPranav Kant
Change-Id: I4ba49ba94a3270a5d53754320e5fbd49e3f5c848
2016-04-11tdf#74885 Fix direction in CMIS property editor scrollbarGiuseppe Castagno
Use outer container size to compute scroll max range. Remove class member function no longer used. Remove class field no longer used. Rename some local variables. Change-Id: Ida2f631ce7a49b2ce4cd4ee2913437b020058ae1 Reviewed-on: https://gerrit.libreoffice.org/22804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-04-11tdf#89095 Start Center: bigger thumbnails for templatesAkshay Deep
ThumbnailDefaultView is now able to dynamically update the size of the thumbnail in its item. Removed padding for thumbnails. Change-Id: Ibc267c848a844098a59525c76e234f4f9c4d0ed1 Reviewed-on: https://gerrit.libreoffice.org/23816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-11clang-tidy performance-unnecessary-value-param in sfx2Noel Grandin
Change-Id: I035eec1f3701c48b9a85c60400c68f9365299b48
2016-04-11make GetGlobalUNOConstant and GetUNOConstant take an OUStringNoel Grandin
and eliminate converting backwards and forwards between sal_Char*/OString/OUString Change-Id: Iaf52ce93f0e732ab338f75d21b95ab4b020a4d6f Reviewed-on: https://gerrit.libreoffice.org/23919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10Replace AddEntry macroJulien Nabet
+ remove useless call to OUString constructor Change-Id: I6544e74dad2b24c694967aae9766af8870c8c06e Reviewed-on: https://gerrit.libreoffice.org/23973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-10Replace macro IterateLayoutItemsJulien Nabet
+ use const iterator when possible Change-Id: I6aa0c312394309455df804947565a3b876aa4d19 Reviewed-on: https://gerrit.libreoffice.org/23968 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-08lok context menu: Handle the case we only get the slot-id.Jan Holesovsky
Change-Id: I7a2537ccebf80c79bf61f041bfb18cd6ddc93ca2
2016-04-08lok context menu: Expose the disabled commands too.Jan Holesovsky
OTOH, don't show choices that don't have the .uno: command, we have no way to handle them. Change-Id: I0df6ffe2049bbf11ba4b8931164be6a3381d3916
2016-04-08lok context menu: Expose context menuPranav Kant
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-08SfxTabDialog: rename members missing their prefixesMiklos Vajna
Change-Id: I6c739d4c64fb0b460e993f2a326a0acfec98b1c7 Reviewed-on: https://gerrit.libreoffice.org/23902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-07tdf#97087 - Give Idles comprehensible and unique namesMuhammet Kara
Change-Id: I435d26c00f48506a3f6bfb22aae156e91636842a Reviewed-on: https://gerrit.libreoffice.org/23887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I57d2efee3e89a2793d0b9620c894a14f8970f284
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I3f077d9937a86b362942173e787dd7cc65a0bbce
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I5a4415c1f722cfd57d07f656e235a824b5ef521c
2016-04-06Revert "Avoid deadlock when two threads call into Frame::close"Michael Stahl
This reverts commit d2a59bb53ab6c6a364538bdc6928420d8cf72ba0. Ironically causes a different deadlock, with a non-main thread holding SolarMutex and blocked in SendMessage, and main thread dropping SolarMutex now and blocking with SalYieldMutex::acquire() instead of ImplSalYieldMutexAcquireWithWait(). vcllo.dll!SalYieldMutex::acquire() Line 139 vcllo.dll!SolarMutexGuard::SolarMutexGuard() Line 1477 tklo.dll!VCLXWindow::removeFocusListener(const com::sun::star::uno::Reference<com::sun::star::awt::XFocusListener> & rxListener) Line 1066 fwklo.dll!`anonymous namespace'::Frame::implts_stopWindowListening() Line 3042 fwklo.dll!`anonymous namespace'::Frame::setComponent(const com::sun::star::uno::Reference<com::sun::star::awt::XWindow> & xComponentWindow, const com::sun::star::uno::Reference<com::sun::star::frame::XController> & xController) Line 1508 fwklo.dll!`anonymous namespace'::Frame::close(unsigned char bDeliverOwnership) Line 1770 sfxlo.dll!SfxViewFrame::Exec_Impl(SfxRequest & rReq) Line 261 sfxlo.dll!SfxStubSfxViewFrameExec_Impl(SfxShell * pShell, SfxRequest & rReq) Line 706 sfxlo.dll!SfxShell::CallExec(void (SfxShell *, SfxRequest &) * pFunc, SfxRequest & rReq) Line 204 sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, bool bRecord) Line 265 sfxlo.dll!SfxDispatcher::PostMsgHandler(SfxRequest * pReq) Line 1088 sfxlo.dll!SfxDispatcher::LinkStubPostMsgHandler(void * instance, SfxRequest * data) Line 1065 sfxlo.dll!Link<SfxRequest *,void>::Call(SfxRequest * data) Line 84 sfxlo.dll!SfxHintPoster::DoEvent_Impl(void * pPostedHint) Line 45 sfxlo.dll!SfxHintPoster::LinkStubDoEvent_Impl(void * instance, void * data) Line 42 vcllo.dll!Link<void *,void>::Call(void * data) Line 84 vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1959 vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, unsigned short nEvent, const void * pEvent) Line 2524 vcllo.dll!SalFrame::CallCallback(unsigned short nEvent, const void * pEvent) Line 273 vcllo.dll!ImplHandleUserEvent(HWND__ * hWnd, long lParam) Line 4111 vcllo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned int wParam, long lParam, int & rDef) Line 5767 Change-Id: Iba97daf9cc90028c3b0ef693f928affa32bf5a0e
2016-04-06Avoid reserved identifierStephan Bergmann
Change-Id: Ica4dc147a49525f0ec65241c2a9f1d3eb75b7285
generated by cgit (git 2.34.1) at 2025-02-10 15:42:10 +0000