summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-08-30tdf#119579 skip floating windows as potential parent for missing help dialogCaolán McNamara
Change-Id: Ibcee9a6aab0b04bf52f3e75a46f52d98864eee4c Reviewed-on: https://gerrit.libreoffice.org/59808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30tdf#119577 Ignore escape key press on sidebar toolboxes not handled byJim Raykowski
...focus manager. This prevents escape key press on More Options tool box in some panel title bars from sending focus to doc view. Change-Id: Iaac9bf31494e4e35f30350580acaa9f42ead49a0 Reviewed-on: https://gerrit.libreoffice.org/59783 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-30Update sidebar panel title decoration expand/collapse bitmapJim Raykowski
...when panel title has focus and space key is pressed Fixes sidebar panel title decoration expand/collapse bitmap not updating when keyboard space key is pressed. This has been present since at least ver 5.1.6.2. Seems trival enough to not have go through the report process. May be why I could find no bug report for it :-) Change-Id: I7c0dfe511a780eb2bdc5ab8d1064549645cc30ae Reviewed-on: https://gerrit.libreoffice.org/59680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30add SfxStyleDialogControllerCaolán McNamara
Change-Id: I5b55b8adb46d894f87dcf68c97f6fd56059354a2 Reviewed-on: https://gerrit.libreoffice.org/59768 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#119554 Expand collapsed panel when panel content gets focusJim Raykowski
Change-Id: I1af7a9e93affc5c6e5e3ba90ba335e59a0900d20 Reviewed-on: https://gerrit.libreoffice.org/59737 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#119527 Fix focus hidden by mouse click panel collapseJim Raykowski
Set focus to the clicked panel title Change-Id: I65993a6a2f8e7a9a2bdaa6cf4527d5b163d81409 Reviewed-on: https://gerrit.libreoffice.org/59694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#119461 Fix focus hidden on deck collapseJim Raykowski
Makes Space key behavior the same as mouse click. Focus remains on the tab button when the deck collapses. Makes Enter key never collapses the deck but to open if collapsed and always place focus on the first panel title. Change-Id: Id6d7624e88b421dcfc62f3d0e79986f10c76a65d Reviewed-on: https://gerrit.libreoffice.org/59616 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#102031 Expand collapsed deck when sidebar docking window gets focusJim Raykowski
SidebarDockingWindow::GetFocus hides focus when deck is in collapsed state so request open deck before setting focus to deck/panel title Change-Id: I7d7f6d940a3722eb02e6356c069c4d9df9642326 Reviewed-on: https://gerrit.libreoffice.org/58712 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29loplugin:constantparam (3)Noel Grandin
Change-Id: Ifc47bb8e096c9a8563021b2fcb44199577740746 Reviewed-on: https://gerrit.libreoffice.org/59747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29loplugin:constantparam (2)Noel Grandin
Change-Id: I528f22876497f87159e3b9453362ebbfb55b7092
2018-08-29new loplugin:oustringbufferNoel Grandin
look for places where we are appending the temporary result of adding strings together, to an OUStringBuffer, where we could rather call append repeatedly and avoid the temporary creation Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82 Reviewed-on: https://gerrit.libreoffice.org/59708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28tdf#119050 sfx2 store: don't inherit temp file permissions when overwritingMiklos Vajna
The too aggressive error handling in commit fb04780cf8523ad4e900ae8b9cecbe7a2697a12a (tdf#116117 sfx2 store: don't inherit temp file permissions when renaming, 2018-03-12) means that if the file is already there, then we don't try to stat() it; even if there is no problem with that. Change-Id: Ie0b9084064834e339bcae3ad7b4a35c54cb9d3c2 Reviewed-on: https://gerrit.libreoffice.org/59684 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-24tdf#119416 Open Special Characters dialog on Enter key pressJim Raykowski
...when focus is on toolbar character map control Change-Id: Ie7b53b18acfe1967a635c64120591a5ff7f2dc33 Reviewed-on: https://gerrit.libreoffice.org/59528 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-24tdf#119364: fix by reverting some previous commits about notebookbarJulien Nabet
Revert: - dcbb65f2a4a3ee70ccd4896d7a5e975dbd9e6509 which was to avoid Avoid com.sun.star.container.NoSuchElementException "Active" when opening embedded form - 6c89f41b02fcd8918e535460994daac4ecd5d37e which was to fix previous commit and fix tdf#119330 Just fix Avoid com.sun.star.container.NoSuchElementException "Active" by testing if OUString returned by lcl_getAppName is empty or not. If empty, just return false Change-Id: I51ec7cba457bafdd161e02f16e3e09fddcd04408 Reviewed-on: https://gerrit.libreoffice.org/59417 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-24tdf#118993 - Missing new Insert Special Character in Calcheiko tietze
Added also to Impress and Draw for consistency Fix for tdf#116355 included and SID_CHARMAP_CONTROL disabled in Impress like SID_CHARMAP Change-Id: I8b9925f6124527dfc27c7a27f6c8832c7e9c88e2 Reviewed-on: https://gerrit.libreoffice.org/58323 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-23tdf#117426 don't crash is infobar is disposed in preview viewCaolán McNamara
Change-Id: Iff2dece2ea5f65c5d0896af888e05703ae709c65 Reviewed-on: https://gerrit.libreoffice.org/59512 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21loplugin:useuniqueptr in DeleteItemOnIdleNoel Grandin
Change-Id: I6a72417bcab1ac48b5d8a73005104c8627dde32b Reviewed-on: https://gerrit.libreoffice.org/59349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20return weld widgets by std::unique_ptr from builderNoel Grandin
Change-Id: I20c007b13dae2d1155034711ad1ad48bfdfd0ba8 Reviewed-on: https://gerrit.libreoffice.org/59288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-18tdf#119330: fix regression in SfxNotebookBar.cxxJulien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=144272 Change-Id: Ibe36c0bbacc5a36db03129ce139b3b4b1adbbf39 Reviewed-on: https://gerrit.libreoffice.org/59296 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-16Resolves: tdf#119013 do not over-aggressively reorder date particlesEike Rathke
In particular not when reading documents as we don't know what the original (default/system) locale was when the date format was created and stored and whether the format's date order actually matched the locale's ordering. Regression from commit 51478cefaa4e265b42e3f67eda0a64767ff3efba CommitDate: Tue Apr 18 17:01:27 2017 +0200 Resolves: tdf#107012 follow date order of the target locale Change-Id: I9d3bdbd512d95ed81ff6459e368a2d7497ec8a2d Reviewed-on: https://gerrit.libreoffice.org/59182 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-16pass SfxMedium around by std::unique_ptrNoel Grandin
Change-Id: Ibde7b68d9248f80d5304991390a80742265f37b3 Reviewed-on: https://gerrit.libreoffice.org/59031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15tdf#119276 Fix loading of images with internal LO URLsTomaž Vajngerl
Change-Id: I30556aba4490bef7f4a6e6b3899cc05f4b6a06d4 Reviewed-on: https://gerrit.libreoffice.org/59104 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-15pass IMapObject around by std::unique_ptrNoel Grandin
and avoid some unnecessary copying Change-Id: Ieb9b1fe169a7d56197bf1e054e9af5dca7804301 Reviewed-on: https://gerrit.libreoffice.org/59019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-14help: Let's make the help urls more standard, and use ?Target=...&... form.Jan Holesovsky
Reviewed-on: https://gerrit.libreoffice.org/58863 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a7485a5db36dc8a8e61285384eed06c46e6a5b53) Change-Id: If9b7f6e50e8e668b7349dae1935ce16965ef19b0 Reviewed-on: https://gerrit.libreoffice.org/58868 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-12Don't show ShowImeStatusWindow in the customization dialogMaxim Monastirsky
Change-Id: I5aeac6cf6ec9fae56c0dba3c176e0d6c52a28a5e Reviewed-on: https://gerrit.libreoffice.org/58899 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-12Fix typosAndrea Gelmini
Change-Id: I2cee481ec18f52d6610ab73b99637268b2340337 Reviewed-on: https://gerrit.libreoffice.org/58886 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-10Use ASCII literals in indexOf and compare result against 0Matteo Casalin
Change-Id: I3bea0f3d0566d46c9f92e74f452b6c5a009adcd6
2018-08-10Reduce OUString operationsMatteo Casalin
Change-Id: I379cc523587da41ee270ac90e8cfdc00526a2745
2018-08-10Fix whitespacesMatteo Casalin
Change-Id: I4d64e537fe6eacf8481479604ee34272073d9aae
2018-08-10Avoid getTokenCount/getToken to get last tokenMatteo Casalin
Change-Id: I19de49e64746a6632c56c0ddb0a0c455c97be414
2018-08-10unnecessary null check before dynamic_cast, in variousNoel Grandin
Change-Id: I76ad0b3152030c29ee28f6a6cc80d0832188d02b Reviewed-on: https://gerrit.libreoffice.org/58774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-09Set umask /before/ using itStephan Bergmann
The test used to fail when umask originally was e.g. 077. Change-Id: I21d346532698feebccc8bb3f6cb9a9dd3002a20e Reviewed-on: https://gerrit.libreoffice.org/58757 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09Improve wording of commentStephan Bergmann
...as discussed on #libreoffice-dev Change-Id: I5314bdcaf0e023db615c68785b76f4ee6144b079 Reviewed-on: https://gerrit.libreoffice.org/58758 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-08loplugin:useuniqueptr in SfxApplication::LoadTemplate and SfxMediumNoel Grandin
pass SfxItemSet around by std::unique_ptr Change-Id: I54da96d8df224f7c4f2fb9ebf06ed32d479298e7 Reviewed-on: https://gerrit.libreoffice.org/58649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-07tdf#119052: hide edit style button in character styleXisco Fauli
Change-Id: I8ec82865b990ff19ead819c990f442edd7423d66 Reviewed-on: https://gerrit.libreoffice.org/58472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-08-05coverity#1438225 Improper use of negative valueCaolán McNamara
and coverity#1438221 Argument cannot be negative coverity#1438213 Argument cannot be negative coverity#1438227 Argument cannot be negative coverity#1438223 Argument cannot be negative coverity#1438222 Argument cannot be negative coverity#1438215 Improper use of negative value coverity#1438220 Improper use of negative value coverity#1438217 Improper use of negative value Change-Id: I398ae9901b27f6b65f03aad03638939b5880a671 Reviewed-on: https://gerrit.libreoffice.org/58626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-02turn SfxPickList singleton a member of SfxApplicationCaolán McNamara
SfxPickList listens to the SfxApplication so it can be made a member of that, and drop the singleton, which is causing trouble like... #0 0x00007ffff613ad7d in ImplDbgTestSolarMutex() () at /libreoffice/symbols/vcl/source/app/dbggui.cxx:47 #1 0x00007ffff6ee86e1 in SfxBroadcaster::RemoveListener(SfxListener&) (this=0x5555565d0380, rListener=...) at /libreoffice/symbols/svl/source/notify/SfxBroadcaster.cxx:126 #2 0x00007ffff6eea993 in SfxListener::~SfxListener() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/svl/source/notify/lstner.cxx:66 #3 0x00007ffff7207b45 in SfxPickListImpl::~SfxPickListImpl() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:84 #4 0x00007ffff7207b45 in SfxPickListImpl::~SfxPickListImpl() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:84 #5 0x00007ffff7206aa5 in std::default_delete<SfxPickListImpl>::operator()(SfxPickListImpl*) const (this=<optimized out>, __ptr=<optimized out>) at /usr/include/c++/7/bits/unique_ptr.h:78 #6 0x00007ffff7206aa5 in std::unique_ptr<SfxPickListImpl, std::default_delete<SfxPickListImpl> >::reset(SfxPickListImpl*) (__p=<optimized out>, this=0x7ffff76775a8 <SfxPickList::ensure()::aUniqueInstance>) at /usr/include/c++/7/bits/unique_ptr.h:376 #7 0x00007ffff7206aa5 in SfxPickList::~SfxPickList() (this=0x7ffff76775a8 <SfxPickList::ensure()::aUniqueInstance>, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:188 #8 0x00007ffff44dc041 in __run_exit_handlers (status=0, listp=0x7ffff4884718 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108 #9 0x00007ffff44dc13a in __GI_exit (status=<optimized out>) at exit.c:139 #10 0x00007ffff44bab9e in __libc_start_main (main=0x555555557880 <main(int, char**)>, argc=10, argv=0x7fffffffdde8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffddd8) at ../csu/libc-start.c:344 #11 0x00005555555578da in _start () Change-Id: Ic781f3eb065fef14da1f10a56246b9b7068e1529 c781f3eb065fef14da1f10a56246b9b7068e1529 Reviewed-on: https://gerrit.libreoffice.org/58494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-02m_xStringLength is unusedCaolán McNamara
Change-Id: I244ca2c34363d0776a3cc18953a1c9b28467da44 Reviewed-on: https://gerrit.libreoffice.org/58493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-31Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from sfx2 to starmath Change-Id: I40ee7bfae6efdadd862319b7b693ad22c648e1c4 Reviewed-on: https://gerrit.libreoffice.org/58222 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-31tdf#118593 sfx2: no need to call into xmlsecurity without signature streamsMiklos Vajna
In the ODF and OOXML cases the ZIP storage already tells us if there are signatures on this file so we can avoid the whole libxmlsec init, which can be slow. The bugreport talks about a smartcard setup, I also heard that the gpg code in xmlsecurity isn't cheap to init, either. Change-Id: Ife9ed577d03e96a9ac2f42a28776b7df58e76c59 Reviewed-on: https://gerrit.libreoffice.org/58344 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-31uitest logger: log more eventsSaurav Chirania
Logging for the following: 1) Object Selection 2) Sidebar / Deck opening 3) Parameters of UNO commands 4) Element Selection (Math) 5) Set Zoom (Impress) 6) Calc - a) Autofilter Launch b) Select Cell / Range of cells c) Switch table 7) Writer - a) Goto page b) Set Zoom Change-Id: Ifc7f603f62d10cfd1062923ded68203e574aebb6 Reviewed-on: https://gerrit.libreoffice.org/57368 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-30loplugin:returnconstant in sfx2Noel Grandin
Change-Id: I9a41a2b53669bebfca573fef8d0d755e4621ce37 Reviewed-on: https://gerrit.libreoffice.org/58333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:stringloop in sfx2..svxNoel Grandin
Change-Id: Ie4ca2421f00259f974b6d94f883adfa11600b1fe Reviewed-on: https://gerrit.libreoffice.org/58251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27loplugin:returnconstant in ucbhelper,drawinglayerNoel Grandin
Change-Id: I4e84c570fe0e555a3aeb1f11632715de466d6e0e Reviewed-on: https://gerrit.libreoffice.org/58192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27svx: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by removing explicitly user-provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non-deleted in the future. (Even if a dtor was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already inline, so why bother with a non-inline dtor.) Change-Id: Ic8c24977a68d33a0051a74617fb4b4dcc2b664df Reviewed-on: https://gerrit.libreoffice.org/58094 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27Related: rhbz#1602589 add comments to coverity annotationsCaolán McNamara
Change-Id: I88c941832a0d682ea4b6028c28edd48cf5df38f7 Reviewed-on: https://gerrit.libreoffice.org/58093 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26Avoid com.sun.star.container.NoSuchElementException "Active" (3)Julien Nabet
Launch Math and notice this kind of logs: warn:unotools:4125:4125:unotools/source/config/confignode.cxx:444: DBG_UNHANDLED_EXCEPTION in com::sun::star::uno::Any utl::OConfigurationNode::getNodeValue(const rtl::OUString&) const type: com.sun.star.container.NoSuchElementException message: Active context: configmgr::RootAccess Change-Id: I4bb1af5caaf53086c243cc8e3a2746ff61cbb869 Reviewed-on: https://gerrit.libreoffice.org/58081 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-24Avoid com.sun.star.container.NoSuchElementException "Active" (2)Julien Nabet
Launch Base, use by default settings then create a form with the wizard and look at this kind of logs: warn:unotools:4125:4125:unotools/source/config/confignode.cxx:444: DBG_UNHANDLED_EXCEPTION in com::sun::star::uno::Any utl::OConfigurationNode::getNodeValue(const rtl::OUString&) const type: com.sun.star.container.NoSuchElementException message: Active context: configmgr::RootAccess Change-Id: I8a5e77ca1d51ab1a8e2b73972ad5d9a7acdce36b Reviewed-on: https://gerrit.libreoffice.org/57900 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-24loplugin:useuniqueptr in SfxViewFrameNoel Grandin
Change-Id: I1edd00a184d8ffab4cf327aefc4e786458ccce52 Reviewed-on: https://gerrit.libreoffice.org/57873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-22 20:08:43 +0000