summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Ifa46b0eb0fb8f288acbcf19f7090a62c6a1ecef3
2016-12-06Convert TextView to unique_ptrMark Page
The destructor contains reset to the unique_ptr's because it is not clear of the importance of the destruction order Change-Id: Ifbbb4fe8352cb3b50f18cebd60cf00af010c086a Reviewed-on: https://gerrit.libreoffice.org/31673 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05tdf#97361 remove = None assignments in sfx2 python unit testskerem
Change-Id: Iba3926d1b044ade69e1306941ed70b644dc577d6 Reviewed-on: https://gerrit.libreoffice.org/31602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05loplugin:unnecessaryoverride (dtors) in sfx2Stephan Bergmann
Change-Id: Ic086a22bccd267824e68df6c963df8da76e6df2c
2016-12-02usageinfo causes one of our more frequent fedora 25 crashesCaolán McNamara
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=17ba9a57f40d5ca29778866a9f96c1c0dfc7593c&bth=2f1801e44e9cb0be2b013624521fb0959dc2c73a&bth=5e8a1e07503f53b13b3a6779084f8b0637aaf5a7&bth=8033013a2ce586bccc23245583fa86ef4a761dce&bth=975271167132418534cb07336601efb5b0c711f0&bth=de75c2ad7917bc889d6307b152f79d34e79ce74d Change-Id: Ie93afa476eca9fdbf7ea17ff0189fbaa493a5531
2016-12-01sfx2: convert legacy DBG_ASSERT in SfxDocumentMetaDataMichael Stahl
Change-Id: Ic340d7226ea3af4bbd6e52c415b32d9be7cd453f
2016-11-30ScTabViewShell::InnerResizePixel must not mark document as modified...Stephan Bergmann
...when merely toggling the edit mode of a Calc document embedded in another document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet"). Interestingly, none of the other document kinds seem to have this problem. (Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls SetDocumentModified() at all?) Anyway, pass this inplaceEditModeChange information down there. Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe
2016-11-30sw: use auto when initializing with a cast to avoid duplicating the type nameMiklos Vajna
Change-Id: Ide7bd0f1f444824b78aa53cfe1db0129cbca1a5d Reviewed-on: https://gerrit.libreoffice.org/31397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30Emoji Control: Larger emoji renderingAkshay Deep
Change-Id: Iec51d4e73926cf8203638d2ad013ddfdd47d8ee4 Reviewed-on: https://gerrit.libreoffice.org/31256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-28tdf#101870 - Template manager thumbnail view control needs a borderAkshay Deep
Change-Id: If1773b99aa816b2b45fe16127ff09a646e3702ae Reviewed-on: https://gerrit.libreoffice.org/31324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-11-28These don’t need to be translatableAdolfo Jayme Barrientos
Change-Id: I889c5130bd32f038cb0b45d959b40bf63c0b3a58
2016-11-28tdf#104106 Enable save whenever edit mode activeMaxim Monastirsky
but in case of a r/o medium do "save as" instead. Change-Id: If99602481deb053c2f834b1c7f5d24eb725df9c1 Reviewed-on: https://gerrit.libreoffice.org/31308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24convert SFX_VISIBILITY constants to scoped enumNoel Grandin
* split the position and the flags information * remove unused DESKTOP constant Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2
2016-11-24convert SFXWB_ constants to scoped enumNoel Grandin
Change-Id: I63d442e51b7e22093da1c232e1b575bc961c0e69
2016-11-23make strings localizableAndras Timar
Change-Id: Ic74b55b12926a23e9e98308407a88e73dc9cb0c7
2016-11-21Kill the AutoPilotPresentations UNO commandGabor Kelemen
The presentation wizard was removed in bb8040595c9b6f0ccde39e6833f27a50abb891d8 but the corresponding UNO command is still available. Change-Id: I54e676672bb53d0283394a0ebffbe9f94f29d9c0 Reviewed-on: https://gerrit.libreoffice.org/30983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-21add missing depDavid Tardon
Change-Id: I0d2a2c32d99ee11e63a2363f8a17bd4efd72cc22
2016-11-21use the right config depDavid Tardon
Change-Id: I1d387ac566008efd5b0fe7e5e4a4f1bc8462107f
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-18editeng: assert SfxPoolItem::operator==Michael Stahl
Change-Id: Ia6c6f4f5af1e3a803b464ab410558984c3861a65
2016-11-18sfx2: let .uno:SignPDF result in a warning before editing the docMiklos Vajna
Editing such a document is most probably not what you want, help the user to avoid the trouble. Change-Id: I87d52d89e12658675b580b7dc21fb38fe41dd777 Reviewed-on: https://gerrit.libreoffice.org/30955 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-18includes should be at the top of the fileNoel Grandin
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17sfx2: let .uno:SignPDF result in a custom infobar textMiklos Vajna
To make the intention a bit more explicit. Change-Id: I70ce053b9f068a2288e4a05eba55fb3e2451b561 Reviewed-on: https://gerrit.libreoffice.org/30935 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-16make the element names in dumpAsXml match the class namesNoel Grandin
Change-Id: I955facfe3e901fcb76798dab342f96a67d5ac63f Reviewed-on: https://gerrit.libreoffice.org/30894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16new loplugin finalprotectedNoel Grandin
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14tdf#103897 No space between template previews from Start CenterNoel Grandin
regression from commit 96e9ffa64706f523d67659a20a0ccce6fbd0cb91 (patch) loplogin:singlevalfields in include/ I did not notice that the mnItemPadding field was shadowing a declaration in a superclass Change-Id: I52cf9945da43fa3d1049b624a6b24bc6d974d445
2016-11-14minor opt tweaksCaolán McNamara
Change-Id: I418d0e04f8d4373c0d9f1f106ac0cc7779029802
2016-11-14loplugin:unusedmethodsNoel Grandin
Checked a couple of them: StandardCheckVisisbilityRedirector is unused since commit b1f8cf37828d5f37527e54774aa4935610aa6325 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Nov 2 10:57:21 2016 +0200 loplugin:singlevalfields SfxQueryStatus is unused since commit 64a708cba9b954afe3331f63c58218eb53b3d0ce Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Nov 5 20:28:27 2016 +0000 Revert "Reverts a commit series that cripple windows ci." Change-Id: If1c9fe26c3ebc573d8c53c8f060b05c27f2711e5 Reviewed-on: https://gerrit.libreoffice.org/30840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14tdf#94262: fix performance of MakeTree_Impl(...) in templdlg.cxxAron Budea
1. replace 2nd level for-loop with a helper unordered_map that maps style name to its pointer 2. replace 3rd level for-loop with std::lower_bound, since the children are inserted sorted (based on natural sort) ...and a few related, minor changes. Change-Id: I48f59f2e1ca416de1e2957e0d1d3708ed6e67112 Reviewed-on: https://gerrit.libreoffice.org/30744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-14tdf#68118: Pass current document frame to SvxScriptSelectorDialogMike Kaganski
... through MacroChooser Without this, current document's macros library is unavailable in "Assign" dialog Change-Id: I83baa3b98858260eab61e8f4fefde3f9979c6d83 Reviewed-on: https://gerrit.libreoffice.org/30600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-13sot: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Ib4ec7d5c3dc89c80cc46bbbe8a14f6b1393ffa76 Reviewed-on: https://gerrit.libreoffice.org/30767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11Resolves: rhbz#1391418 wayland toolbars can't be docked after undockingCaolán McNamara
see gnome#768128 for extra details under wayland, given the misery here I'm going to just disable toggling between docked and undocked under wayland, and throw away user config on toggling docked/undocked away from the defaults. You can still drag docked things around to new docking position, but you can't pull them out of the dock to float. non-wayland is unaffected Change-Id: Iaa859f3420e6d1b103a8b93d1ad8f82dbffe75d4 Reviewed-on: https://gerrit.libreoffice.org/30752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-10sfx2: fix showing PDF signaturesMiklos Vajna
A ZIP storage was unconditionally assumed when calling showDocumentContentSignatures() for "originally" read-only documents, i.e. in case the file itself is read-only at a filesystem level. Change-Id: Iba69000fc396afaf5ab34699e811b5d2c216e2bb Reviewed-on: https://gerrit.libreoffice.org/30758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-10Wrap pointer to dialog with VclPtrTakeshi Abe
Change-Id: Ifaf0f45b12d983d556ca4c7e0b4a57c47ff38597 Reviewed-on: https://gerrit.libreoffice.org/30737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08sfx2: let .uno:SignPDF add a matching button to the infobarMiklos Vajna
When the user uses .uno:SignPDF to open a PDF file in read-only mode, then the infobar now has a "Sign Document" button, which is a shortcut for the File -> Digital Signatures -> Digital Signatures menu item. Change-Id: I2953a5cb1252c5ff1c395d45c54db1a97b39433e
2016-11-08tdf#88023: Only warn about unavailable JRE onceMike Kaganski
The underlying design is that there's a single JavaInteractionHandler instance owned by a JavaContext, and that JavaContext installed in Desktop::Main (desktop/source/app/app.cxx). This patch ensures that no additional JavaContext is created in SfxOfficeDispatch::dispatch*() functions unless they are used without preinstalled JavaContext. Thanks to Stephan Bergmann for guidance! Change-Id: I2569df221067a5b9bf1f6cd5d8f69b561316a170 Reviewed-on: https://gerrit.libreoffice.org/30529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-27 14:54:24 +0000