summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-04-10loplugin:inlinefields in SfxSaveAsTemplateDialogNoel Grandin
Change-Id: I7b32fc64b96e2f89edc810d4a95d3a3f6f885957 Reviewed-on: https://gerrit.libreoffice.org/36352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-07Revert "Remove button handler and let the button dispatch the uno cmd"Michael Stahl
This reverts commit 6584735bba4b96fbde5c7be55dc6c98878ad059a. Ooops, that doesn't build any more without the previous reverted one.
2017-04-07Revert "Related tdf#105566 Update Infobar when signature status changes"Michael Stahl
This reverts commit d8faf3bf9a82e8f49340b5020ec4ee931cc2f3f4. This causes an infinite recursion in JunitTest_sfx2_complex involving the newly added SignatureHelper::updateInfoBarState().
2017-04-07Remove button handler and let the button dispatch the uno cmdSamuel Mehrbrodt
Change-Id: Iac4d0e1bf96505b02102ae94ca703c00d5348466 Reviewed-on: https://gerrit.libreoffice.org/36252 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-07Related tdf#105566 Update Infobar when signature status changesSamuel Mehrbrodt
gpg4libre Change-Id: I8f29cf16905c79d19d46662b087f4fd8778c8147 Reviewed-on: https://gerrit.libreoffice.org/36251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-07Drop remains of the Welcome Screen featureGabor Kelemen
Which was dropped in e299ef4952a580bdbd416cef3e1a2feba4979e13 (that was in 2001) Change-Id: I5860bb44ced35b338f667e47d89f6ed1d597dc11 Reviewed-on: https://gerrit.libreoffice.org/36159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: sfx2Stephan Bergmann
Change-Id: Ic524a0fc2c1038202456dcf0aa51a8a3eb9a70b0
2017-04-06Resolves: rhbz#1438876 detect preferred help module for csv dialogCaolán McNamara
For calc import before any toplevel is created the context is otherwise unknown. If a help id starts with a specific module name, then default to that module name as default help category context. Cosmetic, same help is shown in any case because its in the shared section, but title bar would state "Writer" when context is expected to be "Calc" Change-Id: I3323bc55ef23ec162dad4349efb5e84ec3e8054c
2017-04-06split out module->help mappingCaolán McNamara
and add the missing not-toplevel-in-help ones from... ls instdir/share/config/soffice.cfg/modules|sort|uniq Change-Id: I618d91e1271b3a200928494156d93cbfef45c19f Reviewed-on: https://gerrit.libreoffice.org/36206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-05teach constantparam plugin to find always on and always off bitmask valuesNoel Grandin
Change-Id: If56a483494bd3d7feb3fa67c01000dddd0d34421 Reviewed-on: https://gerrit.libreoffice.org/36085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparamNoel Grandin
Change-Id: I1996319e5b664dff95f7a9b2346aea6092d333ec Reviewed-on: https://gerrit.libreoffice.org/36070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04can simplify nowCaolán McNamara
Change-Id: I234e630f3af1acfa39900464abd7e06efc47a671
2017-04-04Resolves: tdf#106935 restore traditional toolbar labelsCaolán McNamara
Change-Id: I00cf16e9ce429f9186cc900a07f4d386e33b8f7b
2017-04-04Adding other spec-files to READMEdennisroczek
Change-Id: If6e28474a234dc1ca01d927a2a6c1f1a51f430c7 Reviewed-on: https://gerrit.libreoffice.org/36044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-03tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in UnoControls/, editeng/, filter/, odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/, tools/, writerfilter/, and xmloff/. Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1 Reviewed-on: https://gerrit.libreoffice.org/35992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03coverity#440972 Dereference before null checkCaolán McNamara
Change-Id: If4a1da1859dbdf19a7084341003fd6c41700971f Reviewed-on: https://gerrit.libreoffice.org/36040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-01tdf#103391 Add missing title and secondary text to message boxAdolfo Jayme Barrientos
Change-Id: Ib3066f2b9134a07ee63cd9e36908690bf56d49fb
2017-04-01Fix typos: ist -> list and sublocality -> sub localityJens Carl
Change-Id: Ifc5e49528e4aafd19ed9bb1c93294dd921ac9210 Reviewed-on: https://gerrit.libreoffice.org/35993 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-31use actual UNO enums in sfx2Noel Grandin
Change-Id: Ide3ce0bc1afc9de46c2d06b161acff8d32fe1193 Reviewed-on: https://gerrit.libreoffice.org/35911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30remove type decorations on char literalsJochen Nitschke
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30use SFX_INTERFACE_NONE constantNoel Grandin
inside of constructing SfxInterface(0) by hand Change-Id: Ic2cbe39366a36b40b672242a250f68135d4e2cd3 Reviewed-on: https://gerrit.libreoffice.org/35892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Fix typo in methodAndrea Gelmini
Change-Id: Ib2b05abaeacd3b8787f938a49a0d9673096b5f42 Reviewed-on: https://gerrit.libreoffice.org/35857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29convert EViewType to scoped enumNoel Grandin
Change-Id: I5b10aada64408897a56a5932aa28486d7562d617 Reviewed-on: https://gerrit.libreoffice.org/35822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29expand vis to visible; fix typosdennisroczek
* translate German source code comments * remove bogus surce code comments * remove ascii art * removed old StarOffice/Sun internal bug tracker references * remove left over from commit dcd5dee88e3c1185638b190553bef65c2ef6566f Change-Id: I3c5cce621c43e4a03afb76f4cc5a12065914e5ad Reviewed-on: https://gerrit.libreoffice.org/35404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove enum slot code from sfx2Noel Grandin
since we only used it for the pseudo-slot stuff, which is now gone Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a Reviewed-on: https://gerrit.libreoffice.org/35759 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove unhandled SID commands from sfx2Noel Grandin
Change-Id: I5473dbb1fdc2c3779892610ab4ea5f6146291921 Reviewed-on: https://gerrit.libreoffice.org/35742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27create SfxInterfaceId o3tl::strong_intNoel Grandin
Change-Id: Ie52f63382a9fb36f9a472801be012b140bfb51f6 Reviewed-on: https://gerrit.libreoffice.org/35722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27remove unhandled SID commands in sdNoel Grandin
checked to make sure none of the related .uno commands are present in any .xcu files. Change-Id: Iec555836a0a926e070b7632dc1205decf49d331f Reviewed-on: https://gerrit.libreoffice.org/35615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26Fix typosAndrea Gelmini
Change-Id: I5518e764fd8349c476e79bb888e93a1dab01ed1d Reviewed-on: https://gerrit.libreoffice.org/35644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24Just include sal/types.h nowadaysStephan Bergmann
Change-Id: Ic8f6322854ff0ac25c34cd9286545c8aaa27d03b Reviewed-on: https://gerrit.libreoffice.org/35628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22create SfxDisableFlags enumNoel Grandin
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f Reviewed-on: https://gerrit.libreoffice.org/35514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-21Notebookbar: correct initial icon sizeSzymon Kłos
Before this patch initial icon size in the NotebookbarToolBox was determined by Sidebar settings not Notebookbar Change-Id: I66ac709c606ef60fb3505bbbe51dfebbcc81d20c Reviewed-on: https://gerrit.libreoffice.org/35493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-20uitest: use the new ui test logger also for the UNO commandsMarkus Mohrhard
Change-Id: I220b817df82cd0f26f6d8b72a28b7becfd954461 Reviewed-on: https://gerrit.libreoffice.org/35448 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-19uitest: add a way to log the UNO commandsMarkus Mohrhard
Change-Id: Ibbf7fd8e44b0be82e496eab6d98468f03038e60f Reviewed-on: https://gerrit.libreoffice.org/35441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-19Use just geParameter instead of hasParameter + getParameterMatteo Casalin
getParameter returns and empty string if the key is not found, so we can just avoid searching twice for the same key. Change-Id: Ic48debce05fe94d8e087b64bde5a589e54bfb616
2017-03-19OUString-related simplificationsMatteo Casalin
Change-Id: I2f4099410bcdb9e04583cd37bf63ef86ce81f7e5
2017-03-19Can return const OUString&, hereMatteo Casalin
Thanks to Noel Grandin for his suggestion. Change-Id: Ia0d9c46c03928e5551e766572c814f4e9ba6f278
2017-03-19SfxViewFrame::ExecReload_Impl - remove written-only variable aURLMatteo Casalin
Its only user was commented-out by commit 6c1be80980cbf02ecaf07996b1c2be5777f59124 (2004) and then removed by commit 40fe03745fc75609350cf8115134eb07f04eefa7 (2010) Change-Id: I821a97275b79230e9e389a9b57c82110fa16aa8e
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19fix typo/grammar: "the the" --> thedennisroczek
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: https://gerrit.libreoffice.org/35151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17SfxObjectFactory: directly store factory name as OUStringMatteo Casalin
Change-Id: I0779be1e4b344124514115c6645394d26ac09c36 Reviewed-on: https://gerrit.libreoffice.org/35375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Remove SfxObjectFactory::GetShortName()Matteo Casalin
Used in just two places, where GetFactoryName can also work. Change-Id: I8d498345c41aef520ef776a3deb6744cc64756f5 Reviewed-on: https://gerrit.libreoffice.org/35374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>