summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-01-17coverity#1427631 sfx2: fix silly infinite loopMichael Stahl
(regression from 9ef1734f03a008545a01fd394dd0e979bb230a0f) Change-Id: I31dc5e7aff80f647d8417c290f8f34c43e54486d
2018-01-17tdf#60937 Open Start Center on Quickstarter left-clickAbhishek Shrivastava
This patch modifies the click actions on quickstarter on Windows. Earlier a left double click opened up Template Manager, which wasn't user friendly. Now on single left click on quickstarter icon it opens up Start Center Change-Id: I23e56d5d1bb3f4bfc060149dec60de30ae1207cd Reviewed-on: https://gerrit.libreoffice.org/48026 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-17loplugin:unnecessaryparen extend to delete statementsNoel Grandin
Change-Id: Ic4383ea948876a26f791f0e5b0110cef978a26e1 Reviewed-on: https://gerrit.libreoffice.org/48027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16tdf#113755 - avoid null ptr de-reference during shutdown.Michael Meeks
Why the PostUserEvent's that should do the XTDataObject async destroy are not completed by here, is rather unclear; but - de-referencing NULL is not a great thing to do during shutdown. http://crashreport.libreoffice.org/stats/crash_details/a7d8fd19-0512-4292-b3a0-140dcff204c8 Change-Id: I3f294379f07f4cfc0106c1b5fc5e705c41e78b03 Reviewed-on: https://gerrit.libreoffice.org/48007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-01-16use more ScopedVclPtr to avoid missing disposeNoel Grandin
follow on to commit 315be3a276b01e88c794da1dbc6252a8b803d269 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 12 10:48:59 2018 +0000 VclPtr, missing dispose Change-Id: Idfa4709f10928ef6d53ada93db0f5452e5d5c4eb Reviewed-on: https://gerrit.libreoffice.org/47982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16sfx2 store: handle NoFileSync for Save (not SaveAs)Miklos Vajna
The code-path in SfxMedium and lower layers is the same, but not in SfxObjectShell. Change-Id: I85542d17cd6b3c2a0d257f5ff196e6504a194e51 Reviewed-on: https://gerrit.libreoffice.org/47903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-15lokdialog: Allow closing the Format Cell dialogs in any order.Jan Holesovsky
Includes also lots of infrastructural changes, making the conversion of the rest of the dialogs much easier. StartExecuteAsync should be used in-place of StartExecuteModal and the latter removed from the code-base incrementally. More common code from Dialog::Execute should be moved to ImplStartExecuteModal in a next step, as this is used more widely. Change-Id: Idb2c1ec790e38f582438471a0419a56cdcf1439d Reviewed-on: https://gerrit.libreoffice.org/47722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-15More loplugin:cstylecast: sfx2Stephan Bergmann
Change-Id: Ifdb964558f070e7c9ee87eabeaafa5c3c079c0c9
2018-01-14Fix typosAndrea Gelmini
Change-Id: I2b4988e1d81fe60f7699362480cd739d2620c053 Reviewed-on: https://gerrit.libreoffice.org/47856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-14Fix typosAndrea Gelmini
Change-Id: I2a578961837076ebce3c1fb2681b0785d1d490ac Reviewed-on: https://gerrit.libreoffice.org/47857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-13Foreground colors adjustedCaolán McNamara
to comply with WCAG 2.0 level AAA requiring a contrast of 7:1 Change-Id: I71edc354f3f9a3d534452bb378743d1f9639a08f Reviewed-on: https://gerrit.libreoffice.org/47825 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-13gpg4libre: open encrypted files also via gpgThorsten Behrens
Adds code to sfx2 and package to try gpg4libre for extracting session keys, and use them in turn to decrypt odf storage. Change-Id: I1f626143e6c8443b4ad0c4fc5bdbd5ab8d56a451 Reviewed-on: https://gerrit.libreoffice.org/47780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-12tdf#114939 sfx2: notify user of non-interoperable passwordsMichael Stahl
For ODF 1.1 encryption, SHA1 is used as the start-key digest algorithm of PBKDF2. For the ODF export password-to-modify "feature", PBKDF2 is used without a start-key digest round, so the UTF-8 encoded password is directly the input. In both cases, if the user entered a password with a known problematic length, reject it and request a new one. Change-Id: Ie6510c1e668e1ed32be439ebe00354881b6ca83f
2018-01-12tdf#114939 officecfg,sfx2: always use AES/SHA256 in ODF 1.2Michael Stahl
The setting ODFVER_012_EXT_COMPAT "1.2 Extended (compatibility mode)" no longer has an effect on the encryption algorithms. API CHANGE: Remove the configuration settings: Office.Common.Save.ODF.UseSHA1InODF12 Office.Common.Save.ODF.UseBlowfishInODF12 Rationale: * Every release since 2012, from LO >= 3.4 and AOO >= 3.4, can read AES/SHA256 encrypted files. * SHA1 is broken anyway * tdf#114939 causes SHA1 interop issues Retain SHA1/Blowfish only for ODF 1.1 export. Change-Id: I007511d4830a90121e38bf5bb4534df5695621e9
2018-01-12sfx2 store: add API to allow disabling thumbnails only for a single saveMiklos Vajna
This is similar to the officecfg::Office::Common::Save::Document::GenerateThumbnail config setting, but here we allow configuring this at a per-save basis, not persistently. Change-Id: Ieb5bd57f1d8fc9e211011f2647276d985cf53131 Reviewed-on: https://gerrit.libreoffice.org/47812 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-12More loplugin:cstylecast: sfx2Stephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ia3bed56999f3d684f706ce0bd5be8a2269b06d22
2018-01-12no button has default focusCaolán McNamara
Change-Id: I4b9e27d53a01a8d27b8b8faade45cd957ae34fb9 Reviewed-on: https://gerrit.libreoffice.org/47799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-12ODT export: handle NoFileSync store optionMiklos Vajna
SfxMedium already had a m_bDisableFileSync member; if the medium has a storage, then forward this flag to it, so at the end SwitchablePersistenceStream::waitForCompletion() (and the called fileaccess::XStream_impl::waitForCompletion()) does not call osl_syncFile(), either. Times for 100 hello world inputs: 12594 -> 5281 ms is spent in XHTML-load + ODT export + close (42% of original). Change-Id: I2aab6c9e6baf133b211620004dcea66bd41ffc6f Reviewed-on: https://gerrit.libreoffice.org/47766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-11[API CHANGE] migrate PackageKit usage to Modify2Caolán McNamara
xid dropped in favour of application_id Change-Id: Id1eb43aa9c8dfb4eac82f99eff0f84c5320e0da0 Reviewed-on: https://gerrit.libreoffice.org/47661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11tdf#114802 Emojis palette inserts code instead of emojiNoel Grandin
regression from commit 027b25ecd54ac97ea2471ca73e3ba89ce052fe76 use comphelper::InitPropertySequence in more places Change-Id: I587242427c00ebf1faf44ad6b12090a39a1a3ef7 Reviewed-on: https://gerrit.libreoffice.org/47704 Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-10This is a hash: '#', this is a slash: '/'Tor Lillqvist
Change-Id: I3a0bd41f021547678f7e423d10c8900723006bb6
2018-01-10sfx2 store: add API to allow avoiding the fsync of the output fileMiklos Vajna
The use-case is when the consumer of the output file will read it right after SfxBaseModel::storeToURL() returns, in which case an expensive fsync is pointless. Times for 100 hello world inputs: 8516 -> 2785 ms is spent in ODT-load + HTML export + close (33% of original). Change-Id: I05e424a43ebfeea363f82b57af60f5aaa28696b4 Reviewed-on: https://gerrit.libreoffice.org/47695 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-09sfx2 store: avoid custom parent for tempfiles during loadMiklos Vajna
Hopefully this fixes: shutil.Error: [('/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sw/qa/extras/rtfexport/data/testTdf74795__Import_7fmlh7.tmp', '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/tempdir/gbuild53mqa9vx/sw/qa/extras/rtfexport/data/testTdf74795__Import_7fmlh7.tmp', "[Errno 2] No such file or directory: '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sw/qa/extras/rtfexport/data/testTdf74795__Import_7fmlh7.tmp'")] from PythonTest_solenv_python at <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/18100/console>, given that we now set a custom parent for temp files backing up output streams only, not input ones. Change-Id: I395fcb9ff668796ae2ac0425eef9b5d2d8cc0987 Reviewed-on: https://gerrit.libreoffice.org/47664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-09sfx2 store: try rename before copyingMiklos Vajna
Rename is cheaper then copying the content over manually, so try that first. Change-Id: Ieb1d03e39501c1565dae7e3290e318a09ee18965 Reviewed-on: https://gerrit.libreoffice.org/47612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-09sfx2 store: create temp files next to local filesMiklos Vajna
This way it's more likely that we can do a cheap rename instead of a copy in SfxMedium::Commit(). Change-Id: I45c80cd19c3ab3bc70ecbf9793dbe1bb55994ee9 Reviewed-on: https://gerrit.libreoffice.org/47611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-08LOK: Honor the user's language when issuing help.Jan Holesovsky
Change-Id: I2cfe5e5ae0e10dffb7b5672fccdc71af6060491d Reviewed-on: https://gerrit.libreoffice.org/46435 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ca35b857cc99dcd909e5c2662043ea6a4ffdf244) Reviewed-on: https://gerrit.libreoffice.org/46969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-06lok: send modified status when applying cell-formula before savingAshod Nakashian
Without this, the modified status resulting from applying the cell-formula immediately before saving is lost, since it is clobbered after the save. Change-Id: Ie402812d0fc0528020161fffe57e8220c5abfeb5 Reviewed-on: https://gerrit.libreoffice.org/47366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-01-05Fix typosAndrea Gelmini
Change-Id: I766862d255ac285329ae423629c7445837ddd55f Reviewed-on: https://gerrit.libreoffice.org/47280 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-01-05lokdialog: Use only one of the installed langpacks when setting locale.Jan Holesovsky
Change-Id: I446775b121b7806a549f4dbbaa1f2dcf019d9bc2 Reviewed-on: https://gerrit.libreoffice.org/47386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-05lokdialog: Allow language switching in SfxModule(s).Jan Holesovsky
Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b Reviewed-on: https://gerrit.libreoffice.org/47385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-04remove SfxUsrAnyItem typedefNoel Grandin
and rename SfxUsrAnyItem class to SfxUnoAnyItem, the choice being made by leaving the most popular one behind Change-Id: If3818ee0966a50e3036d7e2db951910b6282c91f Reviewed-on: https://gerrit.libreoffice.org/47313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03sfx2: improve reported error message in SfxBaseModel::impl_store()Miklos Vajna
Old: com.sun.star.io.IOException: SfxBaseModel::impl_store <file:///c:/lo/bugs/saved.xhtml> failed: 0x507 New: com.sun.star.io.IOException: SfxBaseModel::impl_store <file:///c:/lo/bugs/saved.xhtml> failed: 0x507(Error Area:Io Class:Access Code:1287) It's much easier to find the relevant define in include/vcl/errcode.hxx based on the new output. Change-Id: I7d98dcf1ead10264672b45de570e51a153090499 Reviewed-on: https://gerrit.libreoffice.org/47319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-03loplugin:passstuffbyref more return improvementsNoel Grandin
slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02RID_* can be extern global variablesNoel Grandin
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: https://gerrit.libreoffice.org/47245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-01Bump copyright year to 2018Adolfo Jayme Barrientos
Change-Id: Iabd06fbda15d2f83f6ee0cdd37b268910d380476
2017-12-29Fix typosAndrea Gelmini
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e Reviewed-on: https://gerrit.libreoffice.org/47126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28follow-up tdf#89676 Add some explanation in commentLaurent BP
Change-Id: I740b91e801dc658551ff7ec848f7e4941b9273af Reviewed-on: https://gerrit.libreoffice.org/47113 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-28tdf#104870 - Impress crashes switching views in read-only modeTamás Zolnai
We need to check read only mode similar to SidebarController::CreatePanels() method. Otherwise SfxUnoPanels::getByName() creates an invalid panel. Change-Id: Ib7801b81c95f3f505a06c00f749ba4ed5809bfe0 Reviewed-on: https://gerrit.libreoffice.org/47116 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-27loplugin:passstuffbyref improved return in xmloff,sfx2Noel Grandin
Change-Id: I7161dfca77f944027bd20614616e22d6acfa27cd Reviewed-on: https://gerrit.libreoffice.org/47081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-22lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22tdf#114088 tdf#113795 Improve Writer templatesLaurent BP
Main topic was to add Title in meta.xml to get names of templates localized Additionnal improvements: Businesscard-with-logo - set Title in meta.xml - remove configuration2 (update manifest.xml) - remove unused font - remove user defined styles - insert field Name instead of Name - remove language dependant information - links that need to be updated at the begining Modern business letter serif - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information Modern_business_letter_sans_serif - replace Open Sans font with Noto Sans - remove unused font - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information CV - set Title in meta.xml - remove unused font - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information Resume - remove unused font - remove configuration2 and settings.xml (update manifest.xml) - remove language dependant information - ODF validator does not accept 0in as first value of style:border-line-width-bottom, but seems valid in ODF 1.2 http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-style_border-line-width-bottom Default - set Title in meta.xml - add thumbnail.png (update manifest.xml) - remove language dependant information Modern - set Title in meta.xml - add thumbnail.png (update manifest.xml) - remove language dependant information Synchronize Templates names in strings.hxx Change-Id: I417c8398b0002a26e2f84d7efdaeddc0576f9a8c Reviewed-on: https://gerrit.libreoffice.org/46580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-12-22Revert "unused SID command in sfx2"Noel Grandin
This reverts commit 08f4ecd5823c420bb7157c238460d50f1f1f9791. Change-Id: I93c4e44de73ce62b4cad7e3c6c56943dafaaebb4 Reviewed-on: https://gerrit.libreoffice.org/46966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-22lokdocview: android: tiled annotations is the cause of the problemPranav Kant
The earlier workaround only fixes it for android but keep other clients like gnome-documents broken. The real problem with these clients is that they ask lokit to render annotations in the tiles. This patch should keep the problem fixed for android and additionally make gnome-documents work, or any other lok clients who do not use comments API but render comments in tiles. Change-Id: I942f988698a9a43abedef7c998589be7f00a4ac0 Reviewed-on: https://gerrit.libreoffice.org/46975 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-12-21unused SID command in sfx2Noel Grandin
Change-Id: Ib11b2fb8d922cf522cc28d86082036b75002ba87 Reviewed-on: https://gerrit.libreoffice.org/46908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21set dbus id for existing DbusSessionHelper usersCaolán McNamara
Change-Id: I64329e21ae79b6607856de9781bee0274b9cb136 Reviewed-on: https://gerrit.libreoffice.org/46854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-21lokdialog: InitShow can happen multiple timesPranav Kant
Change-Id: I120a49f8a3fa96eb93d6de6de1d0715134520678 (cherry picked from commit c24bfdbff68f52d65ca56cc4ff7d8377898180d7)
2017-12-20tdf#104229: properly switch to def sidebar deck on status changeAron Budea
regression since a64999511ae654131d997eec9a3d78478cfc1c75 Change-Id: Id1d0a76f89c41e88511f670f1aac4b866e4c15c6 Reviewed-on: https://gerrit.libreoffice.org/46840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2024-08-10 09:43:20 +0000