summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-02-12cid#705226 missing break in switchNoel Grandin
Change-Id: Id9457d2e7a6778fee9fa5ec32d2bb97cb8b7d296
2014-02-12coverity#1130420 improper use of negativeNoel Grandin
Change-Id: I463764faffb1013a8c8d10c64695289080c3205c
2014-02-11coverity#1130402 Missing break in switchCaolán McNamara
Change-Id: Ifd86d24bb6a7957d4da392bed3f5ebda8d0fa690
2014-02-10coverity#441011 Dereference after null checkCaolán McNamara
Change-Id: I8a3430440bdd8cc1561eb60863c2bda3df8eac6d
2014-02-10Linked with -> Inherit from in style dialogAlexander Wilms
Change-Id: I3ca5f297217c898a12375f7f8e9c57841cd3db84 Reviewed-on: https://gerrit.libreoffice.org/7941 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10related fdo#65430: forgot to 'unlink' setOpenTemplateHdlJoren De Cuyper
This was introduced in 96e7225260aac0815643a4043f4ddb4e6b5764a1 Change-Id: I9bb8abbc9e9167b1e43bebf4477cf73010bf2d92 Reviewed-on: https://gerrit.libreoffice.org/7958 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10fdo#74782 search view doesn't hide local view when searching first timeJoren De Cuyper
See bug report for screenshot of current behavior. When the search button is hit, OnTemplateSearch() is called. If we switch from 'no search' to 'search' view, mpSearchView was not hidden. This'll result in SearchUpdateHdl that mpCurView will not hide. It doesn't matter if we hide it anyway (either when we would start searching, or end searching). If we start searching, we don't have any search term yet (so no result anyway). If we stop searching, it has to be hidden for sure. Change-Id: I6bcf540b4866eeb6a8196c171027b385635cf084 Reviewed-on: https://gerrit.libreoffice.org/7969 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10coverity#1130368 Unchecked dynamic_castCaolán McNamara
Change-Id: Ib4ae0ce1647e15bf1b9d7fe8e2d3bcfcb8ec1466
2014-02-10the return of callcatcherCaolán McNamara
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10Resolves: rhbz#1063170 Don't URI-encode filename in e-mail subjectStephan Bergmann
Change-Id: I7e3f59af5bb7d89c74e2bf199a727b2419714121
2014-02-10startcenter: don't generate thumbnails in headless modeMiklos Vajna
Commit e2eda70f2746f08376d8cdf5e5360df217335aef (startcenter: fdo#72469: Thumbnails also for other file types than ODF, 2014-02-03) turned on thumbnail generation for non-ODF documents as well. This is not that interesting in case --headless is used, however it slows down unit tests quite a lot, resulting in about doubled toplevel noop make time. Numbers on my machine for toplevel 'make' (in case there is no code to rebuild): - before: real 5m56.857s - after: real 2m39.432s Change-Id: I0edc13c29a7713f8faf8158ba240151977cdfa4b
2014-02-09coverity#1169825 Dereference after null checkCaolán McNamara
Change-Id: I74df9084f46e38901b6682b892fa7d0f71d72572
2014-02-09Typo: I/internaly -> I/internallyJulien Nabet
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-07coverity#735493 Logically dead codeCaolán McNamara
Change-Id: Iddf09c1acb7d2e812b86c6f14f5394a6a266d258
2014-02-07fdo#60586 - [Template manager] Switching tabs does not update breadcrumbsJoren De Cuyper
When applying a filter, lets go to the rootfolder of that filter Change-Id: I7034584da65ec777aa3cc288e1423596312caeec Reviewed-on: https://gerrit.libreoffice.org/7905 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07fdo#74506 fdo#74291 -Template manager-store selection before calling dialogJoren De Cuyper
It looks like calling a dialog/querybox result in a deselection of the selected ThumbnailViewItem(s). Therefore lets save this selection first, before calling such dialog. Change-Id: I45a1da4307759ca6472f793fff29b1e2507fd5c9 Reviewed-on: https://gerrit.libreoffice.org/7902 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07fdo#65430 add OnItemDblClicked and setOpenTemplateHdl in templateSearchViewJoren De Cuyper
Currently only templateAbstractView had such handler, which are templateLocalView and templateRemoteView are based on. Change-Id: I6694d0804a8b7e58abc0ddc970e811d053394d6f Reviewed-on: https://gerrit.libreoffice.org/7918 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07templatemanager: Fix empty dialog when saving templates.Jan Holesovsky
We used to call just mpTabControl->Clear() in setSaveMode(); but that worked only with .src dialogs, as the tab pages could have existed even without TabControl containing them. This is not possible with .ui definitions any more (and rightly so!), so show just one tab here for now, until we do a bigger Template manager rework. Change-Id: I400dbcc326e883a1c1f526e94974162c3641f8ae
2014-02-07templatemanager: Nobody calls setSaveMode(false).Jan Holesovsky
Change-Id: Ia1844523c3ed5544b4e250c7607d2148f1c4d3cd
2014-02-07templatemanager: Some items were hidden by default.Jan Holesovsky
Change-Id: Iec847eb2af74442d083153c5e1f307ed32497377
2014-02-07coverity#708818 Unused pointer valueCaolán McNamara
Change-Id: I9ffd3bd9fb4eeb7531dc489ce79c5b74e9ddc903
2014-02-07Convert template manager dialog to .ui + adapt code.Jan Holesovsky
Change-Id: I854abb47c2d22206ed5581373b3e841f221672e3
2014-02-06typo fixes in commentsAndras Timar
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06Typo: pasword -> passwordJulien Nabet
Change-Id: I612bf6bb620a76f9fa3542145e942969b9365d98
2014-02-06Typo: seam(s) -> seem(s)Julien Nabet
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
2014-02-06fdo#74148: sfx2: fix crash when editing templateMichael Stahl
SfxTemplateManagerDlg::OnTemplateEdit() accesses invalid iterator because during loadComponentFromURL() it happens that ThumnailView::LoseFocus() is called and maSelTemplates is cleared. Change-Id: I074a70e5ce8bc89a38b720ddd0325c69c1d2b9ff
2014-02-06coverity#1158398 Uncaught exceptionCaolán McNamara
Change-Id: I943b6233554d91e1a14f545e30f95528ca592924
2014-02-06Introduce com.sun.star.ui.theWindowStateConfiguration singleton.Matúš Kukan
Change-Id: I50861ac8952d54cb1a45846ea72a2ecac4f83409
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04Close Template Dialog when we saved a templatejorendc
Change-Id: I1529e7d628984d9720dd1169816911a957df7a11 Reviewed-on: https://gerrit.libreoffice.org/7850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04*_AppDispatchProvider_get_implementation cannot bypass XInitializationStephan Bergmann
...as SfxAppDispatchProvider implements new-style service css.frame.AppDispatchProvider that doesn't declare any non-default ctors (which looks broken, though) and old-style service css.frame.DispatchProvicer. (And fix the test code to pass in meaningful XInitialization arguments.) Change-Id: Ifcc32d17f6b96ade2acc40ccdb60f7bad2d503a4
2014-02-04startcenter: fdo#72469: Thumbnails also for other file types than ODF.Jan Holesovsky
Change-Id: If905b2f3e51adf7e64df9385ede74368acd11771
2014-02-03fdo#72338: startcenter: Show busy mouse pointer when starting apps.Jan Holesovsky
Change-Id: I8f254419ea7bb4e3e9835bd9fab8229ed89cd0e9
2014-02-03startcenter: Don't cut off the thumbnails.Jan Holesovsky
Change-Id: Ie5ad5f5be48aa873df94a31e980aaabc4ac24868
2014-02-03thumbnails: bSigned is always false, nobody uses the signed sign, kill it.Jan Holesovsky
Not killing the icon itself, still seems to be used by on Windows in the shell code. Change-Id: I21c3b1ae6dfc65b6852659d6157b02324a485774
2014-02-03thumbnails: Provide the size as a default parameter.Jan Holesovsky
And increase it consistently to 256 pixels. Change-Id: I123e11d597269d7e43298504f1dbd0098c9b0149
2014-02-03thumbnails: Consolidate code.Jan Holesovsky
There were 2 copies of the thumbnailing code; consolidate that to one copy directly in VCL. This kills the attempts to do alpha channel that used to be in the VCL copy of the code - it was producing wrong results, the bitmaps ended up empty. Change-Id: I415c410c287a95e75293bdcba5d71083d1d01dc1
2014-02-03Remove needless SAL_DLLPRIVATE annotationsStephan Bergmann
Change-Id: I5794e7ca922941e2d17a89cbaebfb2c6722519f8
2014-02-01fdo#64337 Do not show empty findbar in startcenter.Robert Roth
Using the shortcut for search on the start center displayed an empty toolbar on the start center. This commit adds a check to see whether the command to execute in the startcenter is FocusToFindbar, and if it is, it skips executing it. Change-Id: I0835e87d4a1eef0fc9ff17c184b531592b3e2d5a
2014-01-31Kill one indentation level.Jan Holesovsky
Change-Id: I5a5d98bb2f2d0749fb9113423f5663780ecf3520
2014-01-31fdo#71763: F6 key moves focus on this trip: Menu -> Sidebar -> Thumbnail viewZolnai Tamás
Sidebar and thumbnail View are actually not separate windows but F6 key traversal should simulate it as they would be. Define a new getfocus flag called GETFOCUS_F6 which means focus were grabed as a result of pressing F6 key. Use this and other two (GETFOCUS_FORWARD, GETFOCUS_BACKWARD) flags to indicate the focus were grabbed along subwindow relation (define a new ImplGrabFocusToDocument method with a flag parameter on the analogy of GrabFocus() <-> ImplGrabFocus()). Handle F6, Shift+F6 inside BackingWindow as it would have two subwindow (sidebar and thumbnail view). Plus Ctrl+F6 -> grab focus to the thumbnail view. Change-Id: Ie43d761e7cb0269afb79481a81947a4b96e1dde0 Reviewed-on: https://gerrit.libreoffice.org/7486 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-30fdo#73869 fix highlight RTL Problem at the StartCenter window.Faisal M. Al-Otaibi
Change-Id: I744d8f85c6e4c555ef8916281ebdc709fe6ddfa9 Reviewed-on: https://gerrit.libreoffice.org/7719 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: https://gerrit.libreoffice.org/7732 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30Introduce com.sun.star.ui.theWindowContentFactoryManager singleton.Matúš Kukan
Change-Id: If979db945b2f5e50e146fdadafd1559530c50122
2014-01-29Introduce com.sun.star.ui.theUIElementFactoryManager singleton.Matúš Kukan
To replace single-instance com.sun.star.ui.UIElementFactoryManager service. Change-Id: I4262909c4396e3907d271a56696a06903168a58d
2014-01-29Introduce com.sun.star.frame.ControllerFactory singletons:Matúš Kukan
com.sun.star.frame.thePopupMenuControllerFactory com.sun.star.frame.theStatusbarControllerFactory com.sun.star.frame.theToolbarControllerFactory To replace their single-instance service variants. Change-Id: I00586d0d61e63f9482cb659071e88aa9cf02d5b5
2014-01-29bool improvementsStephan Bergmann
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29Fix the error of shutdownicon.cxx.yangzhang
Change-Id: I91d62edd72e884a0139d3aca46aff0db88b202be Signed-off-by: shaochunfang <shaochun@multicorewareinc.com>
2014-01-28coverity#1019411 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: If7cc1cd9be357c9b9bb82bfffe3f560ac29e61d9