summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-06-07Resolves: tdf#96008 crash when an extension with legacy decks is installedCaolán McNamara
ReadLegacyAddons modifies its vectors of maDecks and maPanels in this case, but a load of things have (c++) references contents of the original contents. Its such a rats nest that the easiest thing seems to be to make them vectors of shared_ptrs and hold DeckDescriptor and PanelDescriptor by shared_ptr and it all works out (cherry picked from commit fce299fc64fcfe5280966631613edda7e6031c16) (cherry picked from commit 89d38b8e0201861edbdad826e28f993aba8786be) Change-Id: I3f628e12c7d5f4224d14d5e0769e450ce893fb54 Reviewed-on: https://gerrit.libreoffice.org/25875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-31tdf#96097: Can't save a doc with signed macro after autosave/save a copyGuillaume Smaha
Change-Id: Icc886a8d228cb786c6f318cfa2556ef113c553eb Reviewed-on: https://gerrit.libreoffice.org/24081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit d7ef7e3e4bc9c6277e5b2d08c2657fea8cf0e639) Reviewed-on: https://gerrit.libreoffice.org/24461 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-05-23set parent window of windows system file picker on save(as)Oliver Specht
If no parent is provided the Windows system file picker uses either the current foreground window or the desktop. The decision depends on the thread id of the foreground window. To make sure the document window is used as parent this is now also sent to the system file picker as it was already done for the internal file picker. Change-Id: Id589cbc1f91db30e065175aaea42ef1512ffb1b9 Reviewed-on: https://gerrit.libreoffice.org/24635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/25211 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-17Resolves: tdf#96092 crash on activating manage changes sidebarCaolán McNamara
Change-Id: I39ab778114e2317ac471e92f9441ed4a83e7023b (cherry picked from commit 296a67874a9e5ee1f93a38716e996207b1d2b59f) Reviewed-on: https://gerrit.libreoffice.org/24957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-10tdf#82160 Reset mouse pointer if doc loading failedMaxim Monastirsky
Change-Id: Ib05226345c4b83d9190839de5cc04068ce1879d8 (cherry picked from commit a4eba3762a01c1b686cf7de19b9391d56606e08d) Reviewed-on: https://gerrit.libreoffice.org/24801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-04-12tdf#89095 Start Center: bigger thumbnails for templatesAkshay Deep
TemplateDefaultView is now able to dynamically update the size of the thumbnail in its item. Removed padding for thumbnails. Change-Id: Ibc267c848a844098a59525c76e234f4f9c4d0ed1 Reviewed-on: https://gerrit.libreoffice.org/23816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 2e6ed7e0a0f7395d548cbbff71cb72ba32d10309) Reviewed-on: https://gerrit.libreoffice.org/23997
2016-04-11tdf#97398: Toggle deck/panel visibility individually for each appKatarina Behrens
Change in visibility of a shared deck ('any, any, ...') or panel made in 1 app must not affect its visibility in the remaining apps Change-Id: I78472ce078409edec796ef649349df4bda62a709 Reviewed-on: https://gerrit.libreoffice.org/23432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 1a045a9df7918adf4c0d8a62db3331f120266c6e) Reviewed-on: https://gerrit.libreoffice.org/23712 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-21tdf#98740 Infobar should not be in the customization optionsSamuel Mehrbrodt
Change-Id: Ib6675d621ad9c6ee5c4576ff95bb6eac39ef4b5f Reviewed-on: https://gerrit.libreoffice.org/23356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-03-15vcl: move graph.[hx]xx to graphic.[hc]xxChris Sherlock
It's IMO a bit confusing to see a "graph" header that doesn't strictly deal with graphs, but graphics. Backporting to 5.1 series to allow for easier backporting of other potential hotfixes. Change-Id: Ic37c6cd78e23d05939486f98667144c4453bb0a3 Reviewed-on: https://gerrit.libreoffice.org/22949 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-02-27tdf#98188: Crash when closing File->Properties->CMIS Properties tabGiuseppe Castagno
Change-Id: I22e1d6cc1c50b9ae613dab7c253ba21451aac584 Reviewed-on: https://gerrit.libreoffice.org/22704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit cadc130171a9bd4f1e6930fed09ad2897e9111b5) Reviewed-on: https://gerrit.libreoffice.org/22716 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-23Related tdf#81718: correctly display file size for...Giuseppe Castagno
...WebDAV elements. WebDAV UCP provider maps UCB 'Size' property to 'DAV:getcontentlength'. DAV:getcontentlength property is defined in Section 15.4 of RFC4918. <http://tools.ietf.org/html/rfc4918#section-15> Change-Id: Ie91d1f2aed417002f4d1ecae3e1188123c04d35b Reviewed-on: https://gerrit.libreoffice.org/22511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 86cd3df1ec9719e3a2a56dad1d9d7935f52a9f61) Reviewed-on: https://gerrit.libreoffice.org/22613 Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-16sfx2: related tdf#56270: loss of embedded objects imported from DOCXMichael Stahl
After the import some of these are kept in RUNNING state. For Math objects imported from MathType3 OLEs in particular, first a new Math object is created and stored to the XStorage, only then is the MathType3 stream imported. This means the Math object is modified and contains data that must be stored. The problem is then that SfxObjectShell::ImportFrom() simply calls setModified(false), clearing the flag without storing the object. For Flat ODF export we lose all the objects that are cached in sw's SwOLELRUCache; for the bugdoc something more inexplicable happens for ODT export where we lose "Object 214" (which is the first one in the cache) but no other ones. (The main difference is that for ODF there is an optimization to copy the embedded object's storage without loading the object, but for Flat ODF every object must be loaded and exported.) (regression from 83777cd6e0f3f1a4458af896fd13344c696ecb1e) Change-Id: Id1474fba9f4da2d5247c7ff4dc6819ddb9829fe8 (cherry picked from commit d81d104833f0ee9349ebcd0d79d2de84ba9a7262) Reviewed-on: https://gerrit.libreoffice.org/22334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-02-11tdf#56544: Support LO's .~lock.*# file locking over smb, tooStephan Bergmann
Change-Id: Ia18c3044aba82f935b13f22ba98aff42e9d5098f (cherry picked from commit 763521335b01a37c511ae8069cade9b4b69fef66) Reviewed-on: https://gerrit.libreoffice.org/22295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-07tdf#97051: prevent duplicate copy of SfxItemSetOliver Specht
the patch f7424ed710e54bb2437a28380b03ed7c26290edc introduced copying of the input item set of SfxTabDialog so now the item set of the style must not be copied anymore. Change-Id: If4155ee5999f0c5cd2ac754578a2c1b5ec33b14b Reviewed-on: https://gerrit.libreoffice.org/22022 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de> (cherry picked from commit 869c73d0d2512e483ceedcc895b7cb86e0974ab2)
2016-02-02tdf#96327: Fix accelerator for remote filesGabriele Ponzo
Change the accelerator from F to S, because it was conflicting with file menu. Change-Id: I1f3959ae12b09fb5d48a7379693c6afc1bafa906 Reviewed-on: https://gerrit.libreoffice.org/21898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit 43adbc8489cd724545a6cde72a8720a76ac554f0) Reviewed-on: https://gerrit.libreoffice.org/22016 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-28Related: rhbz#1289394 always provide the screen area the tip applies toCaolán McNamara
this will make it easier to implement native help tips Change-Id: I984dfadaf02e9b7bf542ba82cf070911c89cb699 (cherry picked from commit 01ef12d173fb2c54a49186c8eb4fa40288b82945)
2016-01-18fix a crash found in passingCaolán McNamara
save a spreadsheet with an embedded formula in it to xlsx and alt tab away before the save has completed Change-Id: I9df996d4cb459a2aa688d06a7d53465518bebf5c (cherry picked from commit 50c2d561981d99abad9978811655365ff9884c87)
2016-01-12New saving behaviorMaxim Monastirsky
Changes in this commit: - AlwaysAllowSave config is gone. Saving is always permitted, unless in a read only document. Also changed the behavior in dbaccess to match sfx2. - The toolbar save button is always enabled, to always give access to the dropdown. That's the case even in a read only document, except that it changes to DROPDOWNONLY, and the save as command icon+tooltip. In table/query designers we still disable the button in read only state. - When the document is modified, the toolbar button gets a special icon to indicate that. Reviewed-on: https://gerrit.libreoffice.org/20839 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 22328a224df4619218b88205838307f70612207e) loplugin:unreffun (cherry picked from commit ea708936c4684668f9aefc3ce9ec2001dbd4bdf2) Change-Id: I56c169bf48b78faaf53c2989ce8624f8297ffb6e Tango: Update Save icons and support “savemodified” status Change-Id: I03589895437907b9048542f07128801577fe62dc (cherry picked from commit a7198d38f0294ab5db04a7f4457565ea8b2c32f1) Reviewed-on: https://gerrit.libreoffice.org/21260 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-08Bump copyright year to 2016Adolfo Jayme Barrientos
Change-Id: Ifbd88aa55d5aa32a7b8dc11d7ac0310d0ef1e5d1 (cherry picked from commit 8085555f6de5905028fdc0761c9e5b2fd4a3609a)
2015-12-15tdf#95792: fix saving file the first time on some WebDAV servers.Giuseppe Castagno
Some WebDAV servers don't implement section 7.3 of RFC4918: <http://tools.ietf.org/html/rfc4918#section-7.3> This lack of implementation breaks 'Save As...' functionality when the target is a WebDAV server, by not locking the URL ('reserve the name for use', in RFC4918 parlance). The server not implementing this usually answers with one of '405 Method Not Allowed', '501 Not Implemented' or '412 Precondition Failed' http error codes. The fix should manage this lack of implementation. Change-Id: Ie4689a076aafa365106d02b3ea16459a28fcde65 Reviewed-on: https://gerrit.libreoffice.org/20600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4c82edfb3a9286a0bfef3f006e468e5c331987eb) Reviewed-on: https://gerrit.libreoffice.org/20722 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-12-15fix missing BaseURL when loading embedded objectsMichael Stahl
When the object is edited in the UI, the m_xClient is set to a SfxInPlaceClient and the DocumentBaseURL is retrieved from it. But if the object is not edited, it will be loaded during export via the API and without a m_xClient; in this case the DocumentBaseURL must have been set previously to be available during import. There appears to be no way to get the URL of the document via the API while it is being imported; SfxBaseModel's m_sURL is unfortunately only initialized from SfxObjectShell::FinishedLoading(). During ODF import, the SvXMLEmbeddedObjectHelper creates the embedded object, so let's make it pass in the parent's BaseURL. The "DefaultParentBaseURL" parameter already exists but was unused previously. Change-Id: I3d1ed29b3a2c0e77ec606a1d09f7bc07e7860733 (cherry picked from commit b0fc09daf1086423a9bd457d9a2c043e7ff41451)
2015-12-15sfx2: fix valgrind warningMichael Stahl
==7727== Conditional jump or move depends on uninitialised value(s) ==7727== at 0x9121E24: SfxDockingWindow::Resize() (dockwin.cxx:451) ==7727== by 0x3CADFAC3: SmElementsDockingWindow::Resize() (ElementsDockingWindow.cxx:753) Change-Id: Ie6e8a61f6c295373e5ccad409e2557e7c2dd6c1a (cherry picked from commit 8831281942b0ffe3dbdcea6febcda97a2ab665b3)
2015-12-10Memory leakStephan Bergmann
Change-Id: Ica40750d628946678019376d91db67ba3f9ed67e (cherry picked from commit 5ac6e00274e732435b55c2908db9cea658fe549b)
2015-12-08Missing deleteStephan Bergmann
Change-Id: I8ba75fcd2f98a49fe9d620af6b248f32911d7fe8 (cherry picked from commit de7018f755af0b2372c0e261f53d57de6cf77c38)
2015-12-03Resolves: tdf#95960 displaced field value in user-defined propertiesCaolán McNamara
Change-Id: Idc9e8fd0c35de48a2366dca3850bcc4e69ef997f (cherry picked from commit afc565bf26464a4999b45d8bc57545fa1ff534e5)
2015-12-02tdf#96162: sfx2: avoid re-creating existing sidebar PanelsMichael Stahl
Writer's naviagtor crashes when you click on a frame to select it, because the SwContent* that is passed to SwContentTree::GotoContent() is deleted because SidebarController::CreatePanels() re-creates every single panel and then ResetPanels() disposes the existing ones, which deletes the naviagtor's SwContent instances. (regression from 536c259cb9644971d0eb0cdfb7d823c5383a5481) Change-Id: I8f875df816a2d5948026a1d3f30b86bb2418acda (cherry picked from commit 02f2c2f8a160133731d707a8359f5cd576bff434)
2015-11-26vcl: reduce pointless timer / scheduler / idle includes.Michael Meeks
Change-Id: I8bf7f8d6ba1a54f2969e055956fadc52ff6c8673
2015-11-25loplugin:unusedfields in include/sfx2/Noel Grandin
Change-Id: I3eb27ed10e82ee56b33866ac576c1b1f8c9756b9
2015-11-24Pad this control a bitAdolfo Jayme Barrientos
Change-Id: Id05a77b83783c0e12a77bd5e91e595fa0ae29629
2015-11-24loplugin:unusedfields in include/framework/Noel Grandin
Change-Id: I04603a3b78b0611fcca4974b00e2da06045308d1
2015-11-23loplugin:unusedfields in sfx2/Noel Grandin
Change-Id: Id0d81901501683001107677c5573450c857ad094
2015-11-20Revert "tdf#95614 fix freezing with linked images"Michael Stahl
This reverts commit 58e2a9efe554ff2ac09a902d13a18e954487b672. It breaks CppunitTest_sw_globalfilter. Change-Id: I0eb787d698276b86bf4d77a5300ea98cce0fdea5
2015-11-20tdf#95614 fix freezing with linked imagesLászló Németh
Change-Id: Id9c718fda8f15d804e07ad87ff4ca930c2ea70cf
2015-11-20loplugin:nullptrStephan Bergmann
Change-Id: Ieb8821ed16707afd26329cb84277c96dca66d5b7
2015-11-20loplugin:stringconstantStephan Bergmann
Change-Id: Ia0a89419fffb9081df7da4696c3ec21ef3f0256b
2015-11-20loplugin:staticmethodsStephan Bergmann
Change-Id: Ia306219fdcce4633e85c34db343a99b21e88157e
2015-11-20loplugin:nullptrStephan Bergmann
Change-Id: I12e145be9c9f19c51e86075298f616b003054e10
2015-11-20tdf#67770 store sidebar elements statesLaurent Godard
deck & panel states at user registry level when disposing a sidebar if a shared deck (with "any" context application) is modified, it apply to all applications (eg. Gallery between calc and writer); TODO ? clean ResourceManager Get/Set const/non-const add panels when deck is created & refactoring * macro example Sub Main controller = thisComponent.currentcontroller sidebar = thisComponent.currentcontroller.getSidebar() sidebar.setVisible(true) decks = sidebar.getdecks() deck = decks.getByName("PropertyDeck") deck.activate(true) deck.setTitle("new deck title") deck.moveLast() panels = deck.getPanels() panel = panels.getByName("TextPropertyPanel") panel.setTitle("new panel title") panel.expand(true) ' expand and collapse other panel.moveLast() End Sub Change-Id: I2552000af92a366ebb51a479962a094b72e400b6 Reviewed-on: https://gerrit.libreoffice.org/17992 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-20loplugin:sallogareasStephan Bergmann
Change-Id: Ib1f06cb5f925535858bc14aab6f59ad7fd2a3a8d
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin
and use them Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec Reviewed-on: https://gerrit.libreoffice.org/20055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-19loplugin:sallogareasStephan Bergmann
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-18Unify menu-based toolbar controllersMaxim Monastirsky
The new GenericPopupToolbarController takes by default the popup menu controller that registered for the same .uno:Something command, and sets ToolBoxItemBits to ToolBoxItemBits::DROPDOWNONLY. If a different command specified using the "Value" property - takes the popup menu controller that registered for this command, and sets bits to ToolBoxItemBits::DROPDOWN. Change-Id: I75c5300bd27fcc9f618f2ee0df2aa6aefd088239 Reviewed-on: https://gerrit.libreoffice.org/20040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-11-18fix for windows buildNoel Grandin
after my commit 032dae364b4853635186b7541e40c71588f9050a "use unique_ptr for pImpl in sfx2/" Change-Id: Ib7361a6b030a8ed28383bf0d30935bd3fb4a397d
2015-11-18use unique_ptr for pImpl in sfx2/Noel Grandin
Change-Id: I564fa80a2642a4849127f3c25236634289b5b93d
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Id3bdce8776ebbdf700eabceed1e123a444a7bc4d
2015-11-16Move CommandInfoProvider to vcl and use it from thereSamuel Mehrbrodt
Change-Id: If7e3ef81cad8974bc54f359096e3ecc700fa62d6 Reviewed-on: https://gerrit.libreoffice.org/19984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16pch: CommandInfoProvider.hxx was renamed.Jan Holesovsky
Change-Id: I871ef2c50d393183dbca891efc1394455bf3acc6
2015-11-16Cleanup: Consolidate the different ways to get command labels/tooltipsSamuel Mehrbrodt
Change-Id: Ieab809a3122c9d592894b84ec2e68195a4e02dde
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>