summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2013-09-30Fixing the problem with Sidebar-alignmentPrashant Pandey
Currently, when the sidebar is taken from right side of the screen to left side of the screen, the vertical tab -bar is still attached towards the right side of deck. Ideally, when the sidebar is attched towards the left side of the screen, the tab-bar should automatically set towards the left side of deck. Change-Id: I1f56e5f0b7dfef37760e6563e7d757f7901cf2cd Reviewed-on: https://gerrit.libreoffice.org/5979 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-30Add hack to optionally get stable ODF output from the same inputTor Lillqvist
To be used in regression testing and similar scenarios, where the output ODF is *not* intended to be further manipulated in LibreOffice. An environment variable LIBO_ONEWAY_STABLE_ODF_EXPORT is used to toggle this behaviour. I am not 100% sure whether the generated ODF with the hack toggled on is even fully correct, but correctness is not the purpose of the hack anyway. Two classes of issues handled: 1) Automatic style names and 2) use of randomness. For class 1), when the hack toggle is in effect, we generate the names at first as strings based on all the properties of the style, and sort them based on those, and then rename them (for brevity in the output) to the "normal" form of a short prefix plus a number (like "P12"). Sure, it would have been better to just figure out *why* the automatic style naming currently is not stable in the first place, but outputs the styles in different order (with some styles being assigned different numbers) in separate invokations of LibreOffice), but I was unable to understand that. Possibly this code could be used in all cases, except that it does break some unit test (can't recall which right now). I don't know whether that is simply because the unit test assumes too much knowledge of the internal workings of the automatic style name generation, or whether the generated ODF is actually invalid. For 2), I found a handful of places where randomness was used to generated various kinds of identifiers in ODF output. I changed those to just use large (64-bit) non-overlapping integers instead. I assume there *is* a point in the original code in each case that explains why randomness is needed, so the hack definitely needs to be optional and used only for the above mentioned scenarios. Change-Id: I17b657197e38bcf24abdfe61ad4a277f4339eeae
2013-09-28fix change tracking options preview sizesCaolán McNamara
Change-Id: I39bf97cd84685132180694fc99bb3a298ec798ed
2013-09-27cppcheck: redundantAssignmentJulien Nabet
Change-Id: I43ae91f0b91479fb279b0efbeb0cb4195e7b083a
2013-09-27Google Drive files don't need Checkout bar.Cao Cuong Ngo
Plus, the Name property has been changed to Id, that was the reason the Checkin bar disappeared. Change-Id: I03f6ef4e1399c0f8b2a347ca8acd8a42daffa497
2013-09-27Move the current template dir a bit down.Jan Holesovsky
Change-Id: I7d8fea0a2fb8a73a5d108cc8b2ac36b7829f029c
2013-09-26Fix Infobar crashCao Cuong Ngo
The infobar should be added to the infobar list. Change-Id: I105dd5091daf3596fdd7dd119a07d6160444c673
2013-09-26CMIS file picker: it really does not like ID MarkCao Cuong Ngo
The file picker can't go back folder if we use ID mark in the URL. Conflicts: ucb/source/ucp/cmis/cmis_content.cxx Change-Id: I6985feec71dc23848ee022e0bab9e8515a21ffd2
2013-09-26typo fixes in commentsAndras Timar
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-25We need <tools/string.hxx>Tor Lillqvist
Change-Id: I1e4df48bbbdb8c2ee4840e02aeb1d585aeec63f7
2013-09-25Related: fdo#38838 remove UniString::EqualsIgnoreCaseAsciiCaolán McNamara
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-23Cmis Versions dialogCao Cuong Ngo
Change-Id: Ie863282062a6932a55543143e841917c54223ac9 Reviewed-on: https://gerrit.libreoffice.org/5925 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-09-22gbuild: add gb_Library_use_restargetMichael Stahl
Change-Id: Ic0a2fd3c1adeb55ec27f6a2eb4709be598120fba
2013-09-21sfx2: fix sfx2::sidebar::Theme lifecycleMichael Stahl
It's a horrible idea to have global VCL Images, since that will inevitably crash on shutdown when the static dtor runs after DeInitVCL, which breaks ~every JunitTest now. 0x00002af6750d2d51 in rtl::Reference<sfx2::sidebar::Theme>::~Reference (this=0x2af6756ceb28 <sfx2::sidebar::Theme::mpInstance>, __in_chrg=<optimized out>) Try to fix that by moving the global sidebar::Theme instance to SfxApplication where it can hopefully be deleted before shutdown. Change-Id: Ia78f1e458699335b53a741b6463ce48af69584a7
2013-09-21WaE: shadowed variable in higher debug levelCaolán McNamara
Change-Id: I560e5559306277006a2b6dbeacad54ee60a182d0
2013-09-20Related: fdo#69444 additionally care from zero recently-used items caseCaolán McNamara
Change-Id: I45c68dd7cac0a6666401ae4833b6ae090882659c
2013-09-20cook up a scheme to allow windows to have per-module settingsCaolán McNamara
Change-Id: I5fa62c3c2af2ccbbc7e8a61e5537488515b2808c
2013-09-20Resolves: #i122470# Fixed programmatic triggered switching of sidebar decksAndre Fischer
(cherry picked from commit 7b26aba94e5544937f1e37e34915bcb276bc3c27) Conflicts: sd/sdi/sdraw.sdi sd/source/ui/framework/tools/FrameworkHelper.cxx sd/source/ui/inc/framework/FrameworkHelper.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviews6.cxx sfx2/Package_inc.mk sfx2/inc/sfx2/sidebar/Sidebar.hxx Change-Id: Ic6b518e734fe59a7b713e85e934487347b847c5a
2013-09-20Turn sidebar back to non-experimentalCaolán McNamara
This reverts commit 7ce2a89f4f8fa84232896766276cb3433ada239c. Change-Id: I53f572777e84f66fd4c3d18fb686dac09095804a revert d38cb53e3bcf3fd95a75e03b01c3b7a209d07b46 Change-Id: I5b243b69e50084316aaeab250d6b01079c12b718 Revert "sidebar: disable impress task pane if sidebar is enabled." This reverts commit ee1726bfdba483623d496a3bcc09089e8b55cd65. revert 54d820a7815af03a248c1aa424fae9bf9a4881f4 Change-Id: Ie7c83d88f5427a7e42fa50879280a0c4a7c2cdd1 Revert "Only register and use the Sidebar if it is globally enabled." This reverts commit 66a5cc468cef0c6db8b42b7f25367f04208e6f2e. Conflicts: sfx2/source/view/viewfrm.cxx Change-Id: I17fe702996c4adf7f387573d36ea993f8cc32c96 Revert "disable sidebar menu option if it is disabled." This reverts commit 05f0eb57618d090fa45011120a907a3b1157accb. Revert "finally get the taskpane rendering again" This reverts commit 228bb7ffe0d404ba1225f7b4d26ca71e098577d9. Conflicts: officecfg/registry/data/org/openoffice/Office/Impress.xcu sd/source/ui/framework/factories/TaskPanelFactory.cxx sd/source/ui/framework/tools/FrameworkHelper.cxx Change-Id: I248cc9a769695cde19e78774d42ce666dc685599 Revert "don't throw up the sidebar on start." This reverts commit 645db9a2bd9b1eec381de60c491e6b7f9ee7a7b4. Conflicts: officecfg/registry/data/org/openoffice/Office/Views.xcu Change-Id: I911859757e2e019836e8ed5213d2ba69ff82aec8 Revert "update to the right service name for new URLs." This reverts commit 55f49970f4085e3a1498961edabd5303bd6bea6c. Conflicts: sd/source/ui/framework/tools/FrameworkHelper.cxx Change-Id: I1ba2762a4c969a9125ff8354a9b6035813290021 Revert "tentatively restore more UNO / task-pane goo ..." This reverts commit 052ac10a6f9b28b9b06884dd3ed41879722be6c9. Conflicts: officecfg/registry/data/org/openoffice/Office/Impress.xcu Change-Id: I7e62f27329af033df811549436718648a6447dea Revert "more reverts, first cut at making sidebar optional." This reverts commit a65a423e22fc03d0b7850bbf20dfc30f6cfa34dd. Revert "add experimental option for sidebar to 'Advanced' pane." This reverts commit 54d820a7815af03a248c1aa424fae9bf9a4881f4. Conflicts: cui/source/options/optjava.cxx sd/source/ui/framework/module/ImpressModule.cxx Change-Id: I09a6c0f7834c8ef330d05a014505aaaf09ae096f Revert "Restore FrameworkHelper taskpane URLs." This reverts commit e9c2d5b26b1e1b52bdf87192a76314b7362fa80c. more foo Change-Id: I2eaa2fbd74dc7a2f7ba937d310472cee6b5a0b57 really go to town on it Change-Id: I885dc03cd0286bbfdf05c05da9f0bbea2b78bcf4
2013-09-20indent: Just some indenting for better readingAndres Gomez
Change-Id: Id840dd00c71afc1930e6bb9b634e888b88fe7391 Reviewed-on: https://gerrit.libreoffice.org/6001 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-20uno: new InteropGrabBag UNO prop in OfficeDocumentAndres Gomez
Added the new InteropGrabBag property to the OfficeDocument service and modified the JUnit UNO unit tests for it. Added specific implementation in the sfx2 module for the SfxBaseModel class. Added specific inherited implementations in the sc, sd, starmath and sw modules for the ScModelObj, SdXImpressDocument, SmModel, and SwXTextDocument classes. This new property is intended by now for its usage on preserving OOX's theming although the aim is to be able to re-create the theming in the future from saved properties. It could also be used for preserving other attributes for interoperability among document formats. Change-Id: Ia822856293c70ae22911afa794e3e38bcaa31f86 Reviewed-on: https://gerrit.libreoffice.org/6000 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-19Make scrolling in ThumbnailView smoother and not per-lineKrisztian Pinter
Change-Id: I3df50dc953c6a5123b62f129b6e303ff682c6d9b Reviewed-on: https://gerrit.libreoffice.org/5951 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-18sal_Bool -> boolJulien Nabet
Change-Id: I7429af4dc64ec6c69b6b9297779e51614362cf52
2013-09-18Resolves: fdo#69444 cursor keys don't move between recent used docsCaolán McNamara
because each item is identified by an id, but that isn't set on the recent used so it stays stuck on the first one. change the ctor of the base element to require an id to be passed to it and adjust all the good code and then use the index+1 of the recently used elements as the id. Change-Id: I1e5978ddedbd4718923ef72d67598158d5ba8ee7
2013-09-18Related: fdo#69444 unsigned arithmetic is a PITACaolán McNamara
Change-Id: I8662fc36476a2a029f6bab306306181359b3f688
2013-09-18Resolves: fdo#69440 only ask for tabcontrol in builder dialogsCaolán McNamara
Change-Id: I6001f8921f3b90283525355b0094c4377c42c663
2013-09-18startcenter: Tweak Start Center layoutKrisztian Pinter
Change-Id: Ia63acef184455f3d515f0da0a90a46d8318fbbe0 Reviewed-on: https://gerrit.libreoffice.org/5901 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-17fdo#63926: remove extra include paths in svtools/ and sfx2/Marcos Paulo de Souza
Change-Id: I0b47849ba0fa0dfaf4a481779a5ece09be496c1e Reviewed-on: https://gerrit.libreoffice.org/5973 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-16Resolves: fdo#69236 route size request to layout widget, not hard-coded valueCaolán McNamara
a) For the sidebar the sidebars automatically handle scrolling, but for the older panel the widgets has to do the scrolling so add scrolling parents to the .ui b) Fold the DialogListBox scrolling widget implementation into VclScrolledWindow and remove the duplication. Change-Id: Ife9ccd8c501e5dee7bf3102a92c8261d979cd834
2013-09-15Save should encrypt OOXML document if it was loaded encrypted.Tomaž Vajngerl
Currently Agile encryption is not supported, so all documents loaded with "agile" encryption will be encrypted with "standard" encryption when they are saved afterwards. Change-Id: Id0477f43c00ed70032ca6b3390eebb1105d5ffa7
2013-09-13String to OUStringThomas Arnhold
This removes nearly all ToLowerAscii() calls. Conflicts: linguistic/source/convdic.cxx linguistic/source/convdiclist.cxx linguistic/source/dlistimp.cxx sc/source/filter/html/htmlexp.cxx Change-Id: Iddcaacfb7383e1df3d2f13751a3c788eba953fdd Reviewed-on: https://gerrit.libreoffice.org/5895 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-09-12drop tools/string.hxx from a bunch of placesCaolán McNamara
Change-Id: Id6d22b71f2b552ea7872e8a3da6afe207e856561
2013-09-11#i123198# catch and ignore uno exceptions in ↵Herbert Dürr
sfx2::sidebar::TabBar::Item::HandleClick() Patch by: Herbert Duerr Scenario found by: Thorsten Wagner (cherry picked from commit 1a078f3584e8a288c0ec33f176638406423ade63)
2013-09-09unify strip previews optimal size in one placeCaolán McNamara
Change-Id: I6ae1073d013c9d9bbca39c505955436cd4950d1b
2013-09-09callcatcher: update unused codeCaolán McNamara
Change-Id: I76825425ff084d3fb1e331fb7ff13b097744c208 Reviewed-on: https://gerrit.libreoffice.org/5882 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-07CID#1078580: Dereference after null checkJulien Nabet
Change-Id: I822d9110132955b62e11373fc7cc773eacbf6740
2013-09-06FileDialogHelper - remove unneeded commentsTomaž Vajngerl
Change-Id: I4f2c4394248430aa60c5938e0a90e9de3920fae9
2013-09-06move backing component dnd support into the large thumbnail areasCaolán McNamara
of the backing window Change-Id: Icf399a8834a25de43909769be08854134991885a
2013-09-05update pchThomas Arnhold
Change-Id: I6d5e8d3fd69189935a3338fee19b60022f70a7eb
2013-09-05CID#705713: fix memory leakMarkus Mohrhard
Change-Id: Ic157c57fcf3fd30fe46c8c09098d532fef9cd4b2
2013-09-05match original intent of String::Erase(String::Search))Caolán McNamara
the single argument String::Erase erased from the passed in index to the end of the string Search returns STRING_NOTFOUND on failure, which results in String::Erase erasing nothing and so leaving the original string untouched. Change-Id: I83939fce2a92c38fbfb62196b7248908117c1e69
2013-09-05fix windows build after my OUString changesNoel Grandin
this block of code is inside a WNT define Change-Id: I602b66267d84761e425c194c8f144ce9acd5f11f
2013-09-05convert sfx2/source/appl/* from String to OUStringNoel Grandin
Change-Id: I59901bdc3c953bf883c0b543bd1e0b5d6a96e80a
2013-09-04Remove more unused methodsMarcos Paulo de Souza
Change-Id: I8fec40d767905bcca366257a67f669eaa1055cbc Reviewed-on: https://gerrit.libreoffice.org/5789 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-09-04startcenter: Fix template buttons breaking when used with k.boardKrisztian Pinter
Change-Id: I14a6b5610b4cb337101403bbbf5c5d70af012c54 Reviewed-on: https://gerrit.libreoffice.org/5806 Reviewed-by: Krisztian Pinter <pin.terminator@gmail.com> Tested-by: Krisztian Pinter <pin.terminator@gmail.com>
2013-09-04startcenter: Rename variablesKrisztian Pinter
Change-Id: I3137502e6ee3c4c4dce6ac1b99325f5e8c771e02 Reviewed-on: https://gerrit.libreoffice.org/5805 Reviewed-by: Krisztian Pinter <pin.terminator@gmail.com> Tested-by: Krisztian Pinter <pin.terminator@gmail.com>
2013-09-03Resolves: fdo#68726 make navigator child dialog float on topCaolán McNamara
i.e. set its parent to the thing it wants to be on top of As an aside I'm not entirely sure that this little dialog has the decorations set on it that it would like, I suspect it wants to be more like the tearable-off font color floatingwindow. But lets not muddy the waters in this commit. Change-Id: I9e0c35fbb66e50c04c7b28904d3937cf9ae417f4
2013-09-03warning C4701: potentially uninitialized local variable 'pItem' usedStephan Bergmann
Change-Id: I04cc1589139841f50fcaa5ef9e1deaf53fb00096
2013-09-03startcenter: Add tooltips for thumbnails with long filenamesKrisztian Pinter
Change-Id: Id9bab881f74b40691cb3e7364af78758d769a8a6 Reviewed-on: https://gerrit.libreoffice.org/5756 Reviewed-by: Krisztian Pinter <pin.terminator@gmail.com> Tested-by: Krisztian Pinter <pin.terminator@gmail.com>
2013-09-03Remove more unused methodsMarcos Paulo de Souza
Change-Id: I79548f9dd1b83ef940e7a1302cf7b728610fed4a Reviewed-on: https://gerrit.libreoffice.org/5757 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>