summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-09-15tdf#111799 Added missing initialization of fontSerge Krot
The font was not intialized for the TextLayouterDevice object inside ThumbnailViewItem::addTextPrimitives() method. Change-Id: I18dc9e2c6fa09c43d66f7b230133cbeb00b7f585 Reviewed-on: https://gerrit.libreoffice.org/42287 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-14loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: Iebcf75f406a2cb9914bf3cbc1019a53c08e9203e
2017-09-13Fraction: make conversion operators and constructor explicitNoel Grandin
and simplify some of the calculations that needed to be changed. Which resulted in one unit test needing to change by one pixel, let's hope not an indication of a real problem. Change-Id: Ie56434f35f4e58d21ee6f671392e93dc7542fca3 Reviewed-on: https://gerrit.libreoffice.org/42240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13clang-tidy modernize-use-emplace in sfx2Noel Grandin
Change-Id: I3d6b9dfa86c3637e5cb6fad81702c15d4c894e72 Reviewed-on: https://gerrit.libreoffice.org/42229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12cppcheck: identicalConditionAfterEarlyExitJochen Nitschke
Change-Id: I59d91390ee303eadc10315405cce44cfd7c37d56 Reviewed-on: https://gerrit.libreoffice.org/42179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08set parent for file dialog helperCaolán McNamara
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08loplugin:unusedfieldsNoel Grandin
Change-Id: Ie26c52090d984c40cc108c9f20eb2ba31a866796 Reviewed-on: https://gerrit.libreoffice.org/42090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-06remove unused dummytypes.cxxNoel Grandin
after commit 0c1532c62bc489e5e811a641919492316bcbe8e3 "removed unused type for avmedia dummytypes" Change-Id: I6148bdc60d3b681bc4ab8f3775e0b55e0a92d67d Reviewed-on: https://gerrit.libreoffice.org/42010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-06const correctness in o3tl::array_viewNoel Grandin
Change-Id: I44c1ace97ae44069c5a0c6a247aa8a0b49896ad3 Reviewed-on: https://gerrit.libreoffice.org/41985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-06removed unused type for avmedia dummytypesjan Iversen
Removed StaticType, since opengrok can only find 1 place it is present. Change-Id: I5a2aacb53c6a22d510e79c152b3725fa7821351d
2017-09-05tdf#109202: pass arg of --convert-images-to to (f)odt filterKatarina Behrens
Tunelling 1 piece of information through 20 layers of abstraction Advanced tunelling all the way to sfx2 Exhausted beyond recognition arrived to [Flat]ODF filter Change-Id: I0597c20c28f5cf8e2c60c4398622b36bda83abd0 Reviewed-on: https://gerrit.libreoffice.org/41777 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04new loplugin:redundantpointeropsNoel Grandin
Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d Reviewed-on: https://gerrit.libreoffice.org/41787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02set parent for open file dialogCaolán McNamara
Change-Id: Ic823085567afde211b3991ebb60199dd336f562d Reviewed-on: https://gerrit.libreoffice.org/41819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-02always use a systemwindow for file dialog parentCaolán McNamara
cause the native dialogs can only be a parent of a "real" system window Change-Id: I6d06bda25c74b9a25f71e405027d3fb31711e136 Reviewed-on: https://gerrit.libreoffice.org/41812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-02set parent for export dialog same as save dialogCaolán McNamara
Change-Id: I33f416339693ef95c7a44a72d7c9c8e4b2e9b380 Reviewed-on: https://gerrit.libreoffice.org/41811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-01bump FileDialogHelper to XFilePicker3Caolán McNamara
Change-Id: I726676aaa8944bc3b6418abe305ad03f8ec96c59 Reviewed-on: https://gerrit.libreoffice.org/41783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-31gpg4libre/comphelper: add storage helper for GPG encryption dataThorsten Behrens
Change-Id: Idba9ad7a821cb33070cf5e5a0f79ae55db99b276 Reviewed-on: https://gerrit.libreoffice.org/41504 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-30Resolves: tdf#95960 improve custom properties pageCaolán McNamara
wrt widget heights and positions and other flakiness take the natural combobox height as the line height, use a vclgrid element for each row to get everything set to the same height move the positioning code into Resize, etc. Change-Id: I22de98ef91e39d1e7e45bbe62f68496d55c0c1cb Reviewed-on: https://gerrit.libreoffice.org/41734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-30gpg4libre: request key from filepickerThorsten Behrens
Change-Id: I3a20f293bd12fc3de76fb1e846452c0a574e8794 Reviewed-on: https://gerrit.libreoffice.org/41503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-29tdf#112027: avoid leaks in FillTreeBox (sfx2)Julien Nabet
Next step could be using std::unique_ptr<StyleTree_Impl> instead of StyleTree_Impl* Change-Id: Ifbf5313fedf1fc0310073918f91edd6fe75d0afc Reviewed-on: https://gerrit.libreoffice.org/41710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-29rename SBX errorcodes to BASICNoel Grandin
Change-Id: Ia6c2d2379a2f6e9b1109e2c04edd5cdd9dcf242f Reviewed-on: https://gerrit.libreoffice.org/41706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-29make custom properties tab page some reasonable starting widthCaolán McNamara
Change-Id: I50f1a552a39b2fb70e6c0c340f27834381eaa92e
2017-08-29Resolves: rhbz#1400287 resizing properties dialog hides widgetsCaolán McNamara
Change-Id: I5d066f53c5bdfb4dd50d60c5cb4b66e425c0293c Reviewed-on: https://gerrit.libreoffice.org/41696 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-29move all the basic errcodes to one fileNoel Grandin
Change-Id: Ic3353c80ac9fdbd17f17503b1c973c9a7cef0c7f Reviewed-on: https://gerrit.libreoffice.org/41617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-27OUString: constify and avoid temporariesMatteo Casalin
Change-Id: I1cb48585580f545623b2015318cb16d331519217
2017-08-27Use 'else' for consecutive checks on rHint.GetId()Matteo Casalin
Change-Id: Ied5e23344aa58ade4ebc4a0deaf757f5af2e0899
2017-08-25Drop gratuitous initial :: from comphelper::ProfileZoneTor Lillqvist
Change-Id: Iae7d86b857d0563d9ed9d9b4187e009554698412
2017-08-25Allow non-modal Dialogs during FileImport/LoadArmin Le Grand
When opening a file that triggers Dialogs (e.g. cannot read/repair/FileType) the Frame from which it was initialized gets blocked. This irritates quite some people. Changed this to a non-modal Dialog so that the user can continue to work with all opened docs, open new ones, close and print/PDF/export these. Change-Id: I048d3de3369527cec20d26396b87439254764b8a Reviewed-on: https://gerrit.libreoffice.org/41534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-24remove unused error codes in svtoolsNoel Grandin
which seem to be unused since initial import Change-Id: Id5216bac53fafc1020003de10d8dde381b1121cf Reviewed-on: https://gerrit.libreoffice.org/41491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23tdf#111844 infobar icons/text on high dpiHeiko Tietze
scaling factor added to text position Change-Id: Iaeb48fd4ac0439680fa3b6ca43f23a617efe1457 Reviewed-on: https://gerrit.libreoffice.org/41417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-22Convert ErrCode area to scoped enumNoel Grandin
Change-Id: Ifa365bbac3c7eb21da9381ec8bb3be6b6785016b Reviewed-on: https://gerrit.libreoffice.org/41402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22convert WB_QUICK_SEARCH/WB_FORCE_MAKEVISIBLE to bool fieldsNoel Grandin
Change-Id: Ic297d97911a6c0356d24ffe4b58442dfe866139f Reviewed-on: https://gerrit.libreoffice.org/41407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21tdf#111844 infobar icons on high dpiheiko tietze
scaling factor added Change-Id: Iccfc76832ccfaaffb9950d4b591b379dfb0d9eca Reviewed-on: https://gerrit.libreoffice.org/41401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-20tdf#107129: correct showing orderSzymon Kłos
Change-Id: I2e72b8e0d3ff8ef9de16d634d85d43ef2da9ca75 Reviewed-on: https://gerrit.libreoffice.org/41361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-19drop unused SfxSizeItemJochen Nitschke
unused since commit 48bf5e855ae02fd1bea87938978f29ee6147285c Date: Thu Nov 16 14:30:58 2000 +0000 Remove tests for INET_PROT_FILE Change-Id: I2dc134f529675204caad78c7e50417adb55e8e4f Reviewed-on: https://gerrit.libreoffice.org/41320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18drop unused CntContentTypeItemJochen Nitschke
unused since commit cdae06a664bfc3279bd9f177473357cce316b9b1 Date: Fri Apr 6 11:17:10 2001 +0000 #78400# Template scanning reimplemented using UCB Change-Id: I3e742be5a7c5467628dbe5a19171c4dfcef07c58 Reviewed-on: https://gerrit.libreoffice.org/41274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I8eddd2cb43631d15a04f3edd3cf218232bda45af
2017-08-18loplugin:unnecessaryparenNoel Grandin
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17implementing callback for ruler invalidationAditya Dewan
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Removing unused serialisation codeVarun Dhall
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8 Reviewed-on: https://gerrit.libreoffice.org/41233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15tdf#109210 - Non-standard background color at the new controlsAkshay Deep
Change-Id: I381626d80470db18044d517c2c8bb76b2bc6a829 Reviewed-on: https://gerrit.libreoffice.org/40879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-15tdf#100864 Assign a tooltip to the button to close paneTakeshi Abe
which appears at the top-right corner of both Impress's Slide Pane and Draw's Page Pane. Change-Id: Ida52ccc35e42546cd6260001e22335b04608034d Reviewed-on: https://gerrit.libreoffice.org/40803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-08-14Creating a button for the hamburger menuGökhan Gurbetoğlu
Things done in this commit: - Created a hamburger menu button on the right. - Moved the opening menu to match the new hamburger button. - Added 1 pixel at the end of shortcut toolbox so no overlapping with the tabs would occur. Change-Id: I3d05eec72e260575563e4d016945af0777541cfb Reviewed-on: https://gerrit.libreoffice.org/38450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>