summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-06-28tdf#107690 OOXML import/export of setting "Open as read-only"László Németh
Import custom document property _MarkAsFinal as LoadReadonly setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX and PPTX documents. Before this fix, LibreOffice opened read-only OOXML documents as editable, also saved and exported _MarkAsFinal=true silently, resulting unintented read-only warning info bar in MSO. This commit improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. Note: LoadReadonly (on File->Properties...->Security, property "Open file read-only") doesn't show "Edit read-only" info bar from commit 630186ff4e0eba7317e542f8c3eca39ebd068721, but it's still possible to switch on editing by Edit->Edit Mode. MSO shows info bar for _MarkAsFinal. (There is an advantage to hide the info bar in LibreOffice in a mixed environment, to avoid overwriting of press-ready MSO files by LibreOffice.) Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal in MSO: (1) Switching on editing doesn't remove the LoadReadonly property automatically in LO. (2) Saving with LoadReadonly doesn't switch off editing of the actual (still opened) document in LO. Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216 Reviewed-on: https://gerrit.libreoffice.org/56180 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-27tdf#117900 Reload document after signing signature lineSamuel Mehrbrodt
So that the graphic reflects the new "signed" state Change-Id: Ic943581c4dfff53fbf9fbd5f1398c98842497a25 Reviewed-on: https://gerrit.libreoffice.org/56477 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-24Notebookbar:Disabled appearence of context toolbarsKshitij Pathania
Change-Id: Ib4a5a1f1904976e9f511d7a908393cb072bc3aea Reviewed-on: https://gerrit.libreoffice.org/56341 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-06-23tdf#96099 Remove trivial std::vector typedefs in sd, sfx2, shellArkadiy Illarionov
Change-Id: Ib3708c9650f273de4a2f549d2ce9f2465bd37d6c Reviewed-on: https://gerrit.libreoffice.org/56206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-23Remove duplicate call functionJens Carl
Change-Id: I5803b6a1874e35ee0da6e23daed21eb127ea5a76 Reviewed-on: https://gerrit.libreoffice.org/56269 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-19Fix typoSamuel Mehrbrodt
Change-Id: I57a5d3b1dcffba4c439a2f3817e8661c605e1b5f Reviewed-on: https://gerrit.libreoffice.org/56085 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-19tidy up setting parentsCaolán McNamara
Change-Id: Ic0d30d066c76f2b30a5c4e6c864d80c8242c2444 Reviewed-on: https://gerrit.libreoffice.org/56067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-19tdf#101915 make F11 close the sidebar when focus is in sidebarJim Raykowski
...style list panel Change-Id: I034ba4310cd0942aad0a2e6f807213e14327e7b4 Reviewed-on: https://gerrit.libreoffice.org/55969 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-18weld SfxSecurityPageCaolán McNamara
and drop the sole use of WB_EARLYTOGGLE Change-Id: I01e7d085eb3f9daf5a62a048178ab90defb4c5b1 Reviewed-on: https://gerrit.libreoffice.org/55983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18set explicit parent for signing warning messagesCaolán McNamara
Change-Id: Ifbd1aaec13e2f3a51963c4942face64847eefc07 Reviewed-on: https://gerrit.libreoffice.org/55989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxDocumentDescPageCaolán McNamara
Change-Id: I52abfe33e39fbb2e96fe0634b9ac3d8d50068ee7 Reviewed-on: https://gerrit.libreoffice.org/55988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxDocumentFontsPageCaolán McNamara
Change-Id: I09bb788455053c266ce18d21055157147668263e Reviewed-on: https://gerrit.libreoffice.org/55968 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxManageStyleSheetPageCaolán McNamara
Change-Id: I3769d294e5a5458d3172c330360f7e6207c3d1b1 Reviewed-on: https://gerrit.libreoffice.org/55961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17use hub.libreoffice.org for links from within LibreOfficeChristian Lohmaier
Change-Id: I01eff9b5d921787ff0c251ab8467912144577705
2018-06-17Fix crash on deactivating Chart after playing aroundArmin Le Grand
Change-Id: I55fab9213d3571e9457c1a0e0d68574ab4760d1e Reviewed-on: https://gerrit.libreoffice.org/55931 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-15Implement infobar encouraging the community involvement.Jan Holesovsky
Change-Id: I06128ed7d28d17fa9a395878efaef4b890f5dbe0 Reviewed-on: https://gerrit.libreoffice.org/55760 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-15fix setPreviewsToSamePlaceCaolán McNamara
Change-Id: I70a6f44ecd25155faf64adaf795d330b12c247c7 Reviewed-on: https://gerrit.libreoffice.org/55817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14tdf#33209: Context-sensitive help for extensions in otherwise HTML-help casesStephan Bergmann
When extensions bring along help content (in the form of .xhp files), that was completely unavailable in --without-help (i.e., defering to online HTML help) and --with-help=html (i.e., displaying the new offline HTML help in a browser) builds. (Merely extended tooltips brought along by extensions would work in those builds.) With this change, at least context-sensitive help (i.e., pressing F1 in an extension's dialog) will be shown. Although not integrated with the rest of the (browser-based HTML) help, but using LO's own old help viewer. (Which will then of course only offer the combined help content of all the installed extensions, not any help content provided by LO itself. Thus, links from extensions' help content to LO help content will not work.) This is only a cheap stopgap. If an extension brings along help content other than context-sensitive help (which is reachable by pressing F1 in the respective context), there is no easy way for the user to reach it. (That includes help pages listed in an extension's help.tree, and index entries. See the commit message of 4a0ca73c31990568bf20a1c3f0906c3a5770a38e "Add some help content to test-passive.oxt" for an overview of what help conent an extension can provide.) Regarding the details of this code change, I left the comphelper::LibreOfficeKit::isActive() case alone, assuming that that case never wants to display LO's own old help viewer, for one reason or another. (But please correct me/the code if that assumption is wrong.) Change-Id: I2209b1aa48888c5f25674fbe4ce6643eff1268c6 Reviewed-on: https://gerrit.libreoffice.org/55816 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-14do setPreviewsToSamePlace at SfxTabDialogController display timeCaolán McNamara
Change-Id: Ia38c1a577b7d054ab4e7e70a8f2cbce16a3573f5 Reviewed-on: https://gerrit.libreoffice.org/55793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14tdf#116742: Only enable "CMIS" versions button for versionable CMISMike Kaganski
Change-Id: I9230e1b973d55113287c013ff7b2c167af25a95c Reviewed-on: https://gerrit.libreoffice.org/55776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-13weld SvxCharPositionPageCaolán McNamara
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55759 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12fix leak in SfxApplication::OpenDocExec_ImplNoel Grandin
when calling Link on SfxLinkItem, none of the callee sites free the memory associated with the Clone()'ed SfxPoolItem, so just skip the cloning, and make the Link take a const pointer to make this more obvious. Change-Id: Icd187e9d8d3ace9bf2e6ff183489999b105708e4 Reviewed-on: https://gerrit.libreoffice.org/55671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12rename SfxFilterTupel->SfxFilterTupleNoel Grandin
Change-Id: Idbbc5d0b28f7f876a774904d8279d342906b642d Reviewed-on: https://gerrit.libreoffice.org/55662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12resizing of optionalbox now follows priority order strictlyKshitij Pathania
earlier box were not following the assigned priorities thus causing the reordering issue Change-Id: I8631312946322164a358d70fd9c47aa6ddfb95e2 Reviewed-on: https://gerrit.libreoffice.org/55644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-06-12loplugin:constantparamNoel Grandin
Change-Id: Ia769b3176aea287cd57414d7ce8e88c6da43883e Reviewed-on: https://gerrit.libreoffice.org/55622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11tdf#114875 Added an option to not show "No offline help installed" popupNickson Thanda
Change-Id: I8067c0c374af57f5ad8e6f5fffd3a9783521824f Reviewed-on: https://gerrit.libreoffice.org/55254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-11loplugin:unusedmethodsNoel Grandin
Change-Id: I26a0da1ec9cda9030371977596053a45303756a0 Reviewed-on: https://gerrit.libreoffice.org/55609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-07Introduce a LO_IMPORT_USE_PDFIUM envvar to force PDFium for PDF import.Jan Holesovsky
Change-Id: Ibb7734430b955dad4aefec22260ba8694ccb9183
2018-06-07sd: import PDFs as images using Pdfium new SdPdfFilterAshod Nakashian
LOK now opens PDFs as images using Pdfium, which has a superior accuracy and support to poppler, the default pdf reader. Change-Id: Ifbbecf7f048f001836fb98886705cba47e6bed4e
2018-06-07tdf#96099 Remove std::vector typedefsAbhyudaya Sharma
Change-Id: Ic7e1cecaecadf3f9ebfa183727d61046dd87e473 Reviewed-on: https://gerrit.libreoffice.org/55260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-06weld SwSectionIndentTabPageCaolán McNamara
Change-Id: I961686c1257f0d85686df06aa7c73c324d0f70b8 Reviewed-on: https://gerrit.libreoffice.org/55387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-05tdf#101915 move focus to sidebar styles panelJim Raykowski
Change-Id: I3a150761a401caf1e76b5ec0ee36e537c14df8e0 Reviewed-on: https://gerrit.libreoffice.org/52612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-04Fix .xltx file extension in Template import dialogAbhyudaya Sharma
Change-Id: Ib7cb462720d13c31f0946a9c8b721d05ce7c9dfe Reviewed-on: https://gerrit.libreoffice.org/55267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-06-04make CreateStyleFamilies return std::unique_ptrNoel Grandin
Change-Id: Ibb7bec9ede8045a6cea42c02f61f14ad36d2b434 Reviewed-on: https://gerrit.libreoffice.org/53730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-03uitest logger: support for buttons, dialog, command and key loggingSaurav Chirania
This patch adds logging faclity for radiobuttons, checkboxes and button clicks. It modifies the logging for UNO commands and dialogs execution for consistency with other log statements. It also makes key logging more informative by printing the details of the object on which the user is typing. Change-Id: I911d0dfb64dacfde64193f0aea21f7d837dbf9da Reviewed-on: https://gerrit.libreoffice.org/54745 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-01OOXML types are now visible in Template Import DialogAbhyudaya Sharma
Change-Id: I5414391cebc4a5a8e08d6d0004fefc3a0acc8111 Reviewed-on: https://gerrit.libreoffice.org/55128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-06-01loplugin: look for CPPUNIT_ASSERT_EQUALS with params swappedNoel Grandin
idea originally from either tml or moggi, can't remember which Change-Id: Id78d75035036d3aa1666e33469c6eeb38f9e624d Reviewed-on: https://gerrit.libreoffice.org/55126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-31drop Graphic::GetBitmapNoel Grandin
so that we flush out various code using Bitmap, in favour of using BitmapEx. This is part of the process of making Bitmap largely an internal detail of vcl Change-Id: Iaf2ead5e3d9960838723fb55b812b97108093d74 Reviewed-on: https://gerrit.libreoffice.org/55062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-30tdf#112034 , tdf#107266 label color on basis of persona and personaKshitij Pathania
flipping is fixed. Labelcolor not gets updated immediately but when statechanged function triggers via executemethod things workwell.(like it triggers on changing mode of notebookbar) Change-Id: I755fb4ff434d7971112d2f0beb44ca09f4a7e0f1 Reviewed-on: https://gerrit.libreoffice.org/54301 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-05-30tdf#117872: Revert "tdf#115284: Unify LibreOffice and system full-screen..."Tor Lillqvist
Instead, never participate in the macOS system full-screen mode. There is just too much complexity involved, and the way LibreOffice works really isn't prepared for the concept of windows having the option from a system point of view to being full-screenable or not. This means that the green bubble in window title bars changes from being a (system) full-screen toggle to being a maximize/restore toggle. Sure, the "maximize" concept also probably can be confused with LibreOffice's own full-screen concept. For instance, the Start Centre window is not expecting to be made full-screen. Still, when you from the Start Centre open a Writer document, it is the *same* window that is re-used as the Writer window, and then suddenly should be prepared to handle going full-screen. Also, it is up to each separate kind of document window whether it can be made full-screen (from the LibreOffice point of view) or not. Writer windows can, but Impress windows can't, for example. The View>Full Screen menu entry is added separately each case. Maybe I will come back to this mess later, or not. Anybody else is welcome to have a go, too, of course. This reverts commit 4b42fd7e9516fbbd8a92d97680524f32dd260fb2. Change-Id: I6983481cbd30c0e5190c450483b1246006c80632 Reviewed-on: https://gerrit.libreoffice.org/55049 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-29weld SvxTransformTabDialogCaolán McNamara
Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644 Reviewed-on: https://gerrit.libreoffice.org/55012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29we need to be able to query the ranges before creating the pagesCaolán McNamara
so don't create the pages until the first execute Change-Id: I5ecc31d5a08bae44c0a912e39b786420f2da86ee Reviewed-on: https://gerrit.libreoffice.org/55007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29Resolves: tdf#117712 closing help crashesCaolán McNamara
since... commit 9fa32e5dce345dea17129587c401c03520fb398b Date: Wed May 16 11:54:52 2018 +0200 fix leak of HelpListener_Impl in SfxHelpWindow_Impl Change-Id: I7e2cbb5d0c69e96fc7f2e1cc0c5563203c1f3dce Reviewed-on: https://gerrit.libreoffice.org/55024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28loplugin:unusedmethodsNoel Grandin
Change-Id: I64df1f467986b3d70c058adff289a6dd8f00fb20 Reviewed-on: https://gerrit.libreoffice.org/54821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-26Reuse existing variableMike Kaganski
Change-Id: I8048b21de3a6cc7e027ad0123d1ef8aab32366dc Reviewed-on: https://gerrit.libreoffice.org/54829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-05-25Improve re-throwing of UNO exceptionsNoel Grandin
(*) if we are already throwing a Wrapped*Exception, get the exception using cppu::getCaughtexception. (*) when catching and then immediately throwing UNO exceptions, use cppu::getCaughtException to prevent exception slicing (*) if we are going to catch an exception and then immediately throw a RuntimeException, rather throw a WrappedTargetRuntimeException and preserve the original exception information. Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558 Reviewed-on: https://gerrit.libreoffice.org/54692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-25loplugin:passstuffbyrefNoel Grandin
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-30 06:33:19 +0000