summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-05-08convert DELETEX to DELETEZNoel Grandin
one of these is bad enough Change-Id: Ifc40f3e3c067bb715c6befab9193d22d0c56a6e7 Reviewed-on: https://gerrit.libreoffice.org/53960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07cppcheck: accessMovedJochen Nitschke
Change-Id: Ia0d0761660a2096c308b1738ccc0294cb3b2a456 Reviewed-on: https://gerrit.libreoffice.org/53907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-05-07loplugin:useuniqueptr in SfxDocumentInfoItem and CustomPropertiesWindowNoel Grandin
Change-Id: I535200a5b26725cdefc3e6e3ce5e1e925e7a7bfd Reviewed-on: https://gerrit.libreoffice.org/53876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SfxCmisVersionsDialogNoel Grandin
Change-Id: Ib2ad8550fa452478066039d79a75f75cb5605460 Reviewed-on: https://gerrit.libreoffice.org/53870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SfxVersionDialogNoel Grandin
Change-Id: I6adb8baff9792c65e3474c10e6ffdac56fe2e5ff Reviewed-on: https://gerrit.libreoffice.org/53869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SfxModalDialogNoel Grandin
Change-Id: I612b92045c3a1cf4a443adf2b35fe7ac6f1aa0bf Reviewed-on: https://gerrit.libreoffice.org/53868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-05Fix typosAndrea Gelmini
Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: https://gerrit.libreoffice.org/53638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-04weld SwOutlineTabDialogCaolán McNamara
Change-Id: I55c0e9a62dd9dd970a87ef295bb5fbb82c80d2d8 Reviewed-on: https://gerrit.libreoffice.org/53848 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-04Revert "Enable new Help to be installed as extension"Stephan Bergmann
This reverts commit cdbb14cedb7d07aec0dda47fbb5ab65a02fb0cf6, no longer needed after e606179d5722427bc4137838585b38892e01b328 "tdf#116240: Include --with-help=html in installation sets". Change-Id: Iaf26b937aa40a6563589ac182b7365224b455482 Reviewed-on: https://gerrit.libreoffice.org/53725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-04coverity#1435273 Resource leak in objectCaolán McNamara
Change-Id: I781b2d6f6b550e5b381c041a27d282c4dca9d6dd Reviewed-on: https://gerrit.libreoffice.org/53805 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-04no need to expose m_pExampleSet as non-constNoel Grandin
Change-Id: Ife6b4115a8aa48eba6f86ecf4eb66e3dc5e1830e Reviewed-on: https://gerrit.libreoffice.org/53796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-04loplugin:useuniqueptr in SfxManageStyleSheetPageNoel Grandin
Change-Id: Ia20be44b7a574a8afe1edbf5bf313da4391898d1 Reviewed-on: https://gerrit.libreoffice.org/53760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-04loplugin:useuniqueptr in SfxAppData_ImplNoel Grandin
Change-Id: I861dd9459e4c986557198b918dc099a0bb119d7d Reviewed-on: https://gerrit.libreoffice.org/53759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-04Removed executable permission on data filesAndrea Gelmini
chmod -x for doc, xlsx, png, hxx, cxx, xls, ppt, hpp Change-Id: I52aed261e318cfd765e9adb3ed8edd226c8a59d8 Reviewed-on: https://gerrit.libreoffice.org/52569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-04Reverse debug logicEike Rathke
Two warning messages are too much.. Change-Id: Ifaa40e1c7a32b488d1a40374507efea5e893280f
2018-05-04Debug string access out-of-boundsEike Rathke
Change-Id: Ie5afbcdc9818e09261c2458f03ce26da1fefcf49
2018-05-03coverity#1435275 Uninitialized scalar fieldCaolán McNamara
Change-Id: I5a488d11565166c4143bd8992f40cb776906cb2b Reviewed-on: https://gerrit.libreoffice.org/53804 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-03m_bStandardPushed is deadNoel Grandin
Change-Id: Ibea072af1c6f6de968535807dadf89866123ba44 Reviewed-on: https://gerrit.libreoffice.org/53775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02Fix typosAndrea Gelmini
Change-Id: I56477227bafdd7fdb29aa5a5c857cbfda110e395 Reviewed-on: https://gerrit.libreoffice.org/53643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-05-02loplugin:useuniqueptr in ShutdownIconNoel Grandin
Change-Id: I7ccc31ff9cfdca7229b2acf00ebd35c98560a4e9 Reviewed-on: https://gerrit.libreoffice.org/53701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in ThumbnailViewNoel Grandin
Change-Id: I1851af82e7f1e56a5b309be55da6dc08b6d34ace Reviewed-on: https://gerrit.libreoffice.org/53704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in TemplateLocalViewNoel Grandin
Change-Id: I248c0aed295502ee5da15004403cc02a483dd893 Reviewed-on: https://gerrit.libreoffice.org/53703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in SfxEventNamesListNoel Grandin
Change-Id: Ie296881069393001842f4424f398b0edefd89ac5 Reviewed-on: https://gerrit.libreoffice.org/53702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-01weld ScShowTabDlgCaolán McNamara
Change-Id: Ice5da193d0efbf8e4a61d68c0fcef90f6c6d8e78 Reviewed-on: https://gerrit.libreoffice.org/53665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-01update when gaining/losing focusCaolán McNamara
Change-Id: I0f650502f43a4c1c27b0eb8b3ddab857d5c64480 Reviewed-on: https://gerrit.libreoffice.org/53674 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-30tdf#117039: update infobar instead of removing and re-adding itKatarina Behrens
Apparently AppendInfoBar ends up calling back into SID_SIGNATURE status function at some point, creating an endless recursion. I'm too lazy to debug why so I'm cowardly avoiding it Change-Id: Ib1e4b7f12fea197887b099e9a9f03b4e58884ec1 Reviewed-on: https://gerrit.libreoffice.org/53519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-29Drop ShutdownIcon::GetResString l10n wrapper methodGabor Kelemen
Just a wrapper above SfxResId, simpler to use that. Change-Id: I3a0a6d262d873591b3eeb924f76373df572cf434 Reviewed-on: https://gerrit.libreoffice.org/53548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29weld SwFootNoteOptionDlgCaolán McNamara
Change-Id: I00713527deab7f8cb9f137c35db7d28c5a896171 Reviewed-on: https://gerrit.libreoffice.org/53609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-28weld SwEnvDlgCaolán McNamara
Change-Id: Ib92f790030ca6fbf64273cf45c710b2f698f45a4 Reviewed-on: https://gerrit.libreoffice.org/53569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-28Enable undocking of sidebar by dragging a deck gripKatarina Behrens
Change-Id: I59d15b4c61045bfd97dd937e6f383652db33fd8f Reviewed-on: https://gerrit.libreoffice.org/53496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-28loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I84868b3115c534a8240394283cc3beedf8cb3a80 Reviewed-on: https://gerrit.libreoffice.org/53543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-27weld SwLabDlgCaolán McNamara
Change-Id: I55c543776c03b1d1da0331552b98e6e281e35937 Reviewed-on: https://gerrit.libreoffice.org/53488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26weld SwLabPreviewCaolán McNamara
Change-Id: I710eacd28f3b6c38890145cf82eeca8bec6ae1f6 Reviewed-on: https://gerrit.libreoffice.org/53328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26identify tab pages by name for save/storing active tabCaolán McNamara
Change-Id: Id66f8ff62ed08724702572f457b9fc857d567e89 Reviewed-on: https://gerrit.libreoffice.org/53465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26Change mouse cursor to Move when over sidebar deck gripKatarina Behrens
Change-Id: Ic6a271245a6c2da307238d799dbd606e435f7aa1 Reviewed-on: https://gerrit.libreoffice.org/53379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-25SvTabListBox::SetTabs, pass count explicitNoel Grandin
passing count as first element in array, dodgy. Change-Id: I49905b554b3b4d6cc3fa419a36389cd2e5ded463
2018-04-24Prep mouse event handler to indicate dragging startedKatarina Behrens
Change-Id: Icdb865e511047b166767ca9e87e808c308ad7643 Reviewed-on: https://gerrit.libreoffice.org/53324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-24Show grip on sidebar's deck title to be used for drag'n'drop laterKatarina Behrens
Change-Id: I4d76d49742056d278e73a995dcbb8c4a64b374bd Reviewed-on: https://gerrit.libreoffice.org/53323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-23set SfxTabPage parent dialog explicitlyCaolán McNamara
Change-Id: If7813f9f5e35694312b055cc92868638bc3773d5 Reviewed-on: https://gerrit.libreoffice.org/53326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23type mismatch at 1st parameter ('vcl::Window *const' vs 'const vcl::Window *')Caolán McNamara
Change-Id: I4e72c5c66b3826f00ad65da81f253c32ca9cdcbb Reviewed-on: https://gerrit.libreoffice.org/53334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23move GetConfigId from TabPage to SfxTabPageCaolán McNamara
Change-Id: Id2c687c2270cb1c2419cc6664200292b2740d0a4 Reviewed-on: https://gerrit.libreoffice.org/53325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23weld SfxPrintOptionsDialogCaolán McNamara
and SwMMResultPrintDialog Change-Id: Icded6a26a3a151293bea0c9173334cf634283e89 Reviewed-on: https://gerrit.libreoffice.org/53299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-22place an intermediate class as parent for SfxTabPagesCaolán McNamara
so a SfxTabPage can be parented by a vcl::Window or a welded native notebook tabpage. That ways the same SfxTabPage can be used at the same time in both a native dialog or a vcl dialog. The impl can be changed to the weld api, and when hosted in a native dialog the vcl impl of that will be instantiated, while native otherwise. e.g. print options appearing in print options dialog and general options. This allows incremental changeover. Change-Id: I6f1fed1e8d0898b01853bb878757bad41cbf9bba Reviewed-on: https://gerrit.libreoffice.org/53193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-22try to fix oss-fuzz build harderCaolán McNamara
Change-Id: Ief83120b35ffc77e3cf8760638b9442bf3a53400 Reviewed-on: https://gerrit.libreoffice.org/53272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-21cppcheck: identicalInnerConditionJochen Nitschke
renamed temporary list in EnhancedCustomShape2d.cxx to avoid shadow of a local variable Change-Id: I17a2261dafd2067480fcc5314af4f48765d6b690 Reviewed-on: https://gerrit.libreoffice.org/53244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-21tdf#94498 add repeat search in Basic IDE by shortcuttagezi
additionally deduplicate code and remove unnecessary abstraction Change-Id: Ib826b5cac74e95ce4ae8d02368b0983eb4942b29 Reviewed-on: https://gerrit.libreoffice.org/52027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-21loplugin:unusedmethodsNoel Grandin
Change-Id: I9dc6e81149eae3ba2284fa7fe608dd9252503dce Reviewed-on: https://gerrit.libreoffice.org/53197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-20loplugin:unusedfieldsNoel Grandin
Change-Id: I9c80805788d49b13552c168a36fdf395da19df26 Reviewed-on: https://gerrit.libreoffice.org/53196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20tdf#42949 Remove unnecessary localization headers of svtoolsGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<svtools/svtresid.hxx\> -e \<svtools/strings.hrc\> | xargs grep -c SvtResId | grep :0$ | grep -v /pch Change-Id: I861fed778660412dc73616da29503538b3fe9ccb Reviewed-on: https://gerrit.libreoffice.org/53136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20loplugin:singlevalfieldsNoel Grandin
Change-Id: I8f3bad622daa3ce118d20c5be12294a3fab85c2a Reviewed-on: https://gerrit.libreoffice.org/53166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-21 05:47:49 +0000