summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-10-12sfx2: clean up redundant virtual keywords in classificationhelperMiklos Vajna
Change-Id: If6da4e79c17dc27a13e043a3f23cdbac0ae7f7d0
2016-10-11tdf#100352 Provide Catalan classification fileAdolfo Jayme Barrientos
Change-Id: If0bccf16fb83deaf5b13ab5f45d1aaec9ed48bda
2016-10-11loplugin:unnecessaryoverride in sfx2Noel Grandin
Change-Id: I9097a5cfb861e6659a5d9ae10f9c45f2edcae2ec Reviewed-on: https://gerrit.libreoffice.org/29686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10safemode: Add uno command and menu entrySamuel Mehrbrodt
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10de-src another standalone PushButtonCaolán McNamara
Change-Id: I5e38e8877d70efd3b6413a14c0c121a8babb44f8
2016-10-10de-src standalong PushButtonCaolán McNamara
Change-Id: I6f062e04377fc74ec2fea3ea4390943b715e06d1
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-09de-src solo ComboBoxCaolán McNamara
Change-Id: Ie3f687f203c66f93114f5b2421af924ae4c2f76a
2016-10-08stray unused pushbutton and fixedtext resourcesCaolán McNamara
Change-Id: Ia610c28e93e853f17e80ffb5203928474113c300
2016-10-08de-src last two RadioButtonsCaolán McNamara
Change-Id: I8e6f7ec86a17b2ee87a62a5fbe235047413ec403
2016-10-07de-src RID_HELP_ONSTARTUP_BOX checkboxCaolán McNamara
Change-Id: I30ff54c55078333526ad34256f1c81c62fca920c
2016-10-07HID_HELP_ONSTARTUP_BOX goes nowhere in helpCaolán McNamara
Change-Id: I9a8556fcda0bd39107491dd178b816e4421f160c
2016-10-07tdf#102776 : switching the menubar in all windowsSzymon Kłos
Change-Id: I74804605ec9dd15d1e4dbea15f09709dbf9c8770 Reviewed-on: https://gerrit.libreoffice.org/29580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-10-07SfxViewFrame::GetParentViewFrame_Impl always returns nullptrStephan Bergmann
...ever since 4d61332a3cb172cdfe29f64efb325f6ef20c573c "[CWS autorecovery] removed (now) unused methods in Sfx(Top)Frame" Change-Id: I3a1bc00d8a11337211cdf7265ad8e5e7d5363600
2016-10-07sfx2: resolve "enum ApplicationType" conflict...Michael Stahl
... with windows.h by putting our enum into a namespace, and while we're at it convert it to enum class etc. Change-Id: I804cd82565e77e6ab9a9d3a529f1ea43379fe0be
2016-10-07sidebar theme loads pngs by name that are not picked up automaticallyCaolán McNamara
anywhere else, so explicitly list them here in an auxillary ilst some are mentioned in sfx2/source/sidebar/Theme.cxx, and some are mentioned in *IconURL properties in officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu Change-Id: I0cf3919c20277d4c88783f06da53c5e889049a06
2016-10-07loplugin:staticmethods: sfx2Stephan Bergmann
Change-Id: I64bd8564b335481a8cdfb053cc9563bea8ef47d3
2016-10-07we don't need the code, but we need the images in the src fileCaolán McNamara
apparently so they can be found at postprocess time and inserted into the image zips for the use of the pngs by other consumers Change-Id: Ib45834da69462109fdf7502176a6f4721057d980
2016-10-07Revert "SidebarResource doesn't do anything useful"Caolán McNamara
This reverts commit e9886d32923e5fa3995f44701f27148f59df5c0f.
2016-10-06tdf#102776 : fixed Notebookbar hidingSzymon Kłos
Change-Id: I86cdf2aa9fd5167073da215f5baf50bb4f64f4dd Reviewed-on: https://gerrit.libreoffice.org/29579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-10-06SidebarResource doesn't do anything usefulCaolán McNamara
Change-Id: Id716c9f9caa1a1e4f8ae0e7e05837bebdec4335a
2016-10-06tdf#101813 sw,sfx2: enable inserting master document as sectionMichael Stahl
Traditionally only ordinary com.sun.star.text.TextDocument could be inserted as a section but then commit 3da8f3680556e0163f660a0a159930337c8c32ff unintentionally enabled inserting everything, including master documents (com.sun.star.text.GlobalDocument). I'm really not sure if this should be allowed or not but apparently somebody finds it useful so here we add some crude hacks to enable it (to be reverted in case it causes trouble). (regression? from 805fd1ca343d6295b8114a24cc29bdac332f266d) Change-Id: I439b2516fcbe54977ff04e487a920acd38c27152
2016-10-06coverity#1373513 Uninitialized scalar fieldCaolán McNamara
Change-Id: Id035cb04c0cd7879d7075b7c1bcd0359564f2f0b
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-06drop now unused sfx2/sidebar/ResourceDefinitions.hrcCaolán McNamara
Change-Id: I151a37a37435a44e7331d957bd9d36f84cdf8677
2016-10-05tdf#102238 START CENTER: Templates should be activated with single clickAkshay Deep
Change-Id: If38f8fffd959c50b3befd521d2110e4c54e86be5 Reviewed-on: https://gerrit.libreoffice.org/29295 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05tdf#101249 Notebookbar: remember the menubar visibilitySzymon Kłos
Change-Id: Ia4e89bfc97d102b2c548a19e62e262accb54d17d Reviewed-on: https://gerrit.libreoffice.org/29539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-10-05Replace DdeData conversion operators with proper functionsStephan Bergmann
Change-Id: I866bdcbf1b6a5cda4472b6655ace866a3d5a8983
2016-10-05sfx2: clean up redundant virtual keywords in classificationcontrollerMiklos Vajna
Change-Id: I7ac297a675034e64dcd629bf8243d9579bbeec6e Reviewed-on: https://gerrit.libreoffice.org/29535 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-04can now remove both PopupContainer copiesCaolán McNamara
the recently unused svx one, and the forgotten not-built sfx2 one Change-Id: I1a4ede49dc74bb71f250ee3eee999d1a3dfbee57
2016-10-04comphelper: move setTiledPainting() from SfxViewShellMiklos Vajna
And make it a static one. The primary point of that member function is to prevent invalidations during paint, and since multiple views are allowed, it wasn't extended to filter out invalidations from all views, not just from the current one. (Same goes for other callback types.) Change-Id: I23e6b2c2ff94227f2b72c481148b2d8279ae2905
2016-10-03loplugin:staticmethodsStephan Bergmann
Change-Id: Iac376aff079cddd030a07883f3cccf71a7ff5f91
2016-10-03Surely this is Linux-only codeTor Lillqvist
The initial commit in 2012 even says so, and nothing has changed it since. Feel free to fix more properly by making sure this code can be called only on Linux.. Change-Id: Idb0a2b5594daa0cde7f4797b51ba3e5876170f9f
2016-10-01Fix typosAndrea Gelmini
Change-Id: I6aeda978911b25caa45d4e459e581fc743e93d2c Reviewed-on: https://gerrit.libreoffice.org/29442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Revert "don't write item right before destruction"Jochen Nitschke
triggers warnings in the dtor if RefCount isn't reset. revert till we have better ref counts and don't need debug code in dtor. This reverts commit b74d2433c856d6d172d9588f4b6d59c31ec02853. Change-Id: I1835885d94e15339aa7602037d850e1524fd9662 Reviewed-on: https://gerrit.libreoffice.org/29427 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-01Notebookbar: fixed context handlingSzymon Kłos
After last changes context switching was not working. Removed unnecessary Resize call to avoid flickering. Change-Id: I7931f4d442737c704c41bb7944c6d95e45b964f7 Reviewed-on: https://gerrit.libreoffice.org/29411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-09-30loplugin:constantparamNoel Grandin
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29tdf#102776 : toolbar mode changing in multiple windowsSzymon Kłos
This patch provides better toolbar mode switching: - only in current module (if eg. Writer and Calc opened) - in multiple windows with the same module (two Writer docs) Change-Id: I81bfe626b677bc0168c4a7cd6ce5563ceed5c14b Reviewed-on: https://gerrit.libreoffice.org/29394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-09-29LOK: conditionally include part number in invalidation payloadMiklos Vajna
Since desktop/ code queues, compresses and only emits callbacks on idle, it's possible that two invalidations are in the queue, and there was a setPart() call between them. In this case it's impossible to tell what part the invalidation was sent for. Fix this by conditionally including the part number in the invalidation payload. It's off by default, a new feature flag is added to request this behavior. gtktiledviewer enables this feature flag by default, though just to show the part number in the debug output. Android doesn't enable it. Change-Id: I73e6def848c0eb61d64e71026002c7a0e750aab4
2016-09-27tdf#101249 fixed crash after inserting OLE object 2Szymon Kłos
Change-Id: I1997e69e09cfae10b26a3b3e851583714ee9b3e9 Reviewed-on: https://gerrit.libreoffice.org/29318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-09-27sw: avoid emitting invalid cursor pos during end text edit of commentMiklos Vajna
A comment text edit (provided by editeng) works with relative twip coordinates, conversion of the cursor position to absolute twips happens in ImpEditView::ShowCursor(), provided that the pOutWin member has a map mode origin that respresents the offset correctly. This is not true during SwSidebarWin::DeactivatePostIt(), the map mode origin is already reset back to 0, so just don't emit callbacks during shutdown, the sw body text cursor will be shown later anyway. Change-Id: I02c15bb9fad99db8e43fd2f37df770dd165be788
2016-09-26tdf#101249 fixed crash after inserting OLE objectSzymon Kłos
Change-Id: I4ddd52f5da1745a2b9f2d6d54d5091d8f10107e7 Reviewed-on: https://gerrit.libreoffice.org/29155 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-26tdf#102063 Notebookbar wont appear on launchSzymon Kłos
* removed static members from SfxNotebookBar to avoid crashes * Updating Notebookbar state after module load Change-Id: Ia4e3dcb0b6e2c5aa7c5205992dbf3575e72fa354 Reviewed-on: https://gerrit.libreoffice.org/28841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-26convert ITEMCONN_ constants to scoped enumNoel Grandin
Remove unused enum values. Which means that these methods simplify to constant values: ItemConnectionBase::GetEnableState() -> TRISTATE_INDET ItemConnectionBase::IsActive() -> true so inline those values. Which means that ControlWrapperBase::ModifyControl is always called with a first parameter of TRISTATE_INDET, so drop that first parameter. Change-Id: I6d63b63b2f15faad2336665f60e7239e35b74e47