summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-10-22cannot interact with chart sidebar as the previous deck is still activeCaolán McNamara
Change-Id: I7972ef73b8c11ae78569fa1c7dc0a244ebba3f30 Reviewed-on: https://gerrit.libreoffice.org/62182 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18Resolves: tdf#120612 help response missingCaolán McNamara
Change-Id: I096bdcc93899dfd41d88cb9d00d54c51cebeca92 Reviewed-on: https://gerrit.libreoffice.org/61825 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-09tdf#120271 related: Allow finalizing of LastTimeGetInvolvedShownMike Kaganski
This avoids abort() on modifying the setting in case it's finalized Change-Id: I5982a4d7bf867301d7ba0e7e0dbb3f7c87013134 Reviewed-on: https://gerrit.libreoffice.org/61430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit ec235750bb30c3b66bd8b642f6abd1f9ea8244df) Reviewed-on: https://gerrit.libreoffice.org/61543 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-09-27tdf#119238: keep replaced file's identity when renaming docfileMike Kaganski
Regression from 2157a3536f97ff5ae7c82611a801fef7e3708983 sfx2 store: try rename before copying Rename is cheaper then copying the content over manually, so try that first. On Windows, we need to keep the file's dentity, including metadata (e.g., creation time, which is kept in FS). WinAPI has ReplaceFileW specifically for this, and it keeps ACLs of the original file, and otherwise makes the changed file not a separate entry, but updated old file from system's PoV. Eventually, we could try to restructure creating backup copies (e.g., for documents when configured so) to take advantage of this function being able to do that. Change-Id: I6001a2a3af5e10bc010f5ef129f4bb6f83ee1581 Reviewed-on: https://gerrit.libreoffice.org/60163 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins (cherry picked from commit c9343988204ee3e9889f3cc833adbbaca83e53e6) Reviewed-on: https://gerrit.libreoffice.org/61041
2018-09-24Resolves: tdf#119624 stray image_position bottom for some icons in buttonsCaolán McNamara
icons are off by default so not usually seen Change-Id: I6076fd87250fc4595d279c830e14779147b7857a Reviewed-on: https://gerrit.libreoffice.org/60936 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-19add locale to joinus link so hub can redirect to language specific pagesChristian Lohmaier
Change-Id: Ibed6f899ad0219bf0211ac50c0595484ddba8c92 Reviewed-on: https://gerrit.libreoffice.org/60696 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 17d981d795f18422e1435180d42baeba509c1280) Reviewed-on: https://gerrit.libreoffice.org/60742 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-17tdf#119316 sfx2 store: no move on macOSMiklos Vajna
osl::FileStatus::getAttributes() and osl::File::setAttributes() doesn't preserve all the necessary file properties (at least "Hide extension" is not handled), so always copy on macOS instead. (cherry picked from commit 7823684cb6fbe752dc64300799c5d102f61e0b70) Change-Id: I529467cc3d432d04e593f936c13ed4656a18150c Reviewed-on: https://gerrit.libreoffice.org/60307 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-13tdf#119802 LibreOffice crashes when I save multiple times in a rowNoel Grandin
regression from commit c2452e52f644649723df10e3cd6bbd48d6bafb49 loplugin:useuniqueptr in SfxDispatcher_Impl Change-Id: Ia6e097c72e8571540c9cbd1512aedd85e4c2433e Reviewed-on: https://gerrit.libreoffice.org/60395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3778399872ad592b4416e54a154e8bcc02d73a2e) Reviewed-on: https://gerrit.libreoffice.org/60420
2018-09-10tdf#119381 sfx2 store: don't break symlink targetsMiklos Vajna
osl::File::move() would not follow symlinks for the target, so don't move the file in that case. (cherry picked from commit 72be5ac08aa963bdd42d2e56a62f43e69f728caa) Change-Id: I907e1ba8db04dad670c884ea0283947f953117da Reviewed-on: https://gerrit.libreoffice.org/59982 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-06tdf#117895: "Edit document properties before saving"...Henry Castro
option leaves just-saved document modified; changes are not saved Change-Id: Icad48fe1edcfb4c10c40f297326c23110144df53 Reviewed-on: https://gerrit.libreoffice.org/57211 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/59142 Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-03tdf#119579 skip floating windows as potential parent for missing help dialogCaolán McNamara
Change-Id: Ibcee9a6aab0b04bf52f3e75a46f52d98864eee4c Reviewed-on: https://gerrit.libreoffice.org/59809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#119050 sfx2 store: don't inherit temp file permissions when overwritingMiklos Vajna
The too aggressive error handling in commit fb04780cf8523ad4e900ae8b9cecbe7a2697a12a (tdf#116117 sfx2 store: don't inherit temp file permissions when renaming, 2018-03-12) means that if the file is already there, then we don't try to stat() it; even if there is no problem with that. (cherry picked from commit 38afe2976eea427999c39ee3a73e7938ec8d5f7b) Change-Id: Ie0b9084064834e339bcae3ad7b4a35c54cb9d3c2 Reviewed-on: https://gerrit.libreoffice.org/59709 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24tdf#117426 don't crash is infobar is disposed in preview viewCaolán McNamara
Change-Id: Iff2dece2ea5f65c5d0896af888e05703ae709c65 Reviewed-on: https://gerrit.libreoffice.org/59513 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-17Resolves: tdf#119013 do not over-aggressively reorder date particlesEike Rathke
In particular not when reading documents as we don't know what the original (default/system) locale was when the date format was created and stored and whether the format's date order actually matched the locale's ordering. Regression from commit 51478cefaa4e265b42e3f67eda0a64767ff3efba CommitDate: Tue Apr 18 17:01:27 2017 +0200 Resolves: tdf#107012 follow date order of the target locale Change-Id: I9d3bdbd512d95ed81ff6459e368a2d7497ec8a2d Reviewed-on: https://gerrit.libreoffice.org/59182 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5b8007afdb97d416ee7c22bf9226e927d61e9bd3) Reviewed-on: https://gerrit.libreoffice.org/59215 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16tdf#119052: hide edit style button in character styleXisco Fauli
Change-Id: I8ec82865b990ff19ead819c990f442edd7423d66 Reviewed-on: https://gerrit.libreoffice.org/58472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 8e7d6bd5095404337c6e6dab1b9a20f69765ef29) Reviewed-on: https://gerrit.libreoffice.org/58694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16tdf#119276 Fix loading of images with internal LO URLsTomaž Vajngerl
Change-Id: I30556aba4490bef7f4a6e6b3899cc05f4b6a06d4 Reviewed-on: https://gerrit.libreoffice.org/59104 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 43b7aa5133ce3bfb44c5203aea37fa4474bc3a61) Reviewed-on: https://gerrit.libreoffice.org/59144 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-08-13Don't show ShowImeStatusWindow in the customization dialogMaxim Monastirsky
Change-Id: I5aeac6cf6ec9fae56c0dba3c176e0d6c52a28a5e Reviewed-on: https://gerrit.libreoffice.org/58899 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit d42d937e6edb85bb8c2795cd54dc237e0da49bd6) Reviewed-on: https://gerrit.libreoffice.org/58902 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-10Set umask /before/ using itStephan Bergmann
The test used to fail when umask originally was e.g. 077. Change-Id: I21d346532698feebccc8bb3f6cb9a9dd3002a20e Reviewed-on: https://gerrit.libreoffice.org/58757 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit bab5511870e8ad847020645628df8090116f0e8b) Reviewed-on: https://gerrit.libreoffice.org/58778 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-08-01tdf#118593 sfx2: no need to call into xmlsecurity without signature streamsMiklos Vajna
In the ODF and OOXML cases the ZIP storage already tells us if there are signatures on this file so we can avoid the whole libxmlsec init, which can be slow. The bugreport talks about a smartcard setup, I also heard that the gpg code in xmlsecurity isn't cheap to init, either. (cherry picked from commit 7ac4e48687d7679927f5659e941024445946ffa7) Change-Id: Ife9ed577d03e96a9ac2f42a28776b7df58e76c59 Reviewed-on: https://gerrit.libreoffice.org/58363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-23fix shutdown crash when SfxApplication has already been destroyedMarkus Mohrhard
See e.g. http://crashreport.libreoffice.org/stats/crash_details/dc1ae6ff-923e-44f6-99a9-84893039efd7 Change-Id: I3b5a24bfb62977ca922bf3bececb6676691bf6ea Reviewed-on: https://gerrit.libreoffice.org/57789 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 715fcaff01ed048c52c69264a7a0fb773dd57b32) Reviewed-on: https://gerrit.libreoffice.org/57808 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-18bubble referer to LinkManager::GetGraphicFromAnyCaolán McNamara
Change-Id: Id2c6d629692a365f96f3f81c5686930668389a6a Reviewed-on: https://gerrit.libreoffice.org/57549 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-18tdf#107690 OOXML import/export of setting "Open as read-only"László Németh
Import custom document property _MarkAsFinal as LoadReadonly setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX and PPTX documents. Before this fix, LibreOffice opened read-only OOXML documents as editable, also saved and exported _MarkAsFinal=true silently, resulting unintented read-only warning info bar in MSO. This commit improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. Note: LoadReadonly (on File->Properties...->Security, property "Open file read-only") doesn't show "Edit read-only" info bar from commit 630186ff4e0eba7317e542f8c3eca39ebd068721, but it's still possible to switch on editing by Edit->Edit Mode. MSO shows info bar for _MarkAsFinal. (There is an advantage to hide the info bar in LibreOffice in a mixed environment, to avoid overwriting of press-ready MSO files by LibreOffice.) Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal in MSO: (1) Switching on editing doesn't remove the LoadReadonly property automatically in LO. (2) Saving with LoadReadonly doesn't switch off editing of the actual (still opened) document in LO. (cherry picked from commit 9a5c56a9c4e04589b0a6bb710573922e459d9685 and bbdb6cb8ed0d77eeb2e413b38f29d2084bd8257b (unit tests)) Change-Id: I79897605e1fabe0708cce0b0c6216c152b201fc9 Reviewed-on: https://gerrit.libreoffice.org/56752 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-17coverity#1437960 Resource leak in objectCaolán McNamara
Change-Id: Icee05e1ef1fef213de293971beb9e17753c8eb3b Reviewed-on: https://gerrit.libreoffice.org/57460 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-06tdf#103226 Notebookbar:Disabled appearence of context toolbarsKshitij Pathania
Change-Id: Ib4a5a1f1904976e9f511d7a908393cb072bc3aea Reviewed-on: https://gerrit.libreoffice.org/56341 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 2c317751c4b7661c10bd9eb11094febeccd1b816) Reviewed-on: https://gerrit.libreoffice.org/57054
2018-07-06resizing of optionalbox now follows priority order strictlyKshitij Pathania
earlier box were not following the assigned priorities thus causing the reordering issue Change-Id: I8631312946322164a358d70fd9c47aa6ddfb95e2 Reviewed-on: https://gerrit.libreoffice.org/55644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 4c6e11886a9d396bf7be18e9e3209a73c6e303ad) Reviewed-on: https://gerrit.libreoffice.org/56992 Tested-by: Jenkins
2018-07-06tdf#112034 , tdf#107266 label color on basis of persona and personaKshitij Pathania
flipping is fixed. Labelcolor not gets updated immediately but when statechanged function triggers via executemethod things workwell.(like it triggers on changing mode of notebookbar) Change-Id: I755fb4ff434d7971112d2f0beb44ca09f4a7e0f1 Reviewed-on: https://gerrit.libreoffice.org/54301 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit e02b3b095e472646c58eecd36d5a27b056dcb99e) Reviewed-on: https://gerrit.libreoffice.org/56990 Tested-by: Jenkins
2018-07-03tdf#117757 sfx2 save-as: fix leftover temporary files for embedded objectsMiklos Vajna
This is really similar to c1676204447df942e766c0780c1580e1f0427b73 (tdf#117225 sfx2: fix leftover temp file when saving doc with embedded objects, 2018-05-14), just this is save as, not save. (cherry picked from commit b8fd1a814ffc80f2802c5b980febabcffe9606cb) Change-Id: If78d91262bfbe97846287deb0794e4101ef7b4af Reviewed-on: https://gerrit.libreoffice.org/56869 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-28tdf#117900 Reload document after signing signature lineSamuel Mehrbrodt
So that the graphic reflects the new "signed" state Change-Id: Ic943581c4dfff53fbf9fbd5f1398c98842497a25 Reviewed-on: https://gerrit.libreoffice.org/56477 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 22ccb4cb8b99cc6766282256939d3f79a0c56109) Reviewed-on: https://gerrit.libreoffice.org/56511 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-19tidy up setting parentsCaolán McNamara
Change-Id: Ic0d30d066c76f2b30a5c4e6c864d80c8242c2444 Reviewed-on: https://gerrit.libreoffice.org/56082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-19tdf#101915 make F11 close the sidebar when focus is in sidebarJim Raykowski
...style list panel Change-Id: I034ba4310cd0942aad0a2e6f807213e14327e7b4 Reviewed-on: https://gerrit.libreoffice.org/55969 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> (cherry picked from commit 3a8375eb974eb8ba36ac616478acd881b70f8e19) Reviewed-on: https://gerrit.libreoffice.org/56078
2018-06-18set explicit parent for signing warning messagesCaolán McNamara
Change-Id: Ifbd1aaec13e2f3a51963c4942face64847eefc07 Reviewed-on: https://gerrit.libreoffice.org/56027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxDocumentDescPageCaolán McNamara
Change-Id: I52abfe33e39fbb2e96fe0634b9ac3d8d50068ee7 Reviewed-on: https://gerrit.libreoffice.org/56025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxSecurityPageCaolán McNamara
and drop the sole use of WB_EARLYTOGGLE Change-Id: I01e7d085eb3f9daf5a62a048178ab90defb4c5b1 Reviewed-on: https://gerrit.libreoffice.org/55986 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxDocumentFontsPageCaolán McNamara
Change-Id: I09bb788455053c266ce18d21055157147668263e Reviewed-on: https://gerrit.libreoffice.org/55982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxManageStyleSheetPageCaolán McNamara
Change-Id: I3769d294e5a5458d3172c330360f7e6207c3d1b1 Reviewed-on: https://gerrit.libreoffice.org/55966 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17use hub.libreoffice.org for links from within LibreOfficeChristian Lohmaier
Change-Id: I01eff9b5d921787ff0c251ab8467912144577705 (cherry picked from commit cbd0d1da85a7ae6b35023274c7267872b3d920e7)
2018-06-17Fix crash on deactivating Chart after playing aroundArmin Le Grand
Change-Id: I55fab9213d3571e9457c1a0e0d68574ab4760d1e Reviewed-on: https://gerrit.libreoffice.org/55931 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit bf1f49c837264c8f59197b9487d40e32821526c3) Reviewed-on: https://gerrit.libreoffice.org/55937 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-15Implement infobar encouraging the community involvement.Jan Holesovsky
Change-Id: I06128ed7d28d17fa9a395878efaef4b890f5dbe0 Reviewed-on: https://gerrit.libreoffice.org/55760 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit c3fa7a82b7657b00f30394df59e2ffc610350686) Reviewed-on: https://gerrit.libreoffice.org/55880 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-15tdf#33209: Context-sensitive help for extensions in otherwise HTML-help casesStephan Bergmann
When extensions bring along help content (in the form of .xhp files), that was completely unavailable in --without-help (i.e., defering to online HTML help) and --with-help=html (i.e., displaying the new offline HTML help in a browser) builds. (Merely extended tooltips brought along by extensions would work in those builds.) With this change, at least context-sensitive help (i.e., pressing F1 in an extension's dialog) will be shown. Although not integrated with the rest of the (browser-based HTML) help, but using LO's own old help viewer. (Which will then of course only offer the combined help content of all the installed extensions, not any help content provided by LO itself. Thus, links from extensions' help content to LO help content will not work.) This is only a cheap stopgap. If an extension brings along help content other than context-sensitive help (which is reachable by pressing F1 in the respective context), there is no easy way for the user to reach it. (That includes help pages listed in an extension's help.tree, and index entries. See the commit message of 4a0ca73c31990568bf20a1c3f0906c3a5770a38e "Add some help content to test-passive.oxt" for an overview of what help conent an extension can provide.) Regarding the details of this code change, I left the comphelper::LibreOfficeKit::isActive() case alone, assuming that that case never wants to display LO's own old help viewer, for one reason or another. (But please correct me/the code if that assumption is wrong.) Reviewed-on: https://gerrit.libreoffice.org/55816 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 06a1c2c9fc467604372495023983874fba33ca85) Conflicts: sfx2/source/appl/sfxhelp.cxx Change-Id: I2209b1aa48888c5f25674fbe4ce6643eff1268c6 Reviewed-on: https://gerrit.libreoffice.org/55825 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-14do setPreviewsToSamePlace at SfxTabDialogController display timeCaolán McNamara
Change-Id: Ia38c1a577b7d054ab4e7e70a8f2cbce16a3573f5 Reviewed-on: https://gerrit.libreoffice.org/55810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharPositionPageCaolán McNamara
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-06weld SwSectionIndentTabPageCaolán McNamara
Change-Id: I961686c1257f0d85686df06aa7c73c324d0f70b8 Reviewed-on: https://gerrit.libreoffice.org/55389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-05tdf#101915 move focus to sidebar styles panelJim Raykowski
Change-Id: I3a150761a401caf1e76b5ec0ee36e537c14df8e0 Reviewed-on: https://gerrit.libreoffice.org/52612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> (cherry picked from commit b5af679c74774036de323b687a3901bd8f97a09b) Reviewed-on: https://gerrit.libreoffice.org/55305
2018-05-30tdf#117872: Revert "tdf#115284: Unify LibreOffice and system full-screen..."Tor Lillqvist
Instead, never participate in the macOS system full-screen mode. There is just too much complexity involved, and the way LibreOffice works really isn't prepared for the concept of windows having the option from a system point of view to being full-screenable or not. This means that the green bubble in window title bars changes from being a (system) full-screen toggle to being a maximize/restore toggle. Sure, the "maximize" concept also probably can be confused with LibreOffice's own full-screen concept. For instance, the Start Centre window is not expecting to be made full-screen. Still, when you from the Start Centre open a Writer document, it is the *same* window that is re-used as the Writer window, and then suddenly should be prepared to handle going full-screen. Also, it is up to each separate kind of document window whether it can be made full-screen (from the LibreOffice point of view) or not. Writer windows can, but Impress windows can't, for example. The View>Full Screen menu entry is added separately each case. Maybe I will come back to this mess later, or not. Anybody else is welcome to have a go, too, of course. This reverts commit 4b42fd7e9516fbbd8a92d97680524f32dd260fb2. Change-Id: I6983481cbd30c0e5190c450483b1246006c80632 Reviewed-on: https://gerrit.libreoffice.org/55049 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit c1452e73091412ba0bb72306329e1912df2ba513) Reviewed-on: https://gerrit.libreoffice.org/55065
2018-05-29weld SvxTransformTabDialogCaolán McNamara
Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644 Reviewed-on: https://gerrit.libreoffice.org/55018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29we need to be able to query the ranges before creating the pagesCaolán McNamara
so don't create the pages until the first execute Change-Id: I5ecc31d5a08bae44c0a912e39b786420f2da86ee Reviewed-on: https://gerrit.libreoffice.org/55015 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29Resolves: tdf#117712 closing help crashesCaolán McNamara
since... commit 9fa32e5dce345dea17129587c401c03520fb398b Date: Wed May 16 11:54:52 2018 +0200 fix leak of HelpListener_Impl in SfxHelpWindow_Impl Change-Id: I7e2cbb5d0c69e96fc7f2e1cc0c5563203c1f3dce Reviewed-on: https://gerrit.libreoffice.org/55025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28loplugin:passstuffbyrefNoel Grandin
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ff3bdde2527123fc9e011ff0d93e958174632186) Reviewed-on: https://gerrit.libreoffice.org/54914 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24tdf#115284: Unify LibreOffice and system full-screen concepts on macOSTor Lillqvist
Also tdf#76476, and probably more. Make it so that when a window is in full-screen mode from LibreOffice's point of view, it is also full-screen from the system's point of view, and vice versa. All three ways to enter and leave full-screen mode can now be used with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full Screen" menu entry, and the green bubble on the title bar. Don't disable/deactivate/etc menus while in full-screen mode. The menu auto-hides so there is no harm in having it function normally. Don't display the floating toolbar with a single "Full Screen" button in it as the way to leave full-screen mode. Instead, the same three ways that can be used to enter full-screen mode work to leave it, too. Sadly I could not figure out a way to set a window properly to full-screen at the point where a document window is created and set to be the same size as that kind of document window was the previous time it was open in LibreOffice. Thus don't save state for full-screen windows as we can't properly restore them. At least not for macOS. It is not good to just restore them as non-full-screened but still at the size they had when full-screen. One irritating glitch remains, and I was unable to fix that properly: I now prevent closing the document window that is in full-screen mode. Otherwise, if it is closed, the full-screen mode remains even if no window is open there; the desktop is completely black. Moving the cursor to the top edge, the LibreOffice menu is there, though. I tried to fix that but with no fully satisfying result. (Some attempts even lead to crashes, so just disabling closing is better than crashing at least.) Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f Reviewed-on: https://gerrit.libreoffice.org/54760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-24rework custom widget welding to enable inheritenceCaolán McNamara
Change-Id: I0d391b3fe9d2d610ae41e2a03cd2e195a866e103 Reviewed-on: https://gerrit.libreoffice.org/54681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-01 19:57:22 +0000